137680 2014-10-13 17:35:09 -0700 Web Inspector: Paint Flashing button does not match page state after reload 2014-10-13 21:43:58 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck simon.fraser timothy webkit-bug-importer oldest_to_newest 1041428 0 joepeck 2014-10-13 17:35:09 -0700 * SUMMARY After activating the Paint Flashing button and reloading the page, the button is deactivated but the page is performing paint flashing. Lets make this a frontend property entirely. Enabled only when the inspector is open, and remembered across sessions. * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Enable paint flashing (DOM Tree view button) 3. Reload the page => pain flashing is enabled on the page, but the button is disabled 1041429 1 webkit-bug-importer 2014-10-13 17:35:19 -0700 <rdar://problem/18642469> 1041430 2 239766 joepeck 2014-10-13 17:37:53 -0700 Created attachment 239766 [PATCH] Proposed Fix 1041461 3 239766 commit-queue 2014-10-13 21:43:55 -0700 Comment on attachment 239766 [PATCH] Proposed Fix Clearing flags on attachment: 239766 Committed r174670: <http://trac.webkit.org/changeset/174670> 1041462 4 commit-queue 2014-10-13 21:43:58 -0700 All reviewed patches have been landed. Closing bug. 239766 2014-10-13 17:37:53 -0700 2014-10-13 21:43:54 -0700 [PATCH] Proposed Fix paint-flashing.patch text/plain 5137 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVjYjZhYWUuLjRmNjBlZDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE0LTEwLTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUGFpbnQg Rmxhc2hpbmcgYnV0dG9uIGRvZXMgbm90IG1hdGNoIHBhZ2Ugc3RhdGUgYWZ0ZXIgcmVsb2FkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc2ODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmxvYWRlZCk6CisgICAg ICAgIE1ha2UgcGFpbnQgZmxhc2hpbmcgYSBmcm9udGVuZCBzZXR0aW5nLiBFbmFibGUgaXQgd2hl biB0aGUgaW5zcGVjdG9yCisgICAgICAgIGlzIG9wZW5lZCBpZiBpdCB3YXMgcHJldmlvdXNseSBl bmFibGVkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUNvbnRlbnRWaWV3KToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5ET01UcmVlQ29udGVudFZpZXcucHJvdG90eXBlLl90b2dnbGVQYWlu dEZsYXNoaW5nKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlQ29udGVudFZpZXcucHJv dG90eXBlLl9zaG93UGFpbnRSZWN0c1NldHRpbmdDaGFuZ2VkKToKKyAgICAgICAgSGF2ZSB0aGUg cGFpbnQgZmxhc2hpbmcgYnV0dG9uIGFsd2F5cyBtYXRjaCB0aGUgZ2xvYmFsIHNldHRpbmcuCisK KzIwMTQtMTAtMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBJbXByb3ZlIGFwcGVhcmFuY2Ugb2YgYWxwaGEgY29sb3Igc3dh dGNoZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NzYyNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01h aW4uanMKaW5kZXggZWI4ZjU1MS4uMDExZjM3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTYzLDkgKzE2MywxMyBAQCBXZWJJ bnNwZWN0b3IubG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMuc2hvd1JlcGxheUludGVyZmFj ZVNldHRpbmcgPSBuZXcgV2ViSW5zcGVjdG9yLlNldHRpbmcoInNob3ctd2ViLXJlcGxheSIsIGZh bHNlKTsKIAogICAgIHRoaXMuc2hvd0phdmFTY3JpcHRUeXBlSW5mb3JtYXRpb25TZXR0aW5nID0g bmV3IFdlYkluc3BlY3Rvci5TZXR0aW5nKCJzaG93LWphdmFzY3JpcHQtdHlwZS1pbmZvcm1hdGlv biIsIGZhbHNlKTsKLSAgICBpZiAodGhpcy5zaG93SmF2YVNjcmlwdFR5cGVJbmZvcm1hdGlvblNl dHRpbmcudmFsdWUpCisgICAgaWYgKHRoaXMuc2hvd0phdmFTY3JpcHRUeXBlSW5mb3JtYXRpb25T ZXR0aW5nLnZhbHVlICYmIFJ1bnRpbWVBZ2VudCAmJiBSdW50aW1lQWdlbnQuZW5hYmxlVHlwZVBy b2ZpbGVyKQogICAgICAgICBSdW50aW1lQWdlbnQuZW5hYmxlVHlwZVByb2ZpbGVyKCk7CiAKKyAg ICB0aGlzLnNob3dQYWludFJlY3RzU2V0dGluZyA9IG5ldyBXZWJJbnNwZWN0b3IuU2V0dGluZygi c2hvdy1wYWludC1yZWN0cyIsIGZhbHNlKTsKKyAgICBpZiAodGhpcy5zaG93UGFpbnRSZWN0c1Nl dHRpbmcudmFsdWUgJiYgUGFnZUFnZW50ICYmIFBhZ2VBZ2VudC5zZXRTaG93UGFpbnRSZWN0cykK KyAgICAgICAgUGFnZUFnZW50LnNldFNob3dQYWludFJlY3RzKHRydWUpOworCiAgICAgdGhpcy5t b3VzZUNvb3JkcyA9IHsKICAgICAgICAgeDogMCwKICAgICAgICAgeTogMApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRW aWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUNvbnRlbnRWaWV3LmpzCmluZGV4IDgyOGMyYjguLjNiZDMwNzIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVl Q29udGVudFZpZXcuanMKQEAgLTQyLDkgKzQyLDExIEBAIFdlYkluc3BlY3Rvci5ET01UcmVlQ29u dGVudFZpZXcgPSBmdW5jdGlvbihyZXByZXNlbnRlZE9iamVjdCkKICAgICB0aGlzLl9jb21wb3Np dGluZ0JvcmRlcnNCdXR0b25OYXZpZ2F0aW9uSXRlbS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3Bl Y3Rvci5CdXR0b25OYXZpZ2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0aGlzLl90b2dnbGVDb21w b3NpdGluZ0JvcmRlcnMsIHRoaXMpOwogICAgIHRoaXMuX2NvbXBvc2l0aW5nQm9yZGVyc0J1dHRv bk5hdmlnYXRpb25JdGVtLmVuYWJsZWQgPSAhIVBhZ2VBZ2VudC5nZXRDb21wb3NpdGluZ0JvcmRl cnNWaXNpYmxlOwogCisgICAgV2ViSW5zcGVjdG9yLnNob3dQYWludFJlY3RzU2V0dGluZy5hZGRF dmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHRoaXMuX3No b3dQYWludFJlY3RzU2V0dGluZ0NoYW5nZWQsIHRoaXMpOwogICAgIHRoaXMuX3BhaW50Rmxhc2hp bmdCdXR0b25OYXZpZ2F0aW9uSXRlbSA9IG5ldyBXZWJJbnNwZWN0b3IuQWN0aXZhdGVCdXR0b25O YXZpZ2F0aW9uSXRlbSgicGFpbnQtZmxhc2hpbmciLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkVu YWJsZSBwYWludCBmbGFzaGluZyIpLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkRpc2FibGUgcGFp bnQgZmxhc2hpbmciKSwgIkltYWdlcy9QYWludEZsYXNoaW5nLnN2ZyIsIDE2LCAxNik7CiAgICAg dGhpcy5fcGFpbnRGbGFzaGluZ0J1dHRvbk5hdmlnYXRpb25JdGVtLmFkZEV2ZW50TGlzdGVuZXIo V2ViSW5zcGVjdG9yLkJ1dHRvbk5hdmlnYXRpb25JdGVtLkV2ZW50LkNsaWNrZWQsIHRoaXMuX3Rv Z2dsZVBhaW50Rmxhc2hpbmcsIHRoaXMpOwotICAgIHRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25O YXZpZ2F0aW9uSXRlbS5lbmFibGVkID0gdHJ1ZTsKKyAgICB0aGlzLl9wYWludEZsYXNoaW5nQnV0 dG9uTmF2aWdhdGlvbkl0ZW0uZW5hYmxlZCA9ICEhUGFnZUFnZW50LnNldFNob3dQYWludFJlY3Rz OworICAgIHRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25OYXZpZ2F0aW9uSXRlbS5hY3RpdmF0ZWQg PSBQYWdlQWdlbnQuc2V0U2hvd1BhaW50UmVjdHMgJiYgV2ViSW5zcGVjdG9yLnNob3dQYWludFJl Y3RzU2V0dGluZy52YWx1ZTsKIAogICAgIFdlYkluc3BlY3Rvci5zaG93U2hhZG93RE9NU2V0dGlu Zy5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHRo aXMuX3Nob3dTaGFkb3dET01TZXR0aW5nQ2hhbmdlZCwgdGhpcyk7CiAgICAgdGhpcy5fc2hvd3NT aGFkb3dET01CdXR0b25OYXZpZ2F0aW9uSXRlbSA9IG5ldyBXZWJJbnNwZWN0b3IuQWN0aXZhdGVC dXR0b25OYXZpZ2F0aW9uSXRlbSgic2hvd3Mtc2hhZG93LURPTSIsIFdlYkluc3BlY3Rvci5VSVN0 cmluZygiU2hvdyBzaGFkb3cgRE9NIG5vZGVzIiksIFdlYkluc3BlY3Rvci5VSVN0cmluZygiSGlk ZSBzaGFkb3cgRE9NIG5vZGVzIiksIHNoYWRvd0RPTUltYWdlLnNyYywgc2hhZG93RE9NSW1hZ2Uu d2lkdGgsIHNoYWRvd0RPTUltYWdlLmhlaWdodCk7CkBAIC00MzAsMTEgKzQzMiw3IEBAIFdlYklu c3BlY3Rvci5ET01UcmVlQ29udGVudFZpZXcucHJvdG90eXBlID0gewogCiAgICAgX3RvZ2dsZVBh aW50Rmxhc2hpbmc6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgY29uc29sZS5hc3Nl cnQoUGFnZUFnZW50LnNldFNob3dQYWludFJlY3RzKTsKLQotICAgICAgICB2YXIgYWN0aXZhdGVk ID0gIXRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25OYXZpZ2F0aW9uSXRlbS5hY3RpdmF0ZWQ7Ci0g ICAgICAgIHRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25OYXZpZ2F0aW9uSXRlbS5hY3RpdmF0ZWQg PSBhY3RpdmF0ZWQ7Ci0gICAgICAgIFBhZ2VBZ2VudC5zZXRTaG93UGFpbnRSZWN0cyhhY3RpdmF0 ZWQpOworICAgICAgICBXZWJJbnNwZWN0b3Iuc2hvd1BhaW50UmVjdHNTZXR0aW5nLnZhbHVlID0g IVdlYkluc3BlY3Rvci5zaG93UGFpbnRSZWN0c1NldHRpbmcudmFsdWU7CiAgICAgfSwKIAogICAg IF91cGRhdGVDb21wb3NpdGluZ0JvcmRlcnNCdXR0b25Ub01hdGNoUGFnZVNldHRpbmdzOiBmdW5j dGlvbigpCkBAIC00NTEsNiArNDQ5LDE1IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlQ29udGVudFZp ZXcucHJvdG90eXBlID0gewogICAgICAgICB9KTsKICAgICB9LAogCisgICAgX3Nob3dQYWludFJl Y3RzU2V0dGluZ0NoYW5nZWQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgY29uc29s ZS5hc3NlcnQoUGFnZUFnZW50LnNldFNob3dQYWludFJlY3RzKTsKKworICAgICAgICB0aGlzLl9w YWludEZsYXNoaW5nQnV0dG9uTmF2aWdhdGlvbkl0ZW0uYWN0aXZhdGVkID0gV2ViSW5zcGVjdG9y LnNob3dQYWludFJlY3RzU2V0dGluZy52YWx1ZTsKKworICAgICAgICBQYWdlQWdlbnQuc2V0U2hv d1BhaW50UmVjdHModGhpcy5fcGFpbnRGbGFzaGluZ0J1dHRvbk5hdmlnYXRpb25JdGVtLmFjdGl2 YXRlZCk7CisgICAgfSwKKwogICAgIF9zaG93U2hhZG93RE9NU2V0dGluZ0NoYW5nZWQ6IGZ1bmN0 aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy5fc2hvd3NTaGFkb3dET01CdXR0b25OYXZp Z2F0aW9uSXRlbS5hY3RpdmF0ZWQgPSBXZWJJbnNwZWN0b3Iuc2hvd1NoYWRvd0RPTVNldHRpbmcu dmFsdWU7Cg==