137664 2014-10-13 11:45:12 -0700 Add StringCapture helper for thread-safe lambda capture 2014-10-13 16:02:58 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned ap benjamin cmarcelo commit-queue zan oldest_to_newest 1041322 0 koivisto 2014-10-13 11:45:12 -0700 . 1041338 1 239740 koivisto 2014-10-13 13:43:23 -0700 Created attachment 239740 patch 1041340 2 commit-queue 2014-10-13 13:45:08 -0700 Attachment 239740 did not pass style-queue: ERROR: Source/WTF/wtf/text/WTFString.h:642: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/text/WTFString.h:643: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1041341 3 239740 andersca 2014-10-13 13:47:22 -0700 Comment on attachment 239740 patch View in context: https://bugs.webkit.org/attachment.cgi?id=239740&action=review > Source/WTF/wtf/text/WTFString.h:637 > +// For thread-safe lambda capture: Could use a FIXME saying that once we use C++14 we don't need this. > Source/WTF/wtf/text/WTFString.h:642 > + explicit StringCapture(const String& string) : m_string(string) { } I think you should add a move constructor as well. > Source/WTF/wtf/text/WTFString.h:644 > + const String& string() const { return m_string; } Maybe add a String string() releaseString { return m_string; } as well? (Of course, in that case the lambda would have to be made mutable). 1041396 4 koivisto 2014-10-13 16:02:58 -0700 https://trac.webkit.org/r174660 239740 2014-10-13 13:43:23 -0700 2014-10-13 13:47:21 -0700 patch string-capture.patch text/plain 2132 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzQ2NTQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEwLTEzICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgU3RyaW5nQ2FwdHVyZSBoZWxwZXIgZm9yIHRo cmVhZC1zYWZlIGxhbWJkYSBjYXB0dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzc2NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVyZSBpcyBjdXJyZW50bHkgbm8gY2xlYW4gd2F5IHRvIGNhcHR1 cmUgU3RyaW5ncyBpbiB0aHJlYWQtc2FmZSBtYW5uZXIuIFRoaXMgd2lsbCBub3cgd29yazoKKwor ICAgICAgICBTdHJpbmdDYXB0dXJlIHN0cmluZ0NhcHR1cmUoc3RyaW5nKTsKKyAgICAgICAgYXV0 byBsYW1iZGFUaGF0UnVuc0luT3RoZXJUaHJlYWQgPSBbc3RyaW5nQ2FwdHVyZV0geyBTdHJpbmcg c3RyaW5nID0gc3RyaW5nQ2FwdHVyZS5zdHJpbmcoKTsgLi4uIH0KKworICAgICAgICBUaGlzIHR5 cGUgd29uJ3QgYmUgbmVjZXNzYXJ5IHdpdGggQysrMTQgaW5pdGlhbGl6ZWQgbGFtYmRhIGNhcHR1 cmU6IFtzdHJpbmcgPSBzdHJpbmcuaXNvbGF0ZWRDb3B5KCldLgorCisgICAgICAgICogd3RmL3Rl eHQvV1RGU3RyaW5nLmg6CisgICAgICAgIChXVEY6OlN0cmluZ0NhcHR1cmU6OlN0cmluZ0NhcHR1 cmUpOiBDcmVhdGUgaXNvbGF0ZWQgY29weSBpbiBjb3B5LWNvbnN0cnVjdG9yLgorICAgICAgICAo V1RGOjpTdHJpbmdDYXB0dXJlOjpzdHJpbmcpOgorCiAyMDE0LTEwLTExICBLd2FuZ0h5dWsgS2lt ICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEVuYWJsZSBXZWJQIHN1 cHBvcnQuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgJKHJldmlzaW9uIDE3NDY1MykKKysr IFNvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzNCw2 ICs2MzQsMjAgQEAgcHJpdmF0ZToKICAgICBjb25zdCBjaGFyKiBtX2NoYXJhY3RlcnM7CiB9Owog CisvLyBGb3IgdGhyZWFkLXNhZmUgbGFtYmRhIGNhcHR1cmU6CisvLyBTdHJpbmdDYXB0dXJlIHN0 cmluZ0NhcHR1cmUoc3RyaW5nKTsKKy8vIGF1dG8gbGFtYmRhVGhhdFJ1bnNJbk90aGVyVGhyZWFk ID0gW3N0cmluZ0NhcHR1cmVdIHsgU3RyaW5nIHN0cmluZyA9IHN0cmluZ0NhcHR1cmUuc3RyaW5n KCk7IC4uLiB9CitjbGFzcyBTdHJpbmdDYXB0dXJlIHsKK3B1YmxpYzoKKyAgICBleHBsaWNpdCBT dHJpbmdDYXB0dXJlKGNvbnN0IFN0cmluZyYgc3RyaW5nKSA6IG1fc3RyaW5nKHN0cmluZykgeyB9 CisgICAgU3RyaW5nQ2FwdHVyZShjb25zdCBTdHJpbmdDYXB0dXJlJiBvdGhlcikgOiBtX3N0cmlu ZyhvdGhlci5tX3N0cmluZy5pc29sYXRlZENvcHkoKSkgeyB9CisgICAgY29uc3QgU3RyaW5nJiBz dHJpbmcoKSBjb25zdCB7IHJldHVybiBtX3N0cmluZzsgfQorCitwcml2YXRlOgorICAgIHZvaWQg b3BlcmF0b3I9KGNvbnN0IFN0cmluZ0NhcHR1cmUmKSA9IGRlbGV0ZTsKKyAgICBTdHJpbmcgbV9z dHJpbmc7Cit9OworCiAvLyBTaGFyZWQgZ2xvYmFsIGVtcHR5IHN0cmluZy4KIFdURl9FWFBPUlRf U1RSSU5HX0FQSSBjb25zdCBTdHJpbmcmIGVtcHR5U3RyaW5nKCk7CiAKQEAgLTY2NCw2ICs2Nzgs NyBAQCB1c2luZyBXVEY6OmlzQWxsU3BlY2lhbENoYXJhY3RlcnM7CiB1c2luZyBXVEY6OmlzU3Bh Y2VPck5ld2xpbmU7CiB1c2luZyBXVEY6OnJldmVyc2VGaW5kOwogdXNpbmcgV1RGOjpBU0NJSUxp dGVyYWw7Cit1c2luZyBXVEY6OlN0cmluZ0NhcHR1cmU7CiAKICNpbmNsdWRlIDx3dGYvdGV4dC9B dG9taWNTdHJpbmcuaD4KICNlbmRpZgo=