137662 2014-10-13 11:28:25 -0700 [iOS] LayoutTestRelay: Detect broken pipe when webkitpy cancels a run 2014-10-15 10:01:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler commit-queue ddkilzer simon.fraser oldest_to_newest 1041313 0 dfarler 2014-10-13 11:28:25 -0700 Rarely, with proper timing, the LayoutTestRelay's simulator app can crash while the didReceiveStderrData and didReceiveStdoutData NSFileHandle delegate methods are running, but the pipe will be broken, so LayoutTestRelay will crash. We should catch NSFileHandleOperationException and call didCrashWithMessage, same as on the write side. We have broken pipe coverage for: webkitpy -> [stdin] LayoutTestRelay -> [stdin] DRT and need coverage for: webkitpy [stdout result] <- LayoutTestRelay [NSFileHandle] <- [stdout] DRT webkitpy [stderr result] <- LayoutTestRelay [NSFileHandle] <- [stderr] DRT 1041317 1 dfarler 2014-10-13 11:28:38 -0700 <rdar://problem/18635888> 1041319 2 dfarler 2014-10-13 11:38:45 -0700 Actually wait, this is on the webkitpy side, so I think this might actually be the case where we timed out, or a run was cancelled, and webkitpy stopped reading our stdout/stderr. I think the proper thing to do is just exit(1) here. 1041321 3 239736 dfarler 2014-10-13 11:45:03 -0700 Created attachment 239736 Patch 1041323 4 commit-queue 2014-10-13 11:46:35 -0700 Attachment 239736 did not pass style-queue: ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:110: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:110: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:122: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:122: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1041873 5 239736 darin 2014-10-15 09:40:55 -0700 Comment on attachment 239736 Patch I suggest naming the exception “exception” rather than “e”. 1041878 6 dfarler 2014-10-15 10:01:16 -0700 Committed r174728: <http://trac.webkit.org/changeset/174728> 1041879 7 dfarler 2014-10-15 10:01:33 -0700 Thanks Darin - 239736 2014-10-13 11:45:03 -0700 2014-10-15 09:40:54 -0700 Patch bug-137662-20141013114507.patch text/plain 2495 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2Q0OTMwN2YwMjFlZDdkMTI2YmYyMjM3MzllMzZkY2Vh NjI4MDkyNy4uYWYxYjVmMTg2ZDE2ZWZjZDY1ZTZkOTYwMWYxMzExOTBmZjhmODE1MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE0LTEwLTEzICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBMYXlvdXRUZXN0UmVsYXk6IERldGVjdCBicm9rZW4gcGlwZSB3aGVuIHJlYWRp bmcgc2ltdWxhdG9yIGFwcCdzIHN0ZG91dCBhbmQgc3RkZXJyLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NjYyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGxheW91dCB0ZXN0IGhhcm5lc3MgY2Fu IGNsb3NlIExheW91dFRlc3RSZWxheSdzIHN1YnByb2Nlc3MKKyAgICAgICAgc3Rkb3V0IGFuZCBz dGRlcnIgaW4gdGhlIGNhc2Ugb2YgYSB0aW1lb3V0IG9yIGlmIGEgcnVuIGlzCisgICAgICAgIGNh bmNlbGxlZCBhbmQgdGhlIEZJRk9zIGFyZSBjbGVhbmVkIHVwLiBJZiBMYXlvdXRUZXN0UmVsYXkK KyAgICAgICAgZmluZHMgdGhhdCBubyBvbmUgaXMgbGlzdGVuaW5nIHRvIGl0cyBzdGRvdXQvc3Rk ZXJyIChicm9rZW4KKyAgICAgICAgcGlwZSksIHRoZW4ganVzdCBleGl0KDEpLCB0aGVyZSBpcyBu b3RoaW5nIHRvIHJlcG9ydC4KKworICAgICAgICAqIExheW91dFRlc3RSZWxheS9MYXlvdXRUZXN0 UmVsYXkvTFRSZWxheUNvbnRyb2xsZXIubToKKyAgICAgICAgKC1bTFRSZWxheUNvbnRyb2xsZXIg ZGlkUmVjZWl2ZVN0ZG91dERhdGE6XSk6CisgICAgICAgIEFkZCBAdHJ5L0BjYXRjaCBmb3IgTlNG aWxlSGFuZGxlT3BlcmF0aW9uRXhjZXB0aW9uLgorICAgICAgICAoLVtMVFJlbGF5Q29udHJvbGxl ciBkaWRSZWNlaXZlU3RkZXJyRGF0YTpdKToKKyAgICAgICAgQWRkIEB0cnkvQGNhdGNoIGZvciBO U0ZpbGVIYW5kbGVPcGVyYXRpb25FeGNlcHRpb24uCisKIDIwMTQtMTAtMTAgIERhdmlkIEZhcmxl ciAgPGRmYXJsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIExheW91dFRlc3RSZWxheSBz aG91bGQgZW5zdXJlIGl0cyBEUlQvV0tUUiBkaWVzIHdoZW4gcmVjZWl2aW5nIGtpbGwvdGVybSBz aWduYWxzCmRpZmYgLS1naXQgYS9Ub29scy9MYXlvdXRUZXN0UmVsYXkvTGF5b3V0VGVzdFJlbGF5 L0xUUmVsYXlDb250cm9sbGVyLm0gYi9Ub29scy9MYXlvdXRUZXN0UmVsYXkvTGF5b3V0VGVzdFJl bGF5L0xUUmVsYXlDb250cm9sbGVyLm0KaW5kZXggNjMxYzBlZmI1NzMyOTMwY2FiNjE4YmUxMjk4 M2JkNTY5OGEzOGVjNi4uOWRiYWE0NzE5NWJlZjRhOGJjODkxZGU2YTViYjg2ZTNiYjI2YTBmZCAx MDA2NDQKLS0tIGEvVG9vbHMvTGF5b3V0VGVzdFJlbGF5L0xheW91dFRlc3RSZWxheS9MVFJlbGF5 Q29udHJvbGxlci5tCisrKyBiL1Rvb2xzL0xheW91dFRlc3RSZWxheS9MYXlvdXRUZXN0UmVsYXkv TFRSZWxheUNvbnRyb2xsZXIubQpAQCAtMTA1LDEyICsxMDUsMjYgQEAgLSAoTlNTdHJpbmcgKilw cm9jZXNzTmFtZQogCiAtICh2b2lkKWRpZFJlY2VpdmVTdGRvdXREYXRhOihOU0RhdGEgKilkYXRh CiB7Ci0gICAgW1tzZWxmIHN0YW5kYXJkT3V0cHV0XSB3cml0ZURhdGE6ZGF0YV07CisgICAgQHRy eSB7CisgICAgICAgIFtbc2VsZiBzdGFuZGFyZE91dHB1dF0gd3JpdGVEYXRhOmRhdGFdOworICAg IH0gQGNhdGNoIChOU0V4Y2VwdGlvbiAqZSkgeworICAgICAgICAvLyBOU0ZpbGVIYW5kbGVPcGVy YXRpb25FeGNlcHRpb24KKyAgICAgICAgLy8gQnJva2VuIHBpcGUgLSB0aGUgdGVzdCBoYXJuZXNz IHN0b3BwZWQgbGlzdGVuaW5nIHRvIHVzLAorICAgICAgICAvLyBwcm9iYWJseSBiZWNhdXNlIHdl IHRpbWVkIG91dCBvciBhIHJ1biB3YXMgY2FuY2VsZWQuCisgICAgICAgIGV4aXQoRVhJVF9GQUlM VVJFKTsKKyAgICB9CiB9CiAKIC0gKHZvaWQpZGlkUmVjZWl2ZVN0ZGVyckRhdGE6KE5TRGF0YSAq KWRhdGEKIHsKLSAgICBbW3NlbGYgc3RhbmRhcmRFcnJvcl0gd3JpdGVEYXRhOmRhdGFdOworICAg IEB0cnkgeworICAgICAgICBbW3NlbGYgc3RhbmRhcmRFcnJvcl0gd3JpdGVEYXRhOmRhdGFdOwor ICAgIH0gQGNhdGNoIChOU0V4Y2VwdGlvbiAqZSkgeworICAgICAgICAvLyBOU0ZpbGVIYW5kbGVP cGVyYXRpb25FeGNlcHRpb24KKyAgICAgICAgLy8gQnJva2VuIHBpcGUgLSB0aGUgdGVzdCBoYXJu ZXNzIHN0b3BwZWQgbGlzdGVuaW5nIHRvIHVzLAorICAgICAgICAvLyBwcm9iYWJseSBiZWNhdXNl IHdlIHRpbWVkIG91dCBvciBhIHJ1biB3YXMgY2FuY2VsZWQuCisgICAgICAgIGV4aXQoRVhJVF9G QUlMVVJFKTsKKyAgICB9CiB9CiAKIC0gKHZvaWQpZGlkRGlzY29ubmVjdAo=