<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137656</bug_id>
          
          <creation_ts>2014-10-13 05:26:17 -0700</creation_ts>
          <short_desc>[GTK][CMake] Non-ninja build is broken since r174422</short_desc>
          <delta_ts>2014-10-13 23:58:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk, Regression</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gustavo</cc>
    
    <cc>pnormand</cc>
    
    <cc>svillar</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1041269</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-13 05:26:17 -0700</bug_when>
    <thetext>For some reason CMake doesn&apos;t know how to generate DerivedSources/WebInspectorUI/UserInterface/Protocol/InspectorJSBackendCommands.js. The rule is there and it works when using ninja. It even fails if JavaScriptCore is built before and the file is already generated. 

make[2]: *** No rule to make target &apos;DerivedSources/WebInspectorUI/UserInterface/Protocol/InspectorJSBackendCommands.js&apos;, needed by &apos;DerivedSources/webkit2gtk/InspectorGResourceBundle.xml&apos;.  Alto.
[  1%] [  1%] CMakeFiles/Makefile2:986: recipe for target &apos;Source/WebKit2/CMakeFiles/WebKit2-forwarding-headers.dir/all&apos; failed
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2-forwarding-headers.dir/all] Error 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041270</commentid>
    <comment_count>1</comment_count>
      <attachid>239723</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-13 05:29:28 -0700</bug_when>
    <thetext>Created attachment 239723
Patch

Making the forwarding headers generation rule not depend on generated sources seems to fix the problem</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041273</commentid>
    <comment_count>2</comment_count>
      <attachid>239723</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2014-10-13 06:13:55 -0700</bug_when>
    <thetext>Comment on attachment 239723
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239723&amp;action=review

Do not have enough knowledge to review this...

&gt; Source/WebKit2/ChangeLog:3
&gt; +        [GTK][CMake] Non-nonja build is broken since r174422

Nit: ninja</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041275</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-13 06:16:14 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 239723 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=239723&amp;action=review
&gt; 
&gt; Do not have enough knowledge to review this...
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:3
&gt; &gt; +        [GTK][CMake] Non-nonja build is broken since r174422
&gt; 
&gt; Nit: ninja

Oops</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041486</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-13 23:58:31 -0700</bug_when>
    <thetext>Committed r174671: &lt;http://trac.webkit.org/changeset/174671&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239723</attachid>
            <date>2014-10-13 05:29:28 -0700</date>
            <delta_ts>2014-10-13 07:25:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk-forwarding-headers-generated-sources.diff</filename>
            <type>text/plain</type>
            <size>2853</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktp
dDIvQ01ha2VMaXN0cy50eHQKaW5kZXggNGE0NjU0NS4uYTc2MDg0MiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0
cy50eHQKQEAgLTY4NSwxMSArNjg1LDExIEBAIGVuZG1hY3JvKCkKIAogV0VCS0lUX0lOQ0xVREVf
Q09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCiAKLUdFTkVSQVRFX1dFQktJVDJfTUVTU0FHRV9TT1VS
Q0VTKFdlYktpdDJfU09VUkNFUyAiJHtXZWJLaXQyX01FU1NBR0VTX0lOX0ZJTEVTfSIpCitHRU5F
UkFURV9XRUJLSVQyX01FU1NBR0VfU09VUkNFUyhXZWJLaXQyX0RFUklWRURfU09VUkNFUyAiJHtX
ZWJLaXQyX01FU1NBR0VTX0lOX0ZJTEVTfSIpCiAKIGFkZF9kZWZpbml0aW9ucygtREJVSUxESU5H
X1dFQktJVCkKIGluY2x1ZGVfZGlyZWN0b3JpZXMoJHtXZWJLaXQyX0lOQ0xVREVfRElSRUNUT1JJ
RVN9KQotYWRkX2xpYnJhcnkoV2ViS2l0MiAke1dlYktpdDJfTElCUkFSWV9UWVBFfSAke1dlYktp
dDJfU09VUkNFU30pCithZGRfbGlicmFyeShXZWJLaXQyICR7V2ViS2l0Ml9MSUJSQVJZX1RZUEV9
ICR7V2ViS2l0Ml9TT1VSQ0VTfSAke1dlYktpdDJfREVSSVZFRF9TT1VSQ0VTfSkKIAogYWRkX2Rl
cGVuZGVuY2llcyhXZWJLaXQyIFdlYkNvcmUpCiBhZGRfZGVwZW5kZW5jaWVzKFdlYktpdDIgJHtX
RUJLSVQyX0VYVFJBX0RFUEVOREVOQ0lFU30pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmFiZjI4MS4uYWYxZDg5
MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0xMC0xMyAgQ2FybG9zIEdhcmNp
YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bQ01ha2VdIE5v
bi1ub25qYSBidWlsZCBpcyBicm9rZW4gc2luY2UgcjE3NDQyMgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NjU2CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBXZWJLaXQyLWZvcndhcmRpbmctaGVh
ZGVycyBkZXBlbmQgb25seSBvbiBzdGF0aWMsCisgICAgICAgIG5vbi1nZW5lcmF0ZWQgc291cmNl
cy4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorICAgICAgICAqIFBsYXRmb3JtR1RLLmNt
YWtlOgorCiAyMDE0LTEwLTEyICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEu
Y29tPgogCiAgICAgICAgIFtTT1VQXSBbV0syXSBXZWJQcm9jZXNzIGFuZCBOZXR3b3JrUHJvY2Vz
cyBpbml0aWFsaXphdGlvbiBjbGVhcnMgY2FjaGUgY29udGVudHMKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsu
Y21ha2UKaW5kZXggZmZkNjIzZC4uMzlhZmM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv
UGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UK
QEAgLTE1LDEzICsxNSw2IEBAIGFkZF9kZWZpbml0aW9ucygtRExJQkRJUj0iJHtMSUJfSU5TVEFM
TF9ESVJ9IikKIHNldChXZWJLaXQyX1VTRV9QUkVGSVhfSEVBREVSIE9OKQogCiBsaXN0KEFQUEVO
RCBXZWJLaXQyX1NPVVJDRVMKLSAgICAke0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0RJUn0v
SW5zcGVjdG9yR1Jlc291cmNlQnVuZGxlLmMKLSAgICAke0RFUklWRURfU09VUkNFU19XRUJLSVQy
R1RLX0RJUn0vV2ViS2l0Mkluc3BlY3RvckdSZXNvdXJjZUJ1bmRsZS5jCi0gICAgJHtERVJJVkVE
X1NPVVJDRVNfV0VCS0lUMkdUS19ESVJ9L1dlYktpdDJSZXNvdXJjZXNHUmVzb3VyY2VCdW5kbGUu
YwotCi0gICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19BUElfRElSfS9XZWJLaXRFbnVt
VHlwZXMuY3BwCi0gICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19BUElfRElSfS9XZWJL
aXRNYXJzaGFsLmNwcAotCiAgICAgTmV0d29ya1Byb2Nlc3MvZ3RrL05ldHdvcmtQcm9jZXNzTWFp
bkd0ay5jcHAKIAogICAgIE5ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNw
cApAQCAtMzE1LDYgKzMwOCwxNSBAQCBsaXN0KEFQUEVORCBXZWJLaXQyX1NPVVJDRVMKICAgICBX
ZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwCiApCiAKK2xpc3QoQVBQRU5EIFdlYktp
dDJfREVSSVZFRF9TT1VSQ0VTCisgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19ESVJ9
L0luc3BlY3RvckdSZXNvdXJjZUJ1bmRsZS5jCisgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lU
MkdUS19ESVJ9L1dlYktpdDJJbnNwZWN0b3JHUmVzb3VyY2VCdW5kbGUuYworICAgICR7REVSSVZF
RF9TT1VSQ0VTX1dFQktJVDJHVEtfRElSfS9XZWJLaXQyUmVzb3VyY2VzR1Jlc291cmNlQnVuZGxl
LmMKKworICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfQVBJX0RJUn0vV2ViS2l0RW51
bVR5cGVzLmNwcAorICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfQVBJX0RJUn0vV2Vi
S2l0TWFyc2hhbC5jcHAKKykKKwogc2V0KFdlYktpdDJHVEtfSU5TVEFMTEVEX0hFQURFUlMKICAg
ICAke0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0FQSV9ESVJ9L1dlYktpdEVudW1UeXBlcy5o
CiAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19BUElfRElSfS9XZWJLaXRWZXJzaW9u
LmgK
</data>
<flag name="review"
          id="264445"
          type_id="1"
          status="+"
          setter="pnormand"
    />
          </attachment>
      

    </bug>

</bugzilla>