137655 2014-10-13 03:40:22 -0700 Fix the !ENABLE(VIDEO) build after r174353 2014-10-14 01:14:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137218 1 ossy ossy adachan commit-queue eric.carlson esprehn+autocc kangil.han ossy oldest_to_newest 1041265 0 ossy 2014-10-13 03:40:22 -0700 Fix the !ENABLE(VIDEO) build after r174353 1041266 1 239722 ossy 2014-10-13 03:40:54 -0700 Created attachment 239722 Patch Linking CXX shared library ../../lib/libewebkit2.so ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/dom/Document.cpp.o: In function WebCore::Document::updateIsPlayingAudio(): Document.cpp:(.text._ZN7WebCore8Document20updateIsPlayingAudioEv+0x44): undefined reference to WebCore::MediaSession::hasMediaCharacteristics(unsigned int) const collect2: error: ld returned 1 exit status 1041302 2 adachan 2014-10-13 10:45:57 -0700 Thanks for fixing, Csaba. 1041495 3 239722 commit-queue 2014-10-14 01:14:04 -0700 Comment on attachment 239722 Patch Clearing flags on attachment: 239722 Committed r174674: <http://trac.webkit.org/changeset/174674> 1041496 4 commit-queue 2014-10-14 01:14:08 -0700 All reviewed patches have been landed. Closing bug. 239722 2014-10-13 03:40:54 -0700 2014-10-14 01:14:02 -0700 Patch bug-137655-20141013124057.patch text/plain 3444 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGI5NDQ2ZDFlZDg3YzQ4 ZjNmYzU2MDU2MDVjN2Q3YmU0ZDM5MmUzOS4uNDIyMGE0YzM2NmE1MDFiN2JmNDkwMmVlMzM0Nzhi YjFmNTVmYWUwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEwLTEzICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKFZJREVPKSBidWlsZCBhZnRlciByMTc0MzUzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc2NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgICogZG9t L0RvY3VtZW50Lmg6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKiBwYWdlL1Bh Z2UuaDoKKwogMjAxNC0wOS0zMCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlh LmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBQYXNzIHRoZSB2YWxpZCBzZXQgb2Yg dHJhY2tzIHRvIGdyb3cgYmV5b25kIGdyb3d0aCBsaW1pdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CmluZGV4IGVlM2E1NzA1MDc4ZWY5MDkzNDg1OGI2MGI1ZTAxYzM2MGYxMmI4ZWEuLjkzN2UyZDky ZTY0ZTJkMmVkNDM1ZTE5YjkxNGI1ODhiZTgwNTk5NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cApAQCAtMzI2OSw2ICszMjY5LDcgQEAgdm9pZCBEb2N1bWVudDo6dXBkYXRlVmlld3BvcnRVbml0 c09uUmVzaXplKCkKICAgICB9CiB9CiAKKyNpZiBFTkFCTEUoVklERU8pCiB2b2lkIERvY3VtZW50 OjpyZWdpc3Rlck1lZGlhU2Vzc2lvbihNZWRpYVNlc3Npb24mIG1lZGlhU2Vzc2lvbikKIHsKICAg ICBtX21lZGlhU2Vzc2lvbnMuYWRkKCZtZWRpYVNlc3Npb24pOwpAQCAtMzI5OSw2ICszMzAwLDcg QEAgdm9pZCBEb2N1bWVudDo6dXBkYXRlSXNQbGF5aW5nQXVkaW8oKQogICAgIGlmIChwYWdlKCkp CiAgICAgICAgIHBhZ2UoKS0+dXBkYXRlSXNQbGF5aW5nQXVkaW8oKTsKIH0KKyNlbmRpZgogCiB2 b2lkIERvY3VtZW50OjpzdHlsZVJlc29sdmVyQ2hhbmdlZChTdHlsZVJlc29sdmVyVXBkYXRlRmxh ZyB1cGRhdGVGbGFnKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCA2YmRjMDYyMGI0Njc0MGQx YTIwZTBjNmYzNWZlZTRkYzZiNjRhY2JkLi5hNTE3ZDNiNWY3YjY3Nzk0NmVkYzllYTI0YTlhNzZk MjFhOWIxZTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaApAQCAtMTI4OSwxMCArMTI4OSwxMiBAQCBw dWJsaWM6CiAgICAgYm9vbCBoYXNTdHlsZVdpdGhWaWV3cG9ydFVuaXRzKCkgY29uc3QgeyByZXR1 cm4gbV9oYXNTdHlsZVdpdGhWaWV3cG9ydFVuaXRzOyB9CiAgICAgdm9pZCB1cGRhdGVWaWV3cG9y dFVuaXRzT25SZXNpemUoKTsKIAorI2lmIEVOQUJMRShWSURFTykKICAgICB2b2lkIHJlZ2lzdGVy TWVkaWFTZXNzaW9uKE1lZGlhU2Vzc2lvbiYpOwogICAgIHZvaWQgdW5yZWdpc3Rlck1lZGlhU2Vz c2lvbihNZWRpYVNlc3Npb24mKTsKICAgICBib29sIGlzUGxheWluZ0F1ZGlvKCkgY29uc3QgeyBy ZXR1cm4gbV9pc1BsYXlpbmdBdWRpbzsgfQogICAgIHZvaWQgdXBkYXRlSXNQbGF5aW5nQXVkaW8o KTsKKyNlbmRpZgogCiBwcm90ZWN0ZWQ6CiAgICAgZW51bSBDb25zdHJ1Y3Rpb25GbGFncyB7IFN5 bnRoZXNpemVkID0gMSwgTm9uUmVuZGVyZWRQbGFjZWhvbGRlciA9IDEgPDwgMSB9OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv UGFnZS5jcHAKaW5kZXggM2FkYTdlZGNhZGQyZDIxNTA1Y2NjYTAzNmI3YzIyNTE5OTVkMmMyZC4u NDM4NjQyNzQ1MTYxZThiNzUyODhmNDg0MjlmMjJlZWZhODk1MWQyOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu Y3BwCkBAIC0xMTkzLDYgKzExOTMsNyBAQCB2b2lkIFBhZ2U6OmVuYWJsZUxlZ2FjeVByaXZhdGVC cm93c2luZyhib29sIHByaXZhdGVCcm93c2luZ0VuYWJsZWQpCiAgICAgc2V0U2Vzc2lvbklEKHBy aXZhdGVCcm93c2luZ0VuYWJsZWQgPyBTZXNzaW9uSUQ6OmxlZ2FjeVByaXZhdGVTZXNzaW9uSUQo KSA6IFNlc3Npb25JRDo6ZGVmYXVsdFNlc3Npb25JRCgpKTsKIH0KIAorI2lmIEVOQUJMRShWSURF TykKIHZvaWQgUGFnZTo6dXBkYXRlSXNQbGF5aW5nQXVkaW8oKQogewogICAgIGJvb2wgaXNQbGF5 aW5nQXVkaW8gPSBmYWxzZTsKQEAgLTEyMTAsNiArMTIxMSw3IEBAIHZvaWQgUGFnZTo6dXBkYXRl SXNQbGF5aW5nQXVkaW8oKQogCiAgICAgY2hyb21lKCkuY2xpZW50KCkuaXNQbGF5aW5nQXVkaW9E aWRDaGFuZ2UobV9pc1BsYXlpbmdBdWRpbyk7CiB9CisjZW5kaWYKIAogI2lmICFBU1NFUlRfRElT QUJMRUQKIHZvaWQgUGFnZTo6Y2hlY2tTdWJmcmFtZUNvdW50Q29uc2lzdGVuY3koKSBjb25zdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmggYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BhZ2UuaAppbmRleCBjOTI3ZTIxMDQxNTkzZDcwYTkyZTBkODg0MTZkZmM3NTIzZDY0YjFj Li5jMTZjMGEzNTYxZmFhMWU2M2ViZWRkNWU4ZDJhMjdmYzMyMjYxYmJiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu aApAQCAtNDM2LDggKzQzNiwxMCBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBl bmFibGVMZWdhY3lQcml2YXRlQnJvd3NpbmcoYm9vbCBwcml2YXRlQnJvd3NpbmdFbmFibGVkKTsK ICAgICBib29sIHVzZXNFcGhlbWVyYWxTZXNzaW9uKCkgY29uc3QgeyByZXR1cm4gbV9zZXNzaW9u SUQuaXNFcGhlbWVyYWwoKTsgfQogCisjaWYgRU5BQkxFKFZJREVPKQogICAgIGJvb2wgaXNQbGF5 aW5nQXVkaW8oKSBjb25zdCB7IHJldHVybiBtX2lzUGxheWluZ0F1ZGlvOyB9CiAgICAgdm9pZCB1 cGRhdGVJc1BsYXlpbmdBdWRpbygpOworI2VuZGlmCiAKIHByaXZhdGU6CiAgICAgV0VCQ09SRV9F WFBPUlQgdm9pZCBpbml0R3JvdXAoKTsK