137650 2014-10-12 12:41:49 -0700 iOS DRT snapshots are limited to the page visible area 2014-12-11 15:26:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue dbates dfarler simon.fraser thorton oldest_to_newest 1041219 0 simon.fraser 2014-10-12 12:41:49 -0700 iOS DRT snapshots are limited to the page visible area 1041220 1 239707 simon.fraser 2014-10-12 12:44:38 -0700 Created attachment 239707 Patch 1041221 2 dfarler 2014-10-12 13:06:42 -0700 Are we OK to keep the iPhone models as the default then? 1041222 3 simon.fraser 2014-10-12 13:29:53 -0700 I wasn't able to successfully get iPad Air models working. Even if I did, we'd have to do rotation to get the entire 800x600, so I think this is simpler. 1041235 4 239707 dbates 2014-10-12 23:13:40 -0700 Comment on attachment 239707 Patch This looks sane to me. Does this patch resolve or help us resolve <rdar://problem/14637393>? 1041374 5 239707 commit-queue 2014-10-13 15:18:59 -0700 Comment on attachment 239707 Patch Rejecting attachment 239707 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 239707, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: portIOS.mm Hunk #1 FAILED at 60. Hunk #2 FAILED at 76. 2 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm.rej patching file Tools/DumpRenderTree/mac/DumpRenderTreeWindow.mm Hunk #1 FAILED at 81. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/mac/DumpRenderTreeWindow.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Daniel Bates']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4676569930924032 1054644 6 simon.fraser 2014-12-11 15:26:43 -0800 http://trac.webkit.org/changeset/174650 239707 2014-10-12 12:44:38 -0700 2014-10-13 15:18:59 -0700 Patch bug-137650-20141012124442.patch text/plain 6325 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU4ZDc0NTZhMmJjNTE2 MjAxOTQzZmQ2OWUxZGU0MWMxZjExYzM0My4uZGFkOTYyODZkYzIxMjlkYjk4NzUxMjIxOTNjZWE2 OTNjOTMxMjUxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEwLTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIGlPUyBEUlQgc25h cHNob3RzIGFyZSBsaW1pdGVkIHRvIHRoZSBwYWdlIHZpc2libGUgYXJlYQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NjUwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGVnYWN5VGlsZUNhY2hlIGRyYXdp bmcgd2FzIGxpbWl0ZWQgdG8gdGhlIHdpbmRvdydzIHZpc2libGUgYXJlYSwgZm91bmQgYnkKKyAg ICAgICAgY3Jhd2xpbmcgdXAgdGhlIGxheWVyIGhpZXJhcmNoeSB0byB0aGUgcm9vdCBsYXllci4g VGhpcyBjYXVzZWQgdGVzdCBzbmFwc2hvdHMgdG8KKyAgICAgICAgYmUgbWlzc2luZyBub24tY29t cG9zaXRlZCBjb250ZW50IG91dHNpZGUgdGhlIGlQaG9uZSB2aXNpYmxlIGFyZWEsIHdoaWNoIGhp bmRlcnMKKyAgICAgICAgdGVzdGluZy4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSBhZGRpbmcg YSB0ZXN0LW9ubHkgbW9kZSB3aGVyZSB0aGUgd2luZG93IHZpc2libGUgYXJlYSBpcyB0aGUgZW50 aXJlIHdpbmRvdy4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lmg6Cisg ICAgICAgICogcGxhdGZvcm0vaW9zL3dhay9XQUtXaW5kb3cubW06CisgICAgICAgICgtW1dBS1dp bmRvdyBzZXRFbnRpcmVXaW5kb3dWaXNpYmxlRm9yVGVzdGluZzpdKToKKyAgICAgICAgKC1bV0FL V2luZG93IF92aXNpYmxlUmVjdFJlc3BlY3RpbmdNYXNrc1RvQm91bmRzOl0pOgorCiAyMDE0LTEw LTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGlzPD4o KSAvIGRvd25jYXN0PD4oKSBmb3IgSW1hZ2Ugc3ViY2xhc3NlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtXaW5kb3cuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy93YWsvV0FLV2luZG93LmgKaW5kZXggM2NmYTNjOTdjZjdkNGM4M2Q4NTVkZDI3 OTU4ZGYyYmQyNjAzZmI1Ni4uM2Q5NjBlMDczZTE3ZDI5NjY4ZDQ3ZDkxN2U3ZmNhOTBiZGEwMDY3 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtXaW5kb3cu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1dpbmRvdy5oCkBAIC04 NSw2ICs4NSw3IEBAIGV4dGVybiBOU1N0cmluZyAqIGNvbnN0IFdBS1dpbmRvd1Zpc2liaWxpdHlE aWRDaGFuZ2VOb3RpZmljYXRpb247CiAKICAgICBCT09MIF92aXNpYmxlOwogICAgIEJPT0wgX3Vz ZU9yaWVudGF0aW9uRGVwZW5kZW50Rm9udEFudGlhbGlhc2luZzsKKyAgICBCT09MIF9lbnRpcmVX aW5kb3dWaXNpYmxlRm9yVGVzdGluZzsKIH0KIAogQHByb3BlcnR5IChub25hdG9taWMsIGFzc2ln bikgQk9PTCB1c2VPcmllbnRhdGlvbkRlcGVuZGVudEZvbnRBbnRpYWxpYXNpbmc7CkBAIC0xMzIs NiArMTMzLDggQEAgZXh0ZXJuIE5TU3RyaW5nICogY29uc3QgV0FLV2luZG93VmlzaWJpbGl0eURp ZENoYW5nZU5vdGlmaWNhdGlvbjsKIC0gKENHUmVjdClleHBvc2VkU2Nyb2xsVmlld1JlY3Q7CiAv LyBzZXRFeHBvc2VkU2Nyb2xsVmlld1JlY3Qgc2hvdWxkIG9ubHkgZXZlciBiZSBjYWxsZWQgZnJv bSBVSUtpdC4KIC0gKHZvaWQpc2V0RXhwb3NlZFNjcm9sbFZpZXdSZWN0OihDR1JlY3QpZXhwb3Nl ZFNjcm9sbFZpZXdSZWN0OworLy8gVXNlZCBvbmx5IGJ5IER1bXBSZW5kZXJUcmVlLgorLSAodm9p ZClzZXRFbnRpcmVXaW5kb3dWaXNpYmxlRm9yVGVzdGluZzooQk9PTCllbnRpcmVXaW5kb3dWaXNp YmxlOwogCiAvLyBUaWxpbmcgc3VwcG9ydAogLSAodm9pZClsYXlvdXRUaWxlczsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtXaW5kb3cubW0KaW5kZXggMTYzMWUwOTZjMjcw ZWYzMWU4YmYzYmFkN2ZjYTAwZGUxZGFkODg5MC4uNjc0YTNlNDU1YmRhMzIwMWIyOGViNTZkMzMy NWMyZTFlN2E2YjRjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dh ay9XQUtXaW5kb3cubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtX aW5kb3cubW0KQEAgLTQyNSw2ICs0MjUsMTEgQEAgLSAodm9pZClzZXRUaWxlc09wYXF1ZTooQk9P TClvcGFxdWUKICAgICBfdGlsZUNhY2hlLT5zZXRUaWxlc09wYXF1ZShvcGFxdWUpOwogfQogCist ICh2b2lkKXNldEVudGlyZVdpbmRvd1Zpc2libGVGb3JUZXN0aW5nOihCT09MKWVudGlyZVdpbmRv d1Zpc2libGUKK3sKKyAgICBfZW50aXJlV2luZG93VmlzaWJsZUZvclRlc3RpbmcgPSBlbnRpcmVX aW5kb3dWaXNpYmxlOworfQorCiAtIChDR1JlY3QpX3Zpc2libGVSZWN0UmVzcGVjdGluZ01hc2tz VG9Cb3VuZHM6KEJPT0wpcmVzcGVjdHNNYXNrc1RvQm91bmRzCiB7CiAgICAgaWYgKCFDR1JlY3RJ c051bGwoX2Zyb3plblZpc2libGVSZWN0KSkKQEAgLTQzMiw2ICs0MzcsOCBAQCAtIChDR1JlY3Qp X3Zpc2libGVSZWN0UmVzcGVjdGluZ01hc2tzVG9Cb3VuZHM6KEJPT0wpcmVzcGVjdHNNYXNrc1Rv Qm91bmRzCiAKICAgICBDQUxheWVyKiBsYXllciA9IF9ob3N0TGF5ZXI7CiAgICAgQ0dSZWN0IGJv dW5kcyA9IFtsYXllciBib3VuZHNdOworICAgIGlmIChfZW50aXJlV2luZG93VmlzaWJsZUZvclRl c3RpbmcpCisgICAgICAgIHJldHVybiBib3VuZHM7CiAgICAgQ0dSZWN0IHJlY3QgPSBib3VuZHM7 CiAgICAgQ0FMYXllciogc3VwZXJsYXllciA9IFtsYXllciBzdXBlcmxheWVyXTsKIApkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGIyNWEzY2I5ZDg5 MzRhNDI2Yjk0YzI4ODAyOGZjZjRmZWQzMWQyNjguLmU4YWFkODYyZGQzYzQ0NzhkMDBhMDhiMzYx MWFjYjNjZTRhNjQ1NzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxNC0xMC0xMiAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBpT1MgRFJUIHNuYXBzaG90cyBhcmUgbGlt aXRlZCB0byB0aGUgcGFnZSB2aXNpYmxlIGFyZWEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzY1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTGVnYWN5VGlsZUNhY2hlIGRyYXdpbmcgd2Fz IGxpbWl0ZWQgdG8gdGhlIHdpbmRvdydzIHZpc2libGUgYXJlYSwgZm91bmQgYnkKKyAgICAgICAg Y3Jhd2xpbmcgdXAgdGhlIGxheWVyIGhpZXJhcmNoeSB0byB0aGUgcm9vdCBsYXllci4gVGhpcyBj YXVzZWQgdGVzdCBzbmFwc2hvdHMgdG8KKyAgICAgICAgYmUgbWlzc2luZyBub24tY29tcG9zaXRl ZCBjb250ZW50IG91dHNpZGUgdGhlIGlQaG9uZSB2aXNpYmxlIGFyZWEsIHdoaWNoIGhpbmRlcnMK KyAgICAgICAgdGVzdGluZy4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSBhZGRpbmcgYSB0ZXN0 LW9ubHkgbW9kZSB3aGVyZSB0aGUgd2luZG93IHZpc2libGUgYXJlYSBpcyB0aGUgZW50aXJlIHdp bmRvdy4KKyAgICAgICAgCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvaW9zL1BpeGVsRHVtcFN1 cHBvcnRJT1MubW06CisgICAgICAgIChkdW1wV2ViVmlld0FzUGl4ZWxzQW5kQ29tcGFyZVdpdGhF eHBlY3RlZCk6IERyaXZlLWJ5IFJldGFpblB0ciBmaXguCisgICAgICAgICogRHVtcFJlbmRlclRy ZWUvbWFjL0R1bXBSZW5kZXJUcmVlV2luZG93Lm1tOgorICAgICAgICAoLVtEdW1wUmVuZGVyVHJl ZVdpbmRvdyBpbml0V2l0aExheWVyOl0pOiBDYWxsIHNldEVudGlyZVdpbmRvd1Zpc2libGVGb3JU ZXN0aW5nOllFUworICAgICAgICBmb3IgdGhlIERSVCB3aW5kb3cuCisgICAgICAgIAorCiAyMDE0 LTEwLTExICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFBhZ2Ugbm90IGZ1bGx5IHJlbmRlcmVkIGluIGlPUyBEUlQgc25hcHNob3RzCmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9pb3MvUGl4ZWxEdW1wU3VwcG9ydElPUy5tbSBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2lvcy9QaXhlbER1bXBTdXBwb3J0SU9TLm1tCmluZGV4IGNmY2RjYjli Y2FmYjdhMWI2ODFmMjYwMzQ2NWQ2N2ExNGQ1ODlhYzkuLjMyMmNhNzI1YmFiYTZmN2NlZWI5OTdj NTAyMmQyMDk0ZGViY2Q3MGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2lvcy9Q aXhlbER1bXBTdXBwb3J0SU9TLm1tCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2lvcy9QaXhl bER1bXBTdXBwb3J0SU9TLm1tCkBAIC02MCw4ICs2MCw4IEBAIHZvaWQgZHVtcFdlYlZpZXdBc1Bp eGVsc0FuZENvbXBhcmVXaXRoRXhwZWN0ZWQoY29uc3Qgc3RkOjpzdHJpbmcmIGV4cGVjdGVkSGFz aCkKICAgICBXZWJUaHJlYWRMb2NrKCk7CiAgICAgW2dXZWJCcm93c2VyVmlldyBzZXROZWVkc0Rp c3BsYXldOwogICAgIFtnV2ViQnJvd3NlclZpZXcgbGF5b3V0VGlsZXNOb3ddOwotICAgIENHSW1h Z2VSZWYgc25hcHNob3QgPSBbZ1dlYkJyb3dzZXJWaWV3IGNyZWF0ZVNuYXBzaG90V2l0aFJlY3Q6 W1ttYWluRnJhbWUgd2ViVmlld10gZnJhbWVdXTsKLSAgICBOU0RhdGEgKnBuZ0RhdGEgPSBVSUlt YWdlUE5HUmVwcmVzZW50YXRpb24oW1VJSW1hZ2UgaW1hZ2VXaXRoQ0dJbWFnZTpzbmFwc2hvdF0p OworICAgIFJldGFpblB0cjxDR0ltYWdlUmVmPiBzbmFwc2hvdCA9IGFkb3B0Q0YoW2dXZWJCcm93 c2VyVmlldyBuZXdTbmFwc2hvdFdpdGhSZWN0OltbbWFpbkZyYW1lIHdlYlZpZXddIGZyYW1lXV0p OworICAgIE5TRGF0YSAqcG5nRGF0YSA9IFVJSW1hZ2VQTkdSZXByZXNlbnRhdGlvbihbVUlJbWFn ZSBpbWFnZVdpdGhDR0ltYWdlOnNuYXBzaG90LmdldCgpXSk7CiAgICAgCiAgICAgLy8gSGFzaCB0 aGUgUE5HIGRhdGEKICAgICBjaGFyIGFjdHVhbEhhc2hbMzNdOwpAQCAtNzYsNSArNzYsNCBAQCB2 b2lkIGR1bXBXZWJWaWV3QXNQaXhlbHNBbmRDb21wYXJlV2l0aEV4cGVjdGVkKGNvbnN0IHN0ZDo6 c3RyaW5nJiBleHBlY3RlZEhhc2gpCiAgICAgcHJpbnRmKCJDb250ZW50LVR5cGU6IGltYWdlL3Bu Z1xuIik7CiAgICAgcHJpbnRmKCJDb250ZW50LUxlbmd0aDogJWx1XG4iLCAodW5zaWduZWQgbG9u ZylbcG5nRGF0YSBsZW5ndGhdKTsKICAgICBmd3JpdGUoW3BuZ0RhdGEgYnl0ZXNdLCAxLCBbcG5n RGF0YSBsZW5ndGhdLCBzdGRvdXQpOwotICAgIENHSW1hZ2VSZWxlYXNlKHNuYXBzaG90KTsKIH0K ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZVdpbmRv dy5tbSBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZVdpbmRvdy5tbQpp bmRleCBjYTBjYmIyYjI1OGQ2YWU4MWIxMTYzYmJjZTc5Yjg0MGRlZjdkMjc5Li42NzNlNjg4ZGE4 OTIwMjYxZDFiNTQ3NTRiODgxZDBkYzMyMTczNGI2IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWVXaW5kb3cubW0KKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlV2luZG93Lm1tCkBAIC04MSw4ICs4MSwxMCBAQCAtIChp ZClpbml0V2l0aENvbnRlbnRSZWN0OihOU1JlY3QpY29udGVudFJlY3Qgc3R5bGVNYXNrOihOU1VJ bnRlZ2VyKXN0eWxlTWFzayBiYQogI2Vsc2UKIC0gKGlkKWluaXRXaXRoTGF5ZXI6KENBTGF5ZXIg KilsYXllcgogewotICAgIGlmICgoc2VsZiA9IFtzdXBlciBpbml0V2l0aExheWVyOmxheWVyXSkp CisgICAgaWYgKChzZWxmID0gW3N1cGVyIGluaXRXaXRoTGF5ZXI6bGF5ZXJdKSkgeworICAgICAg ICBbc2VsZiBzZXRFbnRpcmVXaW5kb3dWaXNpYmxlRm9yVGVzdGluZzpZRVNdOwogICAgICAgICBb c2VsZiBfYWRkVG9PcGVuV2luZG93c107CisgICAgfQogCiAgICAgcmV0dXJuIHNlbGY7CiB9Cg==