137649 2014-10-12 12:05:03 -0700 Add more detailed wait time information to EWS metrics 2014-10-13 11:48:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap dbates lforschler rniwa thorton oldest_to_newest 1041217 0 ap 2014-10-12 12:05:03 -0700 Median time is good, but we also need to know whether EWS pipes get clogged during peak hours. 1041218 1 239706 ap 2014-10-12 12:11:23 -0700 Created attachment 239706 proposed patch 1041236 2 239706 dbates 2014-10-12 23:34:41 -0700 Comment on attachment 239706 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=239706&action=review > Tools/ChangeLog:11 > + There is always some wait due to polling nature of the queues, which is well understood Nit: "due to" => "due to the" > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:396 > + var patchesThatWaitedMoreThan3Minutes = []; This is OK as-is. I take it that you find patchesThatWaitedMoreThan3Minutes reads better than patchesThatWaitedMoreThanThreeMinutes. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:170 > + addLine(this.element, formatPercentage(this._results.patchesThatWaitedMoreThan3MinutesCount / this._results.totalPatches) + " of patches had wait time more than 3 minutes."); Nit: "...had wait time more..." => "...had a wait time of more..." 1041237 3 239706 dbates 2014-10-12 23:38:22 -0700 Comment on attachment 239706 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=239706&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:396 >> + var patchesThatWaitedMoreThan3Minutes = []; > > This is OK as-is. I take it that you find patchesThatWaitedMoreThan3Minutes reads better than patchesThatWaitedMoreThanThreeMinutes. I'm assuming that you plan to make use of this array of patch IDs in a follow up patch. Otherwise, we should make this variable a counter such that its data type is number. 1041324 4 ap 2014-10-13 11:48:42 -0700 Committed <http://trac.webkit.org/r174655>. > I'm assuming that you plan to make use of this array of patch IDs in a follow up patch. Otherwise, we should make this variable a counter such that its data type is number. This is a debugging helper that I'd like to keep. When some results look surprising, it helps to have a relatively easy way to tell which patches they were based on. If the tool takes up, we can have the data in UI one day, to help with addressing issues on the bots. 239706 2014-10-12 12:11:23 -0700 2014-10-12 23:38:22 -0700 proposed patch 3Minutes.txt text/plain 4407 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NDY0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE0LTEwLTEyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEFkZCBtb3JlIGRldGFpbGVkIHdhaXQgdGltZSBpbmZvcm1hdGlvbiB0byBF V1MgbWV0cmljcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM3NjQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkZWQgYXZlcmFnZSBhbmQgd29yc3QgdGltZSAod2UgdXNlZCB0byBvbmx5IGhhdmUgbWVk aWFuKSwgYW5kIGFsc28gYSBwZXJjZW50YWdlCisgICAgICAgIG9mIHBhdGNoZXMgdGhhdCB0b29r IGEgbm9uLXRyaXZpYWwgdGltZSB0byBzdGFydC4gTm9uLXRyaXZpYWwgaXMgZGVmaW5lZCBhcyAz IG1pbnV0ZXMuCisKKyAgICAgICAgVGhlcmUgaXMgYWx3YXlzIHNvbWUgd2FpdCBkdWUgdG8gcG9s bGluZyBuYXR1cmUgb2YgdGhlIHF1ZXVlcywgd2hpY2ggaXMgd2VsbCB1bmRlcnN0b29kCisgICAg ICAgIGFuZCBkb2Vzbid0IG5lZWQgdG8gYmUgbWVhc3VyZWQuIFdoYXQgbmVlZHMgdG8gYmUgbWVh c3VyZWQgaXMgd2hldGhlciB0aGVyZSBpcyBlbm91Z2gKKyAgICAgICAgYm90IG1hY2hpbmVzIHRv IHByb2Nlc3MgcGF0Y2hlcyBhcyBzb29uIGFzIHRoZXkgYXJlIHN1Ym1pdHRlZC4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TY3JpcHRzL01ldHJpY3NBbmFseXplci5qczoKKyAgICAgICAgKEFuYWx5emVy LnByb3RvdHlwZS5fYW5hbHl6ZUJ1YmJsZVBlcmZvcm1hbmNlKToKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQv U2NyaXB0cy9NZXRyaWNzQnViYmxlVmlldy5qczoKKyAgICAgICAgKE1ldHJpY3NCdWJibGVWaWV3 LnByb3RvdHlwZS5fdXBkYXRlKToKKwogMjAxNC0xMC0xMiAgQWxleGV5IFByb3NrdXJ5YWtvdiAg PGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRpbmcgc3ZuOmlnbm9yZSBzbyB0aGF0IC5weWMg ZmlsZXMgZG9uJ3Qgc2hvdyB1cCBhcyBuZXcuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9N ZXRyaWNzQW5hbHl6ZXIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvTWV0 cmljc0FuYWx5emVyLmpzCShyZXZpc2lvbiAxNzQ2NDApCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9NZXRyaWNzQW5hbHl6ZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTM5Myw2ICszOTMsNyBAQCBB bmFseXplci5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0KIAogICAgICAgICB2YXIgd2FpdFRpbWVz ID0gW107CisgICAgICAgIHZhciBwYXRjaGVzVGhhdFdhaXRlZE1vcmVUaGFuM01pbnV0ZXMgPSBb XTsKICAgICAgICAgdmFyIHRvdGFsVGltZXMgPSBbXTsKICAgICAgICAgdmFyIHRvdGFsVGltZXNG b3JQYXRjaGVzVGhhdFdlcmVOb3RSZXRyaWVkID0gW107CiAgICAgICAgIHZhciB0b3RhbFRpbWVz Rm9yUGF0Y2hlc1RoYXRTcGlubmVkQW5kUGFzc2VkT3JGYWlsZWQgPSBbXTsKQEAgLTQwOCw2ICs0 MDksOSBAQCBBbmFseXplci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAvLyBXYWl0IHRpbWUg aXMgZXF1YWxseSBpbnRlcmVzdGluZyBmb3IgYWxsIHBhdGNoZXMuCiAgICAgICAgICAgICB3YWl0 VGltZXMucHVzaChwYXRjaC53YWl0X2R1cmF0aW9uKTsKIAorICAgICAgICAgICAgaWYgKHBhdGNo LndhaXRfZHVyYXRpb24gPiAzICogNjApCisgICAgICAgICAgICAgICAgcGF0Y2hlc1RoYXRXYWl0 ZWRNb3JlVGhhbjNNaW51dGVzLnB1c2gocGF0Y2hJRCk7CisKICAgICAgICAgICAgIGlmIChwYXRj aC5yZXNvbHV0aW9uID09PSAibm90IHByb2Nlc3NlZCIpCiAgICAgICAgICAgICAgICAgcGF0Y2hl c1RoYXREaWROb3RDb21wbGV0ZS5wdXNoKHBhdGNoSUQpOwogCkBAIC00NDksNiArNDUzLDggQEAg QW5hbHl6ZXIucHJvdG90eXBlID0gewogICAgICAgICAgICAgYXZlcmFnZVRvdGFsVGltZUZvclBh dGNoZXNUaGF0U3Bpbm5lZEFuZFBhc3NlZE9yRmFpbGVkSW5TZWNvbmRzOiB0b3RhbFRpbWVzRm9y UGF0Y2hlc1RoYXRTcGlubmVkQW5kUGFzc2VkT3JGYWlsZWQuYXZlcmFnZSgpLAogICAgICAgICAg ICAgbWVkaWFuV2FpdFRpbWVJblNlY29uZHM6IHdhaXRUaW1lcy5tZWRpYW4oKSwKICAgICAgICAg ICAgIGF2ZXJhZ2VXYWl0VGltZUluU2Vjb25kczogd2FpdFRpbWVzLmF2ZXJhZ2UoKSwKKyAgICAg ICAgICAgIG1heGltdW1XYWl0VGltZUluU2Vjb25kczogTWF0aC5tYXguYXBwbHkoTWF0aCwgd2Fp dFRpbWVzKSwKKyAgICAgICAgICAgIHBhdGNoZXNUaGF0V2FpdGVkTW9yZVRoYW4zTWludXRlc0Nv dW50OiBwYXRjaGVzVGhhdFdhaXRlZE1vcmVUaGFuM01pbnV0ZXMubGVuZ3RoLAogICAgICAgICAg ICAgcGF0Y2hlc1RoYXRDYXVzZWRJbnRlcm5hbEVycm9yOiBwYXRjaGVzVGhhdENhdXNlZEludGVy bmFsRXJyb3IsCiAgICAgICAgIH07CiAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01ldHJp Y3NCdWJibGVWaWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01ldHJp Y3NCdWJibGVWaWV3LmpzCShyZXZpc2lvbiAxNzQ2NDApCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9NZXRyaWNzQnViYmxlVmlldy5qcwkod29ya2luZyBjb3B5KQpAQCAtMTYyLDcgKzE2MiwxMiBA QCBNZXRyaWNzQnViYmxlVmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0KIAogICAgICAgICBh ZGREaXZpZGVyKHRoaXMuZWxlbWVudCk7Ci0gICAgICAgIGFkZExpbmUodGhpcy5lbGVtZW50LCAi TWVkaWFuIHdhaXQgdGltZSBiZWZvcmUgcHJvY2Vzc2luZyBzdGFydGVkOiAiICsgcGx1cmFsaXpl TWludXRlcyh0aGlzLl9yZXN1bHRzLm1lZGlhbldhaXRUaW1lSW5TZWNvbmRzKSArICIuIik7Cisg ICAgICAgIGFkZExpbmUodGhpcy5lbGVtZW50LCAiV2FpdCB0aW1lIGJlZm9yZSBwcm9jZXNzaW5n IHN0YXJ0ZWQ6Iik7CisgICAgICAgIGFkZExpbmUodGhpcy5lbGVtZW50LCAiLSBtZWRpYW46ICIg KyBwbHVyYWxpemVNaW51dGVzKHRoaXMuX3Jlc3VsdHMubWVkaWFuV2FpdFRpbWVJblNlY29uZHMp ICsgIjsiKTsKKyAgICAgICAgYWRkTGluZSh0aGlzLmVsZW1lbnQsICItIGF2ZXJhZ2U6ICIgKyBw bHVyYWxpemVNaW51dGVzKHRoaXMuX3Jlc3VsdHMuYXZlcmFnZVdhaXRUaW1lSW5TZWNvbmRzKSAr ICIuIik7CisgICAgICAgIGFkZExpbmUodGhpcy5lbGVtZW50LCAiLSB3b3JzdDogIiArIHBsdXJh bGl6ZU1pbnV0ZXModGhpcy5fcmVzdWx0cy5tYXhpbXVtV2FpdFRpbWVJblNlY29uZHMpICsgIi4i KTsKKyAgICAgICAgaWYgKHRoaXMuX3Jlc3VsdHMubWVkaWFuV2FpdFRpbWVJblNlY29uZHMgPCAz ICogNjAgJiYgdGhpcy5fcmVzdWx0cy5wYXRjaGVzVGhhdFdhaXRlZE1vcmVUaGFuM01pbnV0ZXND b3VudCkKKyAgICAgICAgICAgIGFkZExpbmUodGhpcy5lbGVtZW50LCBmb3JtYXRQZXJjZW50YWdl KHRoaXMuX3Jlc3VsdHMucGF0Y2hlc1RoYXRXYWl0ZWRNb3JlVGhhbjNNaW51dGVzQ291bnQgLyB0 aGlzLl9yZXN1bHRzLnRvdGFsUGF0Y2hlcykgKyAiIG9mIHBhdGNoZXMgaGFkIHdhaXQgdGltZSBt b3JlIHRoYW4gMyBtaW51dGVzLiIpOwogCiAgICAgICAgIGlmICh0aGlzLl9yZXN1bHRzLnBhdGNo ZXNUaGF0Q2F1c2VkSW50ZXJuYWxFcnJvci5sZW5ndGgpIHsKICAgICAgICAgICAgIGFkZERpdmlk ZXIodGhpcy5lbGVtZW50KTsK