137640 2014-10-11 14:30:57 -0700 [GTK] fails to build with --disable-accelerated-compositing 2015-05-18 06:10:38 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alexander webkit-unassigned berto cgarcia gnome zan oldest_to_newest 1041161 0 239685 alexander 2014-10-11 14:30:57 -0700 Created attachment 239685 Fix compilation with --disable-accelerated-compositing This problem was introduced in changeset <http://trac.webkit.org/changeset/172828>. The attached patch makes compilation process go further until I get the same linkage error as in bug 131267. I can attach the full build log if necessary. The actual error: Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp: In member function ‘void WebKit::WebProcess::platformSetCacheModel(WebKit::CacheModel)’: Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:114:27: error: ‘class WebCore::PageCache’ has no member named ‘setShouldClearBackingStores’ WebCore::pageCache()->setShouldClearBackingStores(true); ^ GNUmakefile:75880: recipe for target 'Source/WebKit2/WebProcess/soup/libwebkit2gtk_3_0_la-WebProcessSoup.lo' failed 1041510 1 alexander 2014-10-14 02:28:49 -0700 (In reply to comment #0) > The attached patch makes compilation process go further until I get the same linkage error as in bug 131267. Linkage error was caused by --disable-webgl. I already provided a patch for that issue in bug 131267. Ignore it in this bug report. 1051422 2 zan 2014-12-01 05:58:27 -0800 What specific version of WebKitGTK+? 1051439 3 alexander 2014-12-01 07:37:24 -0800 2.4.6 and 2.4.7 1053172 4 berto 2014-12-07 10:00:43 -0800 Yes, this should go to the 2.4 branch, I just tested it. 1095613 5 cgarcia 2015-05-18 06:10:38 -0700 Committed to 2.4 http://trac.webkit.org/changeset/184467. Thanks 239685 2014-10-11 14:30:57 -0700 2014-10-14 02:24:42 -0700 Fix compilation with --disable-accelerated-compositing webkit-gtk-accelerated-compositing.patch text/plain 685 alexander ZGlmZiAtdXJOIHdlYmtpdGd0ay0yLjQuNi5vcmlnL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv c291cC9XZWJQcm9jZXNzU291cC5jcHAgd2Via2l0Z3RrLTIuNC42L1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAKLS0tIHdlYmtpdGd0ay0yLjQuNi5vcmln L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAJMjAxNC0w OS0yNiAxMTo0MDo0NS4wMDAwMDAwMDAgKzA0MDAKKysrIHdlYmtpdGd0ay0yLjQuNi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwCTIwMTQtMTAtMTEgMjA6 NDM6MTYuNjg3MTE2ODA3ICswNDAwCkBAIC0xMTAsNyArMTEwLDcgQEAKICAgICBXZWJDb3JlOjpt ZW1vcnlDYWNoZSgpLT5zZXREZWFkRGVjb2RlZERhdGFEZWxldGlvbkludGVydmFsKGRlYWREZWNv ZGVkRGF0YURlbGV0aW9uSW50ZXJ2YWwpOwogICAgIFdlYkNvcmU6OnBhZ2VDYWNoZSgpLT5zZXRD YXBhY2l0eShwYWdlQ2FjaGVDYXBhY2l0eSk7CiAKLSNpZiBQTEFURk9STShHVEspCisjaWYgUExB VEZPUk0oR1RLKSAmJiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgV2ViQ29yZTo6 cGFnZUNhY2hlKCktPnNldFNob3VsZENsZWFyQmFja2luZ1N0b3Jlcyh0cnVlKTsKICNlbmRpZgog Cg==