137630 2014-10-10 17:00:21 -0700 Add an option to run-webkit-tests to print stderr/stdout from the tool 2017-02-16 16:19:48 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=168468 P2 Normal --- 1 simon.fraser dfarler ap commit-queue dbates ddkilzer dfarler glenn jake.nielsen.webkit oldest_to_newest 1041075 0 simon.fraser 2014-10-10 17:00:21 -0700 SSIA 1041081 1 239663 dfarler 2014-10-10 18:06:47 -0700 Created attachment 239663 Patch 1041090 2 ap 2014-10-10 20:22:27 -0700 --debug-rwt-logging already prints stderr. I'm not quite sure what the use case for the new flag is, but maybe it's best to have it only control stdout printing, and keep stderr for the existing one? 1041320 3 dfarler 2014-10-13 11:40:08 -0700 --debug-rwt-logging is extremely noisy and is for debugging webkitpy code. This option is just to have the results transparently show up without having to go to the result files (I assume that's what smfr is requesting). 1041755 4 ap 2014-10-14 18:50:04 -0700 Makes sense, although it's also fairly easy to just run the tool without run-webkit-tests wrapper to get these. +1 for adding the option. 1045302 5 239663 bfulgham 2014-10-31 10:57:57 -0700 Comment on attachment 239663 Patch This seems like a useful change. r=me. 239663 2014-10-10 18:06:47 -0700 2014-10-31 10:57:57 -0700 Patch bug-137630-20141010180650.patch text/plain 3986 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2MxN2E5MjA5MTdmZTMyMDViMmE0NTMxMGY1ODFiOTIx OGNjMTI4OS4uMWM2ODRjNjc2NTA3ZmNiZTAwYjAxMzg4ZjEwZmVhM2NkOGRlMTgwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3 IEBACiAyMDE0LTEwLTEwICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KIAorICAg ICAgICBBZGQgYW4gb3B0aW9uIHRvIHJ1bi13ZWJraXQtdGVzdHMgdG8gcHJpbnQgc3RkZXJyL3N0 ZG91dCBmcm9tIHRoZSB0b29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzc2MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgYSBuZXcgb3B0aW9uLCAtLXByaW50LXJlc3VsdHMsIHRoYXQgd2lsbCBw cmludCBzdGRvdXQgYW5kIHN0ZGVycgorICAgICAgICBmcm9tIHJlc3VsdHMgYXMgdGhleSBjb21l IGluLiBNZXNzYWdlcyBhcmUgaGVhZGVkIGJ5OgorICAgICAgICBwYXRoL3RvL3Rlc3QuaHRtbCBz dGRvdXQ6CisgICAgICAgIC4uLgorCisgICAgICAgIHBhdGgvdG8vdGVzdC5odG1sIHN0ZGVyOgor ICAgICAgICAuLi4KKworICAgICAgICBJZiBlaXRoZXIgYXJlbid0IHByZXNlbnQsICJOb25lIiBp cyBwcmludGVkIG9uIHRoZSBzYW1lIGxpbmUuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHk6CisgICAgICAg IChTaW5nbGVUZXN0UnVubmVyLl9leHBlY3RlZF9kcml2ZXJfb3V0cHV0KToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weToKKyAgICAgICAg KHByaW50X29wdGlvbnMpOgorCisyMDE0LTEwLTEwICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFw cGxlLmNvbT4KKwogICAgICAgICBbaU9TXSBMYXlvdXRUZXN0UmVsYXkgc2hvdWxkIGRldGVjdCBF T0YgYW5kIHByb3Blcmx5IHNpZ25hbCB1bmRlcmx5aW5nIERSVC9XS1RSCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc1MjcKIApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rl c3RfcnVubmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJv bGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5CmluZGV4IGVjOGI1ZDA1MTIwMmY3ZTY2MDFlMGRh ODU3Y2JiODQ4YjhjZDU0MWIuLjg3MGFlM2Y4YjE4MmQxMzAzMDBhZjhlMGVhZjljNDNlNTU4Njhl N2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRy b2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkKQEAgLTc0LDEw ICs3NCwxNiBAQCBjbGFzcyBTaW5nbGVUZXN0UnVubmVyKG9iamVjdCk6CiAgICAgICAgICAgICAg ICAgICAgICAgICBzZWxmLl90ZXN0X25hbWUsIGV4cGVjdGVkX2ZpbGVuYW1lKQogCiAgICAgZGVm IF9leHBlY3RlZF9kcml2ZXJfb3V0cHV0KHNlbGYpOgotICAgICAgICByZXR1cm4gRHJpdmVyT3V0 cHV0KHNlbGYuX3BvcnQuZXhwZWN0ZWRfdGV4dChzZWxmLl90ZXN0X25hbWUpLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fcG9ydC5leHBlY3RlZF9pbWFnZShzZWxmLl90 ZXN0X25hbWUpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fcG9ydC5l eHBlY3RlZF9jaGVja3N1bShzZWxmLl90ZXN0X25hbWUpLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc2VsZi5fcG9ydC5leHBlY3RlZF9hdWRpbyhzZWxmLl90ZXN0X25hbWUpKQor ICAgICAgICBvdXRwdXQgPSBEcml2ZXJPdXRwdXQoc2VsZi5fcG9ydC5leHBlY3RlZF90ZXh0KHNl bGYuX3Rlc3RfbmFtZSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl9wb3J0 LmV4cGVjdGVkX2ltYWdlKHNlbGYuX3Rlc3RfbmFtZSksCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzZWxmLl9wb3J0LmV4cGVjdGVkX2NoZWNrc3VtKHNlbGYuX3Rlc3RfbmFtZSksCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl9wb3J0LmV4cGVjdGVkX2F1ZGlvKHNl bGYuX3Rlc3RfbmFtZSkpCisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMucHJpbnRfcmVzdWx0czoK KyAgICAgICAgICAgIHByaW50ICJcbnt0ZXN0X25hbWV9IHN0ZG91dDoge3N0ZG91dH0iLmZvcm1h dCh0ZXN0X25hbWU9c2VsZi5fdGVzdF9uYW1lLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZG91dD0nXG4nICsgb3V0cHV0LnRleHQg aWYgb3V0cHV0LnRleHQgZWxzZSAnTm9uZScpCisgICAgICAgICAgICBwcmludCAiXG57dGVzdF9u YW1lfSBzdGRlcnI6IHtzdGRlcnJ9Ii5mb3JtYXQodGVzdF9uYW1lPXNlbGYuX3Rlc3RfbmFtZSwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzdGRlcnI9J1xuJyArIG91dHB1dC5lcnJvciBpZiBvdXRwdXQuZXJyb3IgZWxzZSAnTm9uZScp CisgICAgICAgIHJldHVybiBvdXRwdXQKIAogICAgIGRlZiBfc2hvdWxkX2ZldGNoX2V4cGVjdGVk X2NoZWNrc3VtKHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fc2hvdWxkX3J1bl9waXhlbF90 ZXN0IGFuZCBub3QgKHNlbGYuX29wdGlvbnMubmV3X2Jhc2VsaW5lIG9yIHNlbGYuX29wdGlvbnMu cmVzZXRfcmVzdWx0cykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3ZpZXdzL3ByaW50aW5nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvdmlld3MvcHJpbnRpbmcucHkKaW5kZXggZjVjNDJlMjYyYjhjODkzODU4YmJiZjdmNGZl Y2FlYTFmYmQxODQ0NC4uYjhlYWE1YzBlZGYxODBiZWVkNmNlNmVmZDQ5ODhhNGU1ZjNjNmU2ZCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvcHJp bnRpbmcucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3Mv cHJpbnRpbmcucHkKQEAgLTQ4LDYgKzQ4LDggQEAgZGVmIHByaW50X29wdGlvbnMoKToKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0ncHJpbnQgYSBzdW1tYXJpemVkIHJlc3VsdCBm b3IgZXZlcnkgdGVzdCAob25lIGxpbmUgcGVyIHRlc3QpJyksCiAgICAgICAgIG9wdHBhcnNlLm1h a2Vfb3B0aW9uKCctLWRldGFpbHMnLCBhY3Rpb249J3N0b3JlX3RydWUnLCBkZWZhdWx0PUZhbHNl LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdwcmludCBkZXRhaWxlZCByZXN1 bHRzIGZvciBldmVyeSB0ZXN0JyksCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLXBy aW50LXJlc3VsdHMnLCBhY3Rpb249J3N0b3JlX3RydWUnLCBkZWZhdWx0PUZhbHNlLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdQcmludCBzdGRvdXQgYW5kIHN0ZGVyciBmcm9t IHRlc3RzIHRocm91Z2hvdXQuJyksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLWRl YnVnLXJ3dC1sb2dnaW5nJywgYWN0aW9uPSdzdG9yZV90cnVlJywgZGVmYXVsdD1GYWxzZSwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0ncHJpbnQgdGltZXN0YW1wcyBhbmQgZGVi dWcgaW5mb3JtYXRpb24gZm9yIHJ1bi13ZWJraXQtdGVzdHMgaXRzZWxmJyksCiAgICAgXQo=