137624 2014-10-10 14:18:47 -0700 Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators 2014-10-10 15:49:39 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1041016 0 joepeck 2014-10-10 14:18:47 -0700 In production, minified builds we see a warning in our Main.css: [Warning] Unexpected CSS token: ) See also: <https://webkit.org/b/137620> Web Inspector: Poor CSS warning message with missing spaces in calc() +/- operation 1041017 1 webkit-bug-importer 2014-10-10 14:19:14 -0700 <rdar://problem/18615543> 1041020 2 239648 joepeck 2014-10-10 14:30:40 -0700 Created attachment 239648 [PATCH] Proposed Fix 1041021 3 commit-queue 2014-10-10 14:32:02 -0700 Attachment 239648 did not pass style-queue: ERROR: Source/WebInspectorUI/Scripts/cssmin.py:33: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1041039 4 239648 timothy 2014-10-10 15:00:51 -0700 Comment on attachment 239648 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=239648&action=review > Source/WebInspectorUI/ChangeLog:15 > + * Scripts/copy-user-interface-resources-dryrun.rb: Added. Yay! 1041052 5 239648 commit-queue 2014-10-10 15:38:39 -0700 Comment on attachment 239648 [PATCH] Proposed Fix Clearing flags on attachment: 239648 Committed r174615: <http://trac.webkit.org/changeset/174615> 1041053 6 commit-queue 2014-10-10 15:38:42 -0700 All reviewed patches have been landed. Closing bug. 1041056 7 joepeck 2014-10-10 15:49:39 -0700 This fixed the appearance of alpha color swatches in production builds. 239648 2014-10-10 14:30:40 -0700 2014-10-10 15:38:39 -0700 [PATCH] Proposed Fix calc-minification.patch text/plain 3419 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEwNTQ2MzMuLmMwMmIyY2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEwLTEwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIG1p bmlmaWNhdGlvbiBzaG91bGQgbm90IHN0cmlwIHdoaXRlc3BhY2UgYXJvdW5kIGNhbGMgKy8tIGJp bmFyeSBvcGVyYXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNzYyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJlIGNhcmVmdWwgd2hlbiBzdHJpcHBpbmcgd2hpdGVzcGFjZSBhcm91bmQgIisiLiBX ZSB3YW50IHRvIHN0cmlwIGZvcgorICAgICAgICBzZWxlY3RvcnMgImEgKyBiIiBidXQgbm90IGZv ciBjYWxjIGV4cHJlc3Npb25zICJjYWxjKDFweCArIDJweCkiLgorCisgICAgICAgIFRoaXMgaXMg bm90IGEgcGVyZmVjdCBzb2x1dGlvbiwgYnV0IGl0IGRvZXMgYSBnb29kIGpvYi4gSXQgbWF5IHN0 aWxsIGJyZWFrCisgICAgICAgIHdpdGggbW9yZSBjb21wbGV4IGNhbGMgZXhwcmVzc2lvbnMsIGxp a2UgImNhbGMoMXB4ICsgY2FsYygpKSIgYnV0IHRoaXMKKyAgICAgICAgaGFuZGxlcyB0aGUgYmFz aWNzLgorCisgICAgICAgICogU2NyaXB0cy9jb3B5LXVzZXItaW50ZXJmYWNlLXJlc291cmNlcy1k cnlydW4ucmI6IEFkZGVkLgorICAgICAgICAqIFNjcmlwdHMvY3NzbWluLnB5OgorICAgICAgICAo Y3NzbWluaWZ5KToKKwogMjAxNC0xMC0wOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERPTSBTdG9yYWdlIEVkaXRpbmcgaXMg YnJva2VuIGluIG1hbnkgd2F5cywgZnJ1c3RyYXRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9TY3JpcHRzL2NvcHktdXNlci1pbnRlcmZhY2UtcmVzb3VyY2VzLWRyeXJ1bi5y YiBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2NvcHktdXNlci1pbnRlcmZhY2UtcmVz b3VyY2VzLWRyeXJ1bi5yYgpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi45YWZm ZjdmCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29w eS11c2VyLWludGVyZmFjZS1yZXNvdXJjZXMtZHJ5cnVuLnJiCkBAIC0wLDAgKzEsMzUgQEAKKyMh L3Vzci9iaW4vcnVieQorCityZXF1aXJlICdmaWxldXRpbHMnCityZXF1aXJlICd0bXBkaXInCisK K2lmIEFSR1Yuc2l6ZSAhPSAxCisgIHB1dHMgInVzYWdlOiAje0ZpbGUuYmFzZW5hbWUgJDB9IDxv dXRwdXQtZGlyZWN0b3J5PiIKKyAgZXhpdCAxCitlbmQKKworV0VCX0lOU1BFQ1RPUl9QQVRIID0g RmlsZS5leHBhbmRfcGF0aCBGaWxlLmpvaW4oRmlsZS5kaXJuYW1lKF9fRklMRV9fKSwgIi4uIikK K0NPUFlfVVNFUl9JTlRFUkZBQ0VfUkVTT1VSQ0VTX1BBVEggPSBGaWxlLmpvaW4gV0VCX0lOU1BF Q1RPUl9QQVRILCAiU2NyaXB0cyIsICJjb3B5LXVzZXItaW50ZXJmYWNlLXJlc291cmNlcy5wbCIK KworJG91dHB1dF9kaXJlY3RvcnkgPSBGaWxlLmV4cGFuZF9wYXRoIEFSR1ZbMF0KKworRGlyLm1r dG1wZGlyIGRvIHx0bXBkaXJ8CisKKyAgIyBDcmVhdGUgdGhlIG91dHB1dCBkaXJlY3RvcnkgaWYg bmVlZGVkLgorICBGaWxlVXRpbHMubWtkaXJfcCAkb3V0cHV0X2RpcmVjdG9yeQorICAKKyAgIyBD cmVhdGUgZW1wdHkgZGVyaXZlZCBzb3VyY2VzIGV4cGVjdGVkIHRvIGV4aXN0LgorICBGaWxlVXRp bHMudG91Y2goRmlsZS5qb2luKHRtcGRpciwgJ0luc3BlY3RvckpTQmFja2VuZENvbW1hbmRzLmpz JykpCisgIEZpbGVVdGlscy50b3VjaChGaWxlLmpvaW4odG1wZGlyLCAnSW5zcGVjdG9yV2ViQmFj a2VuZENvbW1hbmRzLmpzJykpCisgIAorICAjIFNldHVwIHRoZSBlbnZpcm9ubWVudCBhbmQgcnVu LgorICBFTlZbIkRFUklWRURfU09VUkNFU19ESVIiXSA9IHRtcGRpcgorICBFTlZbIkpBVkFTQ1JJ UFRDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIiXSA9IHRtcGRpcgorICBFTlZbIldFQkNPUkVfUFJJ VkFURV9IRUFERVJTX0RJUiJdID0gdG1wZGlyCisgIEVOVlsiU1JDUk9PVCJdID0gV0VCX0lOU1BF Q1RPUl9QQVRICisgIEVOVlsiVEFSR0VUX0JVSUxEX0RJUiJdID0gJG91dHB1dF9kaXJlY3RvcnkK KyAgRU5WWyJVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BBVEgiXSA9ICIiCisgIEVOVlsi Q09NQklORV9JTlNQRUNUT1JfUkVTT1VSQ0VTIl0gPSAiWUVTIgorICBleGVjIENPUFlfVVNFUl9J TlRFUkZBQ0VfUkVTT1VSQ0VTX1BBVEgKKworZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvU2NyaXB0cy9jc3NtaW4ucHkgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0 cy9jc3NtaW4ucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCBhMDY0MGVi Li43ZjQzMTIyCi0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2Nzc21pbi5weQor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9jc3NtaW4ucHkKQEAgLTMwLDcgKzMw LDggQEAgZGVmIGNzc21pbmlmeShjc3MpOgogICAgICAgICAociJcL1wqLio/XCpcLyIsICIiKSwg ICAgICAgICAgIyBkZWxldGUgY29tbWVudHMKICAgICAgICAgKHIiXG4iLCAiIiksICAgICAgICAg ICAgICAgICAgICMgZGVsZXRlIG5ldyBsaW5lcwogICAgICAgICAociJccysiLCAiICIpLCAgICAg ICAgICAgICAgICAgIyBjaGFuZ2UgbXVsdGlwbGUgc3BhY2VzIHRvIG9uZSBzcGFjZQotICAgICAg ICAociJccz8oWzs6e30sKz5dKVxzPyIsIHIiXDEiKSwgIyBkZWxldGUgc3BhY2Ugd2hlcmUgaXQg aXMgbm90IG5lZWRlZAorICAgICAgICAociJccz8oWzs6e30sfj5dKVxzPyIsIHIiXDEiKSwgIyBk ZWxldGUgc3BhY2Ugd2hlcmUgaXQgaXMgbm90IG5lZWRlZAorICAgICAgICAociJccz8oWy0rXSko Pzpccyg/IVswLTkoXSkpIiwgciJcMSIpLCAjIGRlbGV0ZSB3aGl0ZXNwYWNlIGFyb3VuZCArIGFu ZCAtIHdoZW4gbm90IGZvbGxvd2VkIGJ5IGEgbnVtYmVyIG9yIHBhcmVuLiBFLmcuIHN0cmlwIGZv ciBzZWxlY3RvciAiYSArIGIiIGJ1dCBub3QgImNhbGMoYSArIGIpIiB3aGljaCByZXF1aXJlcyBz cGFjZXMuCiAgICAgICAgIChyIjt9IiwgIn0iKSAgICAgICAgICAgICAgICAgICAjIGNoYW5nZSAn O30nIHRvICd9JyBiZWNhdXNlIHRoZSBzZW1pY29sb24gaXMgbm90IG5lZWRlZAogICAgICkKIAo=