137607 2014-10-10 04:38:07 -0700 Add tiny version to generate-webkitversion.pl 2016-09-17 07:05:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 pulkomandy webkit-unassigned oldest_to_newest 1040890 0 pulkomandy 2014-10-10 04:38:07 -0700 Add tiny version to generate-webkitversion.pl 1040891 1 239618 pulkomandy 2014-10-10 04:40:56 -0700 Created attachment 239618 Patch 1040930 2 239618 ap 2014-10-10 09:36:44 -0700 Comment on attachment 239618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239618&action=review > Source/WebKit/ChangeLog:8 > + WebKit version now has a third "tiny" number. Extract it from the This explains what the patch does, but not why. Can you share the reasons why such a macro is necessary? 1040943 3 pulkomandy 2014-10-10 09:57:10 -0700 The Haiku port of WebKit shows the tiny verson in the about box to help identifying which version of WebKit is used. The mjor/minor versions don't change often enough to be useful for that. 1230803 4 239618 mcatanzaro 2016-09-17 07:05:00 -0700 Comment on attachment 239618 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 239618 2014-10-10 04:40:56 -0700 2016-09-17 07:05:00 -0700 Patch bug-137607-20141010134200.patch text/plain 2315 pulkomandy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE4NjBlMjUxNDBkMDQ5YjQ2 MmQ4N2FkM2ZkMTFlNTkyZWFiMGVlOGEuLmYyZjNmNGU5NWQ0OTRkOTIyYTE5MzYwZjYwMmYyNjVm MWQ5NzViODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTAtMTAgIEFkcmllbiBE ZXN0dWd1ZXMgIDxwdWxrb21hbmR5QGdtYWlsLmNvbT4KKworICAgICAgICBIYW5kbGUgdGlueSB2 ZXJzaW9uIGluIGdlbmVyYXRlLXdlYmtpdHZlcnNpb24ucGwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzYwNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdCB2ZXJzaW9uIG5vdyBoYXMgYSB0aGly ZCAidGlueSIgbnVtYmVyLiBFeHRyYWN0IGl0IGZyb20gdGhlCisgICAgICAgIFhDb2RlIHByb2pl Y3QgYW5kIGFkZCBpdCB0byB0aGUgdmVyc2lvbiBkZWZpbmVzLgorCisgICAgICAgICogc2NyaXB0 cy9nZW5lcmF0ZS13ZWJraXR2ZXJzaW9uLnBsOgorICAgICAgICAocHJpbnRXZWJLaXRWZXJzaW9u SGVhZGVyRmlsZSk6CisKIDIwMTQtMTAtMDYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCA2NC1iaXQgYnVpbGQgZml4IGFmdGVy IHIxNzQzMTUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3NjcmlwdHMvZ2VuZXJhdGUtd2Vi a2l0dmVyc2lvbi5wbCBiL1NvdXJjZS9XZWJLaXQvc2NyaXB0cy9nZW5lcmF0ZS13ZWJraXR2ZXJz aW9uLnBsCmluZGV4IDMzMjFkZTE3NGI1NWFjMmUwY2E3MzVhMTgxYjJjZGQ5MjhkNDI2ODIuLjA4 ZTBjODYxNzUwMmUxZjAxNDRlNGRhNmE0NGEwZmM1ZjVjNTIyMDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvc2NyaXB0cy9nZW5lcmF0ZS13ZWJraXR2ZXJzaW9uLnBsCisrKyBiL1NvdXJjZS9X ZWJLaXQvc2NyaXB0cy9nZW5lcmF0ZS13ZWJraXR2ZXJzaW9uLnBsCkBAIC00NCw2ICs0NCw3IEBA IG15ICR1c2FnZSA9ICJnZW5lcmF0ZS13ZWJraXR2ZXJzaW9uIC0tY29uZmlnIFdlYktpdC9tYWMv Q29uZmlndXJhdGlvbnMvVmVyc2lvbi54CiAKIG15ICRtYWpvcl92ZXJzaW9uID0gIiI7CiBteSAk bWlub3JfdmVyc2lvbiA9ICIiOworbXkgJHRpbnlfdmVyc2lvbiA9ICIiOwogIyBUaGUgYXBwcm9w cmlhdGUgQXBwbGUtbWFpbnRhaW5lZCBWZXJzaW9uLnhjY29uZmlnIGZpbGUgZm9yIFdlYktpdCB2 ZXJzaW9uIGluZm9ybWF0aW9uIGlzIGluIFdlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvLgogbXkg JGNvbmZpZ0ZpbGUgPSAiLi9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0aW9ucy9WZXJzaW9u LnhjY29uZmlnIjsKIG15ICRvdXRwdXREaXIgPSAiIjsKQEAgLTY4LDEwICs2OSwxNSBAQCB3aGls ZSAobXkgJGxpbmUgPSA8SU5QVVQ+KSB7CiAgICAgICAkbGluZSA9fiBzL14oTUlOT1JfVkVSU0lP TilccysoPSlccysoXGQrKTsvJDMvOwogICAgICAgJG1pbm9yX3ZlcnNpb24gPSAkbGluZTsKICAg ICB9CisgICAgaWYgKCRsaW5lID1+IC9eVElOWV9WRVJTSU9OXHMrPVxzK1xkKzsvKSB7CisgICAg ICAkbGluZSA9fiBzL14oVElOWV9WRVJTSU9OKVxzKyg9KVxzKyhcZCspOy8kMy87CisgICAgICAk dGlueV92ZXJzaW9uID0gJGxpbmU7CisgICAgfQogfQogCiAkbWFqb3JfdmVyc2lvbiA9ICI1MzEi IHVubGVzcyAobGVuZ3RoKCRtYWpvcl92ZXJzaW9uKSk7CiAkbWlub3JfdmVyc2lvbiA9ICIzIiB1 bmxlc3MgKGxlbmd0aCgkbWlub3JfdmVyc2lvbikpOworJHRpbnlfdmVyc2lvbiA9ICIwIiB1bmxl c3MgKGxlbmd0aCgkdGlueV92ZXJzaW9uKSk7CiAKIG15ICR3ZWJLaXRWZXJzaW9uUGF0aCA9ICIk b3V0cHV0RGlyL1dlYktpdFZlcnNpb24uaCI7CiAKQEAgLTEyNSw2ICsxMzEsNyBAQCBzdWIgcHJp bnRXZWJLaXRWZXJzaW9uSGVhZGVyRmlsZQogCiAgICAgcHJpbnQgRiAiI2RlZmluZSBXRUJLSVRf TUFKT1JfVkVSU0lPTiAkbWFqb3JfdmVyc2lvblxuIjsKICAgICBwcmludCBGICIjZGVmaW5lIFdF QktJVF9NSU5PUl9WRVJTSU9OICRtaW5vcl92ZXJzaW9uXG5cbiI7CisgICAgcHJpbnQgRiAiI2Rl ZmluZSBXRUJLSVRfVElOWV9WRVJTSU9OICR0aW55X3ZlcnNpb25cblxuIjsKIAogICAgIHByaW50 IEYgIiNlbmRpZiAvL1dlYktpdFZlcnNpb25faFxuIjsKIAo=