137606 2014-10-10 04:15:41 -0700 [EFL][GTK] Make it possible to get verbose output with ninja 2014-10-14 11:15:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137605 137703 1 evab.u-szeged evab.u-szeged cgarcia commit-queue dbates mrobinson ossy oldest_to_newest 1040889 0 evab.u-szeged 2014-10-10 04:15:41 -0700 Make it possible to get verbose output with ninja on gtk and efl port as well. 1040913 1 239626 evab.u-szeged 2014-10-10 08:01:46 -0700 Created attachment 239626 Patch 1041546 2 239626 ossy 2014-10-14 05:27:18 -0700 Comment on attachment 239626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239626&action=review I like the idea, but I think we need some minor fixes. When we use verbose build, we usually do it to be able copy/paste a command and then run it manually, maybe after some manual editing or simple check all the command line arguments. In this case we should disable forcing response files too, see: http://trac.webkit.org/browser/trunk/Source/cmake/OptionsCommon.cmake#L68 > Tools/Scripts/webkitdirs.pm:1832 > + push @args, "-v" if $ENV{VERBOSE} or $ENV{V}; I think VERBOSE environment variable is enough, we don't need two. The makefilegenerator of CMake use VERBOSE also, so it is a good choice. V is an autotoolsism, we can avoid using it here. 1041562 3 evab.u-szeged 2014-10-14 08:25:45 -0700 (In reply to comment #2) > (From update of attachment 239626 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239626&action=review > > I like the idea, but I think we need some minor fixes. > > When we use verbose build, we usually do it to be able copy/paste > a command and then run it manually, maybe after some manual editing > or simple check all the command line arguments. > > In this case we should disable forcing response files too, see: > http://trac.webkit.org/browser/trunk/Source/cmake/OptionsCommon.cmake#L68 > > > Tools/Scripts/webkitdirs.pm:1832 > > + push @args, "-v" if $ENV{VERBOSE} or $ENV{V}; > > I think VERBOSE environment variable is enough, we don't need > two. The makefilegenerator of CMake use VERBOSE also, so it is > a good choice. V is an autotoolsism, we can avoid using it here. I'll remove the V environment variable, thanks for pointing out. However, I tried an EFL build with disabling response files as requested, but even with verbose enabled, the linking failed with "Argument list too long". Shortened version of the last few rows of received console output: [5/96] cd /home/eva/webkit/WebKit/WebKitBuild/Release/Tools/TestWebKitAPI && ............ /home/eva/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/include soup FAILED: : && /usr/bin/cmake -E remove lib/libwebcore_efl.a && /usr/bin/ar ............ && /usr/bin/ranlib lib/libwebcore_efl.a && : Argument list too long ninja: build stopped: subcommand failed. 1041563 4 239801 evab.u-szeged 2014-10-14 08:31:50 -0700 Created attachment 239801 Patch 1041572 5 239801 commit-queue 2014-10-14 09:42:54 -0700 Comment on attachment 239801 Patch Clearing flags on attachment: 239801 Committed r174683: <http://trac.webkit.org/changeset/174683> 1041573 6 commit-queue 2014-10-14 09:42:58 -0700 All reviewed patches have been landed. Closing bug. 1041574 7 239801 mrobinson 2014-10-14 09:45:31 -0700 Comment on attachment 239801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239801&action=review > Tools/Scripts/webkitdirs.pm:1832 > + push @args, "-v" if $ENV{VERBOSE}; It doesn't look like this will work for make-based builds... 1041615 8 ossy 2014-10-14 11:15:15 -0700 (In reply to comment #7) > (From update of attachment 239801 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239801&action=review > > > Tools/Scripts/webkitdirs.pm:1832 > > + push @args, "-v" if $ENV{VERBOSE}; > > It doesn't look like this will work for make-based builds... Oops, make -v is really fast, but doesn't do any build task. :) Fix is in bug137703. Sorry for the trouble. 239626 2014-10-10 08:01:46 -0700 2014-10-14 08:31:44 -0700 Patch bug-137606-20141010170148.patch text/plain 1357 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2NlZDkwZDFlMzNkZDQ1MjkyMTQ2YmM5YmVlYWRlODk1 MDYxMTk4Ny4uNTM5OWE1NzcwYzdjZTdiODg2NTdiOTJkOTY0NTgzZDc4ZTIxMDM4ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTEwLTEwICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bR1RLXSBNYWtlIGl0IHBvc3NpYmxlIHRvIGdl dCB2ZXJib3NlIG91dHB1dCB3aXRoIG5pbmphCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc2MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgLXYgc3dpdGNoIHRvIG5pbmphIGJ1aWxkIGlmIFZFUkJP U0U9MSBvciBWPTEgZW52aXJvbm1lbnQKKyAgICAgICAgdmFyaWFibGUgaXMgc2V0LgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRDTWFrZUdlbmVyYXRl ZFByb2plY3QpOgorCiAyMDE0LTEwLTEwICBBZHJpZW4gRGVzdHVndWVzICA8cHVsa29tYW5keUBn bWFpbC5jb20+CiAKICAgICAgICAgRml4IHBlcmwgc2NyaXB0cyB0byBydW4gd2l0aCBlbnYgb24g TGludXgKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA3NzJkY2M0MjE0ZWFhMmU2ZDdmYTFiOTE4N2QwMjRi ZDgwNWMxMmY1Li5hYzQ5N2RkMzU5NWY0NWNiYWI1YzUzZDM3ZmM3MzE4OTZjYTIxZTY2IDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCkBAIC0xODI5LDYgKzE4MjksNyBAQCBzdWIgYnVpbGRDTWFrZUdlbmVyYXRl ZFByb2plY3QoJCkKICAgICAgICAgJGNvbW1hbmQgPSAiJGJ1aWxkUGF0aC9idWlsZC5zaCI7CiAg ICAgICAgIEBhcmdzID0gKCRtYWtlQXJncyk7CiAgICAgfQorICAgIHB1c2ggQGFyZ3MsICItdiIg aWYgJEVOVntWRVJCT1NFfSBvciAkRU5We1Z9OwogCiAgICAgIyBXZSBjYWxsIHN5c3RlbSgiY21h a2UgQGFyZ3MiKSBpbnN0ZWFkIG9mIHN5c3RlbSgiY21ha2UiLCBAYXJncykgc28gdGhhdCBAYXJn cyBpcwogICAgICMgcGFyc2VkIGZvciBzaGVsbCBtZXRhY2hhcmFjdGVycy4gSW4gcGFydGljdWxh ciwgJG1ha2VBcmdzIG1heSBjb250YWluIHN1Y2ggbWV0YWNoYXJhY3RlcnMuCg== 239801 2014-10-14 08:31:50 -0700 2014-10-14 09:45:31 -0700 Patch bug-137606-20141014173153.patch text/plain 1330 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWYxNGQzMDc1ODI3MTA1NWQ3Zjc5Mzk1MjI4NGM4Y2Ix ZmU5ZTk0Yi4uZThjNzg1YmJiMzViYTM4MWE2ZjJhMjQ0M2ZiMjc4MGEwYTcxNWNkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDE0LTEwLTE0ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF1bR1RLXSBNYWtlIGl0IHBvc3NpYmxlIHRvIGdl dCB2ZXJib3NlIG91dHB1dCB3aXRoIG5pbmphCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc2MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGJ1 aWxkQ01ha2VHZW5lcmF0ZWRQcm9qZWN0KToKKworMjAxNC0xMC0xNCAgRXZhIEJhbGF6c2ZhbHZp ICA8ZXZhYi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCiAgICAgICAgIFtFRkxdIE1h a2UgaXQgcG9zc2libGUgdG8gdXNlIG5pbmphIGZvciBFRkwgYnVpbGQgdG9vCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc2MDUKIApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCmluZGV4IDIxZGY5NDA4ZDNjNzcwZWMzZjc3M2NhZWIxMmIyZDUwMmY4MDA0MTIuLjU4NDA5 ZjIxMzU2NmRiOWE5MDM1ZDg0NzFjNjAwMWZiZjNlNTg0NzMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAg LTE4MjksNiArMTgyOSw3IEBAIHN1YiBidWlsZENNYWtlR2VuZXJhdGVkUHJvamVjdCgkKQogICAg ICAgICAkY29tbWFuZCA9ICIkYnVpbGRQYXRoL2J1aWxkLnNoIjsKICAgICAgICAgQGFyZ3MgPSAo JG1ha2VBcmdzKTsKICAgICB9CisgICAgcHVzaCBAYXJncywgIi12IiBpZiAkRU5We1ZFUkJPU0V9 OwogCiAgICAgIyBXZSBjYWxsIHN5c3RlbSgiY21ha2UgQGFyZ3MiKSBpbnN0ZWFkIG9mIHN5c3Rl bSgiY21ha2UiLCBAYXJncykgc28gdGhhdCBAYXJncyBpcwogICAgICMgcGFyc2VkIGZvciBzaGVs bCBtZXRhY2hhcmFjdGVycy4gSW4gcGFydGljdWxhciwgJG1ha2VBcmdzIG1heSBjb250YWluIHN1 Y2ggbWV0YWNoYXJhY3RlcnMuCg==