137605 2014-10-10 04:06:04 -0700 [EFL] Make it possible to use ninja for EFL build too 2014-11-06 05:51:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137606 137818 1 evab.u-szeged evab.u-szeged commit-queue dbates ossy oldest_to_newest 1040886 0 evab.u-szeged 2014-10-10 04:06:04 -0700 Make it possible to use ninja for EFL build too. 1040888 1 239617 evab.u-szeged 2014-10-10 04:08:26 -0700 Created attachment 239617 Patch 1041108 2 239617 gyuyoung.kim 2014-10-10 22:55:29 -0700 Comment on attachment 239617 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239617&action=review r- due to missing ninja-build in install-dependency. > Tools/Scripts/webkitdirs.pm:1763 > + my $willUseNinja = canUseNinja(); Personally I like to use ninja. To use ninja for EFL, we have to add ninja-build to EFL install-dependency as well. 1041258 3 239720 evab.u-szeged 2014-10-13 02:54:28 -0700 Created attachment 239720 Patch 1041263 4 239720 ossy 2014-10-13 03:34:20 -0700 Comment on attachment 239720 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239720&action=review > Tools/efl/install-dependencies:91 > + > + apt-get install ninja-build Why don't we add it simple to the first section, similar to g++, cmake, etc. ? 1041271 5 239724 evab.u-szeged 2014-10-13 05:45:33 -0700 Created attachment 239724 Patch 1041537 6 239724 ossy 2014-10-14 04:34:36 -0700 Comment on attachment 239724 Patch r=me 1041542 7 239724 commit-queue 2014-10-14 05:09:53 -0700 Comment on attachment 239724 Patch Clearing flags on attachment: 239724 Committed r174681: <http://trac.webkit.org/changeset/174681> 1041543 8 commit-queue 2014-10-14 05:09:55 -0700 All reviewed patches have been landed. Closing bug. 239617 2014-10-10 04:08:26 -0700 2014-10-13 02:54:23 -0700 Patch bug-137605-20141010130829.patch text/plain 1372 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2NlZDkwZDFlMzNkZDQ1MjkyMTQ2YmM5YmVlYWRlODk1 MDYxMTk4Ny4uOGU4MmI2YWMyYzE3NjI0NGRkZTk1MDFlZTg3NDJhODNhYWU5NDEwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTEwLTEwICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTWFrZSBpdCBwb3NzaWJsZSB0byB1c2Ugbmlu amEgZm9yIEVGTCBidWlsZCB0b28KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNzYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVC dWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOgorCiAyMDE0LTEwLTEwICBBZHJpZW4gRGVzdHVn dWVzICA8cHVsa29tYW5keUBnbWFpbC5jb20+CiAKICAgICAgICAgRml4IHBlcmwgc2NyaXB0cyB0 byBydW4gd2l0aCBlbnYgb24gTGludXgKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA3NzJkY2M0MjE0ZWFh MmU2ZDdmYTFiOTE4N2QwMjRiZDgwNWMxMmY1Li4yMWRmOTQwOGQzYzc3MGVjM2Y3NzNjYWViMTJi MmQ1MDJmODAwNDEyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xNzYwLDggKzE3NjAsOCBAQCBzdWIg Z2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKICAgICBjaGRpcigkYnVpbGRQYXRo KSBvciBkaWU7CiAKICAgICAjIEZvciBHVEsrIHdlIHRyeSB0byBiZSBzbWFydCBhYm91dCB3aGVu IHRvIHJlcnVuIGNtYWtlLCBzbyB0aGF0IHdlIGNhbiBoYXZlIGZhc3RlciBpbmNyZW1lbnRhbCBi dWlsZHMuCi0gICAgbXkgJHdpbGxVc2VOaW5qYSA9IGlzR3RrKCkgJiYgY2FuVXNlTmluamEoKTsK LSAgICBpZiAoaXNHdGsoKSAmJiAtZSBjbWFrZUNhY2hlUGF0aCgpICYmIC1lIGNtYWtlR2VuZXJh dGVkQnVpbGRmaWxlKCR3aWxsVXNlTmluamEpKSB7CisgICAgbXkgJHdpbGxVc2VOaW5qYSA9IGNh blVzZU5pbmphKCk7CisgICAgaWYgKC1lIGNtYWtlQ2FjaGVQYXRoKCkgJiYgLWUgY21ha2VHZW5l cmF0ZWRCdWlsZGZpbGUoJHdpbGxVc2VOaW5qYSkpIHsKICAgICAgICAgcmV0dXJuIDA7CiAgICAg fQogCg== 239720 2014-10-13 02:54:28 -0700 2014-10-13 05:45:28 -0700 Patch bug-137605-20141013115432.patch text/plain 1833 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmFlYWY2YWY3MjM4MGQwMmIzZGI5MDczZDRlMjljODRk ZTU1NDU4MS4uOTA5ZTkxZWQwYjgwZTM2Y2MxODUxM2Y5MjMxYjkwNzRjOTYwYTNjMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTEwLTEzICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTWFrZSBpdCBwb3NzaWJsZSB0byB1c2Ugbmlu amEgZm9yIEVGTCBidWlsZCB0b28KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNzYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVC dWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOgorICAgICAgICAqIGVmbC9pbnN0YWxsLWRlcGVu ZGVuY2llczoKKwogMjAxNC0xMC0xMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBQYWdlIG5vdCBmdWxseSByZW5kZXJlZCBpbiBpT1MgRFJUIHNuYXBz aG90cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDc3MmRjYzQyMTRlYWEyZTZkN2ZhMWI5MTg3ZDAyNGJk ODA1YzEyZjUuLjIxZGY5NDA4ZDNjNzcwZWMzZjc3M2NhZWIxMmIyZDUwMmY4MDA0MTIgMTAwNzU1 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KQEAgLTE3NjAsOCArMTc2MCw4IEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVt RnJvbUNNYWtlUHJvamVjdAogICAgIGNoZGlyKCRidWlsZFBhdGgpIG9yIGRpZTsKIAogICAgICMg Rm9yIEdUSysgd2UgdHJ5IHRvIGJlIHNtYXJ0IGFib3V0IHdoZW4gdG8gcmVydW4gY21ha2UsIHNv IHRoYXQgd2UgY2FuIGhhdmUgZmFzdGVyIGluY3JlbWVudGFsIGJ1aWxkcy4KLSAgICBteSAkd2ls bFVzZU5pbmphID0gaXNHdGsoKSAmJiBjYW5Vc2VOaW5qYSgpOwotICAgIGlmIChpc0d0aygpICYm IC1lIGNtYWtlQ2FjaGVQYXRoKCkgJiYgLWUgY21ha2VHZW5lcmF0ZWRCdWlsZGZpbGUoJHdpbGxV c2VOaW5qYSkpIHsKKyAgICBteSAkd2lsbFVzZU5pbmphID0gY2FuVXNlTmluamEoKTsKKyAgICBp ZiAoLWUgY21ha2VDYWNoZVBhdGgoKSAmJiAtZSBjbWFrZUdlbmVyYXRlZEJ1aWxkZmlsZSgkd2ls bFVzZU5pbmphKSkgewogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1Rv b2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVu Y2llcwppbmRleCBlN2JlY2M3ZmIxNjhmOTgyMGI5YmMxNjhmOGNhMTBlMWIzZTYzNzJiLi5lODBl ZDMyMzhhNTViOTFlOWZlOTYwZjVlYTcwZTUxMjZlNGYwNmMzIDEwMDc1NQotLS0gYS9Ub29scy9l ZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZWZsL2luc3RhbGwtZGVwZW5kZW5j aWVzCkBAIC04Nyw2ICs4Nyw4IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0 IHsKICAgICAgICAgbGliYXBhY2hlMi1tb2QtcGhwNSBcCiAgICAgICAgIGxpYnJ1YnkgXAogICAg ICAgICB4dmZiCisKKyAgICBhcHQtZ2V0IGluc3RhbGwgbmluamEtYnVpbGQKIH0KIAogY2hlY2tJ bnN0YWxsZXIK 239724 2014-10-13 05:45:33 -0700 2014-10-14 05:09:53 -0700 Patch bug-137605-20141013144536.patch text/plain 1857 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmFlYWY2YWY3MjM4MGQwMmIzZGI5MDczZDRlMjljODRk ZTU1NDU4MS4uOTA5ZTkxZWQwYjgwZTM2Y2MxODUxM2Y5MjMxYjkwNzRjOTYwYTNjMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTEwLTEzICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTWFrZSBpdCBwb3NzaWJsZSB0byB1c2Ugbmlu amEgZm9yIEVGTCBidWlsZCB0b28KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNzYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVC dWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOgorICAgICAgICAqIGVmbC9pbnN0YWxsLWRlcGVu ZGVuY2llczoKKwogMjAxNC0xMC0xMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBQYWdlIG5vdCBmdWxseSByZW5kZXJlZCBpbiBpT1MgRFJUIHNuYXBz aG90cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDc3MmRjYzQyMTRlYWEyZTZkN2ZhMWI5MTg3ZDAyNGJk ODA1YzEyZjUuLjIxZGY5NDA4ZDNjNzcwZWMzZjc3M2NhZWIxMmIyZDUwMmY4MDA0MTIgMTAwNzU1 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KQEAgLTE3NjAsOCArMTc2MCw4IEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVt RnJvbUNNYWtlUHJvamVjdAogICAgIGNoZGlyKCRidWlsZFBhdGgpIG9yIGRpZTsKIAogICAgICMg Rm9yIEdUSysgd2UgdHJ5IHRvIGJlIHNtYXJ0IGFib3V0IHdoZW4gdG8gcmVydW4gY21ha2UsIHNv IHRoYXQgd2UgY2FuIGhhdmUgZmFzdGVyIGluY3JlbWVudGFsIGJ1aWxkcy4KLSAgICBteSAkd2ls bFVzZU5pbmphID0gaXNHdGsoKSAmJiBjYW5Vc2VOaW5qYSgpOwotICAgIGlmIChpc0d0aygpICYm IC1lIGNtYWtlQ2FjaGVQYXRoKCkgJiYgLWUgY21ha2VHZW5lcmF0ZWRCdWlsZGZpbGUoJHdpbGxV c2VOaW5qYSkpIHsKKyAgICBteSAkd2lsbFVzZU5pbmphID0gY2FuVXNlTmluamEoKTsKKyAgICBp ZiAoLWUgY21ha2VDYWNoZVBhdGgoKSAmJiAtZSBjbWFrZUdlbmVyYXRlZEJ1aWxkZmlsZSgkd2ls bFVzZU5pbmphKSkgewogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1Rv b2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVu Y2llcwppbmRleCBlN2JlY2M3ZmIxNjhmOTgyMGI5YmMxNjhmOGNhMTBlMWIzZTYzNzJiLi4wZTFl M2MzNDc0MWVkNTZmYjY0YzVmNmQxOGU4N2FlMDA5Y2IzNWQyIDEwMDc1NQotLS0gYS9Ub29scy9l ZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZWZsL2luc3RhbGwtZGVwZW5kZW5j aWVzCkBAIC03Miw2ICs3Miw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0 IHsKICAgICAgICAgbGlieHNzLWRldiBcCiAgICAgICAgIGxpYnh0LWRldiBcCiAgICAgICAgIGxp Ynh0c3QtZGV2IFwKKyAgICAgICAgbmluamEtYnVpbGQgXAogICAgICAgICByYWdlbCBcCiAgICAg ICAgIHJ1YnkgXAogICAgICAgICBzdWJ2ZXJzaW9uIFwK