137602 2014-10-10 02:33:53 -0700 Add test to check stretchy value is case sensitive 2014-10-14 03:58:42 -0700 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned commit-queue darin dbarton fred.wang mrobinson oldest_to_newest 1040861 0 alex 2014-10-10 02:33:53 -0700 It is not usual for other specs so it is good we have a test checking the sensitiveness of the attribute. This is a followup of the bug #136883. 1040866 1 239611 alex 2014-10-10 02:37:24 -0700 Created attachment 239611 patch 1040938 2 239611 darin 2014-10-10 09:46:56 -0700 Comment on attachment 239611 patch Two thoughts: 1) We should also check that "false" is case sensitive. I presume there is some case where the default for stretchy is true, and "false" changes it back to false, but "False" does not. 2) Tests that explain what the results should look like are generally better than tests that don't. Even though this is a reference test it would be nice if it was self-explanatory in the browser. In many cases I put expected results in the original as well as the expected file so a human being can compare things visually, and then put the expected result twice in the expected.html file. For example, fast/text/international/old-turkic-direction.html takes that approach. 1041520 3 alex 2014-10-14 03:11:10 -0700 (In reply to comment #2) > (From update of attachment 239611 [details]) > Two thoughts: > > 1) We should also check that "false" is case sensitive. I presume there is some case where the default for stretchy is true, and "false" changes it back to false, but "False" does not. > > 2) Tests that explain what the results should look like are generally better than tests that don't. Even though this is a reference test it would be nice if it was self-explanatory in the browser. In many cases I put expected results in the original as well as the expected file so a human being can compare things visually, and then put the expected result twice in the expected.html file. For example, fast/text/international/old-turkic-direction.html takes that approach. Thanks for the proposals, I'll add both of them before landing. 1041530 4 alex 2014-10-14 03:58:26 -0700 Landed http://trac.webkit.org/changeset/174680 Thanks! 239611 2014-10-10 02:37:24 -0700 2014-10-14 03:58:42 -0700 patch stretchy-case-sensitive.patch text/plain 1665 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2NjJhYWE0Li42YTA5MmQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMTAt MTAgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgQWRk IHRlc3QgdG8gY2hlY2sgc3RyZXRjaHkgdmFsdWUgaXMgY2FzZSBzZW5zaXRpdmUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzYwMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWF0aG1sL3ByZXNlbnRh dGlvbi9tby1zdHJldGNoeS1jYXNlLXNlbnNpdGl2ZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBtYXRobWwvcHJlc2VudGF0aW9uL21vLXN0cmV0Y2h5LWNhc2Utc2Vuc2l0aXZlLmh0 bWw6IEFkZGVkLgorCiAyMDE0LTEwLTA5ICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIENoYW5nZXMgaW4gdGhlIHN0cmV0Y2h5IGF0dHJpYnV0ZSBkbyBu b3QgdXBkYXRlIHJlbmRlcmluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWF0aG1sL3ByZXNl bnRhdGlvbi9tby1zdHJldGNoeS1jYXNlLXNlbnNpdGl2ZS1leHBlY3RlZC5odG1sIGIvTGF5b3V0 VGVzdHMvbWF0aG1sL3ByZXNlbnRhdGlvbi9tby1zdHJldGNoeS1jYXNlLXNlbnNpdGl2ZS1leHBl Y3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmI1MjIwMzcKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tYXRobWwvcHJlc2VudGF0aW9uL21vLXN0cmV0 Y2h5LWNhc2Utc2Vuc2l0aXZlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxMSBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorICAgIDxtYXRoPgorICAgICAgICA8bXJvdz4KKyAg ICAgICAgICAgIDxtbyBzdHJldGNoeT0iZmFsc2UiPiZJbnRlZ3JhbDs8L21vPgorICAgICAgICAg ICAgPG1zcGFjZSBoZWlnaHQ9Ijc1cHgiIGRlcHRoPSIxcHgiLz4KKyAgICAgICAgPC9tcm93Pgor ICAgIDwvbWF0aD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21h dGhtbC9wcmVzZW50YXRpb24vbW8tc3RyZXRjaHktY2FzZS1zZW5zaXRpdmUuaHRtbCBiL0xheW91 dFRlc3RzL21hdGhtbC9wcmVzZW50YXRpb24vbW8tc3RyZXRjaHktY2FzZS1zZW5zaXRpdmUuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi40NTY5MGNkCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvbWF0aG1sL3ByZXNlbnRhdGlvbi9tby1zdHJldGNoeS1jYXNl LXNlbnNpdGl2ZS5odG1sCkBAIC0wLDAgKzEsMTEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ Cis8Ym9keT4KKyAgICA8bWF0aD4KKyAgICAgICAgPG1yb3c+CisgICAgICAgICAgICA8bW8gc3Ry ZXRjaHk9IlRydWUiPiZJbnRlZ3JhbDs8L21vPgorICAgICAgICAgICAgPG1zcGFjZSBoZWlnaHQ9 Ijc1cHgiIGRlcHRoPSIxcHgiLz4KKyAgICAgICAgPC9tcm93PgorICAgIDwvbWF0aD4KKzwvYm9k eT4KKzwvaHRtbD4K