137592 2014-10-09 19:56:30 -0700 New perf dashboard UI tries to fetch commits all the time 2016-02-16 13:53:38 -0800 1 1 1 Unclassified WebKit Perf Dashboard 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa barraclough benjamin cdumez commit-queue kling rniwa oldest_to_newest 1040788 0 rniwa 2014-10-09 19:56:30 -0700 Avoid trying to fetch commits for repositories without any reported commits, and also cache the fetched commit logs in the client side instead of always XHRing to the server. 1040789 1 239592 rniwa 2014-10-09 20:02:48 -0700 Created attachment 239592 Fixes the bug 1040800 2 239592 commit-queue 2014-10-09 20:45:22 -0700 Comment on attachment 239592 Fixes the bug Clearing flags on attachment: 239592 Committed r174555: <http://trac.webkit.org/changeset/174555> 1040801 3 commit-queue 2014-10-09 20:45:26 -0700 All reviewed patches have been landed. Closing bug. 239592 2014-10-09 20:02:48 -0700 2014-10-09 20:45:22 -0700 Fixes the bug bug-137592-20141009200231.patch text/plain 7468 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0NTUyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMxIEBACisyMDE0LTEwLTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIE5ldyBwZXJmIGRhc2hib2FyZCBVSSB0cmllcyB0byBmZXRjaCBjb21taXRzIGFs bCB0aGUgdGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM3NTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkZWQgaGFzUmVwb3J0ZWRDb21taXRzIGJvb2xlYW4gdG8gcmVwb3NpdG9yeSBtZXRhIGRh dGEgaW4gbWFuaWZlc3QuanNvbiwgYW5kIHVzZWQgdGhhdCBpbgorICAgICAgICB0aGUgZnJvbnQg ZW5kIHRvIGF2b2lkIGlzc3VpbmcgSFRUUCByZXF1ZXN0cyB0byBmZXRjaCBjb21taXQgbG9ncyBm b3IgcmVwb3NpdG9yaWVzIHdpdGgKKyAgICAgICAgbm8gcmVwb3J0ZWQgY29tbWl0cyBhcyB0aGV5 IGFyZSBhbGwgZ29pbmcgdG8gZmFpbC4KKworICAgICAgICBBbHNvIGFkZGVkIGFuIGludGVybmFs IGNhY2hlIHRvIEZldGNoQ29tbWl0c0ZvclRpbWVSYW5nZSBpbiB0aGUgZnJvbnQgZW5kIHRvIGF2 b2lkIGZldGNoaW5nCisgICAgICAgIHRoZSBzYW1lIGNvbW1pdCBsb2dzIHJlcGVhdGVkbHkuIFRo ZXJlIGFyZSB0d28gZGF0YSBzdHJ1Y3R1cmVzIHdlIGNhY2hlOiBjb21taXRzQnlSZXZpc2lvbgor ICAgICAgICB3aGljaCBtYXBzIGEgZ2l2ZW4gY29tbWl0IHJldmlzaW9uL2hhc2ggdG8gYSBjb21t aXQgb2JqZWN0OyBhbmQgY29tbWl0c0J5VGltZSB3aGljaCBpcyBhbiBhcnJheQorICAgICAgICBv ZiBjb21taXRzIHNvcnRlZCBjaHJvbm9sb2dpY2FsbHkgYnkgdGltZS4KKworICAgICAgICAqIHB1 YmxpYy9pbmNsdWRlL21hbmlmZXN0LnBocDoKKworICAgICAgICAqIHB1YmxpYy92Mi9hcHAuanM6 CisgICAgICAgIChBcHAuQ29tbWl0c1ZpZXdlckNvbXBvbmVudC5jb21taXRzQ2hhbmdlZCk6CisK KyAgICAgICAgKiBwdWJsaWMvdjIvZGF0YS5qczoKKyAgICAgICAgKEZldGNoQ29tbWl0c0ZvclRp bWVSYW5nZSk6CisgICAgICAgIChGZXRjaENvbW1pdHNGb3JUaW1lUmFuZ2UuX2NhY2hlZENvbW1p dHNCeVJlcG9zaXRvcnkpOgorCisgICAgICAgICogcHVibGljL3YyL21hbmlmZXN0LmpzOgorICAg ICAgICAoQXBwLlJlcG9zaXRvcnkpOgorCiAyMDE0LTEwLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFub3RoZXIgdW5yZXZpZXdlZCBidWlsZCBmaXggYWZ0 ZXIgcjE3NDQ3Ny4KSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVk ZS9tYW5pZmVzdC5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1 YmxpYy9pbmNsdWRlL21hbmlmZXN0LnBocAkocmV2aXNpb24gMTc0NTM3KQorKysgV2Vic2l0ZXMv cGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRlL21hbmlmZXN0LnBocAkod29ya2luZyBjb3B5 KQpAQCAtMTUsMTIgKzE1LDE4IEBAIGNsYXNzIE1hbmlmZXN0R2VuZXJhdG9yIHsKICAgICAgICAg JGNvbmZpZ190YWJsZSA9ICR0aGlzLT5kYi0+ZmV0Y2hfdGFibGUoJ3Rlc3RfY29uZmlndXJhdGlv bnMnKTsKICAgICAgICAgJHBsYXRmb3JtX3RhYmxlID0gJHRoaXMtPmRiLT5mZXRjaF90YWJsZSgn cGxhdGZvcm1zJyk7CiAgICAgICAgICRyZXBvc2l0b3JpZXNfdGFibGUgPSAkdGhpcy0+ZGItPmZl dGNoX3RhYmxlKCdyZXBvc2l0b3JpZXMnKTsKKworICAgICAgICAkcmVwb3NpdG9yaWVzX3dpdGhf Y29tbWl0ID0gJHRoaXMtPmRiLT5xdWVyeV9hbmRfZmV0Y2hfYWxsKAorICAgICAgICAgICAgJ1NF TEVDVCBESVNUSU5DVChjb21taXRfcmVwb3NpdG9yeSkgRlJPTSBjb21taXRzIFdIRVJFIGNvbW1p dF9yZXBvcnRlZCBJUyBUUlVFJykgb3IgYXJyYXkoKTsKKyAgICAgICAgZm9yZWFjaCAoJHJlcG9z aXRvcmllc193aXRoX2NvbW1pdCBhcyAmJHJvdykKKyAgICAgICAgICAgICRyb3cgPSAkcm93Wydj b21taXRfcmVwb3NpdG9yeSddOworCiAgICAgICAgICR0aGlzLT5tYW5pZmVzdCA9IGFycmF5KAog ICAgICAgICAgICAgJ3Rlc3RzJyA9PiAkdGhpcy0+dGVzdHMoKSwKICAgICAgICAgICAgICdtZXRy aWNzJyA9PiAkdGhpcy0+bWV0cmljcygpLAogICAgICAgICAgICAgJ2FsbCcgPT4gJHRoaXMtPnBs YXRmb3JtcygkY29uZmlnX3RhYmxlLCAkcGxhdGZvcm1fdGFibGUsIGZhbHNlKSwKICAgICAgICAg ICAgICdkYXNoYm9hcmQnID0+ICR0aGlzLT5wbGF0Zm9ybXMoJGNvbmZpZ190YWJsZSwgJHBsYXRm b3JtX3RhYmxlLCB0cnVlKSwKLSAgICAgICAgICAgICdyZXBvc2l0b3JpZXMnID0+ICR0aGlzLT5y ZXBvc2l0b3JpZXMoJHJlcG9zaXRvcmllc190YWJsZSksCisgICAgICAgICAgICAncmVwb3NpdG9y aWVzJyA9PiAkdGhpcy0+cmVwb3NpdG9yaWVzKCRyZXBvc2l0b3JpZXNfdGFibGUsICRyZXBvc2l0 b3JpZXNfd2l0aF9jb21taXQpLAogICAgICAgICAgICAgJ2J1aWxkZXJzJyA9PiAkdGhpcy0+YnVp bGRlcnMoKSwKICAgICAgICAgICAgICdidWdUcmFja2VycycgPT4gJHRoaXMtPmJ1Z190cmFja2Vy cygkcmVwb3NpdG9yaWVzX3RhYmxlKSwKICAgICAgICAgKTsKQEAgLTg1LDEyICs5MSwxNiBAQCBj bGFzcyBNYW5pZmVzdEdlbmVyYXRvciB7CiAgICAgICAgIHJldHVybiAkcGxhdGZvcm1zOwogICAg IH0KIAotICAgIHByaXZhdGUgZnVuY3Rpb24gcmVwb3NpdG9yaWVzKCRyZXBvc2l0b3JpZXNfdGFi bGUpIHsKKyAgICBwcml2YXRlIGZ1bmN0aW9uIHJlcG9zaXRvcmllcygkcmVwb3NpdG9yaWVzX3Rh YmxlLCAkcmVwb3NpdG9yaWVzX3dpdGhfY29tbWl0KSB7CiAgICAgICAgICRyZXBvc2l0b3JpZXMg PSBhcnJheSgpOwogICAgICAgICBpZiAoISRyZXBvc2l0b3JpZXNfdGFibGUpCiAgICAgICAgICAg ICByZXR1cm4gJHJlcG9zaXRvcmllczsKLSAgICAgICAgZm9yZWFjaCAoJHJlcG9zaXRvcmllc190 YWJsZSBhcyAkcm93KQotICAgICAgICAgICAgJHJlcG9zaXRvcmllc1skcm93WydyZXBvc2l0b3J5 X25hbWUnXV0gPSBhcnJheSgndXJsJyA9PiAkcm93WydyZXBvc2l0b3J5X3VybCddLCAnYmxhbWVV cmwnID0+ICRyb3dbJ3JlcG9zaXRvcnlfYmxhbWVfdXJsJ10pOworICAgICAgICBmb3JlYWNoICgk cmVwb3NpdG9yaWVzX3RhYmxlIGFzICRyb3cpIHsKKyAgICAgICAgICAgICRyZXBvc2l0b3JpZXNb JHJvd1sncmVwb3NpdG9yeV9uYW1lJ11dID0gYXJyYXkoCisgICAgICAgICAgICAgICAgJ3VybCcg PT4gJHJvd1sncmVwb3NpdG9yeV91cmwnXSwKKyAgICAgICAgICAgICAgICAnYmxhbWVVcmwnID0+ ICRyb3dbJ3JlcG9zaXRvcnlfYmxhbWVfdXJsJ10sCisgICAgICAgICAgICAgICAgJ2hhc1JlcG9y dGVkQ29tbWl0cycgPT4gaW5fYXJyYXkoJHJvd1sncmVwb3NpdG9yeV9pZCddLCAkcmVwb3NpdG9y aWVzX3dpdGhfY29tbWl0KSk7CisgICAgICAgIH0KIAogICAgICAgICByZXR1cm4gJHJlcG9zaXRv cmllczsKICAgICB9CkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2Fw cC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2Fw cC5qcwkocmV2aXNpb24gMTc0NTM3KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92Mi9hcHAuanMJKHdvcmtpbmcgY29weSkKQEAgLTE0MDgsNyArMTQwOCw3IEBAIEFwcC5Db21t aXRzVmlld2VyQ29tcG9uZW50ID0gRW1iZXIuQ29tcG8KICAgICAgICAgdmFyIHRvID0gcmV2aXNp b25JbmZvLmdldCgnY3VycmVudFJldmlzaW9uJyk7CiAgICAgICAgIHZhciBmcm9tID0gcmV2aXNp b25JbmZvLmdldCgncHJldmlvdXNSZXZpc2lvbicpIHx8IHRvOwogICAgICAgICB2YXIgcmVwb3Np dG9yeSA9IHRoaXMuZ2V0KCdyZXBvc2l0b3J5Jyk7Ci0gICAgICAgIGlmICghZnJvbSB8fCAhcmVw b3NpdG9yeSkKKyAgICAgICAgaWYgKCFmcm9tIHx8ICFyZXBvc2l0b3J5IHx8ICFyZXBvc2l0b3J5 LmdldCgnaGFzUmVwb3J0ZWRDb21taXRzJykpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAg ICAgdmFyIHNlbGYgPSB0aGlzOwpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92Mi9kYXRhLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjIvZGF0YS5qcwkocmV2aXNpb24gMTc0NTM3KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy92Mi9kYXRhLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDE1ICsxLDQ0IEBACiAv LyBXZSBkb24ndCB1c2UgRFMuTW9kZWwgZm9yIHRoZXNlIG9iamVjdCB0eXBlcyBiZWNhdXNlIHdl IGNhbid0IGFmZm9yZCB0byBwcm9jZXNzIG1pbGxpb25zIG9mIHRoZW0uCiAKLUZldGNoQ29tbWl0 c0ZvclRpbWVSYW5nZSA9IGZ1bmN0aW9uIChyZXBvc2l0b3J5LCBmcm9tLCB0bykKK2Z1bmN0aW9u IEZldGNoQ29tbWl0c0ZvclRpbWVSYW5nZShyZXBvc2l0b3J5LCBmcm9tLCB0bykKIHsKICAgICB2 YXIgdXJsID0gJy4uL2FwaS9jb21taXRzLycgKyByZXBvc2l0b3J5LmdldCgnaWQnKSArICcvJyAr IGZyb20gKyAnLScgKyB0bzsKLSAgICBjb25zb2xlLmxvZygnRmV0Y2hpbmcgJyArIHVybCkKKwor ICAgIHZhciBjYWNoZWRDb21taXRzID0gRmV0Y2hDb21taXRzRm9yVGltZVJhbmdlLl9jYWNoZWRD b21taXRzQnlSZXBvc2l0b3J5W3JlcG9zaXRvcnldOworICAgIGlmICghY2FjaGVkQ29tbWl0cykg eworICAgICAgICBjYWNoZWRDb21taXRzID0ge2NvbW1pdHNCeVJldmlzaW9uOiB7fSwgY29tbWl0 c0J5VGltZTogW119OworICAgICAgICBGZXRjaENvbW1pdHNGb3JUaW1lUmFuZ2UuX2NhY2hlZENv bW1pdHNCeVJlcG9zaXRvcnlbcmVwb3NpdG9yeV0gPSBjYWNoZWRDb21taXRzOworICAgIH0KKwor ICAgIGlmIChjYWNoZWRDb21taXRzKSB7CisgICAgICAgIHZhciBzdGFydENvbW1pdCA9IGNhY2hl ZENvbW1pdHMuY29tbWl0c0J5UmV2aXNpb25bZnJvbV07CisgICAgICAgIHZhciBlbmRDb21taXQg PSBjYWNoZWRDb21taXRzLmNvbW1pdHNCeVJldmlzaW9uW3RvXTsKKyAgICAgICAgaWYgKHN0YXJ0 Q29tbWl0ICYmIGVuZENvbW1pdCkgeworICAgICAgICAgICAgcmV0dXJuIG5ldyBFbWJlci5SU1ZQ LlByb21pc2UoZnVuY3Rpb24gKHJlc29sdmUpIHsKKyAgICAgICAgICAgICAgICByZXNvbHZlKGNh Y2hlZENvbW1pdHMuY29tbWl0c0J5VGltZS5zbGljZShzdGFydENvbW1pdC5pbmRleCwgZW5kQ29t bWl0LmluZGV4ICsgMSkpIH0pOworICAgICAgICB9CisgICAgfQorCisgICAgY29uc29sZS5sb2co J0ZlY3RoaW5nICcgKyB1cmwpOworCiAgICAgcmV0dXJuIG5ldyBFbWJlci5SU1ZQLlByb21pc2Uo ZnVuY3Rpb24gKHJlc29sdmUsIHJlamVjdCkgewogICAgICAgICAkLmdldEpTT04odXJsLCBmdW5j dGlvbiAoZGF0YSkgewogICAgICAgICAgICAgaWYgKGRhdGEuc3RhdHVzICE9ICdPSycpIHsKICAg ICAgICAgICAgICAgICByZWplY3QoZGF0YS5zdGF0dXMpOwogICAgICAgICAgICAgICAgIHJldHVy bjsKICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZGF0YS5jb21taXRzLmZvckVhY2goZnVu Y3Rpb24gKGNvbW1pdCkgeworICAgICAgICAgICAgICAgIGlmIChjYWNoZWRDb21taXRzLmNvbW1p dHNCeVJldmlzaW9uW2NvbW1pdC5yZXZpc2lvbl0pCisgICAgICAgICAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgICAgICAgICBjb21taXQudGltZSA9IG5ldyBEYXRlKGNvbW1pdC50aW1lLnJl cGxhY2UoJyAnLCAnVCcpKTsKKyAgICAgICAgICAgICAgICBjYWNoZWRDb21taXRzLmNvbW1pdHNC eVJldmlzaW9uW2NvbW1pdC5yZXZpc2lvbl0gPSBjb21taXQ7CisgICAgICAgICAgICAgICAgY2Fj aGVkQ29tbWl0cy5jb21taXRzQnlUaW1lLnB1c2goY29tbWl0KTsKKyAgICAgICAgICAgIH0pOwor CisgICAgICAgICAgICBjYWNoZWRDb21taXRzLmNvbW1pdHNCeVRpbWUuc29ydChmdW5jdGlvbiAo YSwgYikgeyByZXR1cm4gYS50aW1lIC0gYi50aW1lOyB9KTsKKyAgICAgICAgICAgIGNhY2hlZENv bW1pdHMuY29tbWl0c0J5VGltZS5mb3JFYWNoKGZ1bmN0aW9uIChjb21taXQsIGluZGV4KSB7IGNv bW1pdC5pbmRleCA9IGluZGV4OyB9KTsKKwogICAgICAgICAgICAgcmVzb2x2ZShkYXRhLmNvbW1p dHMpOwogICAgICAgICB9KS5mYWlsKGZ1bmN0aW9uICh4aHIsIHN0YXR1cywgZXJyb3IpIHsKICAg ICAgICAgICAgIHJlamVjdCh4aHIuc3RhdHVzICsgKGVycm9yID8gJywgJyArIGVycm9yIDogJycp KTsKQEAgLTE3LDYgKzQ2LDggQEAgRmV0Y2hDb21taXRzRm9yVGltZVJhbmdlID0gZnVuY3Rpb24g KHJlcAogICAgIH0pOwogfQogCitGZXRjaENvbW1pdHNGb3JUaW1lUmFuZ2UuX2NhY2hlZENvbW1p dHNCeVJlcG9zaXRvcnkgPSB7fTsKKwogZnVuY3Rpb24gTWVhc3VyZW1lbnQocmF3RGF0YSkKIHsK ICAgICB0aGlzLl9yYXcgPSByYXdEYXRhOwpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3Jn L3B1YmxpYy92Mi9tYW5pZmVzdC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvcHVibGljL3YyL21hbmlmZXN0LmpzCShyZXZpc2lvbiAxNzQ1MzcpCisrKyBXZWJzaXRl cy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL21hbmlmZXN0LmpzCSh3b3JraW5nIGNvcHkpCkBA IC03Miw2ICs3Miw3IEBAIEFwcC5QbGF0Zm9ybSA9IEFwcC5OYW1lTGFiZWxNb2RlbC5leHRlbmQK IEFwcC5SZXBvc2l0b3J5ID0gQXBwLk5hbWVMYWJlbE1vZGVsLmV4dGVuZCh7CiAgICAgdXJsOiBE Uy5hdHRyKCdzdHJpbmcnKSwKICAgICBibGFtZVVybDogRFMuYXR0cignc3RyaW5nJyksCisgICAg aGFzUmVwb3J0ZWRDb21taXRzOiBEUy5hdHRyKCdib29sZWFuJyksCiAgICAgdXJsRm9yUmV2aXNp b246IGZ1bmN0aW9uIChjdXJyZW50UmV2aXNpb24pIHsKICAgICAgICAgcmV0dXJuICh0aGlzLmdl dCgndXJsJykgfHwgJycpLnJlcGxhY2UoL1wkMS9nLCBjdXJyZW50UmV2aXNpb24pOwogICAgIH0s Cg==