<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137588</bug_id>
          
          <creation_ts>2014-10-09 18:13:57 -0700</creation_ts>
          <short_desc>requestAnimationFrame tests all time out in iOS simulator</short_desc>
          <delta_ts>2016-01-04 11:25:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1040779</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2014-10-09 18:13:57 -0700</bug_when>
    <thetext>The fast/animation tests all time out. I will skip them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1152129</commentid>
    <comment_count>1</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2016-01-03 11:01:06 -0800</bug_when>
    <thetext>Still an issue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1152376</commentid>
    <comment_count>2</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2016-01-04 10:42:28 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; Still an issue?

I am running these tests locally to check.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1152385</commentid>
    <comment_count>3</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2016-01-04 10:53:08 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #1)
&gt; &gt; Still an issue?
&gt; 
&gt; I am running these tests locally to check.

When run locally, all fast/animation tests pass except for:
fast/animation/request-animation-frame-disabled.html

--- /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/animation/request-animation-frame-disabled-expected.txt
+++ /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/animation/request-animation-frame-disabled-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
 
 
-PASS callbackInvoked is false
+FAIL callbackInvoked should be false. Was true.
 PASS successfullyParsed is true
 
 TEST COMPLETE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1152402</commentid>
    <comment_count>4</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2016-01-04 11:16:01 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; (In reply to comment #1)
&gt; &gt; &gt; Still an issue?
&gt; &gt; 
&gt; &gt; I am running these tests locally to check.
&gt; 
&gt; When run locally, all fast/animation tests pass except for:
&gt; fast/animation/request-animation-frame-disabled.html
&gt; 
&gt; ---
&gt; /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-
&gt; results/fast/animation/request-animation-frame-disabled-expected.txt
&gt; +++
&gt; /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-
&gt; results/fast/animation/request-animation-frame-disabled-actual.txt
&gt; @@ -3,7 +3,7 @@
&gt;  On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST
&gt; COMPLETE&quot;.
&gt;  
&gt;  
&gt; -PASS callbackInvoked is false
&gt; +FAIL callbackInvoked should be false. Was true.
&gt;  PASS successfullyParsed is true
&gt;  
&gt;  TEST COMPLETE

So, I think we can close this bug and file one about WebKitRequestAnimationFrameEnabled not working. It does look like people use the pref legitimately so we should probably fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1152408</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2016-01-04 11:21:42 -0800</bug_when>
    <thetext>...and re-enable the tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1152411</commentid>
    <comment_count>6</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2016-01-04 11:25:34 -0800</bug_when>
    <thetext>Re-enabled the fast/animation directory in r194540, filed &lt;https://bugs.webkit.org/show_bug.cgi?id=152701&gt; for the failing test.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>