137581 2014-10-09 16:04:56 -0700 [iOS] DumpRenderTree fails to render every other test when pixel tests are on 2014-12-05 14:12:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED InRadar P2 Normal --- 139314 1 dfarler dbates dbates ddkilzer simon.fraser oldest_to_newest 1040723 0 dfarler 2014-10-09 16:04:56 -0700 When running DumpRenderTree with --pixel-tests, PNG data gets dumped to stdout before the test has finished rendering. This happens regardless of whether the iOS app is in the foreground or background. The consequence: 1. When running the first pixel test "A" on a freshly launched DRT, you get a blank image. 2. Running subsequent test "B" is "one behind", and the previous contents for test "A" are dumped, although "B" does eventually appear in app. Steps to reproduce: Build iOS for iphonesimulator open -a $(xcode-select --print-path)/Applications/iOS\ Simulator.app DYLD_FRAMEWORK_PATH=/absolute/path/to/OpenSource/WebKitBuild/Release-iphonesimulator DYLD_LIBRARY_PATH=/absolute/path/to/OpenSource/WebKitBuild/Release-iphonesimulator /path/to/OpenSource/WebKitBuild/Release/LayoutTestRelay -runtime com.apple.CoreSimulator.SimRuntime.iOS-8-3 -deviceType com.apple.CoreSimulator.SimDeviceType.iPhone-5s -suffix 0 -productDir /absolute/path/to/OpenSource/WebKitBuild/Release-iphonesimulator -app /absolute/path/to/OpenSource/WebKitBuild/Release-iphonesimulator/DumpRenderTree.app -- --pixel-test - | tee /tmp/test.txt # Now listening to stdin, paste the following twice /absolute/path/to/OpenSource/LayoutTests/compositing/regions/fixed-in-named-flow-position-changed.html ^C Now, there will be two PNGs in /tmp/test.txt - paste each into their own image files. Observe. 1040724 1 dfarler 2014-10-09 16:07:10 -0700 Specify your `-runtime` as necessary 1041880 2 dfarler 2014-10-15 10:07:13 -0700 Another effect that I noticed here after smfr's change to wait for the web thread is that if you keep passing in tests with pixel dumps requested, essentially every other test will do the right thing, otherwise resetting to a blank view. Before, it would always be "one behind." So, there's still some state getting in the way. This behavior only happens with --pixel-tests passed at the command line to DumpRenderTree (all tests in server loop mode are pixel tests), or '-p is appended to individual tests in server loop mode. In light of this, I'm retitling the bug to reflect this. 1041881 3 dfarler 2014-10-15 10:07:36 -0700 <rdar://problem/18642906> 1052767 4 242643 dbates 2014-12-05 10:44:37 -0800 Created attachment 242643 Patch 1052844 5 242643 dbates 2014-12-05 14:12:46 -0800 Comment on attachment 242643 Patch Clearing flags on attachment: 242643 Committed r176872: <http://trac.webkit.org/changeset/176872> 1052845 6 dbates 2014-12-05 14:12:52 -0800 All reviewed patches have been landed. Closing bug. 242643 2014-12-05 10:44:37 -0800 2014-12-05 14:12:46 -0800 Patch bug-137581-20141205104512.patch text/plain 2153 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2ODQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjJmM2NkODZmOWQ2OGE5ZGQ2NzgwYjZmMjRjM2M4MjY3 ZDI0MzBlZC4uZDVmYzNhMjRiN2MzYjUxOGJmNWZiNDMyMmI4NzYwNDcxZjNlZjZjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTEyLTA1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBEdW1wUmVuZGVyVHJlZSBmYWlscyB0byByZW5kZXIgZXZlcnkgb3RoZXIgdGVz dCB3aGVuIHBpeGVsIHRlc3RzIGFyZSBvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NTgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODY0Mjkw Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhl cyBhbiBpc3N1ZSB3aGVyZSB0aGUgRHVtcFJlbmRlclRyZWUgc25hcHNob3QgbWF5IHJlZmxlY3Qg dGhlIHJlbmRlcmVkIGNvbnRlbnQKKyAgICAgICAgb2YgdGhlIHRlc3QgdGhhdCBwcm9jZWVkZWQg dGhlIGN1cnJlbnRseSBydW5uaW5nIHRlc3QuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9p b3MvUGl4ZWxEdW1wU3VwcG9ydElPUy5tbToKKyAgICAgICAgKGR1bXBXZWJWaWV3QXNQaXhlbHNB bmRDb21wYXJlV2l0aEV4cGVjdGVkKTogRW5zdXJlIHRoYXQgVUlLaXQgaGFzIHBlcmZvcm1lZCBh IGxheW91dAorICAgICAgICBvZiB0aGUgVUlXZWJCcm93c2VyVmlldyB2aWV3LiBBbHNvLCByZW1v dmUgdW5uZWNlc3NhcnkgY2FsbCB0byAtW1VJV2ViRG9jdW1lbnRWaWV3IGxheW91dFRpbGVzTm93 XQorICAgICAgICBhcyAtW1VJV2ViRG9jdW1lbnRWaWV3IG5ld1NuYXBzaG90V2l0aFJlY3RdIHdp bGwgbGF5b3V0IHRoZSB0aWxlcy4KKwogMjAxNC0xMi0wNCAgQWxleGV5IFByb3NrdXJ5YWtvdiAg PGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSdW4gaHR0cCB0ZXN0cyBwYXJhbGxlbApkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL1BpeGVsRHVtcFN1cHBvcnRJT1MubW0gYi9U b29scy9EdW1wUmVuZGVyVHJlZS9pb3MvUGl4ZWxEdW1wU3VwcG9ydElPUy5tbQppbmRleCAzMjJj YTcyNWJhYmE2ZjdjZWViOTk3YzUwMjJkMjA5NGRlYmNkNzBmLi44NDc0YzdhODk5ZjZmMjYxMmEz YzNhNmIyYzFiMjA2NDM3YWNkN2ViIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9p b3MvUGl4ZWxEdW1wU3VwcG9ydElPUy5tbQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9pb3Mv UGl4ZWxEdW1wU3VwcG9ydElPUy5tbQpAQCAtNTUsMTEgKzU1LDkgQEAgUGFzc1JlZlB0cjxCaXRt YXBDb250ZXh0PiBjcmVhdGVCaXRtYXBDb250ZXh0RnJvbVdlYlZpZXcoYm9vbCBvbnNjcmVlbiwg Ym9vbCBpbmMKIHZvaWQgZHVtcFdlYlZpZXdBc1BpeGVsc0FuZENvbXBhcmVXaXRoRXhwZWN0ZWQo Y29uc3Qgc3RkOjpzdHJpbmcmIGV4cGVjdGVkSGFzaCkKIHsKICAgICAvLyBUT0RPOiA8cmRhcjov L3Byb2JsZW0vNjU1ODM2Nj4gRHVtcFJlbmRlclRyZWU6IEludmVzdGlnYXRlIHRlc3RSZXBhaW50 U3dlZXBIb3Jpem9udGFsbHkgYW5kIGR1bXBTZWxlY3Rpb25SZWN0Ci0gICAgCi0gICAgLy8gVGFr ZSBzbmFwc2hvdAogICAgIFdlYlRocmVhZExvY2soKTsKKyAgICBbZ1dlYkJyb3dzZXJWaWV3IGxh eW91dElmTmVlZGVkXTsgLy8gUmUtZW5hYmxlcyB0aWxlIHBhaW50aW5nLCB3aGljaCB3YXMgZGlz YWJsZWQgd2hlbiBjb21taXR0aW5nIHRoZSBmcmFtZSBsb2FkLgogICAgIFtnV2ViQnJvd3NlclZp ZXcgc2V0TmVlZHNEaXNwbGF5XTsKLSAgICBbZ1dlYkJyb3dzZXJWaWV3IGxheW91dFRpbGVzTm93 XTsKICAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gc25hcHNob3QgPSBhZG9wdENGKFtnV2ViQnJv d3NlclZpZXcgbmV3U25hcHNob3RXaXRoUmVjdDpbW21haW5GcmFtZSB3ZWJWaWV3XSBmcmFtZV1d KTsKICAgICBOU0RhdGEgKnBuZ0RhdGEgPSBVSUltYWdlUE5HUmVwcmVzZW50YXRpb24oW1VJSW1h Z2UgaW1hZ2VXaXRoQ0dJbWFnZTpzbmFwc2hvdC5nZXQoKV0pOwogICAgIAo=