137562 2014-10-09 12:07:57 -0700 [EFL] Crash on facebook.com 2014-10-10 16:49:34 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 hyuki.kim webkit-unassigned cdumez commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1040628 0 hyuki.kim 2014-10-09 12:07:57 -0700 Crash occurs on the facebook.com when the webview is resized after the <select> item is clicked but no item is chosen. #0 0x00007ffff20286b5 in WebKit::WebPopupMenuListenerEfl::valueChanged (this=0x21100000000, newSelectedIndex=525) at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/WebPopupMenuListenerEfl.cpp:38 #1 0x00007ffff1f93cfe in WKPopupMenuListenerSetSelection (listenerRef=0x21100000000, selectedIndex=525) at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/API/C/efl/WKPopupMenuListener.cpp:36 #2 0x00007ffff1fc220e in EwkPopupMenu::close (this=0x20ad7a0) at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp:60 #3 0x00007ffff1fc2336 in ewk_popup_menu_close (popupMenu=0x20ad7a0) at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp:94 #4 0x0000000000406811 in on_window_resize (user_data=0x6aee50, e=0x8000000300000019, elm_window=0x80000002e0000018, event_info=0x0) at /home/hyuki/git/webkit2/Tools/MiniBrowser/efl/main.c:335 #5 0x00007fffec432573 in _eo_evas_object_cb (data=0x1a1d2c0, eo_obj=0x80000002e0000018, desc=<optimized out>, event_info=0x0) at lib/evas/canvas/evas_callbacks.c:130 #6 0x00007fffe4b66b48 in _ev_cb_call (obj_id=0x80000002e0000018, class_data=0x6b9880, list=<optimized out>) at lib/eo/eo_base_class.c:690 #7 0x00007fffe4b61743 in _eo_op_internal (p_list=0x7fffffffd808, op=16, op_type=EO_OP_TYPE_REGULAR, cur_klass=0x6b7de0, eo_ptr=0x6b9840, line=302, file=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c") at lib/eo/eo.c:306 #8 _eo_dov_internal (p_list=0x7fffffffd808, op_type=EO_OP_TYPE_REGULAR, klass=0x6b7de0, obj=0x6b9840, line=302, file=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c") at lib/eo/eo.c:338 #9 _eo_obj_dov_internal (p_list=0x7fffffffd808, obj=0x6b9840, line=302, file=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c") at lib/eo/eo.c:359 #10 eo_do_internal (file=file@entry=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c", line=line@entry=302, obj_id=obj_id@entry=0x80000002e0000018) at lib/eo/eo.c:396 #11 0x00007fffec432a81 in evas_object_event_callback_call (eo_obj=0x80000002e0000018, obj=0x6b98b0, type=EVAS_CALLBACK_RESIZE, event_info=0x0, event_id=13493) at lib/evas/canvas/evas_callbacks.c:302 #12 0x00007fffec46553e in evas_object_inform_call_resize (eo_obj=0x80000002e0000018) at lib/evas/canvas/evas_object_inform.c:41 #13 0x00007fffe4b61743 in _eo_op_internal (p_list=0x7fffffffd9d8, op=49, op_type=EO_OP_TYPE_REGULAR, cur_klass=0x6b7de0, eo_ptr=0x6b9840, line=787, file=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c") at lib/eo/eo.c:306 #14 _eo_dov_internal (p_list=0x7fffffffd9d8, op_type=EO_OP_TYPE_REGULAR, klass=0x6b7de0, obj=0x6b9840, line=787, file=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c") at lib/eo/eo.c:338 #15 _eo_obj_dov_internal (p_list=0x7fffffffd9d8, obj=0x6b9840, line=787, file=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c") at lib/eo/eo.c:359 #16 eo_do_internal (file=file@entry=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c", line=line@entry=787, obj_id=<optimized out>) at lib/eo/eo.c:396 #17 0x00007fffec459738 in evas_object_resize (eo_obj=<optimized out>, w=<optimized out>, h=<optimized out>) at lib/evas/canvas/evas_object_main.c:787 #18 0x00007fffec95e045 in _elm_win_resize_job (data=<optimized out>) at elm_win.c:656 #19 0x00007fffed4c3dcb in _ecore_job_event_handler (data=<optimized out>, type=<optimized out>, ev=<optimized out>) at lib/ecore/ecore_job.c:153 #20 0x00007fffed4bea87 in _ecore_call_handler_cb (event=<optimized out>, type=<optimized out>, data=<optimized out>, func=<optimized out>) at lib/ecore/ecore_private.h:359 #21 _ecore_event_call () at lib/ecore/ecore_events.c:562 #22 0x00007fffed4c5945 in _ecore_main_loop_iterate_internal (once_only=once_only@entry=0) at lib/ecore/ecore_main.c:2039 ---Type <return> to continue, or q <return> to quit--- #23 0x00007fffed4c5c57 in ecore_main_loop_begin () at lib/ecore/ecore_main.c:1042 #24 0x000000000040cf26 in elm_main (argc=1, argv=0x7fffffffde58) at /home/hyuki/git/webkit2/Tools/MiniBrowser/efl/main.c:2368 #25 0x000000000040cf99 in main (argc=1, argv=0x7fffffffde58) at /home/hyuki/git/webkit2/Tools/MiniBrowser/efl/main.c:2372 1040634 1 239554 hyuki.kim 2014-10-09 12:26:19 -0700 Created attachment 239554 patch 1040635 2 commit-queue 2014-10-09 12:28:07 -0700 Attachment 239554 did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1040637 3 239556 hyuki.kim 2014-10-09 12:29:57 -0700 Created attachment 239556 Patch 1040964 4 239556 cdumez 2014-10-10 10:54:00 -0700 Comment on attachment 239556 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239556&action=review > Tools/MiniBrowser/efl/main.c:1531 > + window->popup.ewk_menu = NULL; Makes sense but please move this below the elm_menu_close(). It is not nice to put this in between the elm_menu null check and the elm_menu_close() call. 1040967 5 hyuki.kim 2014-10-10 10:58:20 -0700 (In reply to comment #4) > (From update of attachment 239556 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239556&action=review > > > Tools/MiniBrowser/efl/main.c:1531 > > + window->popup.ewk_menu = NULL; > > Makes sense but please move this below the elm_menu_close(). It is not nice to put this in between the elm_menu null check and the elm_menu_close() call. Thank you for your review. I will update the patch soon. :) 1040970 6 239638 hyuki.kim 2014-10-10 11:10:58 -0700 Created attachment 239638 patch was updated. 1041069 7 239638 commit-queue 2014-10-10 16:49:30 -0700 Comment on attachment 239638 patch was updated. Clearing flags on attachment: 239638 Committed r174625: <http://trac.webkit.org/changeset/174625> 1041070 8 commit-queue 2014-10-10 16:49:34 -0700 All reviewed patches have been landed. Closing bug. 239554 2014-10-09 12:26:19 -0700 2014-10-09 12:29:57 -0700 patch crash_001.patch text/plain 1442 hyuki.kim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyY2Fi ZTZiLi45ZWY1MDZlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTQtMTAtMDkgIEt3YW5nSHl1ayBLaW0gIDxoeXVr aS5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gRml4IGNyYXNoIG9uIGZhY2Vib29r LmNvbS4KKyAgICAgICAgTmVlZDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3 NTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Jh c2ggb2NjdXJzIG9uIHRoZSBmYWNlYm9vay5jb20gd2hlbiB0aGUgd2VidmlldyBpcyByZXNpemVk CisgICAgICAgIGFmdGVyIHRoZSA8c2VsZWN0PiBpdGVtIGlzIGNsaWNrZWQgYnV0IG5vIGl0ZW0g aXMgY2hvc2VuLgorICAgICAgICBUaGlzIGNyYXNoIGlzIGp1c3QgY2F1c2VkIGJ5IHRoZSByZWZl cmVuY2Ugb2YgaW52YWxpZGF0ZWQgdmFyaWFibGUuCisgICAgICAgIEZyb20gdGhlIEV3a1ZpZXc6 OmNsb3NlUG9wdXBNZW51KCksIGV3a19tZW51IGlzIGp1c3QgaW52YWxpZGF0ZWQuCisgICAgICAg IFRoZXJlZm9yZSBld2tfbWVudSB2YXJpYWJsZSBpcyBub3QgYXZhaWxhYmxlIGFueW1vcmUgd2hl biBvbl9wb3B1cF9tZW51X2hpZGUoKQorICAgICAgICBvbiBNaW5pQnJvd3NlciBpcyBjYWxsZWQu CisgICAgICAgIEFzIGEgcmVzdWx0LCBqdXN0IHNldCBld2tfbWVudSB0byBOVUxMIGluIG9yZGVy IHRvIHByZXZlbnQgY3Jhc2ggY29uZGl0aW9uLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZs L21haW4uYzoKKyAgICAgICAgKG9uX3BvcHVwX21lbnVfaGlkZSk6CisKIDIwMTQtMTAtMDggIEph a2UgTmllbHNlbiAgPGphY29iX25pZWxzZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN0eWxlUXVl dWUgc2hvdWxkIHRocm93IGEgUGF0Y2hJc05vdFZhbGlkIGV4Y2VwdGlvbiB0byBhY2hpZXZlCmRp ZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYwppbmRleCBlNmE2MDAzLi5kYWVmMjkzIDEwMDY0NAotLS0gYS9Ub29scy9N aW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMK QEAgLTE1MjgsNiArMTUyOCw4IEBAIG9uX3BvcHVwX21lbnVfaGlkZShFd2tfVmlld19TbWFydF9E YXRhICpzbWFydERhdGEpCiAgICAgaWYgKCF3aW5kb3ctPnBvcHVwLmVsbV9tZW51KQogICAgICAg ICByZXR1cm4gRUlOQV9GQUxTRTsKIAorICAgIHdpbmRvdy0+cG9wdXAuZXdrX21lbnUgPSBOVUxM OworCiAgICAgZWxtX21lbnVfY2xvc2Uod2luZG93LT5wb3B1cC5lbG1fbWVudSk7CiAKICAgICBy ZXR1cm4gRUlOQV9UUlVFOwo= 239556 2014-10-09 12:29:57 -0700 2014-10-10 11:10:58 -0700 Patch crash_002.patch text/plain 1443 hyuki.kim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyY2Fi ZTZiLi4yYzUzMjIxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTQtMTAtMDkgIEt3YW5nSHl1ayBLaW0gIDxoeXVr aS5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gRml4IGNyYXNoIG9uIGZhY2Vib29r LmNvbS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NzU2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENy YXNoIG9jY3VycyBvbiB0aGUgZmFjZWJvb2suY29tIHdoZW4gdGhlIHdlYnZpZXcgaXMgcmVzaXpl ZAorICAgICAgICBhZnRlciB0aGUgPHNlbGVjdD4gaXRlbSBpcyBjbGlja2VkIGJ1dCBubyBpdGVt IGlzIGNob3Nlbi4KKyAgICAgICAgVGhpcyBjcmFzaCBpcyBqdXN0IGNhdXNlZCBieSB0aGUgcmVm ZXJlbmNlIG9mIGludmFsaWRhdGVkIHZhcmlhYmxlLgorICAgICAgICBGcm9tIHRoZSBFd2tWaWV3 OjpjbG9zZVBvcHVwTWVudSgpLCBld2tfbWVudSBpcyBqdXN0IGludmFsaWRhdGVkLgorICAgICAg ICBUaGVyZWZvcmUgZXdrX21lbnUgdmFyaWFibGUgaXMgbm90IGF2YWlsYWJsZSBhbnltb3JlIHdo ZW4gb25fcG9wdXBfbWVudV9oaWRlKCkKKyAgICAgICAgb24gTWluaUJyb3dzZXIgaXMgY2FsbGVk LgorICAgICAgICBBcyBhIHJlc3VsdCwganVzdCBzZXQgZXdrX21lbnUgdG8gTlVMTCBpbiBvcmRl ciB0byBwcmV2ZW50IGNyYXNoIGNvbmRpdGlvbi4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2Vm bC9tYWluLmM6CisgICAgICAgIChvbl9wb3B1cF9tZW51X2hpZGUpOgorCiAyMDE0LTEwLTA4ICBK YWtlIE5pZWxzZW4gIDxqYWNvYl9uaWVsc2VuQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHlsZVF1 ZXVlIHNob3VsZCB0aHJvdyBhIFBhdGNoSXNOb3RWYWxpZCBleGNlcHRpb24gdG8gYWNoaWV2ZQpk aWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93 c2VyL2VmbC9tYWluLmMKaW5kZXggZTZhNjAwMy4uZGFlZjI5MyAxMDA2NDQKLS0tIGEvVG9vbHMv TWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5j CkBAIC0xNTI4LDYgKzE1MjgsOCBAQCBvbl9wb3B1cF9tZW51X2hpZGUoRXdrX1ZpZXdfU21hcnRf RGF0YSAqc21hcnREYXRhKQogICAgIGlmICghd2luZG93LT5wb3B1cC5lbG1fbWVudSkKICAgICAg ICAgcmV0dXJuIEVJTkFfRkFMU0U7CiAKKyAgICB3aW5kb3ctPnBvcHVwLmV3a19tZW51ID0gTlVM TDsKKwogICAgIGVsbV9tZW51X2Nsb3NlKHdpbmRvdy0+cG9wdXAuZWxtX21lbnUpOwogCiAgICAg cmV0dXJuIEVJTkFfVFJVRTsK 239638 2014-10-10 11:10:58 -0700 2014-10-10 16:49:30 -0700 patch was updated. crash_003.patch text/plain 1394 hyuki.kim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5Zjlk YjAwLi45MTQ1ZDE0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTQtMTAtMTAgIEt3YW5nSHl1ayBLaW0gIDxoeXVr aS5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ3Jhc2ggb24gZmFjZWJvb2suY29t CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc1NjIK KworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICBDcmFzaCBvY2N1 cnMgb24gdGhlIGZhY2Vib29rLmNvbSB3aGVuIHRoZSB3ZWJ2aWV3IGlzIHJlc2l6ZWQKKyAgICAg ICAgYWZ0ZXIgdGhlIDxzZWxlY3Q+IGl0ZW0gaXMgY2xpY2tlZCBidXQgbm8gaXRlbSBpcyBjaG9z ZW4uCisgICAgICAgIFRoaXMgY3Jhc2ggaXMganVzdCBjYXVzZWQgYnkgdGhlIHJlZmVyZW5jZSBv ZiBpbnZhbGlkYXRlZCB2YXJpYWJsZS4KKyAgICAgICAgRnJvbSB0aGUgRXdrVmlldzo6Y2xvc2VQ b3B1cE1lbnUoKSwgZXdrX21lbnUgaXMganVzdCBpbnZhbGlkYXRlZC4KKyAgICAgICAgVGhlcmVm b3JlIGV3a19tZW51IHZhcmlhYmxlIGlzIG5vdCBhdmFpbGFibGUgYW55bW9yZSB3aGVuIG9uX3Bv cHVwX21lbnVfaGlkZSgpCisgICAgICAgIG9uIE1pbmlCcm93c2VyIGlzIGNhbGxlZC4KKyAgICAg ICAgQXMgYSByZXN1bHQsIGp1c3Qgc2V0IGV3a19tZW51IHRvIE5VTEwgaW4gb3JkZXIgdG8gcHJl dmVudCBjcmFzaCBjb25kaXRpb24uCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5j OgorICAgICAgICAob25fcG9wdXBfbWVudV9oaWRlKToKKwogMjAxNC0xMC0xMCAgTWljaGFlbCBT YWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYWJpbGl0eSB0byBzZWxl Y3QgdGFyZmlsZSBuYW1lIGluIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzCmRpZmYgLS1naXQgYS9Ub29s cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpp bmRleCBlNmE2MDAzLi41MDRhMzNlIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwv bWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTE1MjksNiArMTUy OSw3IEBAIG9uX3BvcHVwX21lbnVfaGlkZShFd2tfVmlld19TbWFydF9EYXRhICpzbWFydERhdGEp CiAgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOwogCiAgICAgZWxtX21lbnVfY2xvc2Uod2luZG93 LT5wb3B1cC5lbG1fbWVudSk7CisgICAgd2luZG93LT5wb3B1cC5ld2tfbWVudSA9IE5VTEw7CiAK ICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQo=