137559 2014-10-09 07:48:39 -0700 Get the patch scripts running on Haiku 2014-10-10 02:35:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pulkomandy webkit-unassigned cgarcia commit-queue dbates glenn ossy roger_fong oldest_to_newest 1040545 0 pulkomandy 2014-10-09 07:48:39 -0700 Get the patch scripts running on Haiku 1040546 1 239538 pulkomandy 2014-10-09 07:55:14 -0700 Created attachment 239538 Patch 1040648 2 239538 commit-queue 2014-10-09 12:52:11 -0700 Comment on attachment 239538 Patch Clearing flags on attachment: 239538 Committed r174521: <http://trac.webkit.org/changeset/174521> 1040649 3 commit-queue 2014-10-09 12:52:14 -0700 All reviewed patches have been landed. Closing bug. 1040720 4 roger_fong 2014-10-09 15:47:13 -0700 6 py tests failing on Windows: https://build.webkit.org/builders/Apple%20Win%207%20Release%20(Tests)/builds/47805/steps/webkitpy-test/logs/stdio 1040821 5 cgarcia 2014-10-09 23:32:47 -0700 This broke the script for me (in Debian), not sure why. $ Tools/Scripts/commit-log-editor --print-log Source/WebCore/ChangeLog /usr/bin/env: perl -w: No such file or directory However, this works: $ /usr/bin/env perl -w Tools/Scripts/commit-log-editor --print-log Source/WebCore/ChangeLog 1040822 6 cgarcia 2014-10-09 23:44:52 -0700 hmm, it seems the problem is the -w that is considered the script instead of a command line option 1040826 7 cgarcia 2014-10-09 23:54:15 -0700 As a workaround I've created a sh script called "perl -w" in my path that actually calls perl -w $* 1040851 8 pulkomandy 2014-10-10 01:55:01 -0700 Sorry, I forgot that support for multiple arguments was missing on Linux. A possible fix is removing the -w switch and using "use warnings;" instead, would that be ok? 1040855 9 ossy 2014-10-10 02:05:30 -0700 The problem is that Linux and CygWin pass "perl -w" as one argument which causes the error: - http://en.wikipedia.org/wiki/Shebang_%28Unix%29 - http://mail-index.netbsd.org/netbsd-users/2008/11/09/msg002388.html Now prepare-changelog, commit-log-editor and almost everything is broken on Linux, so we have to fix it ASAP. 1040856 10 ossy 2014-10-10 02:08:52 -0700 (In reply to comment #8) > Sorry, I forgot that support for multiple arguments was missing on Linux. A possible fix is removing the -w switch and using "use warnings;" instead, would that be ok? Good idea. Could you file a new bug report and change all -w to "use warnings" in all perl scripts in Tools? Otherwise we can use "#!/usr/bin/env perl" shebang everywhere, not only in these scripts. 1040863 11 pulkomandy 2014-10-10 02:35:34 -0700 https://bugs.webkit.org/show_bug.cgi?id=137601 239538 2014-10-09 07:55:14 -0700 2014-10-09 12:52:11 -0700 Patch bug-137559-20141009165613.patch text/plain 3671 pulkomandy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmNhYmU2Yjk3ZmQzZjQ3NTE0ZGI1NjJkODY2NjYyZmE5 YzVlOGM3ZC4uZjNiNDljZjdkNzJjNGM5MTg4YWMxZGNhY2MxOWVhNDQxZGIyY2I4ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE0LTEwLTA5ICBBZHJpZW4gRGVzdHVndWVzICA8cHVsa29tYW5keUBnbWFpbC5jb20+ CisKKyAgICAgICAgR2V0IHRoZSBwYXRjaCBzY3JpcHRzIHJ1bm5pbmcgb24gSGFpa3UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzU1OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSAvdXNyL2Jpbi9l bnYgaW5zdGVhZCBvZiBoYXJkY29kaW5nIHBhdGggdG8gcGVybC4KKyAgICAgICAgRGVjbGFyZSBo YWlrdSBwbGF0Zm9ybSBpbiBwbGF0Zm9ybWluZm8ucHkgdG8gYXZvaWQgY2hlY2std2Via2l0LXN0 eWxlCisgICAgICAgIGZhaWx1cmUuCisKKyAgICAgICAgKiBTY3JpcHRzL2NvbW1pdC1sb2ctZWRp dG9yOgorICAgICAgICAqIFNjcmlwdHMvbnVtLWNwdXM6CisgICAgICAgICogU2NyaXB0cy9wcmVw YXJlLUNoYW5nZUxvZzoKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1sYXVuY2hlcjoKKyAgICAgICAg KiBTY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2g6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weToKKyAgICAgICAgKFBsYXRmb3JtSW5mby5fZGV0 ZXJtaW5lX29zX25hbWUpOgorCiAyMDE0LTEwLTA4ICBKYWtlIE5pZWxzZW4gIDxqYWNvYl9uaWVs c2VuQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHlsZVF1ZXVlIHNob3VsZCB0aHJvdyBhIFBhdGNo SXNOb3RWYWxpZCBleGNlcHRpb24gdG8gYWNoaWV2ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9wcmVwYXJlLUNoYW5nZUxvZyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5k ZXggODIzYmIyMGNkYjM0NmY3OGNiMzk4MTZiNTNkMDcwZjU5ZDc0ZjQ5Yi4uN2EyN2RhMWJkNmUw MmQ0ZWVkZDAyNWViZmZlOTY1ZGRhMTVjOTNiNyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9w cmVwYXJlLUNoYW5nZUxvZworKysgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBA IC0xLDQgKzEsNCBAQAotIyEvdXNyL2Jpbi9wZXJsIC13CisjIS91c3IvYmluL2VudiBwZXJsIC13 CiAjIC0qLSBNb2RlOiBwZXJsOyBpbmRlbnQtdGFicy1tb2RlOiBuaWw7IGMtYmFzaWMtb2Zmc2V0 OiAyICAtKi0KIAogIwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9jb21taXQtbG9nLWVkaXRv ciBiL1Rvb2xzL1NjcmlwdHMvY29tbWl0LWxvZy1lZGl0b3IKaW5kZXggOGYyN2Y5MThiOTI2NDZl YzJiZDcxNGJlNTg5NjRmNTMzYjE2MDE0ZC4uNTM0ODk1MzcxZmY4MmM2ZWRkM2EzNDM0YTQyZmI2 YTczOWNmMGNjMSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9jb21taXQtbG9nLWVkaXRvcgor KysgYi9Ub29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yCkBAIC0xLDQgKzEsNCBAQAotIyEv dXNyL2Jpbi9wZXJsIC13CisjIS91c3IvYmluL2VudiBwZXJsIC13CiAKICMgQ29weXJpZ2h0IChD KSAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5LCAyMDEwIEFwcGxlIEluYy4gIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAjIENvcHlyaWdodCAoQykgMjAwOSBUb3JjaCBNb2JpbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9udW0tY3B1cyBiL1Rvb2xzL1Nj cmlwdHMvbnVtLWNwdXMKaW5kZXggOGE4Yzk3ZmNhY2QyYWZkN2RiZjIxODg1YTEzMTc2YTQ3MTBj M2ZkZC4uYWY1YzlmNTNmMzQxYmU5NmY3ZDc3ZjM1MTVhYjIwZjE3ODY0ZDRjNiAxMDA3NTUKLS0t IGEvVG9vbHMvU2NyaXB0cy9udW0tY3B1cworKysgYi9Ub29scy9TY3JpcHRzL251bS1jcHVzCkBA IC0xLDQgKzEsNCBAQAotIyEvdXNyL2Jpbi9wZXJsIC13CisjIS91c3IvYmluL2VudiBwZXJsIC13 CiB1c2Ugc3RyaWN0OwogdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47CmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1sYXVuY2hlciBiL1Rvb2xzL1NjcmlwdHMvcnVuLWxh dW5jaGVyCmluZGV4IGE4NDFiMDViZjU0ZGMxMDFkODgwZjZkOGRlNzY4ZGVlNjFlYWNmM2YuLjUx N2MwNTUxODkwYzllOTE1OTgwNDdkNjZlYTE0NTNjODIwNzgwN2QgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvcnVuLWxhdW5jaGVyCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCkBA IC0xLDQgKzEsNCBAQAotIyEvdXNyL2Jpbi9wZXJsIC13CisjIS91c3IvYmluL2VudiBwZXJsIC13 CiAKICMgQ29weXJpZ2h0IChDKSAyMDA3LCAyMDEzIEFwcGxlIEluYy4gIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAjIENvcHlyaWdodCAoQykgMjAwNyBTdGFpa29zIENvbXB1dGluZyBTZXJ2aWNlcywg SW5jLiAgPGluZm9Ac3RhaWtvcy5uZXQ+CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3N2bi1j cmVhdGUtcGF0Y2ggYi9Ub29scy9TY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2gKaW5kZXggZTFjZTFh Y2VhNzJmNjc0YTdhNjNkMGJiNTJlMTU3YzQzZDhmZDc2NC4uNmNkMGJjOTVjZGU2MDUyMDhjMWUy NjMwZmJiZjk2NmQyMzAxY2RhNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRl LXBhdGNoCisrKyBiL1Rvb2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaApAQCAtMSw0ICsxLDQg QEAKLSMhL3Vzci9iaW4vcGVybCAtdworIyEvdXNyL2Jpbi9lbnYgcGVybCAtdwogCiAjIENvcHly aWdodCAoQykgMjAwNSwgMjAwNiBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogIwpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3Jt aW5mby5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWlu Zm8ucHkKaW5kZXggMGZjZjdiN2E1ZjljMGVjODg2Yjg1ZTM2MzRjOGY4NTg0MjIyOThkMy4uZmVh NDc3YThhODZiZDYxN2E1YzE3Y2RkZWJhMDBmZTQ4ZjA3Mjc1MCAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CkBAIC0xMjks NiArMTI5LDggQEAgY2xhc3MgUGxhdGZvcm1JbmZvKG9iamVjdCk6CiAgICAgICAgICAgICByZXR1 cm4gJ2ZyZWVic2QnCiAgICAgICAgIGlmIHN5c19wbGF0Zm9ybS5zdGFydHN3aXRoKCdvcGVuYnNk Jyk6CiAgICAgICAgICAgICByZXR1cm4gJ29wZW5ic2QnCisgICAgICAgIGlmIHN5c19wbGF0Zm9y bS5zdGFydHN3aXRoKCdoYWlrdScpOgorICAgICAgICAgICAgcmV0dXJuICdoYWlrdScKICAgICAg ICAgcmFpc2UgQXNzZXJ0aW9uRXJyb3IoJ3VucmVjb2duaXplZCBwbGF0Zm9ybSBzdHJpbmcgIiVz IicgJSBzeXNfcGxhdGZvcm0pCiAKICAgICBkZWYgX2RldGVybWluZV9tYWNfdmVyc2lvbihzZWxm LCBtYWNfdmVyc2lvbl9zdHJpbmcpOgo=