137556 2014-10-09 05:49:29 -0700 [EFL] m_soupRequestManager was not declared 2014-10-10 10:36:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux CLOSED DUPLICATE 137613 P2 Normal --- 1 hyuki.kim webkit-unassigned cdumez lucas.de.marchi oldest_to_newest 1040526 0 hyuki.kim 2014-10-09 05:49:29 -0700 There is compilation error caused by undeclared variable for the webkit efl debug build. /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp: In constructor ‘WebKit::RequestManagerClientEfl::RequestManagerClientEfl(WKContextRef)’: /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp:42:12: error: ‘m_soupRequestManager’ was not declared in this scope ASSERT(m_soupRequestManager); ^ /home/hyuki/git/webkit2/Source/WTF/wtf/Assertions.h:232:8: note: in definition of macro ‘ASSERT’ (!(assertion) ? \ ^ [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/ViewClientEfl.cpp.o [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/WebColorPickerClient.cpp.o make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/RequestManagerClientEfl.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 1040527 1 239530 hyuki.kim 2014-10-09 05:59:24 -0700 Created attachment 239530 Fix build break casued by undeclared variable m_soupRequestManager. 1040947 2 239530 cdumez 2014-10-10 10:22:53 -0700 Comment on attachment 239530 Fix build break casued by undeclared variable m_soupRequestManager. https://bugs.webkit.org/show_bug.cgi?id=137613 seems like a better fix. 1040953 3 hyuki.kim 2014-10-10 10:33:14 -0700 (In reply to comment #2) > (From update of attachment 239530 [details]) > https://bugs.webkit.org/show_bug.cgi?id=137613 seems like a better fix. Thx for your review. :) Agree with you. So, close this bug. 1040954 4 hyuki.kim 2014-10-10 10:34:11 -0700 *** This bug has been marked as a duplicate of bug 137613 *** 239530 2014-10-09 05:59:24 -0700 2014-10-10 10:22:53 -0700 Fix build break casued by undeclared variable m_soupRequestManager. buildbreak_001.patch text/plain 1600 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhMmUyYjk2Yi4uYmYwOWE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTEwLTA5ICBLd2FuZ0h5dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIEZpeCBidWlsZCBicmVhayBjYXN1ZWQgYnkgdW5kZWNsYXJlZCB2YXJp YWJsZSBtX3NvdXBSZXF1ZXN0TWFuYWdlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNzU1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBidWlsZCBicmVhayBzaW5jZSB0aGVyZSBpcyBjb21waWxh dGlvbiBlcnJvciBjYXVzZWQgYnkgdW5kZWNsYXJlZCB2YXJpYWJsZSBtX3NvdXBSZXF1ZXN0TWFu YWdlcgorICAgICAgICBmb3IgdGhlIHdlYmtpdCBlZmwgZGVidWcgYnVpbGQuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvZWZsL1JlcXVlc3RNYW5hZ2VyQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6UmVxdWVzdE1hbmFnZXJDbGllbnRFZmw6OlJlcXVlc3RNYW5hZ2VyQ2xpZW50RWZsKToK KwogMjAxNC0xMC0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gVXNlIHRoZSBQYWdlTG9hZFN0YXRlIG9ic2VydmVyIGFsc28gdG8g bW9uaXRvciB0aXRsZSBhbmQgZXN0aW1hdGVkIGxvYWQgcHJvZ3Jlc3MKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUmVxdWVzdE1hbmFnZXJDbGllbnRFZmwuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9SZXF1ZXN0TWFuYWdlckNsaWVudEVmbC5jcHAK aW5kZXggODM5YjVmNC4uNTkwYTYzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2VmbC9SZXF1ZXN0TWFuYWdlckNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9SZXF1ZXN0TWFuYWdlckNsaWVudEVmbC5jcHAKQEAgLTM5LDcgKzM5LDYg QEAgc3RhdGljIGlubGluZSBSZXF1ZXN0TWFuYWdlckNsaWVudEVmbCogdG9SZXF1ZXN0TWFuYWdl ckNsaWVudEVmbChjb25zdCB2b2lkKiBjbGkKIFJlcXVlc3RNYW5hZ2VyQ2xpZW50RWZsOjpSZXF1 ZXN0TWFuYWdlckNsaWVudEVmbChXS0NvbnRleHRSZWYgY29udGV4dCkKIHsKICAgICBtX3JlcXVl c3RNYW5hZ2VyID0gdG9BUEkodG9JbXBsKGNvbnRleHQpLT5zdXBwbGVtZW50PFdlYlNvdXBDdXN0 b21Qcm90b2NvbFJlcXVlc3RNYW5hZ2VyPigpKTsKLSAgICBBU1NFUlQobV9zb3VwUmVxdWVzdE1h bmFnZXIpOwogCiAgICAgV0tTb3VwQ3VzdG9tUHJvdG9jb2xSZXF1ZXN0TWFuYWdlckNsaWVudFYw IHdrUmVxdWVzdE1hbmFnZXJDbGllbnQ7CiAgICAgbWVtc2V0KCZ3a1JlcXVlc3RNYW5hZ2VyQ2xp ZW50LCAwLCBzaXplb2YoV0tTb3VwQ3VzdG9tUHJvdG9jb2xSZXF1ZXN0TWFuYWdlckNsaWVudFYw KSk7Cg==