137551 2014-10-09 00:16:08 -0700 [iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData 2014-10-09 11:16:25 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes ap ddkilzer oldest_to_newest 1040503 0 aestes 2014-10-09 00:16:08 -0700 [iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData 1040504 1 239522 aestes 2014-10-09 00:19:18 -0700 Created attachment 239522 Patch 1040505 2 aestes 2014-10-09 00:19:49 -0700 rdar://problem/17316756 1040514 3 239522 ddkilzer 2014-10-09 02:43:13 -0700 Comment on attachment 239522 Patch r=me 1040608 4 ap 2014-10-09 10:56:02 -0700 Do we have steps to reproduce? Does this happen with all servers that don't support resuming? 1040611 5 aestes 2014-10-09 11:08:21 -0700 (In reply to comment #4) > Do we have steps to reproduce? No, this is a speculative fix based on looking at crash reports. > Does this happen with all servers that don't support resuming? I don't know how to answer that question. I know that CFURLDownloadCopyResumeData() can return null and that we should handle it (this patch aligns our behavior with that of the Mac; e.g. passing a 0-length DataReference to DownloadProxy::didFail). 1040615 6 aestes 2014-10-09 11:16:25 -0700 Committed r174512: <http://trac.webkit.org/changeset/174512> 239522 2014-10-09 00:19:18 -0700 2014-10-09 02:43:12 -0700 Patch bug-137551-20141009001920.patch text/plain 1805 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODE2NDc0ZWI2NzQ4OGY2 ZGVjNDQ1ZTVmZjlkYTYwYTg1NDJjYTQ4OC4uMDVkNDRhMTI2OWJiMWQ5ZGY4NzgwNDBlYzViZWRj NDIyOTU2ZTRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEwLTA5ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDcmFzaCBpbiBDRlVS TERvd25sb2FkQ2xpZW50LmRpZEZhaWwgaWYgdGhlIGRvd25sb2FkIGhhcyBhIG51bGwgcmVzdW1l RGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3 NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ0ZE YXRhR2V0Qnl0ZVB0cigpIGFuZCBDRkRhdGFHZXRMZW5ndGgoKSBjcmFzaCBpZiBwYXNzZWQgYSBu dWxsIHZhbHVlLgorCisgICAgICAgICogU2hhcmVkL0Rvd25sb2Fkcy9pb3MvRG93bmxvYWRJT1Mu bW06CisgICAgICAgIChXZWJLaXQ6OnNldFVwRG93bmxvYWRDbGllbnQpOgorCiAyMDE0LTEwLTA4 ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VG TF1bQ29vcmRpbmF0ZWRHcmFwaGljc10gQWxsIEVGTCBsYXlvdXQgdGVzdHMgYXJlIGJyb2tlbiBz aW5jZSByMTc0MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRz L2lvcy9Eb3dubG9hZElPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvaW9z L0Rvd25sb2FkSU9TLm1tCmluZGV4IDg4ZTA0YTA0Y2NmYjUyMzJiZWVmMGVkMmRiMDhmMDc2ZDE3 MDBiMzUuLmY0ZmY2MmZjYThhMzA2MzRlYzM2ZTJhMmU3Y2I1NzIwNTc5NWJlZjQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvaW9zL0Rvd25sb2FkSU9TLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvaW9zL0Rvd25sb2FkSU9TLm1tCkBA IC0xMTcsNyArMTE3LDcgQEAgc3RhdGljIHZvaWQgc2V0VXBEb3dubG9hZENsaWVudChDRlVSTERv d25sb2FkQ2xpZW50JiBjbGllbnQsIERvd25sb2FkJiBkb3dubG9hZCkKICAgICBjbGllbnQuZGlk RmFpbCA9IFtdKENGVVJMRG93bmxvYWRSZWYgZG93bmxvYWRSZWYsIENGRXJyb3JSZWYgZXJyb3Is IGNvbnN0IHZvaWQqIGNsaWVudEluZm8pIHsKICAgICAgICAgZGlzcGF0Y2hPbk1haW5UaHJlYWQo XnsKICAgICAgICAgICAgIGF1dG8gcmVzdW1lRGF0YSA9IGFkb3B0Q0YoQ0ZVUkxEb3dubG9hZENv cHlSZXN1bWVEYXRhKGRvd25sb2FkUmVmKSk7Ci0gICAgICAgICAgICB0b0Rvd25sb2FkKGNsaWVu dEluZm8pLT5kaWRGYWlsKGVycm9yLCBJUEM6OkRhdGFSZWZlcmVuY2UoQ0ZEYXRhR2V0Qnl0ZVB0 cihyZXN1bWVEYXRhLmdldCgpKSwgQ0ZEYXRhR2V0TGVuZ3RoKHJlc3VtZURhdGEuZ2V0KCkpKSk7 CisgICAgICAgICAgICB0b0Rvd25sb2FkKGNsaWVudEluZm8pLT5kaWRGYWlsKGVycm9yLCBJUEM6 OkRhdGFSZWZlcmVuY2UocmVzdW1lRGF0YSA/IENGRGF0YUdldEJ5dGVQdHIocmVzdW1lRGF0YS5n ZXQoKSkgOiBudWxscHRyLCByZXN1bWVEYXRhID8gQ0ZEYXRhR2V0TGVuZ3RoKHJlc3VtZURhdGEu Z2V0KCkpIDogMCkpOwogICAgICAgICB9KTsKICAgICB9OwogfQo=