137546 2014-10-08 20:18:11 -0700 Add Babak to contributors.json and add historical email addresses for some contributors 2016-11-02 14:54:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa ap benjamin bshafiei burg commit-queue glenn kling mhahnenb ryuan.choi oldest_to_newest 1040463 0 rniwa 2014-10-08 20:18:11 -0700 contributors.json is used to analyze historical commit data and commit logs. Add back historical email addresses for some contributors and also add Babak (Shafiei). 1040464 1 239511 rniwa 2014-10-08 20:21:36 -0700 Created attachment 239511 Patch 1040466 2 commit-queue 2014-10-08 20:25:28 -0700 Attachment 239511 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1040467 3 239511 cdumez 2014-10-08 20:28:05 -0700 Comment on attachment 239511 Patch r=me 1040484 4 ap 2014-10-08 22:19:27 -0700 > contributors.json is used to analyze historical commit data and commit logs. And here am I hoping to remove all inactive contributors from this file, to make Bugzilla autocomplete work better... 1040547 5 rniwa 2014-10-09 08:11:07 -0700 (In reply to comment #4) > > contributors.json is used to analyze historical commit data and commit logs. > > And here am I hoping to remove all inactive contributors from this file, to make Bugzilla autocomplete work better... We can add some flag to indicate they're inactive instead. 1040609 6 ap 2014-10-09 10:59:53 -0700 Is analyzing historical data important enough to clutter this file? It seems like maintaining history is secondary to keeping the project going, so whoever is interested in that should just maintain their own, outside of webkit.org. We actively delete old unused code, so why keep old unused e-mails? 1040629 7 rniwa 2014-10-09 12:13:51 -0700 (In reply to comment #6) > Is analyzing historical data important enough to clutter this file? It seems like maintaining history is secondary to keeping the project going, so whoever is interested in that should just maintain their own, outside of webkit.org. We actively delete old unused code, so why keep old unused e-mails? Yes, it's important. Contributors.json is like a file based database, it's not intended to be read by humans directly. For that, we have team.html and a command tool like webkit-patch find-users or webkitbot's whois command. 1040632 8 rniwa 2014-10-09 12:25:08 -0700 Let me put this way. If a new contributor comes to #webkit and asks webkitbot who ojan is because he saw his name on a change log, then webkitbot should still be able to tell who that is even though Ojan will be considered as an inactive reviewer per recent discussion. I agree we should hide inactive contributors to commit queue, watch list, Bugzilla auto completion, etc... but that doesn't require us to remove inactive contributors or emails from contributors.json. 1040672 9 ap 2014-10-09 13:36:00 -0700 I don't think that I agree with that, using webkitbot to find a user seems like such a rare occurrence that maybe we should just remove the functionality outright, not optimize for it. Keeping old affiliations and inactive e-mails also seems more harmful than useful, just like keeping stale ifdefed-out code. But it's not a huge deal either way. 1040675 10 burg 2014-10-09 13:42:08 -0700 (In reply to comment #8) > Let me put this way. If a new contributor comes to #webkit and asks webkitbot who ojan is because he saw his name on a change log, then webkitbot should still be able to tell who that is even though Ojan will be considered as an inactive reviewer per recent discussion. How will they know to ask webkitbot? Why would they ask webkitbot if Ojan's email is in the ChangeLog? I don't think using contributors.json is a good basis for analyzing historical commit data. There are many contributors inside Apple and outside who are not in that file. A serious software repository mining tool will have to deal with other issues anyway, such as contributors.json names not matching up with the name stored by git config. I am not convinced that keeping old entries in TOT will help much since repository mining will have to piece together metadata from old commits anyway. 1040725 11 rniwa 2014-10-09 16:16:27 -0700 Committed r174538: <http://trac.webkit.org/changeset/174538> 239511 2014-10-08 20:21:36 -0700 2016-11-02 14:54:15 -0700 Patch bug-137546-20141008202122.patch text/plain 2202 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NDQ5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE0LTEwLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEFkZCBCYWJhayB0byBjb250cmlidXRvcnMuanNvbiBhbmQgYWRkIGhpc3Rvcmlj YWwgZW1haWwgYWRkcmVzc2VzIGZvciBzb21lIGNvbnRyaWJ1dG9ycworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NTQ2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY29udHJpYnV0b3JzLmpzb24gaXMgdXNl ZCB0byBhbmFseXplIGhpc3RvcmljYWwgY29tbWl0IGRhdGEgYW5kIGNoYW5nZSBsb2dzLgorCisg ICAgICAgIEFkZCBiYWNrIGhpc3RvcmljYWwgZW1haWwgYWRkcmVzc2VzIGZvciBzb21lIGNvbnRy aWJ1dG9ycyBhbmQgYWxzbyBhZGQgQmFiYWsgKFNoYWZpZWkpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uOgorCiAyMDE0LTEwLTA4 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIFJl c29sdmUgdmFyaW91cyBzdGF0aWMgYW5hbHl6ZXIgd2FybmluZ3MgaW4gVG9vbHMuCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb24KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1 dG9ycy5qc29uCShyZXZpc2lvbiAxNzQ0OTQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTMyNSw2ICsz MjUsMTEgQEAKICAgICAgICAgICAgICJhbmlsc3NvbiIKICAgICAgICAgIF0KICAgICAgIH0sCisg ICAgICAiQmFiYWsgU2hhZmllaSI6IHsKKyAgICAgICAgICAiZW1haWxzIiA6IFsKKyAgICAgICAg ICAgICJic2hhZmllaUBhcHBsZS5jb20iCisgICAgICAgICAgXQorICAgICAgfSwKICAgICAgICJC YWxhenMgS2VsZW1lbiIgOiB7CiAgICAgICAgICAiZW1haWxzIiA6IFsKICAgICAgICAgICAgICJr YmFsYXpzQHdlYmtpdC5vcmciLApAQCAtMjMxMSw3ICsyMzE2LDggQEAKICAgICAgICAgICJlbWFp bHMiIDogWwogICAgICAgICAgICAgInJ5dWFuLmNob2lAZ21haWwuY29tIiwKICAgICAgICAgICAg ICJyeXVhbi5jaG9pQG5hdmVyY29ycC5jb20iLAotICAgICAgICAgICAgInJ5dWFuLmNob2lAd2Vi a2l0Lm9yZyIKKyAgICAgICAgICAgICJyeXVhbi5jaG9pQHdlYmtpdC5vcmciLAorICAgICAgICAg ICAgInJ5dWFuLmNob2lAc2Ftc3VuZy5jb20iCiAgICAgICAgICBdLAogICAgICAgICAgImV4cGVy dGlzZSIgOiAiVGhlIEVGTFdlYktpdCBQb3J0IiwKICAgICAgICAgICJuaWNrcyIgOiBbCkBAIC0z NjQyLDcgKzM2NDgsOCBAQAogICAgICAgfSwKICAgICAgICJCcmlhbiBCdXJnIiA6IHsKICAgICAg ICAgICJlbWFpbHMiIDogWwotICAgICAgICAgICAgImJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHUiCisg ICAgICAgICAgICAiYnVyZ0Bjcy53YXNoaW5ndG9uLmVkdSIsCisgICAgICAgICAgICAiYmJ1cmdA YXBwbGUuY29tIgogICAgICAgICAgXSwKICAgICAgICAgICJleHBlcnRpc2UiIDogIkRldmVsb3Bl ciBUb29scywgV2ViIEluc3BlY3RvciIsCiAgICAgICAgICAibmlja3MiIDogWwpAQCAtNDI5Myw3 ICs0MzAwLDggQEAKICAgICAgIH0sCiAgICAgICAiTWFyayBIYWhuZW5iZXJnIiA6IHsKICAgICAg ICAgICJlbWFpbHMiIDogWwotICAgICAgICAgICAgIm1oYWhuZW5iQGdtYWlsLmNvbSIKKyAgICAg ICAgICAgICJtaGFobmVuYkBnbWFpbC5jb20iLAorICAgICAgICAgICAgIm1oYWhuZW5iZXJnQGFw cGxlLmNvbSIKICAgICAgICAgIF0sCiAgICAgICAgICAiZXhwZXJ0aXNlIiA6ICJKYXZhU2NyaXB0 L0VDTUFTY3JpcHQiLAogICAgICAgICAgIm5pY2tzIiA6IFsK