137522 2014-10-08 07:32:08 -0700 [EFL] REGRESSION(r173929): It broke the Web Inspector 2014-10-17 03:51:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 135120 1 ossy gyuyoung.kim andersca commit-queue gyuyoung.kim ossy timothy oldest_to_newest 1040285 0 ossy 2014-10-08 07:32:08 -0700 After http://trac.webkit.org/changeset/173929 web inspector doesn't work at all in MiniBrowser of EFL. how to reproduce: - start MiniBrowser google.com - right click on anything - click on inspect element - nothing happens 1041130 1 gyuyoung.kim 2014-10-11 07:47:01 -0700 It looks there are two problems on that. One is the "Inspector Element" of context menu doesn't call inspector root function. The other is inspector window isn't shown even when "ctrl + i" shortcut is pressed. Two problems should be fixed. 1041233 2 239711 gyuyoung.kim 2014-10-12 22:26:09 -0700 Created attachment 239711 WIP 1041234 3 gyuyoung.kim 2014-10-12 22:28:34 -0700 I think EFL port needs to implement platformAttach(), platformDetach() and so on in WebInspectorProxyEfl.cpp because r173929 made the WebInspector run on separate web process. 1041241 4 239714 gyuyoung.kim 2014-10-13 00:54:20 -0700 Created attachment 239714 WIP 1041248 5 ossy 2014-10-13 01:37:40 -0700 just a note: I assume the bug137340 ( DFG-JIT / GC bug ) makes EFL inspector crash too. But you can test the inspector with disabling DFG JIT with JSC_useDFGJIT=0 environment variable. 1041817 6 239856 gyuyoung.kim 2014-10-15 01:13:23 -0700 Created attachment 239856 Patch 1042068 7 gyuyoung.kim 2014-10-15 22:09:49 -0700 Ossy, I think EFL inspector should support docking functionality for inspector window. It looks it may need to spend time for implementing it. So, I wonder whether we can show inspector on new window as before. 1042331 8 239856 ossy 2014-10-17 02:09:16 -0700 Comment on attachment 239856 Patch LGTM, r=me. This workaround is reasonable until we can add supporting docking. 1042359 9 239856 commit-queue 2014-10-17 03:51:13 -0700 Comment on attachment 239856 Patch Clearing flags on attachment: 239856 Committed r174820: <http://trac.webkit.org/changeset/174820> 1042360 10 commit-queue 2014-10-17 03:51:17 -0700 All reviewed patches have been landed. Closing bug. 239711 2014-10-12 22:26:09 -0700 2014-10-13 00:54:14 -0700 WIP bug-137522-20141013142612.patch text/plain 1303 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmFiZjI4MWNhZjljMDYz ZWExOWVlNGM2YzFkMjg5YmUxMjBjZGJjYy4uOGM2ZjZiMWU4YzgwZGVjOTgwMTA4ZDA1MTQzN2Ey Y2RhNWJiYjE1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEwLTEyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUkVH UkVTU0lPTihyMTczOTI5KTogSXQgYnJva2UgdGhlIFdlYiBJbnNwZWN0b3IgCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc1MjIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvV2Vi SW5zcGVjdG9yUHJveHlFZmwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94 eTo6cGxhdGZvcm1BdHRhY2gpOgorCiAyMDE0LTEwLTEyICBTZXJnaW8gVmlsbGFyIFNlbmluICA8 c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBbV0syXSBXZWJQcm9jZXNzIGFu ZCBOZXR3b3JrUHJvY2VzcyBpbml0aWFsaXphdGlvbiBjbGVhcnMgY2FjaGUgY29udGVudHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlF ZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94eUVm bC5jcHAKaW5kZXggNzc1ZTE2MDE2MWUzOWViYTE0NDAyMDg3ZGM4N2YyNzcyMzNhMGY3Ny4uNzQ1 NzFkYWIzZTQ0NGZjYjdlMTI3ZWY3ZTdmYzg2ZjcyYWY0ZTg3MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94eUVmbC5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94eUVmbC5jcHAKQEAgLTIw NCw3ICsyMDQsNyBAQCB1bnNpZ25lZCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1JbnNwZWN0 ZWRXaW5kb3dXaWR0aCgpCiAKIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQXR0YWNo KCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGNyZWF0ZUluc3BlY3RvcldpbmRvdygp OwogfQogCiB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybURldGFjaCgpCg== 239714 2014-10-13 00:54:20 -0700 2014-10-15 01:13:16 -0700 WIP bug-137522-20141013165423.patch text/plain 2171 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmFiZjI4MWNhZjljMDYz ZWExOWVlNGM2YzFkMjg5YmUxMjBjZGJjYy4uNWY0MGQxMzJjZDU0NzE4YjQ1ZTEzYjE3ZmViYjI0 ZTJmYTNlMTUwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEwLTEzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUkVH UkVTU0lPTihyMTczOTI5KTogSXQgYnJva2UgdGhlIFdlYiBJbnNwZWN0b3IKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzUyMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2VmbC9XZWJJ bnNwZWN0b3JQcm94eUVmbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5 OjpwbGF0Zm9ybUluc3BlY3RlZFdpbmRvd0hlaWdodCk6CisgICAgICAgIChXZWJLaXQ6OldlYklu c3BlY3RvclByb3h5OjpwbGF0Zm9ybUluc3BlY3RlZFdpbmRvd1dpZHRoKToKKyAgICAgICAgKFdl YktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQXR0YWNoKToKKyAgICAgICAgKFdlYktp dDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGV0YWNoKToKKwogMjAxNC0xMC0xMiAgU2Vy Z2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09VUF0g W1dLMl0gV2ViUHJvY2VzcyBhbmQgTmV0d29ya1Byb2Nlc3MgaW5pdGlhbGl6YXRpb24gY2xlYXJz IGNhY2hlIGNvbnRlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZs L1dlYkluc3BlY3RvclByb3h5RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwv V2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwCmluZGV4IDc3NWUxNjAxNjFlMzllYmExNDQwMjA4N2Rj ODdmMjc3MjMzYTBmNzcuLjI5ZDgwYTFlNjJiZmQxZTMyNjRjN2RhN2M3YWQ4OTQ1YjAzODUzMTgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJv eHlFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9y UHJveHlFZmwuY3BwCkBAIC0xOTIsMjQgKzE5MiwzNiBAQCBTdHJpbmcgV2ViSW5zcGVjdG9yUHJv eHk6Omluc3BlY3RvckJhc2VVUkwoKSBjb25zdAogCiB1bnNpZ25lZCBXZWJJbnNwZWN0b3JQcm94 eTo6cGxhdGZvcm1JbnNwZWN0ZWRXaW5kb3dIZWlnaHQoKQogewotICAgIG5vdEltcGxlbWVudGVk KCk7Ci0gICAgcmV0dXJuIDA7CisgICAgaW50IHdpZHRoOworICAgIGludCBoZWlnaHQ7CisgICAg ZWNvcmVfZXZhc19nZW9tZXRyeV9nZXQobV9pbnNwZWN0b3JXaW5kb3csIDAsIDAsICZ3aWR0aCwg JmhlaWdodCk7CisKKyAgICByZXR1cm4gaGVpZ2h0OwogfQogCiB1bnNpZ25lZCBXZWJJbnNwZWN0 b3JQcm94eTo6cGxhdGZvcm1JbnNwZWN0ZWRXaW5kb3dXaWR0aCgpCiB7Ci0gICAgbm90SW1wbGVt ZW50ZWQoKTsKLSAgICByZXR1cm4gMDsKKyAgICBpbnQgd2lkdGg7CisgICAgaW50IGhlaWdodDsK KyAgICBlY29yZV9ldmFzX2dlb21ldHJ5X2dldChtX2luc3BlY3RvcldpbmRvdywgMCwgMCwgJndp ZHRoLCAmaGVpZ2h0KTsKKworICAgIHJldHVybiB3aWR0aDsKIH0KIAogdm9pZCBXZWJJbnNwZWN0 b3JQcm94eTo6cGxhdGZvcm1BdHRhY2goKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAg Y3JlYXRlSW5zcGVjdG9yV2luZG93KCk7CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBs YXRmb3JtRGV0YWNoKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmICghbV9wYWdl LT5pc1ZhbGlkKCkpCisgICAgICAgIHJldHVybjsKKworICAgIGlmICghbV9pc1Zpc2libGUpCisg ICAgICAgIHJldHVybjsKKworICAgIGNyZWF0ZUluc3BlY3RvcldpbmRvdygpOwogfQogCiB2b2lk IFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybVNldEF0dGFjaGVkV2luZG93SGVpZ2h0KHVuc2ln bmVkKQo= 239856 2014-10-15 01:13:23 -0700 2014-10-17 03:51:13 -0700 Patch bug-137522-20141015171326.patch text/plain 1807 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTRjYjhkZTNjMGM0NjY5 NTU5OGJjN2Y1MjQ3MmI2ODk4MjlmZDdlOC4uYWE3ODU0ZGNhZjQxMDYzMTY3NDNjYWViMTdjNTVh ZmU0OWRmZDViNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEwLTE1ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUkVH UkVTU0lPTihyMTczOTI5KTogSXQgYnJva2UgdGhlIFdlYiBJbnNwZWN0b3IKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzUyMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIxNzM5MjkgbGV0IHdlYiBpbnNw ZWN0b3IgdXNlIGEgc2VwYXJhdGUgd2ViIHByb2Nlc3MuIEJlc2lkZXMgaXQgY2hhbmdlZCB0aGF0 IHRoZSBpbnNwZWN0b3IgaXMgc2hvd24KKyAgICAgICAgYXMgZG9ja2luZyBtb2RlIGJ5IGRlZmF1 bHQuIEhvd2V2ZXIgRUZMIHBvcnQgZG9lc24ndCBzdXBwb3J0IHRvIHNob3cgd2ViIGluc3BlY3Rv ciBhcyBkb2NraW5nIHdpbmRvdyB5ZXQuCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgdG8gc2hvdyB3 ZWIgaW5zcGVjdG9yIG9uIEVGTCBuZXcgd2luZG93IGFzIGJlZm9yZS4gRG9ja2luZyBtb2RlIHNo b3VsZCBiZSBpbXBsZW1lbnRlZCBieQorICAgICAgICB1cGNvbWluZyBwYXRjaC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1BdHRhY2gpOgorCiAyMDE0LTEwLTE0ICBK b29uZ2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbV0syXVtF RkxdIEZpeCB0aGUgcHJvYmxlbSB0aGF0IHRocmVhZHMgY3JlYXRlZCBieSBhIERpc3BhdGNoUXVl dWVFZmwgYXJlIG5vdCBkZXN0cm95ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94eUVmbC5jcHAKaW5kZXggNzc1ZTE2MDE2MWUzOWViYTE0 NDAyMDg3ZGM4N2YyNzcyMzNhMGY3Ny4uM2UyZGExMWU1OWIxZTAzOGFiMjQxN2RiZmJiYjQ3N2Nl OTI3ZDY2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJbnNw ZWN0b3JQcm94eUVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJ bnNwZWN0b3JQcm94eUVmbC5jcHAKQEAgLTIwNCw3ICsyMDQsOCBAQCB1bnNpZ25lZCBXZWJJbnNw ZWN0b3JQcm94eTo6cGxhdGZvcm1JbnNwZWN0ZWRXaW5kb3dXaWR0aCgpCiAKIHZvaWQgV2ViSW5z cGVjdG9yUHJveHk6OnBsYXRmb3JtQXR0YWNoKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwor ICAgIC8vIEZJWE1FOiBFRkwgcG9ydCBkb2Vzbid0IHN1cHBvcnQgdG8gYXR0YWNoIGluc3BlY3Rv ciB2aWV3IHRvIGJyb3dzZXIgd2luZG93IHlldC4gRm9yIG5vdyBuZXcgaW5zcGVjdG9yIHdpbmRv dyBpcyBzaG93biBpbnN0ZWFkLgorICAgIGNyZWF0ZUluc3BlY3RvcldpbmRvdygpOwogfQogCiB2 b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybURldGFjaCgpCg==