137519 2014-10-08 04:40:24 -0700 [webkitpy] Add back the workaround to replace ZipFile.extractall() 2014-10-08 06:19:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evab.u-szeged evab.u-szeged commit-queue ossy oldest_to_newest 1040264 0 evab.u-szeged 2014-10-08 04:40:24 -0700 It was removed by <http://trac.webkit.org/changeset/174266>, because the comment stated it is a workaround for buggy python 2.6.1 which shipped on Snow Leopard. But it turned out the bug is still valid with python 2.7 shipped on the latest Ubuntu (12.04 and 14.04) and OS X 10.9. 1040266 1 239468 evab.u-szeged 2014-10-08 04:46:03 -0700 Created attachment 239468 Patch 1040269 2 239468 ossy 2014-10-08 05:41:21 -0700 Comment on attachment 239468 Patch LGTM, r=me 1040272 3 239468 commit-queue 2014-10-08 06:19:33 -0700 Comment on attachment 239468 Patch Clearing flags on attachment: 239468 Committed r174448: <http://trac.webkit.org/changeset/174448> 1040273 4 commit-queue 2014-10-08 06:19:37 -0700 All reviewed patches have been landed. Closing bug. 239468 2014-10-08 04:46:03 -0700 2014-10-08 06:19:32 -0700 Patch bug-137519-20141008134604.patch text/plain 3160 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NDIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDJmNTU2Y2MxZWM2ZWMwNjVhZjVkNzI2ZDgzNGRjZDM5 MTMxYjYzOC4uMDA2MjRhMmRjMDJjNGRjOTY1MmUwOGRlYTJkMmQxNjgzNzk4MGYzMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE0LTEwLTA4ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW3dlYmtpdHB5XSBBZGQgYmFjayB0aGUgd29ya2Fyb3Vu ZCB0byByZXBsYWNlIFppcEZpbGUuZXh0cmFjdGFsbCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc1MTkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCB3YXMgcmVtb3ZlZCBieSA8aHR0cDovL3RyYWMu d2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTc0MjY2PiwKKyAgICAgICAgYmVjYXVzZSB0aGUgY29tbWVu dCBzdGF0ZWQgaXQgaXMgYSB3b3JrYXJvdW5kIGZvciBidWdneSBweXRob24KKyAgICAgICAgMi42 LjEgd2hpY2ggc2hpcHBlZCBvbiBTbm93IExlb3BhcmQuIEJ1dCBpdCB0dXJuZWQgb3V0IHRoZSBi dWcKKyAgICAgICAgaXMgc3RpbGwgdmFsaWQgd2l0aCBweXRob24gMi43IHNoaXBwZWQgb24gdGhl IGxhdGVzdCBVYnVudHUKKyAgICAgICAgKDEyLjA0IGFuZCAxNC4wNCkgYW5kIE9TIFggMTAuOS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5w eToKKyAgICAgICAgKEF1dG9JbnN0YWxsZXIpOgorICAgICAgICAoQXV0b0luc3RhbGxlci5fZXh0 cmFjdF9hbGwpOgorICAgICAgICAoQXV0b0luc3RhbGxlci5fdW56aXApOgorCiAyMDE0LTEwLTA4 ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMTc0MzM1LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vc3lzdGVtL2F1dG9pbnN0YWxsLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL2F1dG9pbnN0YWxsLnB5CmluZGV4IDAzMWEzZTE1OTM0MzRlOWU4 NjcyMTE3ZWQ4MGNiNWY5OTA1MjFhZmYuLmUxMjdkZDRjYjA3MmI4MjFjZTY2MDkwNzEwNzU3NTdj NTFmMDM3ZTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl bS9hdXRvaW5zdGFsbC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0 ZW0vYXV0b2luc3RhbGwucHkKQEAgLTIxOCw2ICsyMTgsMzQgQEAgY2xhc3MgQXV0b0luc3RhbGxl cihvYmplY3QpOgogCiAgICAgICAgIHJldHVybiB0YXJnZXRfcGF0aAogCisgICAgIyBUaGlzIGlz IGEgcmVwbGFjZW1lbnQgZm9yIFppcEZpbGUuZXh0cmFjdGFsbCgpLCB3aGljaCBkb2Vzbid0Cisg ICAgIyBzZWVtIHRvIHdvcmsgd2l0aCBhbnkgc2hpcHBlZCBweXRob24gMi43LnggdmVyc2lvbnMu CisgICAgIyBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc1 MTk+IGZvciBkZXRhaWxzLgorICAgIGRlZiBfZXh0cmFjdF9hbGwoc2VsZiwgemlwX2ZpbGUsIHRh cmdldF9kaXIpOgorICAgICAgICBmb3IgbmFtZSBpbiB6aXBfZmlsZS5uYW1lbGlzdCgpOgorICAg ICAgICAgICAgcGF0aCA9IG9zLnBhdGguam9pbih0YXJnZXRfZGlyLCBuYW1lKQorICAgICAgICAg ICAgaWYgbm90IG9zLnBhdGguYmFzZW5hbWUocGF0aCk6CisgICAgICAgICAgICAgICAgIyBUaGVu IHRoZSBwYXRoIGVuZHMgaW4gYSBzbGFzaCwgc28gaXQgaXMgYSBkaXJlY3RvcnkuCisgICAgICAg ICAgICAgICAgb3MubWFrZWRpcnMocGF0aCkKKyAgICAgICAgICAgICAgICBjb250aW51ZQorCisg ICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgIyBXZSBvcGVuIHRoaXMgZmlsZSB3L28g ZW5jb2RpbmcsIGFzIHdlJ3JlIHJlYWRpbmcvd3JpdGluZworICAgICAgICAgICAgICAgICMgdGhl IHJhdyBieXRlLXN0cmVhbSBmcm9tIHRoZSB6aXAgZmlsZS4KKyAgICAgICAgICAgICAgICBvdXRm aWxlID0gb3BlbihwYXRoLCAnd2InKQorICAgICAgICAgICAgZXhjZXB0IElPRXJyb3I6CisgICAg ICAgICAgICAgICAgIyBOb3QgYWxsIHppcCBmaWxlcyBzZWVtIHRvIGxpc3QgdGhlIGRpcmVjdG9y aWVzIGV4cGxpY2l0bHksCisgICAgICAgICAgICAgICAgIyBzbyB0cnkgYWdhaW4gYWZ0ZXIgY3Jl YXRpbmcgdGhlIGNvbnRhaW5pbmcgZGlyZWN0b3J5LgorICAgICAgICAgICAgICAgIF9sb2cuZGVi dWcoIkdvdCBJT0Vycm9yOiByZXRyeWluZyBhZnRlciBjcmVhdGluZyBkaXJlY3RvcnkuLi4iKQor ICAgICAgICAgICAgICAgIGRpcm5hbWUgPSBvcy5wYXRoLmRpcm5hbWUocGF0aCkKKyAgICAgICAg ICAgICAgICBvcy5tYWtlZGlycyhkaXJuYW1lKQorICAgICAgICAgICAgICAgIG91dGZpbGUgPSBv cGVuKHBhdGgsICd3YicpCisKKyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICBvdXRm aWxlLndyaXRlKHppcF9maWxlLnJlYWQobmFtZSkpCisgICAgICAgICAgICBmaW5hbGx5OgorICAg ICAgICAgICAgICAgIG91dGZpbGUuY2xvc2UoKQorCiAgICAgZGVmIF91bnppcChzZWxmLCBwYXRo LCBzY3JhdGNoX2Rpcik6CiAgICAgICAgICMgemlwZmlsZS5leHRyYWN0YWxsKCkgZXh0cmFjdHMg dG8gYSBwYXRoIHdpdGhvdXQgdGhlIHRyYWlsaW5nICIuemlwIi4KICAgICAgICAgdGFyZ2V0X2Jh c2VuYW1lID0gb3MucGF0aC5iYXNlbmFtZShwYXRoWzotbGVuKCIuemlwIildKQpAQCAtMjMyLDcg KzI2MCw3IEBAIGNsYXNzIEF1dG9JbnN0YWxsZXIob2JqZWN0KToKICAgICAgICAgICAgIHJhaXNl IEV4Y2VwdGlvbihtZXNzYWdlKQogCiAgICAgICAgIHRyeToKLSAgICAgICAgICAgIHppcF9maWxl LmV4dHJhY3RhbGwoemlwX2ZpbGUsIHNjcmF0Y2hfZGlyKQorICAgICAgICAgICAgc2VsZi5fZXh0 cmFjdF9hbGwoemlwX2ZpbGUsIHNjcmF0Y2hfZGlyKQogICAgICAgICBmaW5hbGx5OgogICAgICAg ICAgICAgemlwX2ZpbGUuY2xvc2UoKQogCg==