137500 2014-10-07 14:36:21 -0700 StyleQueue should throw a PatchIsNotValid exception to achieve consistency with CommitQueue and EWS 2014-10-08 23:50:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jake.nielsen.webkit jake.nielsen.webkit ap commit-queue glenn oldest_to_newest 1040134 0 jake.nielsen.webkit 2014-10-07 14:36:21 -0700 see https://bugs.webkit.org/show_bug.cgi?id=137460 1040138 1 239435 jake.nielsen.webkit 2014-10-07 14:52:39 -0700 Created attachment 239435 Adds the PatchIsNotValid throw to StyleQueue 1040139 2 239435 ap 2014-10-07 14:57:16 -0700 Comment on attachment 239435 Adds the PatchIsNotValid throw to StyleQueue Don't we need to also remove an existing validate() call from StyleQueue? 1040453 3 239507 jake.nielsen.webkit 2014-10-08 17:47:15 -0700 Created attachment 239507 Removes the redundant validate call from StyleQueue 1040488 4 239507 ap 2014-10-08 23:13:21 -0700 Comment on attachment 239507 Removes the redundant validate call from StyleQueue View in context: https://bugs.webkit.org/attachment.cgi?id=239507&action=review > Tools/Scripts/webkitpy/tool/commands/queues.py:327 > + return False I wonder if we should stop returning values from process_work_item; the caller doesn't do anything meaningful with them. > Tools/Scripts/webkitpy/tool/commands/queues.py:467 > + return False And maybe ones in review_patch functions too. It's quite confusing that each subclass is responsible to all results except for _did_pass, it seems better to make them call _did_pass, too. 1040496 5 239507 commit-queue 2014-10-08 23:50:52 -0700 Comment on attachment 239507 Removes the redundant validate call from StyleQueue Clearing flags on attachment: 239507 Committed r174501: <http://trac.webkit.org/changeset/174501> 1040497 6 commit-queue 2014-10-08 23:50:54 -0700 All reviewed patches have been landed. Closing bug. 239435 2014-10-07 14:52:39 -0700 2014-10-08 17:47:15 -0700 Adds the PatchIsNotValid throw to StyleQueue 0001-StyleQueue-should-throw-a-PatchIsNotValid-exception-.patch text/plain 5552 jake.nielsen.webkit RnJvbSA4MjJjNjU5M2JiMzlhMWU4MDk4ZjljYTE5MTY5ZWIxNTYwNTdhMWQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtlIE5pZWxzZW4gPGphY29iX25pZWxzZW5AYXBwbGUuY29t PgpEYXRlOiBUdWUsIDcgT2N0IDIwMTQgMTQ6NTE6MDEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBT dHlsZVF1ZXVlIHNob3VsZCB0aHJvdyBhIFBhdGNoSXNOb3RWYWxpZCBleGNlcHRpb24gdG8KIGFj aGlldmUgY29uc2lzdGVuY3kgd2l0aCBDb21taXRRdWV1ZSBhbmQgRVdTCiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NTAwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zdHlsZXF1ZXVldGFzay5weToKQWRk cyBhIGNhbGwgdG8gdmFsaWRhdGUoKSBpbiBydW4oKS4KKFN0eWxlUXVldWVUYXNrLnJ1bik6Ciog U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weToKQWRk cyBhIHJldHVybiBGYWxzZSBpbiB0aGUgcGF0Y2ggaXMgbm90IHZhbGlkIGV4Y2VwdGlvbiBzdGF0 ZW1lbnQuCihBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbS5yZXZpZXdfcGF0Y2gpOgoqIFNjcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHk6CkFkZHMgYSByZXR1cm4gRmFsc2Ug aW4gdGhlIHBhdGNoIGlzIG5vdCB2YWxpZCBleGNlcHRpb24gc3RhdGVtZW50IGluCmNvbW1pdCBx dWV1ZSwgYW5kIGFkZHMgYW4gZXhjZXB0IHN0YXRlbWVudCB0byBjYXRjaCBQYXRjaElzTm90VmFs aWQKZXhjZXB0aW9ucyBpbiBzdHlsZSBxdWV1ZS4KKENvbW1pdFF1ZXVlLnByb2Nlc3Nfd29ya19p dGVtKToKKFN0eWxlUXVldWUucmV2aWV3X3BhdGNoKToKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAyMSArKysrKysrKysrKysrKysrKysr KysKIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc3R5bGVxdWV1ZXRhc2sucHkgICB8 ICA0ICsrKy0KIC4uLi93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5w eSAgICB8ICAxICsKIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMu cHkgICAgICB8ICA0ICsrKysKIDQgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCBhNGQ2YzY1Li43N2RiYTgyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYgQEAKIDIwMTQtMTAtMDcgIEpha2UgTmll bHNlbiAgPGphY29iX25pZWxzZW5AYXBwbGUuY29tPgogCisgICAgICAgIFN0eWxlUXVldWUgc2hv dWxkIHRocm93IGEgUGF0Y2hJc05vdFZhbGlkIGV4Y2VwdGlvbiB0byBhY2hpZXZlCisgICAgICAg IGNvbnNpc3RlbmN5IHdpdGggQ29tbWl0UXVldWUgYW5kIEVXUworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NTAwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90 L3N0eWxlcXVldWV0YXNrLnB5OgorICAgICAgICBBZGRzIGEgY2FsbCB0byB2YWxpZGF0ZSgpIGlu IHJ1bigpLgorICAgICAgICAoU3R5bGVRdWV1ZVRhc2sucnVuKToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5OgorICAgICAgICBB ZGRzIGEgcmV0dXJuIEZhbHNlIGluIHRoZSBwYXRjaCBpcyBub3QgdmFsaWQgZXhjZXB0aW9uIHN0 YXRlbWVudC4KKyAgICAgICAgKEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtLnJldmlld19wYXRj aCk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weToK KyAgICAgICAgQWRkcyBhIHJldHVybiBGYWxzZSBpbiB0aGUgcGF0Y2ggaXMgbm90IHZhbGlkIGV4 Y2VwdGlvbiBzdGF0ZW1lbnQgaW4KKyAgICAgICAgY29tbWl0IHF1ZXVlLCBhbmQgYWRkcyBhbiBl eGNlcHQgc3RhdGVtZW50IHRvIGNhdGNoIFBhdGNoSXNOb3RWYWxpZAorICAgICAgICBleGNlcHRp b25zIGluIHN0eWxlIHF1ZXVlLgorICAgICAgICAoQ29tbWl0UXVldWUucHJvY2Vzc193b3JrX2l0 ZW0pOgorICAgICAgICAoU3R5bGVRdWV1ZS5yZXZpZXdfcGF0Y2gpOgorCisyMDE0LTEwLTA3ICBK YWtlIE5pZWxzZW4gIDxqYWNvYl9uaWVsc2VuQGFwcGxlLmNvbT4KKwogICAgICAgICBDb21taXQg cXVldWUgZG9lc24ndCBkcm9wIG9ic29sZXRlIHBhdGNoZXMgc29tZXRpbWVzCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0NjAKIApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zdHlsZXF1ZXVldGFzay5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc3R5bGVxdWV1ZXRhc2sucHkKaW5kZXggMDFm N2Y3Mi4uODc2Mjk4YiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Jv dC9zdHlsZXF1ZXVldGFzay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90 L3N0eWxlcXVldWV0YXNrLnB5CkBAIC0yNiw3ICsyNiw3IEBACiAjIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBP RiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNV Q0ggREFNQUdFLgogCi1mcm9tIHdlYmtpdHB5LnRvb2wuYm90LnBhdGNoYW5hbHlzaXN0YXNrIGlt cG9ydCBQYXRjaEFuYWx5c2lzVGFzaywgUGF0Y2hBbmFseXNpc1Rhc2tEZWxlZ2F0ZSwgVW5hYmxl VG9BcHBseVBhdGNoCitmcm9tIHdlYmtpdHB5LnRvb2wuYm90LnBhdGNoYW5hbHlzaXN0YXNrIGlt cG9ydCBQYXRjaEFuYWx5c2lzVGFzaywgUGF0Y2hBbmFseXNpc1Rhc2tEZWxlZ2F0ZSwgVW5hYmxl VG9BcHBseVBhdGNoLCBQYXRjaElzTm90VmFsaWQKIAogCiBjbGFzcyBTdHlsZVF1ZXVlVGFza0Rl bGVnYXRlKFBhdGNoQW5hbHlzaXNUYXNrRGVsZWdhdGUpOgpAQCAtNjMsNiArNjMsOCBAQCBjbGFz cyBTdHlsZVF1ZXVlVGFzayhQYXRjaEFuYWx5c2lzVGFzayk6CiAgICAgICAgICJVbmFibGVkIHRv IGFwcGx5IHdhdGNobGlzdCIpCiAKICAgICBkZWYgcnVuKHNlbGYpOgorICAgICAgICBpZiBub3Qg c2VsZi52YWxpZGF0ZSgpOgorICAgICAgICAgICAgcmFpc2UgUGF0Y2hJc05vdFZhbGlkKHNlbGYu X3BhdGNoKQogICAgICAgICBpZiBub3Qgc2VsZi5fY2xlYW4oKToKICAgICAgICAgICAgIHJldHVy biBGYWxzZQogICAgICAgICBpZiBub3Qgc2VsZi5fdXBkYXRlKCk6CmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5w eQppbmRleCA0NGZmNDM4Li4xNWY2N2YyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkKQEAgLTkxLDYg KzkxLDcgQEAgY2xhc3MgQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0oQWJzdHJhY3RSZXZpZXdR dWV1ZSwgRWFybHlXYXJuaW5nU3lzdGVtVGFza0RlbGUKICAgICAgICAgICAgIHJldHVybiBzdWNj ZWVkZWQKICAgICAgICAgZXhjZXB0IFBhdGNoSXNOb3RWYWxpZDoKICAgICAgICAgICAgIHNlbGYu X2RpZF9lcnJvcihwYXRjaCwgIiVzIGRpZCBub3QgcHJvY2VzcyBwYXRjaC4iICUgc2VsZi5uYW1l KQorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIGV4Y2VwdCBVbmFibGVUb0FwcGx5 UGF0Y2gsIGU6CiAgICAgICAgICAgICBzZWxmLl9kaWRfZXJyb3IocGF0Y2gsICIlcyB1bmFibGUg dG8gYXBwbHkgcGF0Y2guIiAlIHNlbGYubmFtZSkKICAgICAgICAgICAgIHJldHVybiBGYWxzZQpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKaW5kZXgg ZDM0ZTkxYy4uODA5YTcyMCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3F1ZXVlcy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvcXVldWVzLnB5CkBAIC0zMjQsNiArMzI0LDcgQEAgY2xhc3MgQ29tbWl0UXVldWUoUGF0 Y2hQcm9jZXNzaW5nUXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlciwgQ29tbWl0UXVldWVU YXMKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICBleGNlcHQgUGF0Y2hJc05vdFZh bGlkOgogICAgICAgICAgICAgc2VsZi5fZGlkX2Vycm9yKHBhdGNoLCAiJXMgZGlkIG5vdCBwcm9j ZXNzIHBhdGNoLiIgJSBzZWxmLm5hbWUpCisgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAg ICAgZXhjZXB0IFNjcmlwdEVycm9yLCBlOgogICAgICAgICAgICAgdmFsaWRhdG9yID0gQ29tbWl0 dGVyVmFsaWRhdG9yKHNlbGYuX3Rvb2wpCiAgICAgICAgICAgICB2YWxpZGF0b3IucmVqZWN0X3Bh dGNoX2Zyb21fY29tbWl0X3F1ZXVlKHBhdGNoLmlkKCksIHNlbGYuX2Vycm9yX21lc3NhZ2VfZm9y X2J1Zyh0YXNrLCBwYXRjaCwgZSkpCkBAIC00NjQsNiArNDY1LDkgQEAgY2xhc3MgU3R5bGVRdWV1 ZShBYnN0cmFjdFJldmlld1F1ZXVlLCBTdHlsZVF1ZXVlVGFza0RlbGVnYXRlKToKICAgICAgICAg ZXhjZXB0IFVuYWJsZVRvQXBwbHlQYXRjaCwgZToKICAgICAgICAgICAgIHNlbGYuX2RpZF9lcnJv cihwYXRjaCwgIiVzIHVuYWJsZSB0byBhcHBseSBwYXRjaC4iICUgc2VsZi5uYW1lKQogICAgICAg ICAgICAgcmV0dXJuIEZhbHNlCisgICAgICAgIGV4Y2VwdCBQYXRjaElzTm90VmFsaWQ6CisgICAg ICAgICAgICBzZWxmLl9kaWRfZXJyb3IocGF0Y2gsICIlcyBkaWQgbm90IHByb2Nlc3MgcGF0Y2gu IiAlIHNlbGYubmFtZSkKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICBleGNlcHQg U2NyaXB0RXJyb3IsIGU6CiAgICAgICAgICAgICBvdXRwdXQgPSByZS5zdWIocidGYWlsZWQgdG8g cnVuIC4rIGV4aXRfY29kZTogMScsICcnLCBlLm91dHB1dCkKICAgICAgICAgICAgIG1lc3NhZ2Ug PSAiQXR0YWNobWVudCAlcyBkaWQgbm90IHBhc3MgJXM6XG5cbiVzXG5cbklmIGFueSBvZiB0aGVz ZSBlcnJvcnMgYXJlIGZhbHNlIHBvc2l0aXZlcywgcGxlYXNlIGZpbGUgYSBidWcgYWdhaW5zdCBj aGVjay13ZWJraXQtc3R5bGUuIiAlIChwYXRjaC5pZCgpLCBzZWxmLm5hbWUsIG91dHB1dCkKLS0g CjEuOS4zIChBcHBsZSBHaXQtNTApCgo= 239507 2014-10-08 17:47:15 -0700 2014-10-08 23:50:51 -0700 Removes the redundant validate call from StyleQueue 0001-StyleQueue-should-throw-a-PatchIsNotValid-exception-.patch text/plain 5962 jake.nielsen.webkit RnJvbSBjZTI4MTgyMTM0NzI1Nzc0YjFhMDQzZTFiNGZjYTAxNzkxMDAzMGRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtlIE5pZWxzZW4gPGphY29iX25pZWxzZW5AYXBwbGUuY29t PgpEYXRlOiBXZWQsIDggT2N0IDIwMTQgMTc6NDU6NTggLTA3MDAKU3ViamVjdDogW1BBVENIXSBT dHlsZVF1ZXVlIHNob3VsZCB0aHJvdyBhIFBhdGNoSXNOb3RWYWxpZCBleGNlcHRpb24gdG8KIGFj aGlldmUgY29uc2lzdGVuY3kgd2l0aCBDb21taXRRdWV1ZSBhbmQgRVdTCiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NTAwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zdHlsZXF1ZXVldGFzay5weToKQWRk cyBhIGNhbGwgdG8gdmFsaWRhdGUoKSBpbiBydW4oKS4KKFN0eWxlUXVldWVUYXNrLnJ1bik6Ciog U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weToKQWRk cyBhIHJldHVybiBGYWxzZSBpbiB0aGUgcGF0Y2ggaXMgbm90IHZhbGlkIGV4Y2VwdGlvbiBzdGF0 ZW1lbnQuCihBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbS5yZXZpZXdfcGF0Y2gpOgoqIFNjcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHk6CkFkZHMgYSByZXR1cm4gRmFsc2Ug aW4gdGhlIHBhdGNoIGlzIG5vdCB2YWxpZCBleGNlcHRpb24gc3RhdGVtZW50IGluCmNvbW1pdCBx dWV1ZSwgYW5kIGFkZHMgYW4gZXhjZXB0IHN0YXRlbWVudCB0byBjYXRjaCBQYXRjaElzTm90VmFs aWQKZXhjZXB0aW9ucyBpbiBzdHlsZSBxdWV1ZS4KKENvbW1pdFF1ZXVlLnByb2Nlc3Nfd29ya19p dGVtKToKKFN0eWxlUXVldWUucmV2aWV3X3BhdGNoKToKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAyMSArKysrKysrKysrKysrKysrKysr KysKIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc3R5bGVxdWV1ZXRhc2sucHkgICB8 ICA0ICsrKy0KIC4uLi93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5w eSAgICB8ICAxICsKIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMu cHkgICAgICB8ICA3ICsrKystLS0KIDQgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu Z2VMb2cKaW5kZXggYTRkNmM2NS4uNzdkYmE4MiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTEwLTA3ICBKYWtl IE5pZWxzZW4gIDxqYWNvYl9uaWVsc2VuQGFwcGxlLmNvbT4KIAorICAgICAgICBTdHlsZVF1ZXVl IHNob3VsZCB0aHJvdyBhIFBhdGNoSXNOb3RWYWxpZCBleGNlcHRpb24gdG8gYWNoaWV2ZQorICAg ICAgICBjb25zaXN0ZW5jeSB3aXRoIENvbW1pdFF1ZXVlIGFuZCBFV1MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzUwMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s L2JvdC9zdHlsZXF1ZXVldGFzay5weToKKyAgICAgICAgQWRkcyBhIGNhbGwgdG8gdmFsaWRhdGUo KSBpbiBydW4oKS4KKyAgICAgICAgKFN0eWxlUXVldWVUYXNrLnJ1bik6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weToKKyAgICAg ICAgQWRkcyBhIHJldHVybiBGYWxzZSBpbiB0aGUgcGF0Y2ggaXMgbm90IHZhbGlkIGV4Y2VwdGlv biBzdGF0ZW1lbnQuCisgICAgICAgIChBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbS5yZXZpZXdf cGF0Y2gpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMu cHk6CisgICAgICAgIEFkZHMgYSByZXR1cm4gRmFsc2UgaW4gdGhlIHBhdGNoIGlzIG5vdCB2YWxp ZCBleGNlcHRpb24gc3RhdGVtZW50IGluCisgICAgICAgIGNvbW1pdCBxdWV1ZSwgYW5kIGFkZHMg YW4gZXhjZXB0IHN0YXRlbWVudCB0byBjYXRjaCBQYXRjaElzTm90VmFsaWQKKyAgICAgICAgZXhj ZXB0aW9ucyBpbiBzdHlsZSBxdWV1ZS4KKyAgICAgICAgKENvbW1pdFF1ZXVlLnByb2Nlc3Nfd29y a19pdGVtKToKKyAgICAgICAgKFN0eWxlUXVldWUucmV2aWV3X3BhdGNoKToKKworMjAxNC0xMC0w NyAgSmFrZSBOaWVsc2VuICA8amFjb2JfbmllbHNlbkBhcHBsZS5jb20+CisKICAgICAgICAgQ29t bWl0IHF1ZXVlIGRvZXNuJ3QgZHJvcCBvYnNvbGV0ZSBwYXRjaGVzIHNvbWV0aW1lcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NDYwCiAKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc3R5bGVxdWV1ZXRhc2sucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3N0eWxlcXVldWV0YXNrLnB5CmluZGV4 IDAxZjdmNzIuLjg3NjI5OGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9ib3Qvc3R5bGVxdWV1ZXRhc2sucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2JvdC9zdHlsZXF1ZXVldGFzay5weQpAQCAtMjYsNyArMjYsNyBAQAogIyAoSU5DTFVESU5HIE5F R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK ICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP RiBTVUNIIERBTUFHRS4KIAotZnJvbSB3ZWJraXRweS50b29sLmJvdC5wYXRjaGFuYWx5c2lzdGFz ayBpbXBvcnQgUGF0Y2hBbmFseXNpc1Rhc2ssIFBhdGNoQW5hbHlzaXNUYXNrRGVsZWdhdGUsIFVu YWJsZVRvQXBwbHlQYXRjaAorZnJvbSB3ZWJraXRweS50b29sLmJvdC5wYXRjaGFuYWx5c2lzdGFz ayBpbXBvcnQgUGF0Y2hBbmFseXNpc1Rhc2ssIFBhdGNoQW5hbHlzaXNUYXNrRGVsZWdhdGUsIFVu YWJsZVRvQXBwbHlQYXRjaCwgUGF0Y2hJc05vdFZhbGlkCiAKIAogY2xhc3MgU3R5bGVRdWV1ZVRh c2tEZWxlZ2F0ZShQYXRjaEFuYWx5c2lzVGFza0RlbGVnYXRlKToKQEAgLTYzLDYgKzYzLDggQEAg Y2xhc3MgU3R5bGVRdWV1ZVRhc2soUGF0Y2hBbmFseXNpc1Rhc2spOgogICAgICAgICAiVW5hYmxl ZCB0byBhcHBseSB3YXRjaGxpc3QiKQogCiAgICAgZGVmIHJ1bihzZWxmKToKKyAgICAgICAgaWYg bm90IHNlbGYudmFsaWRhdGUoKToKKyAgICAgICAgICAgIHJhaXNlIFBhdGNoSXNOb3RWYWxpZChz ZWxmLl9wYXRjaCkKICAgICAgICAgaWYgbm90IHNlbGYuX2NsZWFuKCk6CiAgICAgICAgICAgICBy ZXR1cm4gRmFsc2UKICAgICAgICAgaWYgbm90IHNlbGYuX3VwZGF0ZSgpOgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0 ZW0ucHkKaW5kZXggNDRmZjQzOC4uMTVmNjdmMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CkBAIC05 MSw2ICs5MSw3IEBAIGNsYXNzIEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKEFic3RyYWN0UmV2 aWV3UXVldWUsIEVhcmx5V2FybmluZ1N5c3RlbVRhc2tEZWxlCiAgICAgICAgICAgICByZXR1cm4g c3VjY2VlZGVkCiAgICAgICAgIGV4Y2VwdCBQYXRjaElzTm90VmFsaWQ6CiAgICAgICAgICAgICBz ZWxmLl9kaWRfZXJyb3IocGF0Y2gsICIlcyBkaWQgbm90IHByb2Nlc3MgcGF0Y2guIiAlIHNlbGYu bmFtZSkKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICBleGNlcHQgVW5hYmxlVG9B cHBseVBhdGNoLCBlOgogICAgICAgICAgICAgc2VsZi5fZGlkX2Vycm9yKHBhdGNoLCAiJXMgdW5h YmxlIHRvIGFwcGx5IHBhdGNoLiIgJSBzZWxmLm5hbWUpCiAgICAgICAgICAgICByZXR1cm4gRmFs c2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1 ZXMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5Cmlu ZGV4IGQzNGU5MWMuLmUyM2YyMzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3F1ZXVlcy5weQpAQCAtMzI0LDYgKzMyNCw3IEBAIGNsYXNzIENvbW1pdFF1ZXVl KFBhdGNoUHJvY2Vzc2luZ1F1ZXVlLCBTdGVwU2VxdWVuY2VFcnJvckhhbmRsZXIsIENvbW1pdFF1 ZXVlVGFzCiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgZXhjZXB0IFBhdGNoSXNO b3RWYWxpZDoKICAgICAgICAgICAgIHNlbGYuX2RpZF9lcnJvcihwYXRjaCwgIiVzIGRpZCBub3Qg cHJvY2VzcyBwYXRjaC4iICUgc2VsZi5uYW1lKQorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAg ICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgIHZhbGlkYXRvciA9IENv bW1pdHRlclZhbGlkYXRvcihzZWxmLl90b29sKQogICAgICAgICAgICAgdmFsaWRhdG9yLnJlamVj dF9wYXRjaF9mcm9tX2NvbW1pdF9xdWV1ZShwYXRjaC5pZCgpLCBzZWxmLl9lcnJvcl9tZXNzYWdl X2Zvcl9idWcodGFzaywgcGF0Y2gsIGUpKQpAQCAtNDUyLDkgKzQ1Myw2IEBAIGNsYXNzIFN0eWxl UXVldWUoQWJzdHJhY3RSZXZpZXdRdWV1ZSwgU3R5bGVRdWV1ZVRhc2tEZWxlZ2F0ZSk6CiAKICAg ICBkZWYgcmV2aWV3X3BhdGNoKHNlbGYsIHBhdGNoKToKICAgICAgICAgdGFzayA9IFN0eWxlUXVl dWVUYXNrKHNlbGYsIHBhdGNoKQotICAgICAgICBpZiBub3QgdGFzay52YWxpZGF0ZSgpOgotICAg ICAgICAgICAgc2VsZi5fZGlkX2Vycm9yKHBhdGNoLCAiJXMgZGlkIG5vdCBwcm9jZXNzIHBhdGNo LiIgJSBzZWxmLm5hbWUpCi0gICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgdHJ5Ogog ICAgICAgICAgICAgc3R5bGVfY2hlY2tfc3VjY2VlZGVkID0gdGFzay5ydW4oKQogICAgICAgICAg ICAgaWYgbm90IHN0eWxlX2NoZWNrX3N1Y2NlZWRlZDoKQEAgLTQ2NCw2ICs0NjIsOSBAQCBjbGFz cyBTdHlsZVF1ZXVlKEFic3RyYWN0UmV2aWV3UXVldWUsIFN0eWxlUXVldWVUYXNrRGVsZWdhdGUp OgogICAgICAgICBleGNlcHQgVW5hYmxlVG9BcHBseVBhdGNoLCBlOgogICAgICAgICAgICAgc2Vs Zi5fZGlkX2Vycm9yKHBhdGNoLCAiJXMgdW5hYmxlIHRvIGFwcGx5IHBhdGNoLiIgJSBzZWxmLm5h bWUpCiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAgZXhjZXB0IFBhdGNoSXNOb3RW YWxpZDoKKyAgICAgICAgICAgIHNlbGYuX2RpZF9lcnJvcihwYXRjaCwgIiVzIGRpZCBub3QgcHJv Y2VzcyBwYXRjaC4iICUgc2VsZi5uYW1lKQorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAg ICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgIG91dHB1dCA9IHJlLnN1Yihy J0ZhaWxlZCB0byBydW4gLisgZXhpdF9jb2RlOiAxJywgJycsIGUub3V0cHV0KQogICAgICAgICAg ICAgbWVzc2FnZSA9ICJBdHRhY2htZW50ICVzIGRpZCBub3QgcGFzcyAlczpcblxuJXNcblxuSWYg YW55IG9mIHRoZXNlIGVycm9ycyBhcmUgZmFsc2UgcG9zaXRpdmVzLCBwbGVhc2UgZmlsZSBhIGJ1 ZyBhZ2FpbnN0IGNoZWNrLXdlYmtpdC1zdHlsZS4iICUgKHBhdGNoLmlkKCksIHNlbGYubmFtZSwg b3V0cHV0KQotLSAKMS45LjMgKEFwcGxlIEdpdC01MCkKCg==