137499 2014-10-07 13:39:29 -0700 [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds 2014-10-07 14:35:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates aestes commit-queue ddkilzer dfarler glenn simon.fraser oldest_to_newest 1040121 0 dbates 2014-10-07 13:39:29 -0700 Currently run-webkit-tests only honors the TestExpectation file for 32-bit iOS Simulator builds of iOS WebKit. We should teach it to honor TestExpectation for 64-bit iOS Simulator builds of iOS WebKit. Once we honor the TestExpectation file for 64-bit builds we can look to rebaseline the iOS Simulator layout test results. 1040122 1 239431 dbates 2014-10-07 13:40:54 -0700 Created attachment 239431 Patch 1040126 2 dbates 2014-10-07 13:51:56 -0700 I didn't write a unit test for this change since the code in class IOSSimulatorPort represents port-specific configuration settings, which is subject to change (maybe it will not change often and hence it would be good to write a test?). Let me know if it's preferred to add a unit test for such a change. 1040132 3 239431 commit-queue 2014-10-07 14:35:14 -0700 Comment on attachment 239431 Patch Clearing flags on attachment: 239431 Committed r174406: <http://trac.webkit.org/changeset/174406> 1040133 4 commit-queue 2014-10-07 14:35:18 -0700 All reviewed patches have been landed. Closing bug. 239431 2014-10-07 13:40:54 -0700 2014-10-07 14:35:14 -0700 Patch bug-137499-20141007134054.patch text/plain 3484 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0Mjc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWFiMTAyNzUxZDkxNzM0NjU5YmRiNjNmYmJmODA2ZTdj ODFhOTAzNi4uNGRkMmQwMzc0MDNjMGQwYjYwZWE5M2ZhYTIzYjI0NTE3YzQ5YWZlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTEwLTA3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBUZWFjaCBydW4td2Via2l0LXRlc3RzIHRvIGhvbm9yIFRlc3RFeHBlY3RhdGlv biBmaWxlIGZvciBpT1MgU2ltdWxhdG9yIDY0LWJpdCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzQ5OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGFuIGlzc3VlIHdoZXJlIHRoZSBU ZXN0RXhwZWN0YXRpb24gZmlsZSBmb3IgdGhlIGlPUyBTaW11bGF0b3IgcGxhdGZvcm0gd2FzIG9u bHkKKyAgICAgICAgaG9ub3JlZCB3aGVuIHJ1bm5pbmcgcnVuLXdlYmtpdC10ZXN0cyB3aXRoIGEg MzItYml0IHNpbXVsYXRvciBidWlsZCBvZiBpT1MgV2ViS2l0LiBXZQorICAgICAgICBzaG91bGQg aG9ub3IgdGhlIFRlc3RFeHBlY3RhdGlvbiBmaWxlIGZvciB0aGUgaU9TIFNpbXVsYXRvciBwbGF0 Zm9ybSBmb3IgYm90aCAzMi0gYW5kIDY0LQorICAgICAgICBiaXQgc2ltdWxhdG9yIGJ1aWxkcyBv ZiBpT1MgV2ViS2l0LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToK KyAgICAgICAgKElPU1NpbXVsYXRvclBvcnQuX2dlbmVyYXRlX2FsbF90ZXN0X2NvbmZpZ3VyYXRp b25zKToKKwogMjAxNC0xMC0wMyAgQWtvcyBLaXNzICA8YWtpc3NAaW5mLnUtc3plZ2VkLmh1Pgog CiAgICAgICAgIFtHVEtdIEJ1bXAgdXAgYW5kIHBhdGNoIGRlcGVuZGVuY2llcyB0byBhbGxvdyBi dWlsZGluZyBmb3IgYWFyY2g2NApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L2lvcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKaW5kZXggMzcy ZmVhNjg3MTJmNmE5ZjNjMjAwNWM2YzQ1MTczYjg0ZjU5MTIxZS4uOWNiNTBjYmNjMzVmNzBhZDBk MmViYTliNmFkMTU4MmZjZTI3MTVhMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L2lvcy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CkBA IC0xMzQsNyArMTM0LDggQEAgY2xhc3MgSU9TU2ltdWxhdG9yUG9ydChQb3J0KToKICAgICBkZWYg X2dlbmVyYXRlX2FsbF90ZXN0X2NvbmZpZ3VyYXRpb25zKHNlbGYpOgogICAgICAgICBjb25maWd1 cmF0aW9ucyA9IFtdCiAgICAgICAgIGZvciBidWlsZF90eXBlIGluIHNlbGYuQUxMX0JVSUxEX1RZ UEVTOgotICAgICAgICAgICAgY29uZmlndXJhdGlvbnMuYXBwZW5kKFRlc3RDb25maWd1cmF0aW9u KHZlcnNpb249c2VsZi5fdmVyc2lvbiwgYXJjaGl0ZWN0dXJlPSd4ODYnLCBidWlsZF90eXBlPWJ1 aWxkX3R5cGUpKQorICAgICAgICAgICAgZm9yIGFyY2hpdGVjdHVyZSBpbiBzZWxmLkFSQ0hJVEVD VFVSRVM6CisgICAgICAgICAgICAgICAgY29uZmlndXJhdGlvbnMuYXBwZW5kKFRlc3RDb25maWd1 cmF0aW9uKHZlcnNpb249c2VsZi5fdmVyc2lvbiwgYXJjaGl0ZWN0dXJlPWFyY2hpdGVjdHVyZSwg YnVpbGRfdHlwZT1idWlsZF90eXBlKSkKICAgICAgICAgcmV0dXJuIGNvbmZpZ3VyYXRpb25zCiAK ICAgICBkZWYgX2RyaXZlcl9jbGFzcyhzZWxmKToKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNmZmOTM2NzI1ZDFjNjM3NmZh YWFkNDk3MDFkNjFkZTkyMWEzMTYxLi42MjIxYThiNTBiMWVmZTY4YmNhNWNiMTdiNDE3MDEyNzAz MzA2MGFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMTAtMDcgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFRlYWNoIHJ1bi13ZWJraXQtdGVz dHMgdG8gaG9ub3IgVGVzdEV4cGVjdGF0aW9uIGZpbGUgZm9yIGlPUyBTaW11bGF0b3IgNjQtYml0 IGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM3NDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIGEgbmV3IHBsYXRmb3JtIGRpcmVjdG9yeSwgY2FsbGVkIGlvcy1zaW11bGF0b3IsIGFuZCBh c3NvY2lhdGVkIFRlc3RFeHBlY3RhdGlvbiBmaWxlLgorICAgICAgICBGb3Igbm93LCB0aGVyZSBp cyBhIHNpbmdsZSBlbnRyeSB0byBza2lwIGFsbCBhY2Nlc3NpYmlsaXR5IHRlc3RzIG9uIGlPUyBk dWUgdG8gc2lnbmlmaWNhbnQKKyAgICAgICAgQVBJIGRpZmZlcmVuY2VzLiBXZSdsbCBsaWtlbHkg dXBkYXRlIFRlc3RFeHBlY3RhdGlvbnMgYXMgd2UgcmViYXNlbGluZSBpT1MgU2ltdWxhdG9yCisg ICAgICAgIGxheW91dCB0ZXN0IHJlc3VsdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mtc2lt dWxhdG9yL1Rlc3RFeHBlY3RhdGlvbnM6IEFkZGVkLgorCiAyMDE0LTEwLTAzIEJlYXIgVHJhdmlz IDxiZXRyYXZpc0BhZG9iZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE3MzUzMSk6IFVz ZSBhZnRlciBmcmVlIGluIFdlYkNvcmU6OlJlbmRlclN0eWxlOjpmb250TWV0cmljcyAvCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yL1Rlc3RFeHBlY3RhdGlvbnMK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOWFjNzg1ZmYwZmUwNzAwODM4YzE5YTk2YjUyMTU4YWU5MjY3OTQ2YwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3IvVGVzdEV4 cGVjdGF0aW9ucwpAQCAtMCwwICsxLDcgQEAKKyMgVGhlc2UgYXJlIHRoZSBsYXlvdXQgdGVzdCBl eHBlY3RhdGlvbnMgZm9yIEFwcGxlJ3MgaU9TIHBvcnQgb2YgV2ViS2l0LgorIworIyBTZWUgaHR0 cDovL3RyYWMud2Via2l0Lm9yZy93aWtpL1Rlc3RFeHBlY3RhdGlvbnMgZm9yIG1vcmUgaW5mb3Jt YXRpb24gb24gdGhpcyBmaWxlLgorCisjIENhbm5vdCBlbmFibGUgQVggdGVzdHMgYmVjYXVzZSB0 aGVyZSBhcmUgdG9vIG1hbnkgZGlmZmVyZW5jZXMgYmV0d2VlbiB3aGF0IGlzIGF2YWlsYWJsZQor IyB0aHJvdWdoIHRoZSBpUGhvbmUgQVggQVBJIGFuZCB0aGUgT1MgWCBBWCBBUEkuCithY2Nlc3Np YmlsaXR5Cg==