137495 2014-10-07 12:36:24 -0700 [iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse() 2016-01-30 09:25:39 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 153710 1 psolanki psolanki ap commit-queue japhet psolanki simon.fraser oldest_to_newest 1040094 0 psolanki 2014-10-07 12:36:24 -0700 In r173782, I moved the disk cache handling code from the main thread (UI thread) to the web thread when we are using WebKit1 on iOS. The code tries to access the CFCachedURLResponseRef passed in the block on the web thread. This is problematic because the object may have been released before the block gets to run on the web thread. We need to manually retain/release the response. 1040095 1 psolanki 2014-10-07 12:37:04 -0700 <rdar://problem/18495034> 1040096 2 239427 psolanki 2014-10-07 12:38:36 -0700 Created attachment 239427 Patch 1040104 3 239427 kling 2014-10-07 13:00:46 -0700 Comment on attachment 239427 Patch r=me 1040119 4 239427 commit-queue 2014-10-07 13:37:56 -0700 Comment on attachment 239427 Patch Clearing flags on attachment: 239427 Committed r174404: <http://trac.webkit.org/changeset/174404> 1040120 5 commit-queue 2014-10-07 13:38:01 -0700 All reviewed patches have been landed. Closing bug. 239427 2014-10-07 12:38:36 -0700 2014-10-07 13:37:56 -0700 Patch bug-137495-20141007123838.patch text/plain 1644 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGFlOTE1MzkwOTYxY2Fl MTZkY2UxM2JjMjRmYzcyZDNmMDNlNDRjMi4uZGQzMTFmMmU5N2YzMTA0MGZkYWJmYjdkYzdkYzE4 YWZlNGNmYWY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTA3ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBXZWJLaXQx IGNsaWVudHMgY3Jhc2ggaW4gRGlza0NhY2hlTW9uaXRvcjo6dHJ5R2V0RmlsZUJhY2tlZFNoYXJl ZEJ1ZmZlckZyb21DRlVSTENhY2hlZFJlc3BvbnNlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzQ5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTg0OTUwMzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmV0YWluL3JlbGVhc2UgdGhlIENGQ2FjaGVkVVJMUmVzcG9uc2VSZWYgb2JqZWN0IG90aGVy d2lzZSB3ZSBjb3VsZCBhY2Nlc3MgYSBkZWxldGVkIG9iamVjdAorICAgICAgICBhbmQgY3Jhc2gg b24gdGhlIHdlYiB0aHJlYWQuCisKKyAgICAgICAgKiBsb2FkZXIvY29jb2EvRGlza0NhY2hlTW9u aXRvckNvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6RGlza0NhY2hlTW9uaXRvcjo6RGlza0Nh Y2hlTW9uaXRvcik6CisKIDIwMTQtMTAtMDYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgogCiAgICAgICAgIFJFR1JFU1NJT04gKFNpbXBsZSBMaW5lIExheW91dCk6IElubGluZSBibG9j ayBiYXNlbGluZXMgY29tcHV0ZWQgaW5jb3JyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9jb2NvYS9EaXNrQ2FjaGVNb25pdG9yQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvY29jb2EvRGlza0NhY2hlTW9uaXRvckNvY29hLm1tCmluZGV4IDgyZDYxOWIzYzg3 YTM3MmJiNWYxMGJmNmFkYjY1MzE0ZDEyZmNhYWYuLjIwZWVkMWQ3OGExNTg0MGI1NDlhMzE0ODU4 MWY2ODlhODk3MDY1MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jb2NvYS9E aXNrQ2FjaGVNb25pdG9yQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NvY29h L0Rpc2tDYWNoZU1vbml0b3JDb2NvYS5tbQpAQCAtMTEwLDggKzExMCwxMCBAQCBEaXNrQ2FjaGVN b25pdG9yOjpEaXNrQ2FjaGVNb25pdG9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwg U2Vzc2lvbklEIHNlcwogI2lmIFVTRShXRUJfVEhSRUFEKQogICAgIENGQ2FjaGVkVVJMUmVzcG9u c2VDYWxsQmFja0Jsb2NrIGJsb2NrVG9SdW4gPSBeIChDRkNhY2hlZFVSTFJlc3BvbnNlUmVmIHJl c3BvbnNlKQogICAgIHsKKyAgICAgICAgQ0ZSZXRhaW4ocmVzcG9uc2UpOwogICAgICAgICBXZWJU aHJlYWRSdW4oXiB7CiAgICAgICAgICAgICBibG9jayhyZXNwb25zZSk7CisgICAgICAgICAgICBD RlJlbGVhc2UocmVzcG9uc2UpOwogICAgICAgICB9KTsKICAgICB9OwogI2Vsc2UK