137493 2014-10-07 12:13:11 -0700 REGRESSION (r173356): Downloading a disk image appends ".txt" to it 2014-10-22 13:18:53 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 137855 InRadar P2 Normal --- 1 koivisto webkit-unassigned ap oldest_to_newest 1040080 0 koivisto 2014-10-07 12:13:11 -0700 Some downloads gain incorrect .txt extension 1040081 1 koivisto 2014-10-07 12:13:31 -0700 <rdar://problem/18321947> 1040085 2 239424 koivisto 2014-10-07 12:18:17 -0700 Created attachment 239424 patch 1040089 3 239424 ap 2014-10-07 12:33:55 -0700 Comment on attachment 239424 patch View in context: https://bugs.webkit.org/attachment.cgi?id=239424&action=review > Source/WebKit2/Shared/Downloads/ios/DownloadIOS.mm:134 > + // FIXME: For some reason the filename needs to be accessed or it may be incorrect after > + // CFURLResponse is serialized/deserialized (gains .txt extension) > + response.suggestedFilename(); The fix looks OK to me, although mysterious. Antti is going to look into whether this can be tested with <iframe src="resources/image.dmg"> - we do log suggested file names in WKTR. 1040268 4 koivisto 2014-10-08 05:30:03 -0700 Looks like this can't be tested with reasonable effort. The existing test code for file names runs in policy delegates for the original response. The bug occurs afterwards, when converting the load to download and doing IPC to UI process. The bug is somehow related to the CFNetwork heuristics for figuring out a file name from URL when Content-Disposition header is not present. 1042123 5 koivisto 2014-10-16 08:27:19 -0700 http://trac.webkit.org/changeset/174763 1043534 6 koivisto 2014-10-22 13:18:53 -0700 Reverted in http://trac.webkit.org/changeset/175064. Turns out the root cause is in the MIME type sniffing. *** This bug has been marked as a duplicate of bug 137855 *** 239424 2014-10-07 12:18:17 -0700 2014-10-08 10:00:38 -0700 patch suggested-filename-txt.patch text/plain 2669 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDQwMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEwLTA3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTczMzU2 KTogRG93bmxvYWRpbmcgYSBkaXNrIGltYWdlIGFwcGVuZHMgIi50eHQiIHRvIGl0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0OTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9Eb3dubG9h ZHMvaW9zL0Rvd25sb2FkSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpEb3dubG9hZDo6c3RhcnRX aXRoSGFuZGxlKToKKyAgICAgICAgKiBTaGFyZWQvRG93bmxvYWRzL21hYy9Eb3dubG9hZE1hYy5t bToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWQ6OnN0YXJ0V2l0aEhhbmRsZSk6CisKKyAgICAg ICAgICAgIEl0IGFwcGVhcnMgdGhhdCB0aGUgc3ludGhlc2l6ZWQgTlMvQ0ZVUkxSZXNwb25zZSBm YWlscyB0byBzZXJpYWxpemUgdGhlIHN1Z2dlc3RlZCBmaWxlbmFtZSBjb3JyZWN0bHkKKyAgICAg ICAgICAgIHVubGVzcyBpdCBoYXMgYmVlbiBhY2Nlc3NlZCBmaXJzdC4KKwogMjAxNC0xMC0wNyAg Q2hyaXN0b3BoZSBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gVXNl IGlzPD4oKSAvIGRvd25jYXN0PD4oKSBmb3IgRHJhd2luZ0FyZWFQcm94eSBzdWJjbGFzc2VzCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRzL2lvcy9Eb3dubG9hZElPUy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRzL2lvcy9Eb3dubG9h ZElPUy5tbQkocmV2aXNpb24gMTc0MzQwKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25s b2Fkcy9pb3MvRG93bmxvYWRJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTEyOSw2ICsxMjksMTAg QEAgdm9pZCBEb3dubG9hZDo6c3RhcnQoKQogCiB2b2lkIERvd25sb2FkOjpzdGFydFdpdGhIYW5k bGUoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9u c2UpCiB7CisgICAgLy8gRklYTUU6IEZvciBzb21lIHJlYXNvbiB0aGUgZmlsZW5hbWUgbmVlZHMg dG8gYmUgYWNjZXNzZWQgb3IgaXQgbWF5IGJlIGluY29ycmVjdCBhZnRlcgorICAgIC8vIENGVVJM UmVzcG9uc2UgaXMgc2VyaWFsaXplZC9kZXNlcmlhbGl6ZWQgKGdhaW5zIC50eHQgZXh0ZW5zaW9u KQorICAgIHJlc3BvbnNlLnN1Z2dlc3RlZEZpbGVuYW1lKCk7CisKICAgICBDRlVSTERvd25sb2Fk Q2xpZW50IGNsaWVudDsKICAgICBzZXRVcERvd25sb2FkQ2xpZW50KGNsaWVudCwgKnRoaXMpOwog ICAgIG1fZG93bmxvYWQgPSBhZG9wdENGKENGVVJMRG93bmxvYWRDcmVhdGVBbmRTdGFydFdpdGhM b2FkaW5nQ29ubmVjdGlvbihOVUxMLCBoYW5kbGUtPnJlbGVhc2VDb25uZWN0aW9uRm9yRG93bmxv YWQoKS5nZXQoKSwgbV9yZXF1ZXN0LmNmVVJMUmVxdWVzdChVcGRhdGVIVFRQQm9keSksIHJlc3Bv bnNlLmNmVVJMUmVzcG9uc2UoKSwgJmNsaWVudCkpOwpJbmRleDogU291cmNlL1dlYktpdDIvU2hh cmVkL0Rvd25sb2Fkcy9tYWMvRG93bmxvYWRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9tYWMvRG93bmxvYWRNYWMubW0JKHJldmlzaW9uIDE3NDM0 MCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvbWFjL0Rvd25sb2FkTWFjLm1t CSh3b3JraW5nIGNvcHkpCkBAIC03Myw2ICs3MywxMCBAQCB2b2lkIERvd25sb2FkOjpzdGFydFdp dGhIYW5kbGUoUmVzb3VyY2VICiAgICAgQVNTRVJUKCFtX25zVVJMRG93bmxvYWQpOwogICAgIEFT U0VSVCghbV9kZWxlZ2F0ZSk7CiAKKyAgICAvLyBGSVhNRTogRm9yIHNvbWUgcmVhc29uIHRoZSBm aWxlbmFtZSBuZWVkcyB0byBiZSBhY2Nlc3NlZCBvciBpdCBtYXkgYmUgaW5jb3JyZWN0IGFmdGVy CisgICAgLy8gTlNVUkxSZXNwb25zZSBpcyBzZXJpYWxpemVkL2Rlc2VyaWFsaXplZCAoZ2FpbnMg LnR4dCBleHRlbnNpb24pCisgICAgcmVzcG9uc2Uuc3VnZ2VzdGVkRmlsZW5hbWUoKTsKKwogICAg IG1fZGVsZWdhdGUgPSBhZG9wdE5TKFtbV0tEb3dubG9hZEFzRGVsZWdhdGUgYWxsb2NdIGluaXRX aXRoRG93bmxvYWQ6dGhpc10pOwogICAgIG1fbnNVUkxEb3dubG9hZCA9IFtOU1VSTERvd25sb2Fk IF9kb3dubG9hZFdpdGhMb2FkaW5nQ29ubmVjdGlvbjpoYW5kbGUtPmNvbm5lY3Rpb24oKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmVxdWVzdDptX3JlcXVlc3QubnNVUkxSZXF1ZXN0KFVwZGF0ZUhUVFBCb2R5KQo=