137489 2014-10-07 09:59:39 -0700 [SOUP] [WK2] WebProcess and NetworkProcess initialization clears cache contents 2014-10-12 02:32:16 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar cgarcia commit-queue gustavo mrobinson pnormand oldest_to_newest 1040041 0 svillar 2014-10-07 09:59:39 -0700 The method NetworkProcess::platformInitializeNetworkProcess() creates the SoupCache object and performs the soup_cache_load() to load the index in memory. Loading the index has some side effects like deleting as much resources as needed to get the cache size under the max_size restriction. The problem is that unless soup_cache_set_max_size() is called before soup_cache_load(), the later will use the default cache max size (50Mb IIRC). Should you have a different max_size, it won't matter because the cache was already loaded and the resources exceeding the capacity already wiped. 1040937 1 svillar 2014-10-10 09:44:21 -0700 Actually the same happens with the WebProcess initialization. 1040942 2 239633 svillar 2014-10-10 09:56:42 -0700 Created attachment 239633 Patch 1040945 3 cgarcia 2014-10-10 10:13:31 -0700 I guess resources will never be removed then? if load() is the only one doing that 1041198 4 svillar 2014-10-12 01:56:21 -0700 (In reply to comment #3) > I guess resources will never be removed then? if load() is the only one doing that load() is not the one doing that. load() calls soup_cache_entry_insert() which is the one that makes room in the cache if there is not enough disk space to allocate the resource. soup_cache_entry_insert() is called for every single new resource. This means that old resources will be removed at any time once the cache is full. 1041199 5 239633 commit-queue 2014-10-12 02:32:12 -0700 Comment on attachment 239633 Patch Clearing flags on attachment: 239633 Committed r174639: <http://trac.webkit.org/changeset/174639> 1041200 6 commit-queue 2014-10-12 02:32:16 -0700 All reviewed patches have been landed. Closing bug. 239633 2014-10-10 09:56:42 -0700 2014-10-12 02:32:12 -0700 Patch bug-137489-20141010185644.patch text/plain 3715 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTJlMmI5NmJmNDljZjYx ZDcxMDNjNDBmM2QxZjVmYmViN2Q3YWZkZC4uM2Q2MTgwYWI3Njg0NWUxODkzMzEzZDg2MjU4NzMy ZTI3YzFiODQ3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEwLTEwICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtTT1VQXSBb V0syXSBXZWJQcm9jZXNzIGFuZCBOZXR3b3JrUHJvY2VzcyBpbml0aWFsaXphdGlvbiBjbGVhcnMg Y2FjaGUgY29udGVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNzQ4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRlbXBvcmFyaWx5IHNldCB0aGUgU291cENhY2hlJ3MgbWF4aW11bSBzaXplIHRvIGEg aHVnZSB2YWx1ZQorICAgICAgICBiZWZvcmUgY2FsbGluZyBzb3VwX2NhY2hlX2xvYWQoKSBzbyB0 aGF0IHRoZSBjYWNoZSBpcyBub3Qgc2hyaW5rZWQKKyAgICAgICAgdG8gdGhlIGRlZmF1bHQgdmFs dWUuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5j cHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVO ZXR3b3JrUHJvY2Vzcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NTb3Vw LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2Vi UHJvY2Vzcyk6CisKIDIwMTQtMTAtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVzZSB0aGUgUGFnZUxvYWRTdGF0ZSBvYnNlcnZl ciBhbHNvIHRvIG1vbml0b3IgdGl0bGUgYW5kIGVzdGltYXRlZCBsb2FkIHByb2dyZXNzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNz U291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9j ZXNzU291cC5jcHAKaW5kZXggMWJiODM1MmI0YTU1YWUxNTQ4MTNhMTJhMWNiNzExOTRkOWJhYTFk MS4uMWUyMjMwMTEzNWQxZWZiOTVkYTc5MmQ2MWI5ZGQ1NWZkYjViOGJiYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NT b3VwLmNwcApAQCAtODUsNyArODUsMTIgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1J bml0aWFsaXplTmV0d29ya1Byb2Nlc3MoY29uc3QgTmV0d29ya1Byb2Nlc3NDcmVhdGkKICAgICBB U1NFUlQoIXBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5LmlzRW1wdHkoKSk7CiAgICAgR1Jl ZlB0cjxTb3VwQ2FjaGU+IHNvdXBDYWNoZSA9IGFkb3B0R1JlZihzb3VwX2NhY2hlX25ldyhwYXJh bWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeS51dGY4KCkuZGF0YSgpLCBTT1VQX0NBQ0hFX1NJTkdM RV9VU0VSKSk7CiAgICAgU291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLnNldENh Y2hlKHNvdXBDYWNoZS5nZXQoKSk7CisgICAgLy8gU2V0IGFuIGluaXRpYWwgaHVnZSBtYXhfc2l6 ZSBmb3IgdGhlIFNvdXBDYWNoZSBzbyB0aGUgY2FsbCB0byBzb3VwX2NhY2hlX2xvYWQoKSB3b24n dCBldmljdCBhbnkgY2FjaGVkCisgICAgLy8gcmVzb3VyY2UuIFRoZSBmaW5hbCBzaXplIG9mIHRo ZSBjYWNoZSB3aWxsIGJlIHNldCBieSBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1TZXRDYWNoZU1v ZGVsKCkuCisgICAgdW5zaWduZWQgaW5pdGlhbE1heFNpemUgPSBzb3VwX2NhY2hlX2dldF9tYXhf c2l6ZShzb3VwQ2FjaGUuZ2V0KCkpOworICAgIHNvdXBfY2FjaGVfc2V0X21heF9zaXplKHNvdXBD YWNoZS5nZXQoKSwgR19NQVhVSU5UKTsKICAgICBzb3VwX2NhY2hlX2xvYWQoc291cENhY2hlLmdl dCgpKTsKKyAgICBzb3VwX2NhY2hlX3NldF9tYXhfc2l6ZShzb3VwQ2FjaGUuZ2V0KCksIGluaXRp YWxNYXhTaXplKTsKIAogICAgIGlmICghcGFyYW1ldGVycy5jb29raWVQZXJzaXN0ZW50U3RvcmFn ZVBhdGguaXNFbXB0eSgpKSB7CiAgICAgICAgIHN1cHBsZW1lbnQ8V2ViQ29va2llTWFuYWdlcj4o KS0+c2V0Q29va2llUGVyc2lzdGVudFN0b3JhZ2UocGFyYW1ldGVycy5jb29raWVQZXJzaXN0ZW50 U3RvcmFnZVBhdGgsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAv V2ViUHJvY2Vzc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9zb3VwL1dlYlBy b2Nlc3NTb3VwLmNwcAppbmRleCAwYWFhMzVjYjVhZDgyZjM3OWQ2NTYxMzk1ZmIyZTg0YjM0NTA4 MTU2Li4zNDBlNjAwNDk3NzU5MWMyMGFhMWNmOGZhYTRhNWM4NDljODZmY2M2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAKQEAgLTE1 OSw3ICsxNTksMTIgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9j ZXNzKGNvbnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMKICAgICBBU1NFUlQoIXBhcmFt ZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5LmlzRW1wdHkoKSk7CiAgICAgR1JlZlB0cjxTb3VwQ2Fj aGU+IHNvdXBDYWNoZSA9IGFkb3B0R1JlZihzb3VwX2NhY2hlX25ldyhwYXJhbWV0ZXJzLmRpc2tD YWNoZURpcmVjdG9yeS51dGY4KCkuZGF0YSgpLCBTT1VQX0NBQ0hFX1NJTkdMRV9VU0VSKSk7CiAg ICAgV2ViQ29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLnNldENhY2hl KHNvdXBDYWNoZS5nZXQoKSk7CisgICAgLy8gU2V0IGFuIGluaXRpYWwgaHVnZSBtYXhfc2l6ZSBm b3IgdGhlIFNvdXBDYWNoZSBzbyB0aGUgY2FsbCB0byBzb3VwX2NhY2hlX2xvYWQoKSB3b24ndCBl dmljdCBhbnkgY2FjaGVkCisgICAgLy8gcmVzb3VyY2UuIFRoZSBmaW5hbCBzaXplIG9mIHRoZSBj YWNoZSB3aWxsIGJlIHNldCBieSBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1TZXRDYWNoZU1vZGVs KCkuCisgICAgdW5zaWduZWQgaW5pdGlhbE1heFNpemUgPSBzb3VwX2NhY2hlX2dldF9tYXhfc2l6 ZShzb3VwQ2FjaGUuZ2V0KCkpOworICAgIHNvdXBfY2FjaGVfc2V0X21heF9zaXplKHNvdXBDYWNo ZS5nZXQoKSwgR19NQVhVSU5UKTsKICAgICBzb3VwX2NhY2hlX2xvYWQoc291cENhY2hlLmdldCgp KTsKKyAgICBzb3VwX2NhY2hlX3NldF9tYXhfc2l6ZShzb3VwQ2FjaGUuZ2V0KCksIGluaXRpYWxN YXhTaXplKTsKIAogICAgIGlmICghcGFyYW1ldGVycy5jb29raWVQZXJzaXN0ZW50U3RvcmFnZVBh dGguaXNFbXB0eSgpKSB7CiAgICAgICAgIHN1cHBsZW1lbnQ8V2ViQ29va2llTWFuYWdlcj4oKS0+ c2V0Q29va2llUGVyc2lzdGVudFN0b3JhZ2UocGFyYW1ldGVycy5jb29raWVQZXJzaXN0ZW50U3Rv cmFnZVBhdGgsCg==