137486 2014-10-07 06:26:14 -0700 [GTK] Minibrowser : Add home buton and keyboard support for home page load 2014-10-14 03:49:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned commit-queue gustavo mrobinson pnormand oldest_to_newest 1040008 0 kumar.rohit 2014-10-07 06:26:14 -0700 Currently no keyboard support or home button exists for home page load in GTK Minibrowser. Add home button and keyboard support for home page load using 'Alt' + 'Home' keys. 1040011 1 239409 kumar.rohit 2014-10-07 06:33:34 -0700 Created attachment 239409 Patch 1041504 2 239409 pnormand 2014-10-14 01:51:36 -0700 Comment on attachment 239409 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239409&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:551 > + webkit_web_view_load_uri(window->webView, "http://www.webkitgtk.org/"); I think this URL is hardcoded somewhere else already, right? Would be good to make it a #define 1041514 3 239790 kumar.rohit 2014-10-14 02:43:37 -0700 Created attachment 239790 Patch 1041516 4 239790 commit-queue 2014-10-14 02:49:06 -0700 Comment on attachment 239790 Patch Rejecting attachment 239790 from commit-queue. kumar.rohit@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1041522 5 239790 commit-queue 2014-10-14 03:49:10 -0700 Comment on attachment 239790 Patch Clearing flags on attachment: 239790 Committed r174679: <http://trac.webkit.org/changeset/174679> 1041523 6 commit-queue 2014-10-14 03:49:13 -0700 All reviewed patches have been landed. Closing bug. 239409 2014-10-07 06:33:34 -0700 2014-10-14 02:43:14 -0700 Patch bug-137486-20141007190447.patch text/plain 2739 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0Mzg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTE0NjcwMmQxMzE4Y2NlYWM2ZTY5MTc0Yjg0NGE1ZWQ2 M2MyZGMxNS4uYWEzN2Y1ZWRiNTVkMDY5Y2ZkZTgwMTNhODQ4ODFlYTNmMTY2M2ViMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTEwLTA3ICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHVEtdIE1pbmlicm93c2VyIDogQWRkIGhvbWUgYnV0b24gYW5kIGtleWJvYXJk IHN1cHBvcnQgZm9yIGhvbWUgcGFnZSBsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6Cisg ICAgICAgIChsb2FkSG9tZVBhZ2UpOiBDYWxsYmFjayBmb3IgaG9tZSBwYWdlIGxvYWQuCisgICAg ICAgIChicm93c2VyX3dpbmRvd19pbml0KToKKwogMjAxNC0xMC0wNiAgUnlvc3VrZSBOaXdhICA8 cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNYWtlIHdlYmtpdC1wYXRjaCBmaW5kLXVzZXJz IHVzZWZ1bApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cu YyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKaW5kZXggZDY5MjQxZWVj MDc1ZDZiNzIzMTIyMmRkNzdhMzk3ZDQ1NGVlMzNkOS4uOTk0NTJkNGQyMzRhYjdlNTdjYmZlMGU2 N2U5Y2JjMTJjMTg1MjU4YiAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dz ZXJXaW5kb3cuYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCkBA IC01NDYsNiArNTQ2LDExIEBAIHN0YXRpYyB2b2lkIHN0b3BQYWdlTG9hZChCcm93c2VyV2luZG93 ICp3aW5kb3csIGdwb2ludGVyIHVzZXJfZGF0YSkKICAgICAgICAgd2Via2l0X3dlYl92aWV3X3N0 b3BfbG9hZGluZyh3aW5kb3ctPndlYlZpZXcpOwogfQogCitzdGF0aWMgdm9pZCBsb2FkSG9tZVBh Z2UoQnJvd3NlcldpbmRvdyAqd2luZG93LCBncG9pbnRlciB1c2VyX2RhdGEpCit7CisgICAgd2Vi a2l0X3dlYl92aWV3X2xvYWRfdXJpKHdpbmRvdy0+d2ViVmlldywgImh0dHA6Ly93d3cud2Via2l0 Z3RrLm9yZy8iKTsKK30KKwogc3RhdGljIHZvaWQgYnJvd3NlcldpbmRvd0ZpbmFsaXplKEdPYmpl Y3QgKmdPYmplY3QpCiB7CiAgICAgQnJvd3NlcldpbmRvdyAqd2luZG93ID0gQlJPV1NFUl9XSU5E T1coZ09iamVjdCk7CkBAIC02MzcsNiArNjQyLDEwIEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJfd2lu ZG93X2luaXQoQnJvd3NlcldpbmRvdyAqd2luZG93KQogICAgIGd0a19hY2NlbF9ncm91cF9jb25u ZWN0KHdpbmRvdy0+YWNjZWxHcm91cCwgR0RLX0tFWV9Fc2NhcGUsIDAsIEdUS19BQ0NFTF9WSVNJ QkxFLAogICAgICAgICBnX2NjbG9zdXJlX25ld19zd2FwKEdfQ0FMTEJBQ0soc3RvcFBhZ2VMb2Fk KSwgd2luZG93LCBOVUxMKSk7CiAKKyAgICAvKiBMb2FkIGhvbWUgcGFnZSAqLyAKKyAgICBndGtf YWNjZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfSG9tZSwgR0RL X01PRDFfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUsCisgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3 YXAoR19DQUxMQkFDSyhsb2FkSG9tZVBhZ2UpLCB3aW5kb3csIE5VTEwpKTsKKwogICAgIEd0a1dp ZGdldCAqdG9vbGJhciA9IGd0a190b29sYmFyX25ldygpOwogICAgIHdpbmRvdy0+dG9vbGJhciA9 IHRvb2xiYXI7CiAgICAgZ3RrX29yaWVudGFibGVfc2V0X29yaWVudGF0aW9uKEdUS19PUklFTlRB QkxFKHRvb2xiYXIpLCBHVEtfT1JJRU5UQVRJT05fSE9SSVpPTlRBTCk7CkBAIC02NzksNiArNjg4 LDEyIEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJfd2luZG93X2luaXQoQnJvd3NlcldpbmRvdyAqd2lu ZG93KQogICAgIGd0a193aWRnZXRfYWRkX2FjY2VsZXJhdG9yKEdUS19XSURHRVQoaXRlbSksICJj bGlja2VkIiwgd2luZG93LT5hY2NlbEdyb3VwLCBHREtfS0VZX0YsIEdES19DT05UUk9MX01BU0ss IEdUS19BQ0NFTF9WSVNJQkxFKTsKICAgICBndGtfd2lkZ2V0X3Nob3coR1RLX1dJREdFVChpdGVt KSk7CiAKKyAgICBpdGVtID0gZ3RrX3Rvb2xfYnV0dG9uX25ld19mcm9tX3N0b2NrKEdUS19TVE9D S19IT01FKTsKKyAgICBnX3NpZ25hbF9jb25uZWN0X3N3YXBwZWQoaXRlbSwgImNsaWNrZWQiLCBH X0NBTExCQUNLKGxvYWRIb21lUGFnZSksIHdpbmRvdyk7CisgICAgZ3RrX3Rvb2xiYXJfaW5zZXJ0 KEdUS19UT09MQkFSKHRvb2xiYXIpLCBpdGVtLCAtMSk7CisgICAgZ3RrX3dpZGdldF9hZGRfYWNj ZWxlcmF0b3IoR1RLX1dJREdFVChpdGVtKSwgImNsaWNrZWQiLCB3aW5kb3ctPmFjY2VsR3JvdXAs IEdES19LRVlfSG9tZSwgR0RLX01PRDFfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUpOworICAgIGd0 a193aWRnZXRfc2hvdyhHVEtfV0lER0VUKGl0ZW0pKTsKKwogICAgIGl0ZW0gPSBndGtfdG9vbF9p dGVtX25ldygpOwogICAgIGd0a190b29sX2l0ZW1fc2V0X2V4cGFuZChpdGVtLCBUUlVFKTsKICAg ICBndGtfY29udGFpbmVyX2FkZChHVEtfQ09OVEFJTkVSKGl0ZW0pLCB3aW5kb3ctPnVyaUVudHJ5 KTsK 239790 2014-10-14 02:43:37 -0700 2014-10-14 03:49:10 -0700 Patch bug-137486-20141014151453.patch text/plain 4295 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjQ1ZjU5ZTlkYmM1NDE1NDk0ODg3NmQ3NGI5MTRmNGQx MmM3MWI2My4uMTAxN2MzNTllNTc0M2RkMWYzNzljZTA0ZGM2Nzg5NjI0YWE3Y2MwMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTEwLTE0ICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHVEtdIE1pbmlicm93c2VyIDogQWRkIGhvbWUgYnV0b24gYW5kIGtleWJvYXJk IHN1cHBvcnQgZm9yIGhvbWUgcGFnZSBsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6Cisg ICAgICAgIChsb2FkSG9tZVBhZ2UpOiBDYWxsYmFjayBmb3IgaG9tZSBwYWdlIGxvYWQuCisgICAg ICAgIChicm93c2VyX3dpbmRvd19pbml0KToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJv d3NlcldpbmRvdy5oOgorICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9tYWluLmM6CisgICAgICAg IChtYWluKToKKwogMjAxNC0xMC0xMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBNZWRpYVBsYXllcjo6Y2hhcmFjdGVyaXN0aWNDaGFuZ2VkKCkgaXMgbm90IGNh bGxlZCB3aGVuIG5ldyB0cmFja3MgYXJlIGZvdW5kIGluIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZP YmpDCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jIGIv VG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwppbmRleCBkNjkyNDFlZWMwNzVk NmI3MjMxMjIyZGQ3N2EzOTdkNDU0ZWUzM2Q5Li5kMDdlMTEyZjdjMTRkMWY3YTgwOWZhNmEwZTBk MDFiOWE2MjViNDA1IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3Nlcldp bmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKQEAgLTU0 Niw2ICs1NDYsMTEgQEAgc3RhdGljIHZvaWQgc3RvcFBhZ2VMb2FkKEJyb3dzZXJXaW5kb3cgKndp bmRvdywgZ3BvaW50ZXIgdXNlcl9kYXRhKQogICAgICAgICB3ZWJraXRfd2ViX3ZpZXdfc3RvcF9s b2FkaW5nKHdpbmRvdy0+d2ViVmlldyk7CiB9CiAKK3N0YXRpYyB2b2lkIGxvYWRIb21lUGFnZShC cm93c2VyV2luZG93ICp3aW5kb3csIGdwb2ludGVyIHVzZXJfZGF0YSkKK3sKKyAgICB3ZWJraXRf d2ViX3ZpZXdfbG9hZF91cmkod2luZG93LT53ZWJWaWV3LCBCUk9XU0VSX0RFRkFVTFRfVVJMKTsK K30KKwogc3RhdGljIHZvaWQgYnJvd3NlcldpbmRvd0ZpbmFsaXplKEdPYmplY3QgKmdPYmplY3Qp CiB7CiAgICAgQnJvd3NlcldpbmRvdyAqd2luZG93ID0gQlJPV1NFUl9XSU5ET1coZ09iamVjdCk7 CkBAIC02MzcsNiArNjQyLDEwIEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJfd2luZG93X2luaXQoQnJv d3NlcldpbmRvdyAqd2luZG93KQogICAgIGd0a19hY2NlbF9ncm91cF9jb25uZWN0KHdpbmRvdy0+ YWNjZWxHcm91cCwgR0RLX0tFWV9Fc2NhcGUsIDAsIEdUS19BQ0NFTF9WSVNJQkxFLAogICAgICAg ICBnX2NjbG9zdXJlX25ld19zd2FwKEdfQ0FMTEJBQ0soc3RvcFBhZ2VMb2FkKSwgd2luZG93LCBO VUxMKSk7CiAKKyAgICAvKiBMb2FkIGhvbWUgcGFnZSAqLyAKKyAgICBndGtfYWNjZWxfZ3JvdXBf Y29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfSG9tZSwgR0RLX01PRDFfTUFTSywg R1RLX0FDQ0VMX1ZJU0lCTEUsCisgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3YXAoR19DQUxMQkFD Syhsb2FkSG9tZVBhZ2UpLCB3aW5kb3csIE5VTEwpKTsKKwogICAgIEd0a1dpZGdldCAqdG9vbGJh ciA9IGd0a190b29sYmFyX25ldygpOwogICAgIHdpbmRvdy0+dG9vbGJhciA9IHRvb2xiYXI7CiAg ICAgZ3RrX29yaWVudGFibGVfc2V0X29yaWVudGF0aW9uKEdUS19PUklFTlRBQkxFKHRvb2xiYXIp LCBHVEtfT1JJRU5UQVRJT05fSE9SSVpPTlRBTCk7CkBAIC02NzksNiArNjg4LDEyIEBAIHN0YXRp YyB2b2lkIGJyb3dzZXJfd2luZG93X2luaXQoQnJvd3NlcldpbmRvdyAqd2luZG93KQogICAgIGd0 a193aWRnZXRfYWRkX2FjY2VsZXJhdG9yKEdUS19XSURHRVQoaXRlbSksICJjbGlja2VkIiwgd2lu ZG93LT5hY2NlbEdyb3VwLCBHREtfS0VZX0YsIEdES19DT05UUk9MX01BU0ssIEdUS19BQ0NFTF9W SVNJQkxFKTsKICAgICBndGtfd2lkZ2V0X3Nob3coR1RLX1dJREdFVChpdGVtKSk7CiAKKyAgICBp dGVtID0gZ3RrX3Rvb2xfYnV0dG9uX25ld19mcm9tX3N0b2NrKEdUS19TVE9DS19IT01FKTsKKyAg ICBnX3NpZ25hbF9jb25uZWN0X3N3YXBwZWQoaXRlbSwgImNsaWNrZWQiLCBHX0NBTExCQUNLKGxv YWRIb21lUGFnZSksIHdpbmRvdyk7CisgICAgZ3RrX3Rvb2xiYXJfaW5zZXJ0KEdUS19UT09MQkFS KHRvb2xiYXIpLCBpdGVtLCAtMSk7CisgICAgZ3RrX3dpZGdldF9hZGRfYWNjZWxlcmF0b3IoR1RL X1dJREdFVChpdGVtKSwgImNsaWNrZWQiLCB3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfSG9t ZSwgR0RLX01PRDFfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUpOworICAgIGd0a193aWRnZXRfc2hv dyhHVEtfV0lER0VUKGl0ZW0pKTsKKwogICAgIGl0ZW0gPSBndGtfdG9vbF9pdGVtX25ldygpOwog ICAgIGd0a190b29sX2l0ZW1fc2V0X2V4cGFuZChpdGVtLCBUUlVFKTsKICAgICBndGtfY29udGFp bmVyX2FkZChHVEtfQ09OVEFJTkVSKGl0ZW0pLCB3aW5kb3ctPnVyaUVudHJ5KTsKZGlmZiAtLWdp dCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmggYi9Ub29scy9NaW5pQnJv d3Nlci9ndGsvQnJvd3NlcldpbmRvdy5oCmluZGV4IDY2Njc1NDYyZjU3YTUxODRkMTU3OGIzMGVk MzVhMTIyOTQwMDI3ZWQuLjc5MTBiZWRlYjM0MDAyMjExOGU5NGNjNWVhMmEwMzdiNWM1NDI4OWUg MTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmgKKysrIGIv VG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuaApAQCAtMzcsNiArMzcsNyBAQCBH X0JFR0lOX0RFQ0xTCiAjZGVmaW5lIEJST1dTRVJfSVNfV0lORE9XKG9iaikgICAgICAgICAoR19U WVBFX0NIRUNLX0lOU1RBTkNFX1RZUEUoKG9iaiksIEJST1dTRVJfVFlQRV9XSU5ET1cpKQogI2Rl ZmluZSBCUk9XU0VSX0lTX1dJTkRPV19DTEFTUyhrbGFzcykgKEdfVFlQRV9DSEVDS19DTEFTU19U WVBFKChrbGFzcyksICBCUk9XU0VSX1RZUEVfV0lORE9XKSkKICNkZWZpbmUgQlJPV1NFUl9XSU5E T1dfR0VUX0NMQVNTKG9iaikgIChHX1RZUEVfSU5TVEFOQ0VfR0VUX0NMQVNTKChvYmopLCAgQlJP V1NFUl9UWVBFX1dJTkRPVywgQnJvd3NlcldpbmRvd0NsYXNzKSkKKyNkZWZpbmUgQlJPV1NFUl9E RUZBVUxUX1VSTCAgICAgICAgICAgICJodHRwOi8vd3d3LndlYmtpdGd0ay5vcmcvIgogCiB0eXBl ZGVmIHN0cnVjdCBfQnJvd3NlcldpbmRvdyAgICAgICAgQnJvd3NlcldpbmRvdzsKIHR5cGVkZWYg c3RydWN0IF9Ccm93c2VyV2luZG93Q2xhc3MgICBCcm93c2VyV2luZG93Q2xhc3M7CmRpZmYgLS1n aXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3Rr L21haW4uYwppbmRleCA5NDE4Y2E2NjE1NGNjYmRmYTA0MjI4Y2I5NTRkYzI3NzVlZWU3ZjY0Li4y YmZjMTcwMTVhOTc2M2IwMzNhZWZhNDdlNDViN2VjN2Y2NDE3ZjZmIDEwMDY0NAotLS0gYS9Ub29s cy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWlu LmMKQEAgLTI3OSw3ICsyNzksNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQog ICAgICAgICBmb3IgKGkgPSAwOyB1cmlBcmd1bWVudHNbaV07IGkrKykKICAgICAgICAgICAgIGNy ZWF0ZUJyb3dzZXJXaW5kb3codXJpQXJndW1lbnRzW2ldLCB3ZWJraXRTZXR0aW5ncyk7CiAgICAg fSBlbHNlCi0gICAgICAgIGNyZWF0ZUJyb3dzZXJXaW5kb3coImh0dHA6Ly93d3cud2Via2l0Z3Rr Lm9yZy8iLCB3ZWJraXRTZXR0aW5ncyk7CisgICAgICAgIGNyZWF0ZUJyb3dzZXJXaW5kb3coQlJP V1NFUl9ERUZBVUxUX1VSTCwgd2Via2l0U2V0dGluZ3MpOwogCiAgICAgZ19jbGVhcl9vYmplY3Qo JndlYmtpdFNldHRpbmdzKTsKIAo=