137484 2014-10-07 05:47:05 -0700 Remove build warnings in Hashmap API tests 2014-10-07 22:36:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned commit-queue oldest_to_newest 1040004 0 tanay.c 2014-10-07 05:47:05 -0700 /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:450:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingReleaseKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:472:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingMoveKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:494:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:559:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetUsingReleaseKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:580:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); 1040005 1 239407 tanay.c 2014-10-07 05:53:48 -0700 Created attachment 239407 Patch 1040214 2 239407 commit-queue 2014-10-07 22:36:32 -0700 Comment on attachment 239407 Patch Clearing flags on attachment: 239407 Committed r174418: <http://trac.webkit.org/changeset/174418> 1040215 3 commit-queue 2014-10-07 22:36:34 -0700 All reviewed patches have been landed. Closing bug. 239407 2014-10-07 05:53:48 -0700 2014-10-07 22:36:32 -0700 Patch bug-137484-20141007182421.patch text/plain 2745 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NDM5MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE0LTEwLTA3ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZW1vdmUgYnVpbGQgd2FybmluZ3MgaW4gSGFzaG1hcCBBUEkgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzQ4NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvSGFzaE1hcC5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKTog Q2hhbmdlZCBFWFBFQ1RfRVEoZmFsc2UsIGFkZFJlc3VsdC5pc05ld0VudHJ5KSB0byBFWFBFQ1Rf RkFMU0UoYWRkUmVzdWx0LmlzTmV3RW50cnkpIAorCiAyMDE0LTEwLTA2ICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2Ugd2Via2l0LXBhdGNoIGZpbmQtdXNl cnMgdXNlZnVsCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNw cAkocmV2aXNpb24gMTc0Mzg1KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvSGFz aE1hcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0Nyw3ICs0NDcsNyBAQCBURVNUKFdURl9IYXNo TWFwLCBSZWZQdHJLZXlfQWRkS2V5QWxyZWFkCiAgICAgewogICAgICAgICBSZWZQdHI8UmVmTG9n Z2VyPiBwdHIyKCZhKTsKICAgICAgICAgYXV0byBhZGRSZXN1bHQgPSBtYXAuYWRkKHB0cjIsIDAp OwotICAgICAgICBFWFBFQ1RfRVEoZmFsc2UsIGFkZFJlc3VsdC5pc05ld0VudHJ5KTsKKyAgICAg ICAgRVhQRUNUX0ZBTFNFKGFkZFJlc3VsdC5pc05ld0VudHJ5KTsKICAgICB9CiAKICAgICBFWFBF Q1RfU1RSRVEoInJlZihhKSBkZXJlZihhKSAiLCB0YWtlTG9nU3RyKCkuY19zdHIoKSk7CkBAIC00 NjksNyArNDY5LDcgQEAgVEVTVChXVEZfSGFzaE1hcCwgUmVmUHRyS2V5X0FkZFVzaW5nUmVsZQog ICAgIHsKICAgICAgICAgUmVmUHRyPFJlZkxvZ2dlcj4gcHRyMigmYSk7CiAgICAgICAgIGF1dG8g YWRkUmVzdWx0ID0gbWFwLmFkZChwdHIyLnJlbGVhc2UoKSwgMCk7Ci0gICAgICAgIEVYUEVDVF9F UShmYWxzZSwgYWRkUmVzdWx0LmlzTmV3RW50cnkpOworICAgICAgICBFWFBFQ1RfRkFMU0UoYWRk UmVzdWx0LmlzTmV3RW50cnkpOwogICAgIH0KIAogICAgIEVYUEVDVF9TVFJFUSgicmVmKGEpIGRl cmVmKGEpICIsIHRha2VMb2dTdHIoKS5jX3N0cigpKTsKQEAgLTQ5MSw3ICs0OTEsNyBAQCBURVNU KFdURl9IYXNoTWFwLCBSZWZQdHJLZXlfQWRkVXNpbmdNb3ZlCiAgICAgewogICAgICAgICBSZWZQ dHI8UmVmTG9nZ2VyPiBwdHIyKCZhKTsKICAgICAgICAgYXV0byBhZGRSZXN1bHQgPSBtYXAuYWRk KFdURjo6bW92ZShwdHIyKSwgMCk7Ci0gICAgICAgIEVYUEVDVF9FUShmYWxzZSwgYWRkUmVzdWx0 LmlzTmV3RW50cnkpOworICAgICAgICBFWFBFQ1RfRkFMU0UoYWRkUmVzdWx0LmlzTmV3RW50cnkp OwogICAgIH0KIAogICAgIEVYUEVDVF9TVFJFUSgicmVmKGEpIGRlcmVmKGEpICIsIHRha2VMb2dT dHIoKS5jX3N0cigpKTsKQEAgLTU1Niw3ICs1NTYsNyBAQCBURVNUKFdURl9IYXNoTWFwLCBSZWZQ dHJLZXlfU2V0S2V5QWxyZWFkCiAgICAgewogICAgICAgICBSZWZQdHI8UmVmTG9nZ2VyPiBwdHIy KCZhKTsKICAgICAgICAgYXV0byBhZGRSZXN1bHQgPSBtYXAuc2V0KHB0cjIsIDEpOwotICAgICAg ICBFWFBFQ1RfRVEoZmFsc2UsIGFkZFJlc3VsdC5pc05ld0VudHJ5KTsKKyAgICAgICAgRVhQRUNU X0ZBTFNFKGFkZFJlc3VsdC5pc05ld0VudHJ5KTsKICAgICAgICAgRVhQRUNUX0VRKDEsIG1hcC5n ZXQocHRyLmdldCgpKSk7CiAgICAgfQogCkBAIC01NzcsNyArNTc3LDcgQEAgVEVTVChXVEZfSGFz aE1hcCwgUmVmUHRyS2V5X1NldFVzaW5nUmVsZQogICAgIHsKICAgICAgICAgUmVmUHRyPFJlZkxv Z2dlcj4gcHRyMigmYSk7CiAgICAgICAgIGF1dG8gYWRkUmVzdWx0ID0gbWFwLnNldChwdHIyLnJl bGVhc2UoKSwgMSk7Ci0gICAgICAgIEVYUEVDVF9FUShmYWxzZSwgYWRkUmVzdWx0LmlzTmV3RW50 cnkpOworICAgICAgICBFWFBFQ1RfRkFMU0UoYWRkUmVzdWx0LmlzTmV3RW50cnkpOwogICAgICAg ICBFWFBFQ1RfRVEoMSwgbWFwLmdldChwdHIuZ2V0KCkpKTsKICAgICB9CiAKQEAgLTU5OCw3ICs1 OTgsNyBAQCBURVNUKFdURl9IYXNoTWFwLCBSZWZQdHJLZXlfU2V0VXNpbmdNb3ZlCiAgICAgewog ICAgICAgICBSZWZQdHI8UmVmTG9nZ2VyPiBwdHIyKCZhKTsKICAgICAgICAgYXV0byBhZGRSZXN1 bHQgPSBtYXAuc2V0KFdURjo6bW92ZShwdHIyKSwgMSk7Ci0gICAgICAgIEVYUEVDVF9FUShmYWxz ZSwgYWRkUmVzdWx0LmlzTmV3RW50cnkpOworICAgICAgICBFWFBFQ1RfRkFMU0UoYWRkUmVzdWx0 LmlzTmV3RW50cnkpOwogICAgICAgICBFWFBFQ1RfRVEoMSwgbWFwLmdldChwdHIuZ2V0KCkpKTsK ICAgICB9CiAK