137471 2014-10-06 17:22:31 -0700 [Win] Use of 1-bit Enum type behaves improperly 2014-10-06 20:11:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham mark.lam webkit-bug-importer oldest_to_newest 1039886 0 bfulgham 2014-10-06 17:22:31 -0700 MSVC implements enumerated types as signed values. This causes problems when enums are used as elements in a bit field (especially 1-bit elements) because MSVC wants to include a sign bit in its encoding. This means we lose one bit of resolution, often causing incorrect behavior. Static analysis found this problem in Debugger.h. This patch corrects the bug so that we don't run into this on Windows builds. 1039887 1 webkit-bug-importer 2014-10-06 17:23:12 -0700 <rdar://problem/18563519> 1039888 2 bfulgham 2014-10-06 17:23:25 -0700 See also Bug 134252. 1039891 3 239369 bfulgham 2014-10-06 17:27:24 -0700 Created attachment 239369 Patch 1039910 4 239369 mark.lam 2014-10-06 18:18:24 -0700 Comment on attachment 239369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239369&action=review r=me with the comment added. > Source/JavaScriptCore/debugger/Debugger.h:195 > + unsigned m_steppingMode : 1; I recall Darin saying that the accepted practice is to add a trailing comment to indicate the expected type: unsigned m_steppingMode : 1; // SteppingMode 1039925 5 239369 bfulgham 2014-10-06 20:10:37 -0700 Comment on attachment 239369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239369&action=review >> Source/JavaScriptCore/debugger/Debugger.h:195 >> + unsigned m_steppingMode : 1; > > I recall Darin saying that the accepted practice is to add a trailing comment to indicate the expected type: > > unsigned m_steppingMode : 1; // SteppingMode Will do! 1039926 6 bfulgham 2014-10-06 20:11:38 -0700 Committed in r174381. <http://trac.webkit.org/changeset/174381> 239369 2014-10-06 17:27:24 -0700 2014-10-06 20:10:37 -0700 Patch bug-137471-20141006172726.patch text/plain 1690 bfulgham SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0Mzc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTEwLTA2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIFVzZSBvZiAxLWJpdCBFbnVtIHR5cGUgYmVoYXZlcyBpbXByb3Blcmx5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0NzEKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE4NTU5MTcyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlcHJlc2VudCAxLWJpdCBlbnVtIGVsZW1lbnQgYXMgJ3Vu c2lnbmVkJywgYXMgd2UgaGF2ZSBkb25lIGVsc2V3aGVyZQorICAgICAgICBpbiBXZWJLaXQgdG8g YXZvaWQgcHJvYmxlbXMgd2hlbiBidWlsZGluZyB3aXRoIE1TVkMuCisKKyAgICAgICAgKiBkZWJ1 Z2dlci9EZWJ1Z2dlci5oOgorCiAyMDE0LTEwLTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBGaXhlZCBjb21waWxlciB3YXJuaW5ncyBvbiBXaW5kb3dzIGJ1aWxk LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmgJKHJldmlz aW9uIDE3NDM3NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5o CSh3b3JraW5nIGNvcHkpCkBAIC05MCw3ICs5MCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHN0ZXBP dXRPZkZ1bmN0aW9uKCk7CiAKICAgICBib29sIGlzUGF1c2VkKCkgeyByZXR1cm4gbV9pc1BhdXNl ZDsgfQotICAgIGJvb2wgaXNTdGVwcGluZygpIGNvbnN0IHsgcmV0dXJuIG1fc3RlcHBpbmdNb2Rl ID09IFN0ZXBwaW5nTW9kZUVuYWJsZWQ7IH0KKyAgICBib29sIGlzU3RlcHBpbmcoKSBjb25zdCB7 IHJldHVybiBzdGF0aWNfY2FzdDxTdGVwcGluZ01vZGU+KG1fc3RlcHBpbmdNb2RlKSA9PSBTdGVw cGluZ01vZGVFbmFibGVkOyB9CiAKICAgICB2aXJ0dWFsIHZvaWQgc291cmNlUGFyc2VkKEV4ZWNT dGF0ZSosIFNvdXJjZVByb3ZpZGVyKiwgaW50IGVycm9yTGluZU51bWJlciwgY29uc3QgV1RGOjpT dHJpbmcmIGVycm9yTWVzc2FnZSkgPSAwOwogCkBAIC0xOTIsNyArMTkyLDcgQEAgcHJpdmF0ZToK ICAgICBib29sIG1fYnJlYWtwb2ludHNBY3RpdmF0ZWQgOiAxOwogICAgIGJvb2wgbV9oYXNIYW5k bGVyRm9yRXhjZXB0aW9uQ2FsbGJhY2sgOiAxOwogICAgIGJvb2wgbV9pc0luV29ya2VyVGhyZWFk IDogMTsKLSAgICBTdGVwcGluZ01vZGUgbV9zdGVwcGluZ01vZGUgOiAxOworICAgIHVuc2lnbmVk IG1fc3RlcHBpbmdNb2RlIDogMTsKIAogICAgIFJlYXNvbkZvclBhdXNlIG1fcmVhc29uRm9yUGF1 c2U7CiAgICAgSlNWYWx1ZSBtX2N1cnJlbnRFeGNlcHRpb247Cg==