137458 2014-10-06 13:23:07 -0700 [Win] DateMath's calculateUTCOffset does not account for Daylight Savings Time 2014-10-06 18:15:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 137473 1 bfulgham bfulgham benjamin bfulgham cmarcelo commit-queue webkit-bug-importer oldest_to_newest 1039802 0 bfulgham 2014-10-06 13:23:07 -0700 The code for the Windows path of "calculateUTCOffset" ignores the return value of GetTimeZoneInformation, and always acts as though the running machine is in the standard time zone. This documentation in <http://msdn.microsoft.com/en-us/library/windows/desktop/ms724421(v=vs.85).aspx> clearly indicates a daylight-savings-time-specific return value that indicates that you should use the "daylight bias" portion of the time zone struct to calculate the correct offset. 1039803 1 webkit-bug-importer 2014-10-06 13:24:12 -0700 <rdar://problem/18559172> 1039804 2 239351 bfulgham 2014-10-06 13:30:43 -0700 Created attachment 239351 Patch 1039805 3 bfulgham 2014-10-06 13:31:11 -0700 This bug may be why certain date-related tests are failing depending on user's time zone. 1039806 4 239351 ggaren 2014-10-06 13:34:35 -0700 Comment on attachment 239351 Patch r=me It would be nice to get clarity on whether our existing tests cover this, and to add a test to cover this if it's not already covered. 1039894 5 bfulgham 2014-10-06 17:39:35 -0700 (In reply to comment #4) > (From update of attachment 239351 [details]) > r=me > > It would be nice to get clarity on whether our existing tests cover this, and to add a test to cover this if it's not already covered. We have tests that check for correct calculation of DST-related dates, but we don't have a test that places the test machine in DST or Standard time zones for running the tests. This patch corrects a problem where the local machine state was not being accounted for when computed the time offset compared to UTC. I'll think about this and see if we can come up with a reliable way to toggle this state during test runs. 1039896 6 bfulgham 2014-10-06 17:42:19 -0700 See also <https://bugs.webkit.org/show_bug.cgi?id=137473> for better testing for this feature. 1039908 7 239351 commit-queue 2014-10-06 18:15:22 -0700 Comment on attachment 239351 Patch Clearing flags on attachment: 239351 Committed r174377: <http://trac.webkit.org/changeset/174377> 1039909 8 commit-queue 2014-10-06 18:15:26 -0700 All reviewed patches have been landed. Closing bug. 239351 2014-10-06 13:30:43 -0700 2014-10-06 18:15:22 -0700 Patch bug-137458-20141006133339.patch text/plain 2627 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzQzNjApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTEwLTA2ICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIERhdGVNYXRoJ3MgY2FsY3VsYXRlVVRG T2Zmc2V0IGRvZXMgbm90IGFjY291bnQgZm9yIERTVC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzQ1OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTg1NTkxNzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiBHZXRUaW1lWm9uZUluZm9ybWF0aW9uIGFuZCB1 c2UgdGhlCisgICAgICAgIHByb3BlciBiaWFzIGFnYWluc3QgVVRDIChkZXBlbmRpbmcgb24gd2hl dGhlciB3ZSBhcmUgaW4gZGF5bGlnaHQKKyAgICAgICAgc2F2aW5ncyB0aW1lLCBvciBzdGFuZGFy ZCB0aW1lKS4KKworICAgICAgICBBbHNvLCBoYW5kbGUgcG9zc2libGUgZXJyb3IgY2FzZXMgaW4g dGhlIEZpbGVUaW1lVG9TeXN0ZW1UaW1lCisgICAgICAgIGFuZCBTeXN0ZW1UaW1lVG9UelNwZWNp ZmljTG9jYWxUaW1lLCByYXRoZXIgdGhhbiB1c2luZyBwb3RlbnRpYWxseQorICAgICAgICB1bmlu aXRpYWxpemVkIHZhbHVlcy4KKworICAgICAgICAqIHd0Zi9EYXRlTWF0aC5jcHA6CisgICAgICAg IChXVEY6OmNhbGN1bGF0ZVVUQ09mZnNldCk6IFVzZSBwcm9wZXIgZGF5bGlnaHQtc2F2aW5ncy10 aW1lIHN0YXRlLgorICAgICAgICAoV1RGOjpjYWxjdWxhdGVEU1RPZmZzZXQpOiBBdm9pZCB1bmlu aXRpYWxpemVkIGRhdGEgZHVlIHRvIGZhaWxpbmcKKyAgICAgICAgQVBJIGNhbGxzLgorCiAyMDE0 LTEwLTA2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtX aW5dIFByb2plY3QgZmlsZSBnYXJkZW5pbmcuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9EYXRlTWF0 aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvRGF0ZU1hdGguY3BwCShyZXZpc2lv biAxNzQzNjApCisrKyBTb3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM2Nyw4ICszNjcsMTYgQEAgc3RhdGljIGludDMyX3QgY2FsY3VsYXRlVVRDT2Zmc2V0KCkK IHsKICNpZiBPUyhXSU5ET1dTKQogICAgIFRJTUVfWk9ORV9JTkZPUk1BVElPTiB0aW1lWm9uZUlu Zm9ybWF0aW9uOwotICAgIEdldFRpbWVab25lSW5mb3JtYXRpb24oJnRpbWVab25lSW5mb3JtYXRp b24pOwotICAgIGludDMyX3QgYmlhcyA9IHRpbWVab25lSW5mb3JtYXRpb24uQmlhcyArIHRpbWVa b25lSW5mb3JtYXRpb24uU3RhbmRhcmRCaWFzOworICAgIERXT1JEIHJjID0gOjpHZXRUaW1lWm9u ZUluZm9ybWF0aW9uKCZ0aW1lWm9uZUluZm9ybWF0aW9uKTsKKyAgICBpZiAocmMgPT0gVElNRV9a T05FX0lEX0lOVkFMSUQpCisgICAgICAgIHJldHVybiAwOworCisgICAgaW50MzJfdCBiaWFzID0g MDsKKyAgICBpZiAocmMgPT0gVElNRV9aT05FX0lEX0RBWUxJR0hUKQorICAgICAgICBiaWFzID0g dGltZVpvbmVJbmZvcm1hdGlvbi5CaWFzICsgdGltZVpvbmVJbmZvcm1hdGlvbi5EYXlsaWdodEJp YXM7CisgICAgZWxzZSBpZiAocmMgPT0gVElNRV9aT05FX0lEX1NUQU5EQVJEIHx8IHJjID09IFRJ TUVfWk9ORV9JRF9VTktOT1dOKQorICAgICAgICBiaWFzID0gdGltZVpvbmVJbmZvcm1hdGlvbi5C aWFzICsgdGltZVpvbmVJbmZvcm1hdGlvbi5TdGFuZGFyZEJpYXM7CisKICAgICByZXR1cm4gLWJp YXMgKiA2MCAqIDEwMDA7CiAjZWxzZQogICAgIHRpbWVfdCBsb2NhbFRpbWUgPSB0aW1lKDApOwpA QCAtNDI2LDggKzQzNCwxMCBAQCBzdGF0aWMgZG91YmxlIGNhbGN1bGF0ZURTVE9mZnNldCh0aW1l X3QKICAgICBGSUxFVElNRSB1dGNGaWxlVGltZTsKICAgICBVbml4VGltZVRvRmlsZVRpbWUobG9j YWxUaW1lLCAmdXRjRmlsZVRpbWUpOwogICAgIFNZU1RFTVRJTUUgdXRjU3lzdGVtVGltZSwgbG9j YWxTeXN0ZW1UaW1lOwotICAgIEZpbGVUaW1lVG9TeXN0ZW1UaW1lKCZ1dGNGaWxlVGltZSwgJnV0 Y1N5c3RlbVRpbWUpOwotICAgIFN5c3RlbVRpbWVUb1R6U3BlY2lmaWNMb2NhbFRpbWUoMCwgJnV0 Y1N5c3RlbVRpbWUsICZsb2NhbFN5c3RlbVRpbWUpOworICAgIGlmICghOjpGaWxlVGltZVRvU3lz dGVtVGltZSgmdXRjRmlsZVRpbWUsICZ1dGNTeXN0ZW1UaW1lKSkKKyAgICAgICAgcmV0dXJuIDA7 CisgICAgaWYgKCE6OlN5c3RlbVRpbWVUb1R6U3BlY2lmaWNMb2NhbFRpbWUobnVsbHB0ciwgJnV0 Y1N5c3RlbVRpbWUsICZsb2NhbFN5c3RlbVRpbWUpKQorICAgICAgICByZXR1cm4gMDsKIAogICAg IGRvdWJsZSBvZmZzZXRUaW1lID0gKGxvY2FsVGltZSAqIG1zUGVyU2Vjb25kKSArIHV0Y09mZnNl dDsKIAo=