137447 2014-10-06 05:40:33 -0700 AX: Avoid unnecessary copies in invalidStatus method 2014-12-05 00:44:08 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 k.czech k.czech aboxhall apinheiro cfleizach commit-queue darin dmazzoni jcraig jdiggs kling mario samuel_white webkit-bug-importer oldest_to_newest 1039709 0 k.czech 2014-10-06 05:40:33 -0700 Seems invalidStatus() method could be slightly changed so that it could return reference s to local static objects. 1039710 1 webkit-bug-importer 2014-10-06 05:40:55 -0700 <rdar://problem/18553813> 1039712 2 239331 k.czech 2014-10-06 05:52:52 -0700 Created attachment 239331 proposed patch 1039727 3 239331 cfleizach 2014-10-06 07:13:35 -0700 Comment on attachment 239331 proposed patch At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is 1039730 4 k.czech 2014-10-06 07:47:28 -0700 (In reply to comment #3) > (From update of attachment 239331 [details]) > At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is Thanks for clarifying me this, I do not know either what the current thinking is. 1039733 5 cfleizach 2014-10-06 08:40:36 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 239331 [details] [details]) > > At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is > Thanks for clarifying me this, I do not know either what the current thinking is. My guess is that unless this is a hot patch of code people would probably prefer to not make more statics. Thx 1039987 6 k.czech 2014-10-07 00:40:07 -0700 Thanks Chris for putting some light on this. It seems we should carefully add new statics. 1052184 7 239331 cfleizach 2014-12-03 09:53:40 -0800 Comment on attachment 239331 proposed patch I think we should probably skip this. Do you agree? 1052692 8 k.czech 2014-12-05 00:44:08 -0800 (In reply to comment #7) > Comment on attachment 239331 [details] > proposed patch > > I think we should probably skip this. Do you agree? Thanks Chris, yes I agree we should skip this one. 239331 2014-10-06 05:52:52 -0700 2014-12-03 09:53:40 -0800 proposed patch a11y-unnecessary-copies.patch text/plain 2856 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiODJiYzhhLi42NGE1ZjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMTAtMDYgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgQVg6IEF2b2lkIHVubmVjZXNzYXJ5IGNvcGllcyBpbiBpbnZhbGlkU3RhdHVzIG1l dGhvZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3 NDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaW52 YWxpZFN0YXR1cyBtZXRob2QgY291bGQgYmUgc2xpZ2h0bHkgY2hhbmdlZCBzbyB0aGF0IGl0IGNv dWxkIHJldHVybiByZWZlcmVuY2VzIHRvIGxvY2FsIHN0YXRpYyBvYmplY3RzCisgICAgICAgIHRv IGF2b2lkIHNvbWUgdW5uZWNlc3NhcnkgY29waWVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gYmVoYXZpb3VyIGNoYW5nZS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0Ojpp bnZhbGlkU3RhdHVzKToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmpl Y3QuaDoKKwogMjAxNC0xMC0wNSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25jYXN0PD4oKSBmb3IgU2Nyb2xsaW5nQ29vcmRp bmF0b3IgLyBTY3JvbGxpbmdTdGF0ZU5vZGUgc3ViY2xhc3NlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKaW5kZXggZjZlOTgy Ny4uZTMxOGEzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlPYmplY3QuY3BwCkBAIC0xNzMyLDEzICsxNzMyLDEzIEBAIGJvb2wgQWNjZXNz aWJpbGl0eU9iamVjdDo6YXJpYUlzTXVsdGlsaW5lKCkgY29uc3QKICAgICByZXR1cm4gZXF1YWxJ Z25vcmluZ0Nhc2UoZ2V0QXR0cmlidXRlKGFyaWFfbXVsdGlsaW5lQXR0ciksICJ0cnVlIik7CiB9 CiAKLVN0cmluZyBBY2Nlc3NpYmlsaXR5T2JqZWN0OjppbnZhbGlkU3RhdHVzKCkgY29uc3QKK2Nv bnN0IFN0cmluZyYgQWNjZXNzaWJpbGl0eU9iamVjdDo6aW52YWxpZFN0YXR1cygpIGNvbnN0CiB7 Ci0gICAgU3RyaW5nIGdyYW1tYXJWYWx1ZSA9IEFTQ0lJTGl0ZXJhbCgiZ3JhbW1hciIpOwotICAg IFN0cmluZyBmYWxzZVZhbHVlID0gQVNDSUlMaXRlcmFsKCJmYWxzZSIpOwotICAgIFN0cmluZyBz cGVsbGluZ1ZhbHVlID0gQVNDSUlMaXRlcmFsKCJzcGVsbGluZyIpOwotICAgIFN0cmluZyB0cnVl VmFsdWUgPSBBU0NJSUxpdGVyYWwoInRydWUiKTsKLSAgICBTdHJpbmcgdW5kZWZpbmVkVmFsdWUg PSBBU0NJSUxpdGVyYWwoInVuZGVmaW5lZCIpOworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxT dHJpbmc+IGdyYW1tYXJWYWx1ZShBU0NJSUxpdGVyYWwoImdyYW1tYXIiKSk7CisgICAgc3RhdGlj IE5ldmVyRGVzdHJveWVkPFN0cmluZz4gZmFsc2VWYWx1ZShBU0NJSUxpdGVyYWwoImZhbHNlIikp OworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxTdHJpbmc+IHNwZWxsaW5nVmFsdWUoQVNDSUlM aXRlcmFsKCJzcGVsbGluZyIpKTsKKyAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8U3RyaW5nPiB0 cnVlVmFsdWUoQVNDSUlMaXRlcmFsKCJ0cnVlIikpOworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3ll ZDxTdHJpbmc+IHVuZGVmaW5lZFZhbHVlKEFTQ0lJTGl0ZXJhbCgidW5kZWZpbmVkIikpOwogCiAg ICAgLy8gYXJpYS1pbnZhbGlkIGNhbiByZXR1cm4gZmFsc2UgKGRlZmF1bHQpLCBncmFtbWFyLCBz cGVsbGluZywgb3IgdHJ1ZS4KICAgICBTdHJpbmcgYXJpYUludmFsaWQgPSBzdHJpcExlYWRpbmdB bmRUcmFpbGluZ0hUTUxTcGFjZXMoZ2V0QXR0cmlidXRlKGFyaWFfaW52YWxpZEF0dHIpKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVj dC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgK aW5kZXggYjExMTkwMS4uN2QwYjY3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgKQEAgLTU4OSw3ICs1ODksNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBib29sIGFyaWFIYXNQb3B1cCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CiAgICAgdmlydHVhbCBib29sIGFyaWFQcmVzc2VkSXNQcmVzZW50KCkgY29uc3Q7CiAgICAgYm9v bCBhcmlhSXNNdWx0aWxpbmUoKSBjb25zdDsKLSAgICBTdHJpbmcgaW52YWxpZFN0YXR1cygpIGNv bnN0OworICAgIGNvbnN0IFN0cmluZyYgaW52YWxpZFN0YXR1cygpIGNvbnN0OwogICAgIGJvb2wg c3VwcG9ydHNBUklBRXhwYW5kZWQoKSBjb25zdDsKICAgICBib29sIHN1cHBvcnRzQ2hlY2tlZCgp IGNvbnN0OwogICAgIEFjY2Vzc2liaWxpdHlTb3J0RGlyZWN0aW9uIHNvcnREaXJlY3Rpb24oKSBj b25zdDsK