137446 2014-10-06 03:15:53 -0700 [jhbuild] We should be able to disable wiping on configuration change 2014-10-10 03:25:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mtiborinf webkit-unassigned commit-queue gyuyoung.kim ossy oldest_to_newest 1039695 0 mtiborinf 2014-10-06 03:15:53 -0700 It is annoying that jhbuild automatically and mandatory wipes the full Dependencies directory during hacking jhbuildrc files. We should be able to disable this function with a command line option and/or with an environment variable. 1039696 1 239324 mtiborinf 2014-10-06 03:24:05 -0700 Created attachment 239324 Patch This patch will add a new flag --wipe-on-change to disable wiping on configuration change 1039698 2 239324 ossy 2014-10-06 03:35:07 -0700 Comment on attachment 239324 Patch The patch looks good to me, but the comment is misleading. $wipeOnChange has true default value, but can be disabled with - JHBUILD_WIPE_ON_CHANGE=0 environment variable (or) - --no-wipe-on-change command line option 1039699 3 239324 ossy 2014-10-06 03:44:03 -0700 Comment on attachment 239324 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239324&action=review > Tools/Scripts/update-webkit-libs-jhbuild:34 > +GetOptions('wipe-on-change' => \$wipeOnChange,); You meant 'wipe-on-change!' to have --no-wipe-on-change and --wipe-on-change options too. 1039711 4 239330 mtiborinf 2014-10-06 05:41:07 -0700 Created attachment 239330 Patch v2 This patch has a better description. 1039716 5 239333 mtiborinf 2014-10-06 06:07:58 -0700 Created attachment 239333 Patch v3 Updated description 1040872 6 239333 commit-queue 2014-10-10 03:25:27 -0700 Comment on attachment 239333 Patch v3 Clearing flags on attachment: 239333 Committed r174580: <http://trac.webkit.org/changeset/174580> 1040873 7 commit-queue 2014-10-10 03:25:31 -0700 All reviewed patches have been landed. Closing bug. 239324 2014-10-06 03:24:05 -0700 2014-10-06 05:41:07 -0700 Patch patch_v3.patch text/plain 1575 mtiborinf ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ODk0 MWY0Li4wZmE2MzJjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMTAtMDYgIFRpYm9yIE1lc3phcm9zICA8dG1l c3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW2poYnVpbGRd IFdlIHNob3VsZCBiZSBhYmxlIHRvIGRpc2FibGUgd2lwaW5nIG9uIGNvbmZpZ3VyYXRpb24gY2hh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0 NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQ6IEFkZHMgbmV3IGZsYWcgLS13aXBlLW9u LWNoYW5nZSB0byBkaXNhYmxlIHdpcGluZyBvbiBjb25maWd1cmF0aW9uIGNoYW5nZQorCiAyMDE0 LTEwLTA2ICBac29sdCBCb3JiZWx5ICA8enNib3JiZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgbW92ZWQgbXlzZWxmIHRvIHRoZSBsaXN0IG9m IGNvbW1pdHRlcnMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGli cy1qaGJ1aWxkIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWxpYnMtamhidWlsZAppbmRl eCA4OWJiY2NiLi5iZGEzZjcwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJr aXQtbGlicy1qaGJ1aWxkCisrKyBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpo YnVpbGQKQEAgLTI1LDExICsyNSwxNCBAQCB1c2UgR2V0b3B0OjpMb25nIHF3KDpjb25maWcgcGFz c190aHJvdWdoKTsKIG15ICRwbGF0Zm9ybSA9ICIiOwogJHBsYXRmb3JtID0gImVmbCIgaWYgaXNF ZmwoKTsKICRwbGF0Zm9ybSA9ICJndGsiIGlmIGlzR3RrKCk7CitteSAkd2lwZU9uQ2hhbmdlID0g JEVOVntKSEJVSUxEX1dJUEVfT05fQ0hBTkdFfSAvLyAxOwogCiBpZiAoISRwbGF0Zm9ybSkgewog ICAgIGRpZSAiTm8gcGxhdGZvcm0gc3BlY2lmaWVkIGZvciAiIC4gYmFzZW5hbWUoJDApIC4iLiBV c2UgLS1ndGsgb3IgLS1lZmwuXG4iOwogfQogCitHZXRPcHRpb25zKCd3aXBlLW9uLWNoYW5nZScg PT4gXCR3aXBlT25DaGFuZ2UsKTsKKwogc3ViIGdldE1ENUhhc2hGb3JGaWxlKCQpCiB7CiAgICAg bXkgJGZpbGUgPSBzaGlmdDsKQEAgLTExMSw3ICsxMTQsNyBAQCBjaGRpcihyZWxhdGl2ZVNjcmlw dHNEaXIoKSAuICIvLi4vamhidWlsZCIpIG9yIGRpZSAkITsKIAogbXkgJXByZXR0eVBsYXRmb3Jt ID0gKCAiZWZsIiA9PiAiRUZMIiwgImd0ayIgPT4gIkdUSysiICk7CiAKLWlmICgtZSBnZXRKaGJ1 aWxkUGF0aCgpICYmIGpoYnVpbGRDb25maWd1cmF0aW9uQ2hhbmdlZCgpKSB7CitpZiAoJHdpcGVP bkNoYW5nZSAmJiAtZSBnZXRKaGJ1aWxkUGF0aCgpICYmIGpoYnVpbGRDb25maWd1cmF0aW9uQ2hh bmdlZCgpKSB7CiAgICAgY2xlYW5KaGJ1aWxkKCk7CiB9CiAK 239330 2014-10-06 05:41:07 -0700 2014-10-06 06:07:58 -0700 Patch v2 patch_v4.patch text/plain 1744 mtiborinf ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ODk0 MWY0Li4wZWU1MTc4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMTAtMDYgIFRpYm9yIE1lc3phcm9zICA8dG1l c3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW2poYnVpbGRd IFdlIHNob3VsZCBiZSBhYmxlIHRvIGRpc2FibGUgd2lwaW5nIG9uIGNvbmZpZ3VyYXRpb24gY2hh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0 NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg ZGVmYXVsdCBiZWhhdmlvdXIgaXNuJ3QgY2hhbmdlZCwKKyAgICAgICAgd2lwaW5nIG9uIGNvbmZp Z3VyYXRpb24gY2hhbmdlIGZlYXR1cmUgY2FuIGJlIGRpc2FibGVkIHdpdGgKKyAgICAgICAgc2V0 dGluZyBKSEJVSUxEX1dJUEVfT05fQ0hBTkdFPTAgZW52aXJvbm1lbnQgdmFyaWFibGUKKyAgICAg ICAgb3IgcGFzc2luZyAtLW5vLXdpcGUtb24tY2hhbmdlIGNvbW1hbmQgbGluZSBvcHRpb24uCisK KyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1qaGJ1aWxkOgorCiAyMDE0LTEw LTA2ICBac29sdCBCb3JiZWx5ICA8enNib3JiZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgbW92ZWQgbXlzZWxmIHRvIHRoZSBsaXN0IG9mIGNv bW1pdHRlcnMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1q aGJ1aWxkIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWxpYnMtamhidWlsZAppbmRleCA4 OWJiY2NiLi4zNjFiOGVhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQt bGlicy1qaGJ1aWxkCisrKyBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVp bGQKQEAgLTI1LDExICsyNSwxNCBAQCB1c2UgR2V0b3B0OjpMb25nIHF3KDpjb25maWcgcGFzc190 aHJvdWdoKTsKIG15ICRwbGF0Zm9ybSA9ICIiOwogJHBsYXRmb3JtID0gImVmbCIgaWYgaXNFZmwo KTsKICRwbGF0Zm9ybSA9ICJndGsiIGlmIGlzR3RrKCk7CitteSAkd2lwZU9uQ2hhbmdlID0gJEVO VntKSEJVSUxEX1dJUEVfT05fQ0hBTkdFfSAvLyAxOwogCiBpZiAoISRwbGF0Zm9ybSkgewogICAg IGRpZSAiTm8gcGxhdGZvcm0gc3BlY2lmaWVkIGZvciAiIC4gYmFzZW5hbWUoJDApIC4iLiBVc2Ug LS1ndGsgb3IgLS1lZmwuXG4iOwogfQogCitHZXRPcHRpb25zKCd3aXBlLW9uLWNoYW5nZSEnID0+ IFwkd2lwZU9uQ2hhbmdlLCk7CisKIHN1YiBnZXRNRDVIYXNoRm9yRmlsZSgkKQogewogICAgIG15 ICRmaWxlID0gc2hpZnQ7CkBAIC0xMTEsNyArMTE0LDcgQEAgY2hkaXIocmVsYXRpdmVTY3JpcHRz RGlyKCkgLiAiLy4uL2poYnVpbGQiKSBvciBkaWUgJCE7CiAKIG15ICVwcmV0dHlQbGF0Zm9ybSA9 ICggImVmbCIgPT4gIkVGTCIsICJndGsiID0+ICJHVEsrIiApOwogCi1pZiAoLWUgZ2V0SmhidWls ZFBhdGgoKSAmJiBqaGJ1aWxkQ29uZmlndXJhdGlvbkNoYW5nZWQoKSkgeworaWYgKCR3aXBlT25D aGFuZ2UgJiYgLWUgZ2V0SmhidWlsZFBhdGgoKSAmJiBqaGJ1aWxkQ29uZmlndXJhdGlvbkNoYW5n ZWQoKSkgewogICAgIGNsZWFuSmhidWlsZCgpOwogfQogCg== 239333 2014-10-06 06:07:58 -0700 2014-10-10 03:25:27 -0700 Patch v3 patch_v5.patch text/plain 1735 mtiborinf ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ODk0 MWY0Li4zYTlhNmM3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTAtMDYgIFRpYm9yIE1lc3phcm9zICA8dG1l c3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW2poYnVpbGRd IFdlIHNob3VsZCBiZSBhYmxlIHRvIGRpc2FibGUgd2lwaW5nIG9uIGNvbmZpZ3VyYXRpb24gY2hh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0 NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg ZGVmYXVsdCBiZWhhdmlvdXIgaXNuJ3QgY2hhbmdlZCwgd2lwaW5nIG9uIGNvbmZpZ3VyYXRpb24g Y2hhbmdlIGZlYXR1cmUgY2FuIGJlIGRpc2FibGVkIHdpdGgKKyAgICAgICAgc2V0dGluZyBKSEJV SUxEX1dJUEVfT05fQ0hBTkdFPTAgZW52aXJvbm1lbnQgdmFyaWFibGUKKyAgICAgICAgb3IgcGFz c2luZyAtLW5vLXdpcGUtb24tY2hhbmdlIGNvbW1hbmQgbGluZSBvcHRpb24uCisKKyAgICAgICAg KiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1qaGJ1aWxkOgorCiAyMDE0LTEwLTA2ICBac29s dCBCb3JiZWx5ICA8enNib3JiZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgbW92ZWQgbXlzZWxmIHRvIHRoZSBsaXN0IG9mIGNvbW1pdHRlcnMu CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1qaGJ1aWxkIGIv VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWxpYnMtamhidWlsZAppbmRleCA4OWJiY2NiLi4z NjFiOGVhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1qaGJ1 aWxkCisrKyBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQKQEAgLTI1 LDExICsyNSwxNCBAQCB1c2UgR2V0b3B0OjpMb25nIHF3KDpjb25maWcgcGFzc190aHJvdWdoKTsK IG15ICRwbGF0Zm9ybSA9ICIiOwogJHBsYXRmb3JtID0gImVmbCIgaWYgaXNFZmwoKTsKICRwbGF0 Zm9ybSA9ICJndGsiIGlmIGlzR3RrKCk7CitteSAkd2lwZU9uQ2hhbmdlID0gJEVOVntKSEJVSUxE X1dJUEVfT05fQ0hBTkdFfSAvLyAxOwogCiBpZiAoISRwbGF0Zm9ybSkgewogICAgIGRpZSAiTm8g cGxhdGZvcm0gc3BlY2lmaWVkIGZvciAiIC4gYmFzZW5hbWUoJDApIC4iLiBVc2UgLS1ndGsgb3Ig LS1lZmwuXG4iOwogfQogCitHZXRPcHRpb25zKCd3aXBlLW9uLWNoYW5nZSEnID0+IFwkd2lwZU9u Q2hhbmdlLCk7CisKIHN1YiBnZXRNRDVIYXNoRm9yRmlsZSgkKQogewogICAgIG15ICRmaWxlID0g c2hpZnQ7CkBAIC0xMTEsNyArMTE0LDcgQEAgY2hkaXIocmVsYXRpdmVTY3JpcHRzRGlyKCkgLiAi Ly4uL2poYnVpbGQiKSBvciBkaWUgJCE7CiAKIG15ICVwcmV0dHlQbGF0Zm9ybSA9ICggImVmbCIg PT4gIkVGTCIsICJndGsiID0+ICJHVEsrIiApOwogCi1pZiAoLWUgZ2V0SmhidWlsZFBhdGgoKSAm JiBqaGJ1aWxkQ29uZmlndXJhdGlvbkNoYW5nZWQoKSkgeworaWYgKCR3aXBlT25DaGFuZ2UgJiYg LWUgZ2V0SmhidWlsZFBhdGgoKSAmJiBqaGJ1aWxkQ29uZmlndXJhdGlvbkNoYW5nZWQoKSkgewog ICAgIGNsZWFuSmhidWlsZCgpOwogfQogCg==