<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137445</bug_id>
          
          <creation_ts>2014-10-06 02:11:17 -0700</creation_ts>
          <short_desc>[GTK][Stable] webkitgtk-2.4.6: fails to build with --disable-video</short_desc>
          <delta_ts>2014-10-22 02:39:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pacho Ramos">pachoramos1</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>gnome</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1039686</commentid>
    <comment_count>0</comment_count>
    <who name="Pacho Ramos">pachoramos1</who>
    <bug_when>2014-10-06 02:11:17 -0700</bug_when>
    <thetext>And this error:
In file included from ./Source/WTF/wtf/Platform.h:636:0,
                 from ./Source/JavaScriptCore/config.h:30,
                 from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26:
./Source/WTF/wtf/FeatureDefines.h:880:2: error: #error &quot;ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)&quot;
 #error &quot;ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)&quot;
  ^

Looks similar to:
https://bugs.webkit.org/show_bug.cgi?id=121259

And could be caused by this change:
https://bugs.webkit.org/show_bug.cgi?id=134801

Full build.log is at:
https://bugs.gentoo.org/attachment.cgi?id=386082

From downstream report:
https://bugs.gentoo.org/show_bug.cgi?id=524518

Thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1040283</commentid>
    <comment_count>1</comment_count>
    <who name="Pacho Ramos">pachoramos1</who>
    <bug_when>2014-10-08 07:23:57 -0700</bug_when>
    <thetext>Patch attached to:
https://bugs.gentoo.org/show_bug.cgi?id=524518#c5

should fix this</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1040291</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-08 08:22:57 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Patch attached to:
&gt; https://bugs.gentoo.org/show_bug.cgi?id=524518#c5
&gt; 
&gt; should fix this

Could that patch be attached here as well?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1040409</commentid>
    <comment_count>3</comment_count>
      <attachid>239492</attachid>
    <who name="Pacho Ramos">pachoramos1</who>
    <bug_when>2014-10-08 13:46:19 -0700</bug_when>
    <thetext>Created attachment 239492
patch

Sure</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1040410</commentid>
    <comment_count>4</comment_count>
      <attachid>239493</attachid>
    <who name="Pacho Ramos">pachoramos1</who>
    <bug_when>2014-10-08 13:47:20 -0700</bug_when>
    <thetext>Created attachment 239493
patch

(Credits for Michael Weber)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043394</commentid>
    <comment_count>5</comment_count>
      <attachid>239493</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-22 02:39:20 -0700</bug_when>
    <thetext>Comment on attachment 239493
patch

Pushed to 2.4 branch, thanks!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>239492</attachid>
            <date>2014-10-08 13:46:19 -0700</date>
            <delta_ts>2014-10-08 13:47:20 -0700</delta_ts>
            <desc>patch</desc>
            <filename>url.txt</filename>
            <type>text/plain</type>
            <size>55</size>
            <attacher name="Pacho Ramos">pachoramos1</attacher>
            
              <data encoding="base64">aHR0cHM6Ly81MjQ1MTguYnVncy5nZW50b28ub3JnL2F0dGFjaG1lbnQuY2dpP2lkPTM4NjIzNg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239493</attachid>
            <date>2014-10-08 13:47:20 -0700</date>
            <delta_ts>2014-10-08 13:47:20 -0700</delta_ts>
            <desc>patch</desc>
            <filename>webkit-video.patch</filename>
            <type>text/plain</type>
            <size>834</size>
            <attacher name="Pacho Ramos">pachoramos1</attacher>
            
              <data encoding="base64">LS0tIHdlYmtpdGd0ay0yLjQuNi9Tb3VyY2UvYXV0b3Rvb2xzL1NldHVwV2ViS2l0RmVhdHVyZXMu
bTQKKysrIHdlYmtpdGd0ay0yLjQuNi9Tb3VyY2UvYXV0b3Rvb2xzL1NldHVwV2ViS2l0RmVhdHVy
ZXMubTQKQEAgLTI0LDkgKzI0LDkgQEAKIGZpCiAKIGlmIHRlc3QgIiRlbmFibGVfdmlkZW8iID0g
InllcyI7IHRoZW4KLSAgICBDT05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTPSIkQ09ORklHVVJB
QkxFX0ZFQVRVUkVfREVGSU5FUyBFTkFCTEVfVklERU89MSIKKyAgICBDT05GSUdVUkFCTEVfRkVB
VFVSRV9ERUZJTkVTPSIkQ09ORklHVVJBQkxFX0ZFQVRVUkVfREVGSU5FUyBFTkFCTEVfVklERU89
MSBFTkFCTEVfVklERU9fVFJBQ0s9MSIKIGVsc2UKLSAgICBDT05GSUdVUkFCTEVfRkVBVFVSRV9E
RUZJTkVTPSIkQ09ORklHVVJBQkxFX0ZFQVRVUkVfREVGSU5FUyBFTkFCTEVfVklERU89MCIKKyAg
ICBDT05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTPSIkQ09ORklHVVJBQkxFX0ZFQVRVUkVfREVG
SU5FUyBFTkFCTEVfVklERU89MCBFTkFCTEVfVklERU9fVFJBQ0s9MCIKIGZpCiAKIGlmIHRlc3Qg
IiRlbmFibGVfY3NzX2ZpbHRlcnMiID0gInllcyI7IHRoZW4KQEAgLTE3MSw3ICsxNzEsNiBAQAog
ICAgIEVOQUJMRV9UT1VDSF9JQ09OX0xPQURJTkc9MCBcCiAgICAgRU5BQkxFX1VTRVJfVElNSU5H
PTAgXAogICAgIEVOQUJMRV9WSUJSQVRJT049MCBcCi0gICAgRU5BQkxFX1ZJREVPX1RSQUNLPTEg
XAogICAgIEVOQUJMRV9WSUVXX01PREVfQ1NTX01FRElBPTEgXAogICAgIEVOQUJMRV9XRUJfU09D
S0VUUz0xIFwKICAgICBFTkFCTEVfV0VCX1RJTUlORz0xIFwK
</data>

          </attachment>
      

    </bug>

</bugzilla>