137442 2014-10-06 00:34:24 -0700 There are wrong condition checking on GraphicsContext::roundToDevicePixels 2022-06-01 18:41:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 169031 P2 Normal --- 1 byeongha.cho webkit-unassigned ahmad.saleem792 commit-queue d-r gyuyoung.kim mrobinson zan oldest_to_newest 1039665 0 byeongha.cho 2014-10-06 00:34:24 -0700 There are wrong condition checking on GraphicsContext::roundToDevicePixels() of GraphicsContextCairo.cpp. I think this is copy and paste mistake. // We must ensure width and height are at least 1 (or -1) when // we're given float values in the range between 0 and 1 (or -1 and 0). double width = frect.width(); double height = frect.height(); cairo_user_to_device_distance(cr, &width, &height); if (width > -1 && width < 0) width = -1; else if (width > 0 && width < 1) width = 1; else width = round(width); if (height > -1 && width < 0) //'width' should be replaced with 'height'. height = -1; else if (height > 0 && height < 1) height = 1; else height = round(height); 1039666 1 239315 byeongha.cho 2014-10-06 00:38:01 -0700 Created attachment 239315 Patch 1040201 2 239315 darin 2014-10-07 21:42:40 -0700 Comment on attachment 239315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239315&action=review > Source/WebCore/ChangeLog:8 > + No new tests is needed. There's no functional change. Why is there no functional change? The condition is wrong; it must lead to some kind of bug. 1041799 3 byeongha.cho 2014-10-14 23:05:08 -0700 (In reply to comment #2) > (From update of attachment 239315 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239315&action=review > > Source/WebCore/ChangeLog:8 > > + No new tests is needed. There's no functional change. > Why is there no functional change? The condition is wrong; it must lead to some kind of bug. Yes, you are right. I'm going to upload the patch with detailed description again. Actually, this is regression of '[cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails' issue. I think Zan Dobersek <zandobersek@gmail.com> has made some mistake. So I fixed it. 1041800 4 239851 byeongha.cho 2014-10-14 23:07:14 -0700 Created attachment 239851 Patch 1041801 5 239851 gyuyoung.kim 2014-10-14 23:09:09 -0700 Comment on attachment 239851 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239851&action=review > Source/WebCore/ChangeLog:10 > + commit 957e1a234d3bc5b333615b0c5b6c8da56be4600a I think this full commit log lets us confuse to track history. I think you just mention what revision used wrong condition in ChangeLog. 1041804 6 byeongha.cho 2014-10-14 23:22:58 -0700 Please refer https://bugs.webkit.org/show_bug.cgi?id=54491. 1041806 7 239852 byeongha.cho 2014-10-14 23:38:55 -0700 Created attachment 239852 Patch 1041872 8 239852 darin 2014-10-15 09:40:17 -0700 Comment on attachment 239852 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239852&action=review > Source/WebCore/ChangeLog:9 > + Fixing copy and paste mistake of r79129. > + There are condition checking for width in place of height. Why no test case? Generally we require test cases so we don’t introduce the same mistake again. 1873399 9 ahmad.saleem792 2022-06-01 15:32:46 -0700 I tried to look into GraphicsContextCairo.cpp from Webkit Github mirror but I think code is more simplified and this might not be be applicable anymore. Link - https://github.com/WebKit/WebKit/blob/ecc984f22b6d9d87c82985a6fb0c8b8b4a5c7975/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp Can we close this, if it is not applicable anymore? Thanks! 1873468 10 ap 2022-06-01 18:41:30 -0700 This was fixed in bug 169031 (without a test case!!!), and later simplified to simply call into Cairo indeed. *** This bug has been marked as a duplicate of bug 169031 *** 239315 2014-10-06 00:38:01 -0700 2014-10-14 23:07:05 -0700 Patch bug-137442-20141006163802.patch text/plain 1492 byeongha.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY2NDAzZDMwNDdjYzQ4 ODg1MTQ0MDc0NzY1MGNjYWQ1NDQxNTk4Yy4uMDllYzU5MzlkOTA5NmY0ZmFiNzczYjNhNGEwZGE2 MjQ1ZjU1NzJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTA2ICBCeWVv bmdoYSBDaG8gIDxieWVvbmdoYS5jaG9Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IHdyb25n IGNvbmRpdGlvbiBjaGVja2luZyBvbiBHcmFwaGljc0NvbnRleHQ6OnJvdW5kVG9EZXZpY2VQaXhl bHMoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NzQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBpcyBuZWVkZWQuIFRoZXJlJ3Mgbm8gZnVuY3Rpb25hbCBjaGFuZ2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnJvdW5kVG9EZXZpY2VQaXhlbHMp OgorCiAyMDE0LTA3LTA0ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBDU1MgSklUOiBjb21waWxlIDppbi1yYW5nZSBhbmQgOm91dC1vZi1yYW5nZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp Y3NDb250ZXh0Q2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp cm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCmluZGV4IGRiNzNjMDMwYzE3MTkwYjhiNGIzZmM2 ODdkMzNiNDZlOTcxYWE2YjIuLjg2MWUwOGQyN2JiNzk1N2UzNTZjYTk3YjMyODUxNjI4NDllYzVh ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dy YXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKQEAgLTcxOSw3ICs3MTksNyBAQCBG bG9hdFJlY3QgR3JhcGhpY3NDb250ZXh0Ojpyb3VuZFRvRGV2aWNlUGl4ZWxzKGNvbnN0IEZsb2F0 UmVjdCYgZnJlY3QsIFJvdW5kaW5nTQogICAgICAgICB3aWR0aCA9IDE7CiAgICAgZWxzZQogICAg ICAgICB3aWR0aCA9IHJvdW5kKHdpZHRoKTsKLSAgICBpZiAoaGVpZ2h0ID4gLTEgJiYgd2lkdGgg PCAwKQorICAgIGlmIChoZWlnaHQgPiAtMSAmJiBoZWlnaHQgPCAwKQogICAgICAgICBoZWlnaHQg PSAtMTsKICAgICBlbHNlIGlmIChoZWlnaHQgPiAwICYmIGhlaWdodCA8IDEpCiAgICAgICAgIGhl aWdodCA9IDE7Cg== 239851 2014-10-14 23:07:14 -0700 2014-10-14 23:38:47 -0700 Patch bug-137442-20141015150718.patch text/plain 2921 byeongha.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY2NDAzZDMwNDdjYzQ4 ODg1MTQ0MDc0NzY1MGNjYWQ1NDQxNTk4Yy4uOGRiZjQzMWM1ZDk3YTgwZDFhMDg2ZDRmNzRkYmU1 MWRlODM5Y2IzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ1IEBACisyMDEzLTEwLTA2ICBCeWVv bmdoYSBDaG8gIDxieWVvbmdoYS5jaG9Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IHdyb25n IGNvbmRpdGlvbiBjaGVja2luZyBvbiBHcmFwaGljc0NvbnRleHQ6OnJvdW5kVG9EZXZpY2VQaXhl bHMoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NzQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eGluZyBjb3B5IGFuZCBwYXN0ZSBtaXN0YWtlIG9mIGJlbG93IGNvbW1pdC4KKyAgICAgICAgCisg ICAgICAgIGNvbW1pdCA5NTdlMWEyMzRkM2JjNWIzMzM2MTViMGM1YjZjOGRhNTZiZTQ2MDBhCisg ICAgICAgIEF1dGhvcjogY29tbWl0LXF1ZXVlQHdlYmtpdC5vcmcgPGNvbW1pdC1xdWV1ZUB3ZWJr aXQub3JnQDI2OGY0NWNjLWNkMDktMDQxMC1hYjNjLWQ1MjY5MWI0ZGJmYz4KKyAgICAgICAgRGF0 ZTogICBTYXQgRmViIDE5IDIwOjI4OjQ3IDIwMTEgKzAwMDAKKyAgICAgICAgCisgICAgICAgIDIw MTEtMDItMTkgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKyAgICAgICAg CisgICAgICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCisgICAgICAgIAorICAg ICAgICAgICAgW2NhaXJvXVtjYW52YXNdIERyYXdpbmcgZnJvbS9pbnRvIGZsb2F0IHJlY3Rhbmds ZXMgd2l0aCB3aWR0aCBvciBoZWlnaHQgaW4gcmFuZ2UgMCB0byAxIGZhaWxzCisgICAgICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0OTEKKyAgICAgICAg CisgICAgICAgICAgICBFbmFibGUgYW5vdGhlciBwYXNzaW5nIHRlc3QgYWZ0ZXIgZml4aW5nIGZs b2F0IHZhbHVlcyByb3VuZGluZy4KKyAgICAgICAgCisgICAgICAgICAgICAqIHBsYXRmb3JtL2d0 ay9Ta2lwcGVkOgorICAgICAgICAyMDExLTAyLTE5ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNl a0BnbWFpbC5jb20+CisgICAgICAgIAorICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJv Ymluc29uLgorICAgICAgICAKKyAgICAgICAgICAgIFtjYWlyb11bY2FudmFzXSBEcmF3aW5nIGZy b20vaW50byBmbG9hdCByZWN0YW5nbGVzIHdpdGggd2lkdGggb3IgaGVpZ2h0IGluIHJhbmdlIDAg dG8gMSBmYWlscworICAgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU0NDkxCisgICAgICAgIAorICAgICAgICAgICAgV2hlbiB3aWR0aCBvciBoZWlnaHQg aW4gZmxvYXQgcmVjdGFuZ2xlIGFyZSBpbiByYW5nZSAoMCwgMC41KSBvciAoLTAuNSwgMCkKKyAg ICAgICAgICAgIGFuZCB3b3VsZCByb3VuZCB0byAwLCBhbHRlciB0aGUgYmVoYXZpb3VyIHRvIGVu c3VyZSB0aGF0IHdpZHRoIG9yIGhlaWdodCBhcmUKKyAgICAgICAgICAgIGF0IGxlYXN0IDEgcGl4 ZWwgaW4gc2l6ZSBpbiB0aGVzZSBjYXNlcy4KKyAgICAgICAgCisgICAgICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnJvdW5kVG9EZXZpY2VQaXhlbHMpOgorICAgICAg ICAKKyAgICAgICAgZ2l0LXN2bi1pZDogaHR0cDovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkv d2Via2l0L3RydW5rQDc5MTI5IDI2OGY0NWNjLWNkMDktMDQxMC1hYjNjLWQ1MjY5MWI0ZGJmYwor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpyb3VuZFRvRGV2aWNlUGl4 ZWxzKToKKwogMjAxNC0wNy0wNCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5v cmc+CiAKICAgICAgICAgQ1NTIEpJVDogY29tcGlsZSA6aW4tcmFuZ2UgYW5kIDpvdXQtb2YtcmFu Z2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dy YXBoaWNzQ29udGV4dENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAppbmRleCBkYjczYzAzMGMxNzE5MGI4YjRi M2ZjNjg3ZDMzYjQ2ZTk3MWFhNmIyLi44NjFlMDhkMjdiYjc5NTdlMzU2Y2E5N2IzMjg1MTYyODQ5 ZWM1YWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCkBAIC03MTksNyArNzE5LDcg QEAgRmxvYXRSZWN0IEdyYXBoaWNzQ29udGV4dDo6cm91bmRUb0RldmljZVBpeGVscyhjb25zdCBG bG9hdFJlY3QmIGZyZWN0LCBSb3VuZGluZ00KICAgICAgICAgd2lkdGggPSAxOwogICAgIGVsc2UK ICAgICAgICAgd2lkdGggPSByb3VuZCh3aWR0aCk7Ci0gICAgaWYgKGhlaWdodCA+IC0xICYmIHdp ZHRoIDwgMCkKKyAgICBpZiAoaGVpZ2h0ID4gLTEgJiYgaGVpZ2h0IDwgMCkKICAgICAgICAgaGVp Z2h0ID0gLTE7CiAgICAgZWxzZSBpZiAoaGVpZ2h0ID4gMCAmJiBoZWlnaHQgPCAxKQogICAgICAg ICBoZWlnaHQgPSAxOwo= 239852 2014-10-14 23:38:55 -0700 2014-10-15 09:40:17 -0700 Patch bug-137442-20141015153859.patch text/plain 1569 byeongha.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY2NDAzZDMwNDdjYzQ4 ODg1MTQ0MDc0NzY1MGNjYWQ1NDQxNTk4Yy4uYTNkNzM5YzUyYTVlYzY5OTE0ZTYwY2U5OGQ3OWJk ODlmMDM5NGNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTA2ICBCeWVv bmdoYSBDaG8gIDxieWVvbmdoYS5jaG9Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TihyNzkxMjkpIDogRml4IHdyb25nIGNvbmRpdGlvbiBjaGVja2luZyBvbiBHcmFwaGljc0NvbnRl eHQ6OnJvdW5kVG9EZXZpY2VQaXhlbHMoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNzQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeGluZyBjb3B5IGFuZCBwYXN0ZSBtaXN0YWtlIG9mIHI3OTEy OS4gCisgICAgICAgIFRoZXJlIGFyZSBjb25kaXRpb24gY2hlY2tpbmcgZm9yIHdpZHRoIGluIHBs YWNlIG9mIGhlaWdodC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBo aWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6 cm91bmRUb0RldmljZVBpeGVscyk6CisKIDIwMTQtMDctMDQgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIENTUyBKSVQ6IGNvbXBpbGUgOmluLXJhbmdl IGFuZCA6b3V0LW9mLXJhbmdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKaW5kZXggZGI3 M2MwMzBjMTcxOTBiOGI0YjNmYzY4N2QzM2I0NmU5NzFhYTZiMi4uODYxZTA4ZDI3YmI3OTU3ZTM1 NmNhOTdiMzI4NTE2Mjg0OWVjNWFkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcApA QCAtNzE5LDcgKzcxOSw3IEBAIEZsb2F0UmVjdCBHcmFwaGljc0NvbnRleHQ6OnJvdW5kVG9EZXZp Y2VQaXhlbHMoY29uc3QgRmxvYXRSZWN0JiBmcmVjdCwgUm91bmRpbmdNCiAgICAgICAgIHdpZHRo ID0gMTsKICAgICBlbHNlCiAgICAgICAgIHdpZHRoID0gcm91bmQod2lkdGgpOwotICAgIGlmICho ZWlnaHQgPiAtMSAmJiB3aWR0aCA8IDApCisgICAgaWYgKGhlaWdodCA+IC0xICYmIGhlaWdodCA8 IDApCiAgICAgICAgIGhlaWdodCA9IC0xOwogICAgIGVsc2UgaWYgKGhlaWdodCA+IDAgJiYgaGVp Z2h0IDwgMSkKICAgICAgICAgaGVpZ2h0ID0gMTsK