137438 2014-10-05 17:39:15 -0700 Use is<>() / downcast<>() for TextTrack subclasses 2014-10-05 22:11:08 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137056 1 cdumez cdumez benjamin calvaris commit-queue darin eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble kling philipj rniwa sergio oldest_to_newest 1039634 0 cdumez 2014-10-05 17:39:15 -0700 Use is<>() / downcast<>() for TextTrack subclasses 1039637 1 239308 cdumez 2014-10-05 17:43:20 -0700 Created attachment 239308 Patch 1039650 2 239308 rniwa 2014-10-05 21:35:05 -0700 Comment on attachment 239308 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239308&action=review > Source/WebCore/html/track/TextTrackList.cpp:54 > -int TextTrackList::getTrackIndex(TextTrack *textTrack) > +int TextTrackList::getTrackIndex(TextTrack* textTrack) We don't have to do it in this patch but we should use reference for textTrack. 1039654 3 239308 commit-queue 2014-10-05 22:11:00 -0700 Comment on attachment 239308 Patch Clearing flags on attachment: 239308 Committed r174338: <http://trac.webkit.org/changeset/174338> 1039655 4 commit-queue 2014-10-05 22:11:08 -0700 All reviewed patches have been landed. Closing bug. 239308 2014-10-05 17:43:20 -0700 2014-10-05 22:10:59 -0700 Patch bug-137438-20141005174321.patch text/plain 6841 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFmZjNiZjA1ZGJlMjQ2 NGI4YTJiYjRmMGUwNzY4YTViZjk5OWNiNi4uNTRhNTFlNTg4OTgzYzM4ZjA0NjAyNTMwMjBmNWZj ODM0ODIzMzI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE0LTEwLTA1ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBVc2UgaXM8PigpIC8g ZG93bmNhc3Q8PigpIGZvciBUZXh0VHJhY2sgc3ViY2xhc3NlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NDM4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25jYXN0PD4oKSBm b3IgVGV4dFRyYWNrIHN1YmNsYXNzZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhh dmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZh dGVEaWRSZWNlaXZlSW5pdGlhbGl6YXRpb25TZWdtZW50KToKKyAgICAgICAgKiBodG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cGFy c2VBdHRyaWJ1dGUpOgorICAgICAgICAqIGh0bWwvdHJhY2svSW5iYW5kVGV4dFRyYWNrLmg6Cisg ICAgICAgIChpc1R5cGUpOgorICAgICAgICAqIGh0bWwvdHJhY2svTG9hZGFibGVUZXh0VHJhY2su aDoKKyAgICAgICAgKGlzVHlwZSk6CisgICAgICAgICogaHRtbC90cmFjay9UZXh0VHJhY2tMaXN0 LmNwcDoKKyAgICAgICAgKFRleHRUcmFja0xpc3Q6OmdldFRyYWNrSW5kZXgpOgorICAgICAgICAo VGV4dFRyYWNrTGlzdDo6YXBwZW5kKTogRGVsZXRlZC4KKworMjAxNC0xMC0wNSAgQ2hyaXN0b3Bo ZSBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25j YXN0PD4oKSBmb3IgU3R5bGVTaGVldCBzdWJjbGFzc2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0MjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCmluZGV4IGNhNTM0Y2U4OGNk NjdjMDUwMWNkYTNiYzFhMTg3OTM0NTk3MzQ1ODcuLjY3OTIxZTNiMzJkZDE5M2I0YzM3MGE3ZjA3 N2M5YmY2NTVjYjRjNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz b3VyY2UvU291cmNlQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c291cmNlL1NvdXJjZUJ1ZmZlci5jcHAKQEAgLTkyMiwxMyArOTIyLDEzIEBAIHZvaWQgU291cmNl QnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlRGlkUmVjZWl2ZUluaXRpYWxpemF0aW9uU2VnbWVu dChTb3VyY2VCdWZmCiAgICAgICAgIEFTU0VSVChzZWdtZW50LnRleHRUcmFja3Muc2l6ZSgpID09 IHRleHRUcmFja3MoKS0+bGVuZ3RoKCkpOwogICAgICAgICBmb3IgKGF1dG8mIHRleHRUcmFja0lu Zm8gOiBzZWdtZW50LnRleHRUcmFja3MpIHsKICAgICAgICAgICAgIGlmICh0ZXh0VHJhY2tzKCkt Pmxlbmd0aCgpID09IDEpIHsKLSAgICAgICAgICAgICAgICB0b0luYmFuZFRleHRUcmFjayh0ZXh0 VHJhY2tzKCktPml0ZW0oMCkpLT5zZXRQcml2YXRlKHRleHRUcmFja0luZm8udHJhY2spOworICAg ICAgICAgICAgICAgIGRvd25jYXN0PEluYmFuZFRleHRUcmFjaz4oKnRleHRUcmFja3MoKS0+aXRl bSgwKSkuc2V0UHJpdmF0ZSh0ZXh0VHJhY2tJbmZvLnRyYWNrKTsKICAgICAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgYXV0byB0ZXh0VHJhY2sgPSB0ZXh0 VHJhY2tzKCktPmdldFRyYWNrQnlJZCh0ZXh0VHJhY2tJbmZvLnRyYWNrLT5pZCgpKTsKICAgICAg ICAgICAgIEFTU0VSVCh0ZXh0VHJhY2spOwotICAgICAgICAgICAgdG9JbmJhbmRUZXh0VHJhY2so dGV4dFRyYWNrKS0+c2V0UHJpdmF0ZSh0ZXh0VHJhY2tJbmZvLnRyYWNrKTsKKyAgICAgICAgICAg IGRvd25jYXN0PEluYmFuZFRleHRUcmFjaz4oKnRleHRUcmFjaykuc2V0UHJpdmF0ZSh0ZXh0VHJh Y2tJbmZvLnRyYWNrKTsKICAgICAgICAgfQogCiAgICAgICAgIGZvciAoYXV0byYgdHJhY2tCdWZm ZXIgOiBtX3RyYWNrQnVmZmVyTWFwLnZhbHVlcygpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAKaW5kZXggMWMzMDVhMjY3MGU4MjBhODBjNDFmYTgyYzE5MjI1ZTYyNjg0 ZTU4OC4uNDJkZjhhZjVmOTg4MDQ2NjE2YWYwOWQ5YmVhNTUwY2FhNDk0YTcxMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0xNDY3LDkgKzE0NjcsOSBAQCB2 b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZUFjdGl2ZVRleHRUcmFja0N1ZXMoY29uc3QgTWVk aWFUaW1lJiBtb3ZpZVRpbWUpCiAKICAgICAgICAgLy8gLi4uIGlmIHRoZSB0ZXh0IHRyYWNrIGhh cyBhIGNvcnJlc3BvbmRpbmcgdHJhY2sgZWxlbWVudCwgdG8gdGhlbiBmaXJlIGEKICAgICAgICAg Ly8gc2ltcGxlIGV2ZW50IG5hbWVkIGN1ZWNoYW5nZSBhdCB0aGUgdHJhY2sgZWxlbWVudCBhcyB3 ZWxsLgotICAgICAgICBpZiAoYWZmZWN0ZWRUcmFja3NbaV0tPnRyYWNrVHlwZSgpID09IFRleHRU cmFjazo6VHJhY2tFbGVtZW50KSB7CisgICAgICAgIGlmIChpczxMb2FkYWJsZVRleHRUcmFjaz4o KmFmZmVjdGVkVHJhY2tzW2ldKSkgewogICAgICAgICAgICAgUmVmUHRyPEV2ZW50PiBldmVudCA9 IEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmN1ZWNoYW5nZUV2ZW50LCBmYWxzZSwgZmFsc2Up OwotICAgICAgICAgICAgSFRNTFRyYWNrRWxlbWVudCogdHJhY2tFbGVtZW50ID0gc3RhdGljX2Nh c3Q8TG9hZGFibGVUZXh0VHJhY2sqPihhZmZlY3RlZFRyYWNrc1tpXSktPnRyYWNrRWxlbWVudCgp OworICAgICAgICAgICAgSFRNTFRyYWNrRWxlbWVudCogdHJhY2tFbGVtZW50ID0gZG93bmNhc3Q8 TG9hZGFibGVUZXh0VHJhY2s+KCphZmZlY3RlZFRyYWNrc1tpXSkudHJhY2tFbGVtZW50KCk7CiAg ICAgICAgICAgICBBU1NFUlQodHJhY2tFbGVtZW50KTsKICAgICAgICAgICAgIGV2ZW50LT5zZXRU YXJnZXQodHJhY2tFbGVtZW50KTsKICAgICAgICAgICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC90cmFjay9JbmJhbmRUZXh0VHJhY2suaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv dHJhY2svSW5iYW5kVGV4dFRyYWNrLmgKaW5kZXggMGU1YjUxYTFkM2Q4MDM5MTdhYjhiMWUwMGEz OTdhZDQ3MGM0Y2MxZS4uMDY3MzAyYTQ1YTZkMThkNmFjMmQ0NGI4NmMxYTAzYzMzODk3ZDIxOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9JbmJhbmRUZXh0VHJhY2suaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL0luYmFuZFRleHRUcmFjay5oCkBAIC0zMiw2 ICszMiw3IEBACiAjaW5jbHVkZSAiVGV4dFRyYWNrLmgiCiAjaW5jbHVkZSAiVGV4dFRyYWNrQ3Vl R2VuZXJpYy5oIgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KKyNpbmNsdWRlIDx3dGYvVHlwZUNh c3RzLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtOTIsOSArOTMsMTIgQEAgcHJpdmF0 ZToKICNlbmRpZgogfTsKIAotVFlQRV9DQVNUU19CQVNFKEluYmFuZFRleHRUcmFjaywgVGV4dFRy YWNrLCB0cmFjaywgdHJhY2stPmlzSW5iYW5kKCksIHRyYWNrLmlzSW5iYW5kKCkpOwotCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCiAKLSNlbmRpZgotI2VuZGlmCitTUEVDSUFMSVpFX1RZUEVfVFJB SVRTX0JFR0lOKFdlYkNvcmU6OkluYmFuZFRleHRUcmFjaykKKyAgICBzdGF0aWMgYm9vbCBpc1R5 cGUoY29uc3QgV2ViQ29yZTo6VGV4dFRyYWNrJiB0cmFjaykgeyByZXR1cm4gdHJhY2suaXNJbmJh bmQoKTsgfQorU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19FTkQoKQorCisjZW5kaWYgLy8gRU5BQkxF KFZJREVPX1RSQUNLKQorCisjZW5kaWYgLy8gSW5iYW5kVGV4dFRyYWNrX2gKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svTG9hZGFibGVUZXh0VHJhY2suaCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvdHJhY2svTG9hZGFibGVUZXh0VHJhY2suaAppbmRleCA2ZjUyZjA4NGIxOWFj YjAwZGZjNjQ0ODJiNWMyMjBlMzRkNzEyNDI1Li5iMTEyYjBmZjVlNzYyNTAzMGQ5NTAxNjZmZmUx ZWE5ZGJiNjdjM2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL0xvYWRh YmxlVGV4dFRyYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9Mb2FkYWJsZVRl eHRUcmFjay5oCkBAIC0zMCw2ICszMCw3IEBACiAKICNpbmNsdWRlICJUZXh0VHJhY2suaCIKICNp bmNsdWRlICJUZXh0VHJhY2tMb2FkZXIuaCIKKyNpbmNsdWRlIDx3dGYvVHlwZUNhc3RzLmg+CiAj aW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC03OSw1ICs4 MCwxMCBAQCBwcml2YXRlOgogfTsKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAotI2VuZGlmCi0j ZW5kaWYKK1NQRUNJQUxJWkVfVFlQRV9UUkFJVFNfQkVHSU4oV2ViQ29yZTo6TG9hZGFibGVUZXh0 VHJhY2spCisgICAgc3RhdGljIGJvb2wgaXNUeXBlKGNvbnN0IFdlYkNvcmU6OlRleHRUcmFjayYg dHJhY2spIHsgcmV0dXJuIHRyYWNrLnRyYWNrVHlwZSgpID09IFdlYkNvcmU6OlRleHRUcmFjazo6 VHJhY2tFbGVtZW50OyB9CitTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX0VORCgpCisKKyNlbmRpZiAv LyBFTkFCTEUoVklERU9fVFJBQ0spCisKKyNlbmRpZiAvLyBMb2FkYWJsZVRleHRUcmFja19oCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFja0xpc3QuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tMaXN0LmNwcAppbmRleCBkMTFjZjNj YzY2MGZkMDk0YWYwNTNkNGZmNWYyNjU4Yjk5ZDU2NGM2Li4xNTlmYjNkZGY1ZGNhNGI0YWNjMTdi OTM0MTAyNDBmZjIyMDhiNjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNr L1RleHRUcmFja0xpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRy YWNrTGlzdC5jcHAKQEAgLTUxLDEwICs1MSwxMCBAQCB1bnNpZ25lZCBUZXh0VHJhY2tMaXN0Ojps ZW5ndGgoKSBjb25zdAogICAgIHJldHVybiBtX2FkZFRyYWNrVHJhY2tzLnNpemUoKSArIG1fZWxl bWVudFRyYWNrcy5zaXplKCkgKyBtX2luYmFuZFRyYWNrcy5zaXplKCk7CiB9CiAKLWludCBUZXh0 VHJhY2tMaXN0OjpnZXRUcmFja0luZGV4KFRleHRUcmFjayAqdGV4dFRyYWNrKQoraW50IFRleHRU cmFja0xpc3Q6OmdldFRyYWNrSW5kZXgoVGV4dFRyYWNrKiB0ZXh0VHJhY2spCiB7Ci0gICAgaWYg KHRleHRUcmFjay0+dHJhY2tUeXBlKCkgPT0gVGV4dFRyYWNrOjpUcmFja0VsZW1lbnQpCi0gICAg ICAgIHJldHVybiBzdGF0aWNfY2FzdDxMb2FkYWJsZVRleHRUcmFjayo+KHRleHRUcmFjayktPnRy YWNrRWxlbWVudEluZGV4KCk7CisgICAgaWYgKGlzPExvYWRhYmxlVGV4dFRyYWNrPih0ZXh0VHJh Y2spKQorICAgICAgICByZXR1cm4gZG93bmNhc3Q8TG9hZGFibGVUZXh0VHJhY2s+KCp0ZXh0VHJh Y2spLnRyYWNrRWxlbWVudEluZGV4KCk7CiAKICAgICBpZiAodGV4dFRyYWNrLT50cmFja1R5cGUo KSA9PSBUZXh0VHJhY2s6OkFkZFRyYWNrKQogICAgICAgICByZXR1cm4gbV9lbGVtZW50VHJhY2tz LnNpemUoKSArIG1fYWRkVHJhY2tUcmFja3MuZmluZCh0ZXh0VHJhY2spOwpAQCAtMTc2LDkgKzE3 Niw5IEBAIHZvaWQgVGV4dFRyYWNrTGlzdDo6YXBwZW5kKFBhc3NSZWZQdHI8VGV4dFRyYWNrPiBw cnBUcmFjaykKIAogICAgIGlmICh0cmFjay0+dHJhY2tUeXBlKCkgPT0gVGV4dFRyYWNrOjpBZGRU cmFjaykKICAgICAgICAgbV9hZGRUcmFja1RyYWNrcy5hcHBlbmQodHJhY2spOwotICAgIGVsc2Ug aWYgKHRyYWNrLT50cmFja1R5cGUoKSA9PSBUZXh0VHJhY2s6OlRyYWNrRWxlbWVudCkgeworICAg IGVsc2UgaWYgKGlzPExvYWRhYmxlVGV4dFRyYWNrPigqdHJhY2spKSB7CiAgICAgICAgIC8vIElu c2VydCB0cmFja3MgYWRkZWQgZm9yIDx0cmFjaz4gZWxlbWVudCBpbiB0cmVlIG9yZGVyLgotICAg ICAgICBzaXplX3QgaW5kZXggPSBzdGF0aWNfY2FzdDxMb2FkYWJsZVRleHRUcmFjayo+KHRyYWNr LmdldCgpKS0+dHJhY2tFbGVtZW50SW5kZXgoKTsKKyAgICAgICAgc2l6ZV90IGluZGV4ID0gZG93 bmNhc3Q8TG9hZGFibGVUZXh0VHJhY2s+KCp0cmFjaykudHJhY2tFbGVtZW50SW5kZXgoKTsKICAg ICAgICAgbV9lbGVtZW50VHJhY2tzLmluc2VydChpbmRleCwgdHJhY2spOwogICAgIH0gZWxzZSBp ZiAodHJhY2stPnRyYWNrVHlwZSgpID09IFRleHRUcmFjazo6SW5CYW5kKSB7CiAgICAgICAgIC8v IEluc2VydCB0cmFja3MgYWRkZWQgZm9yIGluLWJhbmQgaW4gdGhlIG1lZGlhIGZpbGUgb3JkZXIu Cg==