137430 2014-10-04 22:23:13 -0700 Use is<>() / downcast<>() for ElementData subclasses 2014-10-05 15:14:59 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137056 1 cdumez cdumez benjamin cmarcelo commit-queue darin esprehn+autocc kangil.han kling rniwa oldest_to_newest 1039566 0 cdumez 2014-10-04 22:23:13 -0700 Use is<>() / downcast<>() for ElementData subclasses 1039567 1 239292 cdumez 2014-10-04 22:27:27 -0700 Created attachment 239292 Patch 1039601 2 239292 commit-queue 2014-10-05 15:14:53 -0700 Comment on attachment 239292 Patch Clearing flags on attachment: 239292 Committed r174329: <http://trac.webkit.org/changeset/174329> 1039602 3 commit-queue 2014-10-05 15:14:59 -0700 All reviewed patches have been landed. Closing bug. 239292 2014-10-04 22:27:27 -0700 2014-10-05 15:14:52 -0700 Patch bug-137430-20141004222728.patch text/plain 7673 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk2NTIwOTRmODk1YjM0 NWE3NTk5NjI4YThkN2M3YTZjMzk0YmY4OC4uMmQxMzY2ZDdhZDQwY2FhODViYzUzZTE4MTI3YTg3 N2IwNDJiYTFhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTEwLTA0ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgaXM8PigpIC8g ZG93bmNhc3Q8PigpIGZvciBFbGVtZW50RGF0YSBzdWJjbGFzc2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc0MzAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgaXM8PigpIC8gZG93bmNhc3Q8Pigp IGZvciBFbGVtZW50RGF0YSBzdWJjbGFzc2VzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8g YmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RWxlbWVudDo6Y2xvbmVBdHRyaWJ1dGVzRnJvbUVsZW1lbnQpOgorICAgICAgICAo V2ViQ29yZTo6RWxlbWVudDo6Y3JlYXRlVW5pcXVlRWxlbWVudERhdGEpOgorICAgICAgICAqIGRv bS9FbGVtZW50RGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50RGF0YTo6ZGVzdHJv eSk6CisgICAgICAgICogZG9tL0VsZW1lbnREYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpFbGVt ZW50RGF0YTo6bGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnREYXRhOjphdHRyaWJ1 dGVCYXNlKToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnREYXRhOjpwcmVzZW50YXRpb25BdHRy aWJ1dGVTdHlsZSk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50RGF0YTo6YXR0cmlidXRlc0l0 ZXJhdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnREYXRhOjpmaW5kQXR0cmlidXRlQnlO YW1lKToKKyAgICAgICAgKGlzVHlwZSk6CisKIDIwMTQtMTAtMDQgIERoaSBBdXJyYWhtYW4gIDxk aW9yYWhtYW5Acm9ja3liYXJzLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgRWxlbWVudC5jbG9z ZXN0KCkgQVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggNmI3YmMxNmUxNzgwMzY2ZWMyM2Nl NTE2NjRiMGFjNzAyYThhMDBkYy4uMTFkYTM1MTNhOTIwMGVjNzdkMGY5ODc5MjllYzIwZDgxOGEx YWY2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMjkzOCwxMCArMjkzOCwxMCBAQCB2b2lk IEVsZW1lbnQ6OmNsb25lQXR0cmlidXRlc0Zyb21FbGVtZW50KGNvbnN0IEVsZW1lbnQmIG90aGVy KQogCiAgICAgLy8gSWYgJ290aGVyJyBoYXMgYSBtdXRhYmxlIEVsZW1lbnREYXRhLCBjb252ZXJ0 IGl0IHRvIGFuIGltbXV0YWJsZSBvbmUgc28gd2UgY2FuIHNoYXJlIGl0IGJldHdlZW4gYm90aCBl bGVtZW50cy4KICAgICAvLyBXZSBjYW4gb25seSBkbyB0aGlzIGlmIHRoZXJlIGlzIG5vIENTU09N IHdyYXBwZXIgZm9yIG90aGVyJ3MgaW5saW5lIHN0eWxlLCBhbmQgdGhlcmUgYXJlIG5vIHByZXNl bnRhdGlvbiBhdHRyaWJ1dGVzLgotICAgIGlmIChvdGhlci5tX2VsZW1lbnREYXRhLT5pc1VuaXF1 ZSgpCisgICAgaWYgKGlzPFVuaXF1ZUVsZW1lbnREYXRhPigqb3RoZXIubV9lbGVtZW50RGF0YSkK ICAgICAgICAgJiYgIW90aGVyLm1fZWxlbWVudERhdGEtPnByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0 eWxlKCkKICAgICAgICAgJiYgKCFvdGhlci5tX2VsZW1lbnREYXRhLT5pbmxpbmVTdHlsZSgpIHx8 ICFvdGhlci5tX2VsZW1lbnREYXRhLT5pbmxpbmVTdHlsZSgpLT5oYXNDU1NPTVdyYXBwZXIoKSkp Ci0gICAgICAgIGNvbnN0X2Nhc3Q8RWxlbWVudCY+KG90aGVyKS5tX2VsZW1lbnREYXRhID0gdG9V bmlxdWVFbGVtZW50RGF0YShvdGhlci5tX2VsZW1lbnREYXRhKS0+bWFrZVNoYXJlYWJsZUNvcHko KTsKKyAgICAgICAgY29uc3RfY2FzdDxFbGVtZW50Jj4ob3RoZXIpLm1fZWxlbWVudERhdGEgPSBk b3duY2FzdDxVbmlxdWVFbGVtZW50RGF0YT4oKm90aGVyLm1fZWxlbWVudERhdGEpLm1ha2VTaGFy ZWFibGVDb3B5KCk7CiAKICAgICBpZiAoIW90aGVyLm1fZWxlbWVudERhdGEtPmlzVW5pcXVlKCkp CiAgICAgICAgIG1fZWxlbWVudERhdGEgPSBvdGhlci5tX2VsZW1lbnREYXRhOwpAQCAtMjk2Myw3 ICsyOTYzLDcgQEAgdm9pZCBFbGVtZW50OjpjcmVhdGVVbmlxdWVFbGVtZW50RGF0YSgpCiAgICAg aWYgKCFtX2VsZW1lbnREYXRhKQogICAgICAgICBtX2VsZW1lbnREYXRhID0gVW5pcXVlRWxlbWVu dERhdGE6OmNyZWF0ZSgpOwogICAgIGVsc2UKLSAgICAgICAgbV9lbGVtZW50RGF0YSA9IHRvU2hh cmVhYmxlRWxlbWVudERhdGEobV9lbGVtZW50RGF0YSktPm1ha2VVbmlxdWVDb3B5KCk7CisgICAg ICAgIG1fZWxlbWVudERhdGEgPSBkb3duY2FzdDxTaGFyZWFibGVFbGVtZW50RGF0YT4oKm1fZWxl bWVudERhdGEpLm1ha2VVbmlxdWVDb3B5KCk7CiB9CiAKIGJvb2wgRWxlbWVudDo6aGFzUGVuZGlu Z1Jlc291cmNlcygpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dERhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnREYXRhLmNwcAppbmRleCAzOTIz ZjM1NmEyZDVhNGM3Y2MwNWViMWNmYzdiYTlkYmQ3NGRhYjhjLi4wMTYyNTY1NDcxYmZiMWUxNTU5 N2YyMjM1YmM3YTQ0Y2Q0NmIwNzQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudERhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50RGF0YS5jcHAKQEAg LTM1LDEwICszNSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgRWxlbWVudERhdGE6 OmRlc3Ryb3koKQogewotICAgIGlmIChpc1VuaXF1ZSgpKQotICAgICAgICBkZWxldGUgdG9Vbmlx dWVFbGVtZW50RGF0YSh0aGlzKTsKKyAgICBpZiAoaXM8VW5pcXVlRWxlbWVudERhdGE+KCp0aGlz KSkKKyAgICAgICAgZGVsZXRlIGRvd25jYXN0PFVuaXF1ZUVsZW1lbnREYXRhPih0aGlzKTsKICAg ICBlbHNlCi0gICAgICAgIGRlbGV0ZSB0b1NoYXJlYWJsZUVsZW1lbnREYXRhKHRoaXMpOworICAg ICAgICBkZWxldGUgZG93bmNhc3Q8U2hhcmVhYmxlRWxlbWVudERhdGE+KHRoaXMpOwogfQogCiBF bGVtZW50RGF0YTo6RWxlbWVudERhdGEoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnREYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudERhdGEuaAppbmRleCA0 MWFmYzY3YWJjM2VmMDZmOGEyNDc2ODhhNzQwMzUyMzcyODhhNTU1Li40NDAwYjgzZDM2YWFlM2Qy YTcxYjU4Nzg1ZmM1YjcwMzRjZTU2NzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudERhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudERhdGEuaApAQCAt MjksNiArMjksNyBAQAogI2luY2x1ZGUgIkF0dHJpYnV0ZS5oIgogI2luY2x1ZGUgIlNwYWNlU3Bs aXRTdHJpbmcuaCIKICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgorI2luY2x1ZGUgPHd0Zi9U eXBlQ2FzdHMuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0xODEsMTAgKzE4Miw2IEBA IHByaXZhdGU6CiAgICAgUGFzc1JlZjxVbmlxdWVFbGVtZW50RGF0YT4gbWFrZVVuaXF1ZUNvcHko KSBjb25zdDsKIH07CiAKLSNkZWZpbmUgRUxFTUVOVF9EQVRBX1RZUEVfQ0FTVFMoVG9WYWx1ZVR5 cGVOYW1lLCBwb2ludGVyUHJlZGljYXRlLCByZWZlcmVuY2VQcmVkaWNhdGUpIFwKLSAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgVG9WYWx1ZVR5cGVOYW1lKiB0byMjVG9WYWx1ZVR5cGVO YW1lKGNvbnN0IFJlZlB0cjxUPiYgZWxlbWVudERhdGEpIHsgcmV0dXJuIHRvIyNUb1ZhbHVlVHlw ZU5hbWUoZWxlbWVudERhdGEuZ2V0KCkpOyB9IFwKLSAgICBUWVBFX0NBU1RTX0JBU0UoVG9WYWx1 ZVR5cGVOYW1lLCBFbGVtZW50RGF0YSwgZWxlbWVudERhdGEsIHBvaW50ZXJQcmVkaWNhdGUsIHJl ZmVyZW5jZVByZWRpY2F0ZSkKLQogI2lmIENPTVBJTEVSKE1TVkMpCiAjcHJhZ21hIHdhcm5pbmco cHVzaCkKICNwcmFnbWEgd2FybmluZyhkaXNhYmxlOiA0MjAwKSAvLyBEaXNhYmxlICJ6ZXJvLXNp emVkIGFycmF5IGluIHN0cnVjdC91bmlvbiIgd2FybmluZwpAQCAtMjAzLDggKzIwMCw2IEBAIHB1 YmxpYzoKICAgICBBdHRyaWJ1dGUgbV9hdHRyaWJ1dGVBcnJheVswXTsKIH07CiAKLUVMRU1FTlRf REFUQV9UWVBFX0NBU1RTKFNoYXJlYWJsZUVsZW1lbnREYXRhLCAhZWxlbWVudERhdGEtPmlzVW5p cXVlKCksICFlbGVtZW50RGF0YS5pc1VuaXF1ZSgpKQotCiAjaWYgQ09NUElMRVIoTVNWQykKICNw cmFnbWEgd2FybmluZyhwb3ApCiAjZW5kaWYKQEAgLTIzMiw4ICsyMjcsNiBAQCBwdWJsaWM6CiAg ICAgQXR0cmlidXRlVmVjdG9yIG1fYXR0cmlidXRlVmVjdG9yOwogfTsKIAotRUxFTUVOVF9EQVRB X1RZUEVfQ0FTVFMoVW5pcXVlRWxlbWVudERhdGEsIGVsZW1lbnREYXRhLT5pc1VuaXF1ZSgpLCBl bGVtZW50RGF0YS5pc1VuaXF1ZSgpKQotCiBpbmxpbmUgdm9pZCBFbGVtZW50RGF0YTo6ZGVyZWYo KQogewogICAgIGlmICghZGVyZWZCYXNlKCkpCkBAIC0yNDMsMzIgKzIzNiwzMiBAQCBpbmxpbmUg dm9pZCBFbGVtZW50RGF0YTo6ZGVyZWYoKQogCiBpbmxpbmUgdW5zaWduZWQgRWxlbWVudERhdGE6 Omxlbmd0aCgpIGNvbnN0CiB7Ci0gICAgaWYgKGlzVW5pcXVlKCkpCi0gICAgICAgIHJldHVybiB0 b1VuaXF1ZUVsZW1lbnREYXRhKHRoaXMpLT5tX2F0dHJpYnV0ZVZlY3Rvci5zaXplKCk7CisgICAg aWYgKGlzPFVuaXF1ZUVsZW1lbnREYXRhPigqdGhpcykpCisgICAgICAgIHJldHVybiBkb3duY2Fz dDxVbmlxdWVFbGVtZW50RGF0YT4oKnRoaXMpLm1fYXR0cmlidXRlVmVjdG9yLnNpemUoKTsKICAg ICByZXR1cm4gYXJyYXlTaXplKCk7CiB9CiAKIGlubGluZSBjb25zdCBBdHRyaWJ1dGUqIEVsZW1l bnREYXRhOjphdHRyaWJ1dGVCYXNlKCkgY29uc3QKIHsKLSAgICBpZiAoaXNVbmlxdWUoKSkKLSAg ICAgICAgcmV0dXJuIHRvVW5pcXVlRWxlbWVudERhdGEodGhpcyktPm1fYXR0cmlidXRlVmVjdG9y LmRhdGEoKTsKLSAgICByZXR1cm4gdG9TaGFyZWFibGVFbGVtZW50RGF0YSh0aGlzKS0+bV9hdHRy aWJ1dGVBcnJheTsKKyAgICBpZiAoaXM8VW5pcXVlRWxlbWVudERhdGE+KCp0aGlzKSkKKyAgICAg ICAgcmV0dXJuIGRvd25jYXN0PFVuaXF1ZUVsZW1lbnREYXRhPigqdGhpcykubV9hdHRyaWJ1dGVW ZWN0b3IuZGF0YSgpOworICAgIHJldHVybiBkb3duY2FzdDxTaGFyZWFibGVFbGVtZW50RGF0YT4o KnRoaXMpLm1fYXR0cmlidXRlQXJyYXk7CiB9CiAKIGlubGluZSBjb25zdCBTdHlsZVByb3BlcnRp ZXMqIEVsZW1lbnREYXRhOjpwcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZSgpIGNvbnN0CiB7Ci0g ICAgaWYgKCFpc1VuaXF1ZSgpKQotICAgICAgICByZXR1cm4gMDsKLSAgICByZXR1cm4gdG9Vbmlx dWVFbGVtZW50RGF0YSh0aGlzKS0+bV9wcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZS5nZXQoKTsK KyAgICBpZiAoIWlzPFVuaXF1ZUVsZW1lbnREYXRhPigqdGhpcykpCisgICAgICAgIHJldHVybiBu dWxscHRyOworICAgIHJldHVybiBkb3duY2FzdDxVbmlxdWVFbGVtZW50RGF0YT4oKnRoaXMpLm1f cHJlc2VudGF0aW9uQXR0cmlidXRlU3R5bGUuZ2V0KCk7CiB9CiAKIGlubGluZSBBdHRyaWJ1dGVJ dGVyYXRvckFjY2Vzc29yIEVsZW1lbnREYXRhOjphdHRyaWJ1dGVzSXRlcmF0b3IoKSBjb25zdAog ewotICAgIGlmIChpc1VuaXF1ZSgpKSB7Ci0gICAgICAgIGNvbnN0IFZlY3RvcjxBdHRyaWJ1dGUs IDQ+JiBhdHRyaWJ1dGVWZWN0b3IgPSB0b1VuaXF1ZUVsZW1lbnREYXRhKHRoaXMpLT5tX2F0dHJp YnV0ZVZlY3RvcjsKKyAgICBpZiAoaXM8VW5pcXVlRWxlbWVudERhdGE+KCp0aGlzKSkgeworICAg ICAgICBjb25zdCBWZWN0b3I8QXR0cmlidXRlLCA0PiYgYXR0cmlidXRlVmVjdG9yID0gZG93bmNh c3Q8VW5pcXVlRWxlbWVudERhdGE+KCp0aGlzKS5tX2F0dHJpYnV0ZVZlY3RvcjsKICAgICAgICAg cmV0dXJuIEF0dHJpYnV0ZUl0ZXJhdG9yQWNjZXNzb3IoYXR0cmlidXRlVmVjdG9yLmRhdGEoKSwg YXR0cmlidXRlVmVjdG9yLnNpemUoKSk7CiAgICAgfQotICAgIHJldHVybiBBdHRyaWJ1dGVJdGVy YXRvckFjY2Vzc29yKHRvU2hhcmVhYmxlRWxlbWVudERhdGEodGhpcyktPm1fYXR0cmlidXRlQXJy YXksIGFycmF5U2l6ZSgpKTsKKyAgICByZXR1cm4gQXR0cmlidXRlSXRlcmF0b3JBY2Nlc3Nvcihk b3duY2FzdDxTaGFyZWFibGVFbGVtZW50RGF0YT4oKnRoaXMpLm1fYXR0cmlidXRlQXJyYXksIGFy cmF5U2l6ZSgpKTsKIH0KIAogQUxXQVlTX0lOTElORSBjb25zdCBBdHRyaWJ1dGUqIEVsZW1lbnRE YXRhOjpmaW5kQXR0cmlidXRlQnlOYW1lKGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSwgYm9vbCBz aG91bGRJZ25vcmVBdHRyaWJ1dGVDYXNlKSBjb25zdApAQCAtMjc2LDcgKzI2OSw3IEBAIEFMV0FZ U19JTkxJTkUgY29uc3QgQXR0cmlidXRlKiBFbGVtZW50RGF0YTo6ZmluZEF0dHJpYnV0ZUJ5TmFt ZShjb25zdCBBdG9taWNTdHJpCiAgICAgdW5zaWduZWQgaW5kZXggPSBmaW5kQXR0cmlidXRlSW5k ZXhCeU5hbWUobmFtZSwgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2FzZSk7CiAgICAgaWYgKGluZGV4 ICE9IGF0dHJpYnV0ZU5vdEZvdW5kKQogICAgICAgICByZXR1cm4gJmF0dHJpYnV0ZUF0KGluZGV4 KTsKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogQUxXQVlTX0lOTElO RSB1bnNpZ25lZCBFbGVtZW50RGF0YTo6ZmluZEF0dHJpYnV0ZUluZGV4QnlOYW1lKGNvbnN0IFF1 YWxpZmllZE5hbWUmIG5hbWUpIGNvbnN0CkBAIC0zNDIsNyArMzM1LDE1IEBAIGlubGluZSBBdHRy aWJ1dGUmIFVuaXF1ZUVsZW1lbnREYXRhOjphdHRyaWJ1dGVBdCh1bnNpZ25lZCBpbmRleCkKICAg ICByZXR1cm4gbV9hdHRyaWJ1dGVWZWN0b3IuYXQoaW5kZXgpOwogfQogCi19Cit9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCiAKLSNlbmRpZgorU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19CRUdJTihXZWJD b3JlOjpTaGFyZWFibGVFbGVtZW50RGF0YSkKKyAgICBzdGF0aWMgYm9vbCBpc1R5cGUoY29uc3Qg V2ViQ29yZTo6RWxlbWVudERhdGEmIGVsZW1lbnREYXRhKSB7IHJldHVybiAhZWxlbWVudERhdGEu aXNVbmlxdWUoKTsgfQorU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19FTkQoKQorCitTUEVDSUFMSVpF X1RZUEVfVFJBSVRTX0JFR0lOKFdlYkNvcmU6OlVuaXF1ZUVsZW1lbnREYXRhKQorICAgIHN0YXRp YyBib29sIGlzVHlwZShjb25zdCBXZWJDb3JlOjpFbGVtZW50RGF0YSYgZWxlbWVudERhdGEpIHsg cmV0dXJuIGVsZW1lbnREYXRhLmlzVW5pcXVlKCk7IH0KK1NQRUNJQUxJWkVfVFlQRV9UUkFJVFNf RU5EKCkKKworI2VuZGlmIC8vIEVsZW1lbnREYXRhX2gKIAo=