137419 2014-10-03 22:32:16 -0700 Support insert iterators for Vectors. [Part 2] 2016-09-17 07:05:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 137374 1 jer.noble jer.noble bfulgham oldest_to_newest 1039456 0 jer.noble 2014-10-03 22:32:16 -0700 Support insert iterators for Vectors. [Part 2] 1039461 1 239268 jer.noble 2014-10-03 23:07:27 -0700 Created attachment 239268 Patch 1221916 2 bfulgham 2016-08-22 11:24:09 -0700 Was this abandoned? Should we be getting it up-to-date and landed? 1230804 3 239268 mcatanzaro 2016-09-17 07:05:22 -0700 Comment on attachment 239268 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 239268 2014-10-03 23:07:27 -0700 2016-09-17 07:05:22 -0700 Patch bug-137419-20141003230730.patch text/plain 5355 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE5ZDRmMGZjMmI3N2RlOWQ3OWY3ZGYx ZTM4ZjE2YTIwN2Y5NTEwNjkuLjU1MzUyNWI1MjcxYWNmNmQ0Mjc2NmZhYzM2OTc3NWNkMDJhNDcx ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTQtMTAtMDMgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CiAKKyAgICAgICAgU3VwcG9ydCBpbnNlcnQgaXRlcmF0b3JzIGZvciBWZWN0 b3JzLiBbUGFydCAyXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM3NDE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVtb3ZlIHRoZSB2ZXJzaW9ucyBvZiBpbnNlcnQoKSB3aGljaCBmb3J3YXJkIHRvIGlu c2VydEF0KCkgYW5kIHJlcGxhY2Ugd2l0aAorICAgICAgICBhIHZlcnNpb24gb2YgaW5zZXJ0KCkg d2hpY2ggdGFrZXMgYSBWZWN0b3I6Oml0ZXJhdG9yLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5o OgorICAgICAgICAoV1RGOjpWZWN0b3I6OnB1c2hfYmFjayk6IEZvcndhcmRzIHRvIGFwcGVuZCgp LgorICAgICAgICAoV1RGOjpPdmVyZmxvd0hhbmRsZXI+OjppbnNlcnQpOiBBZGRlZC4KKworMjAx NC0xMC0wMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBTdXBw b3J0IGluc2VydCBpdGVyYXRvcnMgZm9yIFZlY3RvcnMuIFtQYXJ0IDFdCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzczNzQKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvVmVjdG9yLmggYi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3IuaAppbmRleCA5 ZmNmYjQ3ZDYwN2M1MjA4MTU5N2JlMjFkNWVhYTU1ODczY2I2MDI0Li41YThhMWM0N2Q2YjM0NjBl MWRkNDZkNWVlODEwNjc0MDkxNWVkZmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9WZWN0 b3IuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3IuaApAQCAtNTU4LDYgKzU1OCw3IEBAIHBy aXZhdGU6CiAKIHB1YmxpYzoKICAgICB0eXBlZGVmIFQgVmFsdWVUeXBlOworICAgIHR5cGVkZWYg VCB2YWx1ZV90eXBlOwogCiAgICAgdHlwZWRlZiBUKiBpdGVyYXRvcjsKICAgICB0eXBlZGVmIGNv bnN0IFQqIGNvbnN0X2l0ZXJhdG9yOwpAQCAtNjg0LDE0ICs2ODUsMTQgQEAgcHVibGljOgogCiAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCBhcHBlbmQoY29uc3QgVSosIHNpemVfdCk7CiAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCBhcHBlbmQoVSYmKTsKKyAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBVPiB2b2lkIHB1c2hfYmFjayhVJiYgdmFsdWUpIHsgYXBwZW5kKHN0ZDo6Zm9yd2Fy ZDxVPih2YWx1ZSkpOyB9CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCB1bmNoZWNrZWRB cHBlbmQoVSYmIHZhbCk7CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVSwgc2l6ZV90IG90aGVyQ2Fw YWNpdHk+IHZvaWQgYXBwZW5kVmVjdG9yKGNvbnN0IFZlY3RvcjxVLCBvdGhlckNhcGFjaXR5PiYp OwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IGJvb2wgdHJ5QXBwZW5kKGNvbnN0IFUqLCBzaXpl X3QpOwogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCBpbnNlcnRBdChzaXplX3QgcG9z aXRpb24sIGNvbnN0IFUqLCBzaXplX3QpOwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IHZvaWQg aW5zZXJ0QXQoc2l6ZV90IHBvc2l0aW9uLCBVJiYpOwotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+ IHZvaWQgaW5zZXJ0KHNpemVfdCBwb3NpdGlvbiwgY29uc3QgVSogZGF0YSwgc2l6ZV90IGRhdGFT aXplKSB7IGluc2VydEF0KHBvc2l0aW9uLCBkYXRhLCBkYXRhU2l6ZSk7IH0KLSAgICB0ZW1wbGF0 ZTx0eXBlbmFtZSBVPiB2b2lkIGluc2VydChzaXplX3QgcG9zaXRpb24sIFUmJiB2YWx1ZSkgeyBp bnNlcnRBdChwb3NpdGlvbiwgc3RkOjpmb3J3YXJkPFU+KHZhbHVlKSk7IH0KKyAgICB0ZW1wbGF0 ZTx0eXBlbmFtZSBVPiB2b2lkIGluc2VydChpdGVyYXRvciwgVSYmIHZhbHVlKTsKICAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBVLCBzaXplX3QgYz4gdm9pZCBpbnNlcnRWZWN0b3Ioc2l6ZV90IHBvc2l0 aW9uLCBjb25zdCBWZWN0b3I8VSwgYz4mKTsKIAogICAgIHZvaWQgcmVtb3ZlKHNpemVfdCBwb3Np dGlvbik7CkBAIC0xMTM2LDYgKzExMzcsMjMgQEAgaW5saW5lIHZvaWQgVmVjdG9yPFQsIGlubGlu ZUNhcGFjaXR5LCBPdmVyZmxvd0hhbmRsZXI+OjppbnNlcnRBdChzaXplX3QgcG9zaXRpb24KICAg ICArK21fc2l6ZTsKIH0KIAordGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFj aXR5LCB0eXBlbmFtZSBPdmVyZmxvd0hhbmRsZXI+IHRlbXBsYXRlPHR5cGVuYW1lIFU+Citpbmxp bmUgdm9pZCBWZWN0b3I8VCwgaW5saW5lQ2FwYWNpdHksIE92ZXJmbG93SGFuZGxlcj46Omluc2Vy dChpdGVyYXRvciBzcG90LCBVJiYgdmFsdWUpCit7CisgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlf SU1QTElDQVRJT04oc3BvdCA8PSBlbmQoKSk7CisgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1Q TElDQVRJT04oc3BvdCA+PSBiZWdpbigpKTsKKworICAgIGF1dG8gcHRyID0gY29uc3RfY2FzdDx0 eXBlbmFtZSBzdGQ6OnJlbW92ZV9jb25zdDx0eXBlbmFtZSBzdGQ6OnJlbW92ZV9yZWZlcmVuY2U8 VT46OnR5cGU+Ojp0eXBlKj4oc3RkOjphZGRyZXNzb2YodmFsdWUpKTsKKyAgICBpZiAoc2l6ZSgp ID09IGNhcGFjaXR5KCkpIHsKKyAgICAgICAgcHRyID0gZXhwYW5kQ2FwYWNpdHkoc2l6ZSgpICsg MSwgcHRyKTsKKyAgICAgICAgQVNTRVJUKGJlZ2luKCkpOworICAgIH0KKworICAgIFR5cGVPcGVy YXRpb25zOjptb3ZlT3ZlcmxhcHBpbmcoc3BvdCwgZW5kKCksIHNwb3QgKyAxKTsKKyAgICBuZXcg KE5vdE51bGwsIHNwb3QpIFQoc3RkOjpmb3J3YXJkPFU+KCpwdHIpKTsKKyAgICArK21fc2l6ZTsK K30KKwogdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5LCB0eXBlbmFt ZSBPdmVyZmxvd0hhbmRsZXI+IHRlbXBsYXRlPHR5cGVuYW1lIFUsIHNpemVfdCBjPgogaW5saW5l IHZvaWQgVmVjdG9yPFQsIGlubGluZUNhcGFjaXR5LCBPdmVyZmxvd0hhbmRsZXI+OjppbnNlcnRW ZWN0b3Ioc2l6ZV90IHBvc2l0aW9uLCBjb25zdCBWZWN0b3I8VSwgYz4mIHZhbCkKIHsKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZDQ5N2M1ZDYw MWNjMzUxYWVjMjUzNzY4MDFkNjE5OGZlMzM4OTc4Li44YzdjMDc2ZmFjYjc2NDNiZWVmYjNjNzYy NGI0Y2I0ZGU1MTU4M2NjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTQtMTAtMDMgIEplciBOb2JsZSAgPGplci5u b2JsZUBhcHBsZS5jb20+CiAKKyAgICAgICAgU3VwcG9ydCBpbnNlcnQgaXRlcmF0b3JzIGZvciBW ZWN0b3JzLiBbUGFydCAyXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM3NDE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIHRlc3RzIGZvciB1c2luZyBpbnNlcnRfaXRlcmF0b3IgYW5kIGJhY2tfaW5z ZXJ0X2l0ZXJhdG9yIHdpdGggV1RGOjpWZWN0b3IuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dURi9WZWN0b3IuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisK KzIwMTQtMTAtMDMgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKICAgICAgICAg U3VwcG9ydCBpbnNlcnQgaXRlcmF0b3JzIGZvciBWZWN0b3JzLiBbUGFydCAxXQogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3Mzc0CiAKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1ZlY3Rvci5jcHAgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dURi9WZWN0b3IuY3BwCmluZGV4IDQzYmY3OGU5NDUwZTUxMDQ5NWYw NjJhMGQyZGNiNjdiMTMyYjc3YTguLjUyMmI3MGU4MzFlZjQ5NTNiNjM1NWY1MmFiZThjYWIwM2Vk MDY0NmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1ZlY3Rvci5j cHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvVmVjdG9yLmNwcApAQCAtMjYs NiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogCiAjaW5jbHVkZSAiTW92ZU9ubHkuaCIK KyNpbmNsdWRlIDxpdGVyYXRvcj4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFj ZSBUZXN0V2ViS2l0QVBJIHsKQEAgLTE0Miw2ICsxNDMsNDEgQEAgVEVTVChXVEZfVmVjdG9yLCBS ZXZlcnNlSXRlcmF0b3IpCiAgICAgRVhQRUNUX1RSVUUoZW5kID09IGl0KTsKIH0KIAorVEVTVChX VEZfVmVjdG9yLCBJbnNlcnRJdGVyYXRvcikKK3sKKyAgICBWZWN0b3I8aW50PiB2ZWN0b3IgPSB7 IDEsIDIsIDMsIDQgfTsKKyAgICB2ZWN0b3IucmVzZXJ2ZUNhcGFjaXR5KDgpOworCisgICAgVmVj dG9yPGludD46Oml0ZXJhdG9yIGl0ID0gdmVjdG9yLmJlZ2luKCk7CisgICAgaXQrKzsKKworICAg IGF1dG8gaW5zZXJ0SXQgPSBzdGQ6Omluc2VydGVyKHZlY3RvciwgaXQpOworICAgIGluc2VydEl0 ID0gNTsKKyAgICBpbnNlcnRJdCA9IDY7CisKKyAgICBFWFBFQ1RfRVEoNSwgdmVjdG9yWzFdKTsK KyAgICBFWFBFQ1RfRVEoNiwgdmVjdG9yWzJdKTsKKworICAgIGluc2VydEl0ID0gc3RkOjppbnNl cnRlcih2ZWN0b3IsIHZlY3Rvci5lbmQoKSk7CisgICAgaW5zZXJ0SXQgPSA3OworICAgIGluc2Vy dEl0ID0gODsKKworICAgIEVYUEVDVF9FUSg3LCB2ZWN0b3JbNl0pOworICAgIEVYUEVDVF9FUSg4 LCB2ZWN0b3JbN10pOworfQorCitURVNUKFdURl9WZWN0b3IsIEJhY2tJbnNlcnRJdGVyYXRvcikK K3sKKyAgICBWZWN0b3I8aW50PiB2ZWN0b3IgPSB7IDEsIDIsIDMsIDQgfTsKKyAgICAKKyAgICBh dXRvIGluc2VydEl0ID0gc3RkOjpiYWNrX2luc2VydGVyKHZlY3Rvcik7CisgICAgaW5zZXJ0SXQg PSA1OworICAgIGluc2VydEl0ID0gNjsKKworICAgIEVYUEVDVF9FUSg1LCB2ZWN0b3JbNF0pOwor ICAgIEVYUEVDVF9FUSg2LCB2ZWN0b3JbNV0pOworfQorCiBURVNUKFdURl9WZWN0b3IsIE1vdmVP bmx5X1VuY2hlY2tlZEFwcGVuZCkKIHsKICAgICBWZWN0b3I8TW92ZU9ubHk+IHZlY3RvcjsK