137410 2014-10-03 15:51:48 -0700 Bugzilla status bubble displays an exception showing attachment 175738 2014-10-03 16:49:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://webkit-queues.appspot.com/status-bubble/175738 P2 Normal --- 1 ap ap rniwa oldest_to_newest 1039383 0 ap 2014-10-03 15:51:48 -0700 This old attachment has an incorrect status queue log. We should be tolerant of that. 1039385 1 239247 ap 2014-10-03 15:54:20 -0700 Created attachment 239247 proposed fix 1039407 2 239247 thorton 2014-10-03 16:33:22 -0700 Comment on attachment 239247 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review > Tools/QueueStatusServer/app.yaml:2 > +version: ap # Bugzilla bug ID of last major change please fix the comment. > Tools/QueueStatusServer/handlers/statusbubble.py:141 > + message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer 1039410 3 ap 2014-10-03 16:37:08 -0700 Committed <http://trac.webkit.org/r174303>. 1039412 4 239247 thorton 2014-10-03 16:37:43 -0700 Comment on attachment 239247 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review >> Tools/QueueStatusServer/handlers/statusbubble.py:141 >> + message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message > > IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer Nevermind! 1039414 5 ap 2014-10-03 16:49:20 -0700 Actually committed in 174304 239247 2014-10-03 15:54:20 -0700 2014-10-03 16:37:43 -0700 proposed fix Exception.txt text/plain 3762 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NDI5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE0LTEwLTAzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEJ1Z3ppbGxhIHN0YXR1cyBidWJibGUgZGlzcGxheXMgYW4gZXhjZXB0aW9u IHNob3dpbmcgYXR0YWNobWVudCAxNzU3MzgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNzQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvYXBwLnlhbWw6IFVwZGF0ZSB2 ZXJzaW9uLgorCisgICAgICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxlcnMvc3RhdHVzYnVi YmxlLnB5OiAoU3RhdHVzQnViYmxlLl9idWlsZF9idWJibGUpOgorICAgICAgICBEb24ndCBmYWls IGV2ZW4gaWYgZXhwZWN0ZWQgc3RhdHVzIG1lc3NhZ2UgaXMgbWlzc2luZy4KKworICAgICAgICAq IFF1ZXVlU3RhdHVzU2VydmVyL21vZGVsL3BhdGNobG9nLnB5OiAoUGF0Y2hMb2cpOiBRdWljayB1 bnJlbGF0ZWQgZml4IC0gZGVmaW5lCisgICAgICAgIHRoZSBmaWVsZCBpbiB0aGUgc2FtZSB3YXkg aXQncyBkZWZpbmVkIGluIFF1ZXVlU3RhdHVzIHRhYmxlLgorCiAyMDE0LTEwLTAzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJlY29yZCBsYXRlc3QgbWVz c2FnZSBpbiBQYXRjaExvZyBmb3IgcXVpY2sgYWNjZXNzCkluZGV4OiBUb29scy9RdWV1ZVN0YXR1 c1NlcnZlci9hcHAueWFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9h cHAueWFtbAkocmV2aXNpb24gMTc0MjkxKQorKysgVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvYXBw LnlhbWwJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiBhcHBsaWNhdGlvbjogd2Via2l0 LXF1ZXVlcwotdmVyc2lvbjogMTc0MjkxICMgQnVnemlsbGEgYnVnIElEIG9mIGxhc3QgbWFqb3Ig Y2hhbmdlCit2ZXJzaW9uOiBhcCAjIEJ1Z3ppbGxhIGJ1ZyBJRCBvZiBsYXN0IG1ham9yIGNoYW5n ZQogcnVudGltZTogcHl0aG9uCiBhcGlfdmVyc2lvbjogMQogCkluZGV4OiBUb29scy9RdWV1ZVN0 YXR1c1NlcnZlci9oYW5kbGVycy9zdGF0dXNidWJibGUucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv UXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxlcnMvc3RhdHVzYnViYmxlLnB5CShyZXZpc2lvbiAxNzQy OTApCisrKyBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9zdGF0dXNidWJibGUucHkJ KHdvcmtpbmcgY29weSkKQEAgLTEzOCw3ICsxMzgsOCBAQCBjbGFzcyBTdGF0dXNCdWJibGUod2Vi YXBwLlJlcXVlc3RIYW5kbGVyCiAgICAgICAgICAgICAgICAgYnViYmxlWyJkZXRhaWxzX21lc3Nh Z2UiXSA9ICJQYXNzXG5cbiIgKyBzZWxmLl9pc29fdGltZShzdGF0dXNlc1swXS5kYXRlKQogICAg ICAgICAgICAgZWxpZiBzdGF0dXNlc1swXS5tZXNzYWdlID09ICJGYWlsIjoKICAgICAgICAgICAg ICAgICBidWJibGVbInN0YXRlIl0gPSAiZmFpbCIKLSAgICAgICAgICAgICAgICBidWJibGVbImRl dGFpbHNfbWVzc2FnZSJdID0gc3RhdHVzZXNbMV0ubWVzc2FnZSArICJcblxuIiArIHNlbGYuX2lz b190aW1lKHN0YXR1c2VzWzBdLmRhdGUpCisgICAgICAgICAgICAgICAgbWVzc2FnZV90b19kaXNw bGF5ID0gc3RhdHVzZXNbMV0ubWVzc2FnZSBpZiBsZW4oc3RhdHVzZXMpID4gMSBlbHNlIHN0YXR1 c2VzWzBdLm1lc3NhZ2UKKyAgICAgICAgICAgICAgICBidWJibGVbImRldGFpbHNfbWVzc2FnZSJd ID0gbWVzc2FnZV90b19kaXNwbGF5ICsgIlxuXG4iICsgc2VsZi5faXNvX3RpbWUoc3RhdHVzZXNb MF0uZGF0ZSkKICAgICAgICAgICAgIGVsaWYgc3RhdHVzZXNbMF0ubWVzc2FnZSA9PSAiRXJyb3I6 ICIgKyBxdWV1ZS5uYW1lKCkgKyAiIGRpZCBub3QgcHJvY2VzcyBwYXRjaC4iOgogICAgICAgICAg ICAgICAgIGJ1YmJsZVsic3RhdGUiXSA9ICJub25lIgogICAgICAgICAgICAgICAgIGJ1YmJsZVsi ZGV0YWlsc19tZXNzYWdlIl0gPSAiVGhlIHBhdGNoIGlzIG5vIGxvbmdlciBlbGlnaWJsZSBmb3Ig cHJvY2Vzc2luZy4iCkBAIC0xNTAsNyArMTUxLDggQEAgY2xhc3MgU3RhdHVzQnViYmxlKHdlYmFw cC5SZXF1ZXN0SGFuZGxlcgogICAgICAgICAgICAgICAgICAgICBidWJibGVbImRldGFpbHNfbWVz c2FnZSJdICs9ICJcbiIuam9pbihbc3RhdHVzLm1lc3NhZ2UgZm9yIHN0YXR1cyBpbiBzdGF0dXNl c1sxOl1dKSArICJcblxuIiArIHNlbGYuX2lzb190aW1lKHN0YXR1c2VzWzBdLmRhdGUpCiAgICAg ICAgICAgICBlbGlmIHN0YXR1c2VzWzBdLm1lc3NhZ2UgPT0gIkVycm9yOiAiICsgcXVldWUubmFt ZSgpICsgIiB1bmFibGUgdG8gYXBwbHkgcGF0Y2guIjoKICAgICAgICAgICAgICAgICBidWJibGVb InN0YXRlIl0gPSAiZmFpbCIKLSAgICAgICAgICAgICAgICBidWJibGVbImRldGFpbHNfbWVzc2Fn ZSJdID0gc3RhdHVzZXNbMV0ubWVzc2FnZSArICJcblxuIiArIHNlbGYuX2lzb190aW1lKHN0YXR1 c2VzWzBdLmRhdGUpCisgICAgICAgICAgICAgICAgbWVzc2FnZV90b19kaXNwbGF5ID0gc3RhdHVz ZXNbMV0ubWVzc2FnZSBpZiBsZW4oc3RhdHVzZXMpID4gMSBlbHNlIHN0YXR1c2VzWzBdLm1lc3Nh Z2UKKyAgICAgICAgICAgICAgICBidWJibGVbImRldGFpbHNfbWVzc2FnZSJdID0gbWVzc2FnZV90 b19kaXNwbGF5ICsgIlxuXG4iICsgc2VsZi5faXNvX3RpbWUoc3RhdHVzZXNbMF0uZGF0ZSkKICAg ICAgICAgICAgICAgICBidWJibGVbImZhaWxlZF90b19hcHBseSJdID0gVHJ1ZQogICAgICAgICAg ICAgZWxpZiBzdGF0dXNlc1swXS5tZXNzYWdlLnN0YXJ0c3dpdGgoIkVycm9yOiAiKToKICAgICAg ICAgICAgICAgICBidWJibGVbInN0YXRlIl0gPSAiZXJyb3IiCkluZGV4OiBUb29scy9RdWV1ZVN0 YXR1c1NlcnZlci9tb2RlbC9wYXRjaGxvZy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdWV1ZVN0 YXR1c1NlcnZlci9tb2RlbC9wYXRjaGxvZy5weQkocmV2aXNpb24gMTc0MjkxKQorKysgVG9vbHMv UXVldWVTdGF0dXNTZXJ2ZXIvbW9kZWwvcGF0Y2hsb2cucHkJKHdvcmtpbmcgY29weSkKQEAgLTQx LDcgKzQxLDcgQEAgY2xhc3MgUGF0Y2hMb2coZGIuTW9kZWwpOgogICAgIGZpbmlzaGVkID0gZGIu Qm9vbGVhblByb3BlcnR5KGRlZmF1bHQ9RmFsc2UpCiAgICAgd2FpdF9kdXJhdGlvbiA9IGRiLklu dGVnZXJQcm9wZXJ0eSgpCiAgICAgcHJvY2Vzc19kdXJhdGlvbiA9IGRiLkludGVnZXJQcm9wZXJ0 eSgpCi0gICAgbGF0ZXN0X21lc3NhZ2UgPSBkYi5TdHJpbmdQcm9wZXJ0eSgpCisgICAgbGF0ZXN0 X21lc3NhZ2UgPSBkYi5TdHJpbmdQcm9wZXJ0eShtdWx0aWxpbmU9VHJ1ZSkKIAogICAgIEBjbGFz c21ldGhvZAogICAgIGRlZiBsb29rdXAoY2xzLCBhdHRhY2htZW50X2lkLCBxdWV1ZV9uYW1lKToK