<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137401</bug_id>
          
          <creation_ts>2014-10-03 13:51:44 -0700</creation_ts>
          <short_desc>[CSS Font Loading] Decrement the font loading count before notifying callbacks</short_desc>
          <delta_ts>2014-10-09 12:32:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>135390</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Bear Travis">betravis</reporter>
          <assigned_to name="Bear Travis">betravis</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1039326</commentid>
    <comment_count>0</comment_count>
    <who name="Bear Travis">betravis</who>
    <bug_when>2014-10-03 13:51:44 -0700</bug_when>
    <thetext>http/tests/webfont/fontloader-loading-attribute.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039394</commentid>
    <comment_count>1</comment_count>
    <who name="Bear Travis">betravis</who>
    <bug_when>2014-10-03 16:13:48 -0700</bug_when>
    <thetext>The font loader currently decrements the number of fonts loading after notifying callbacks. This means that the document.fonts.loading will return true when accessed within a callback for document.fonts.loadFont.

We should instead decrement the font loading count before calling callbacks.

This caused the above test failure when the number of fonts loading from JS was added to the loading() test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039408</commentid>
    <comment_count>2</comment_count>
      <attachid>239253</attachid>
    <who name="Bear Travis">betravis</who>
    <bug_when>2014-10-03 16:35:10 -0700</bug_when>
    <thetext>Created attachment 239253
Initial Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1040622</commentid>
    <comment_count>3</comment_count>
      <attachid>239253</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-09 11:46:27 -0700</bug_when>
    <thetext>Comment on attachment 239253
Initial Patch

Rejecting attachment 239253 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.appspot.com&apos;, &apos;--bot-id=webkit-cq-03&apos;, &apos;apply-attachment&apos;, &apos;--no-update&apos;, &apos;--non-interactive&apos;, 239253, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/css/FontLoader.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1392.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;, &apos;--reviewer&apos;, u&apos;Alexey Proskuryakov&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6541415739817984</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1040639</commentid>
    <comment_count>4</comment_count>
    <who name="Bear Travis">betravis</who>
    <bug_when>2014-10-09 12:32:18 -0700</bug_when>
    <thetext>Not sure of the hiccup, but this landed in http://trac.webkit.org/changeset/174515.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239253</attachid>
            <date>2014-10-03 16:35:10 -0700</date>
            <delta_ts>2014-10-09 11:46:27 -0700</delta_ts>
            <desc>Initial Patch</desc>
            <filename>bug-137401-20141003163512.patch</filename>
            <type>text/plain</type>
            <size>3235</size>
            <attacher name="Bear Travis">betravis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU0YzVlY2Y4NTZmMzU5
ZWI3YzE4Y2ZmOGVlMDliYzMxMmRlZjNlZS4uZTdmNzNmM2U0YzEyZWQ5M2I2MjMwMzg5MTJlYjI2
OGEyYjZlZmIxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTEwLTAzICBCZWFy
IFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIEZvbnQgTG9hZGlu
Z10gRGVjcmVtZW50IHRoZSBmb250IGxvYWRpbmcgY291bnQgYmVmb3JlIG5vdGlmeWluZyBjYWxs
YmFja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz
NzQwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu
IHRoZSBjYWxsYmFja3MsIGl0IHNob3VsZCBhcHBlYXIgdGhhdCBmb250IGxvYWQgaGFzIGNvbXBs
ZXRlZC4gVGhpcyBpcworICAgICAgICBhY2Nlc3NlZCB0aHJvdWdoIGxvYWRpbmcoKSwgd2hpY2gg
cmVsaWVzIG9uIHRoZSBjdXJyZW50IG51bWJlciBvZgorICAgICAgICBmb250cyBsb2FkaW5nIHZp
YSBKUyBhbmQgQ1NTLgorCisgICAgICAgIFVuc2tpcHBpbmcgdGhlIGZhaWxpbmcgdGVzdCBodHRw
L3Rlc3RzL3dlYmZvbnQvZm9udGxvYWRlci1sb2FkaW5nLWF0dHJpYnV0ZS5odG1sCisgICAgICAg
IHRlc3Qgd2hpY2ggdGVzdHMgdGhpcy4KKworICAgICAgICAqIGNzcy9Gb250TG9hZGVyLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OkxvYWRGb250Q2FsbGJhY2s6Om5vdGlmeUxvYWRlZCk6CisKIDIw
MTQtMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg
IFVzZSBpczw+KCkgLyBkb3duY2FzdDw+KCkgZm9yIENTU1ZhbHVlIHN1YmNsYXNzZXMKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl
L2Nzcy9Gb250TG9hZGVyLmNwcAppbmRleCA2ZWRmYTc0NTU1YjcxZDRjM2E1Y2M3YmViMGU0NjNm
MzgxZGQwNGNmLi5jNWY4Y2IzMzhiMzg0OGFiNTZhZDAyNTg4MGY5ODdiYWQyOGQ4NzViIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvRm9udExvYWRlci5jcHAKKysrIGIvU291cmNlL1dl
YkNvcmUvY3NzL0ZvbnRMb2FkZXIuY3BwCkBAIC05NSw2ICs5NSw4IEBAIHZvaWQgTG9hZEZvbnRD
YWxsYmFjazo6bm90aWZ5TG9hZGVkKCkKICAgICBpZiAobV9udW1Mb2FkaW5nKQogICAgICAgICBy
ZXR1cm47CiAKKyAgICBtX2ZvbnRMb2FkZXIubG9hZEZvbnREb25lKCp0aGlzKTsKKwogICAgIGlm
IChtX2Vycm9yT2NjdXJlZCkgewogICAgICAgICBpZiAobV9lcnJvckNhbGxiYWNrKQogICAgICAg
ICAgICAgbV9lcnJvckNhbGxiYWNrLT5oYW5kbGVFdmVudCgpOwpAQCAtMTAyLDcgKzEwNCw2IEBA
IHZvaWQgTG9hZEZvbnRDYWxsYmFjazo6bm90aWZ5TG9hZGVkKCkKICAgICAgICAgaWYgKG1fbG9h
ZENhbGxiYWNrKQogICAgICAgICAgICAgbV9sb2FkQ2FsbGJhY2stPmhhbmRsZUV2ZW50KCk7CiAg
ICAgfQotICAgIG1fZm9udExvYWRlci5sb2FkRm9udERvbmUoKnRoaXMpOwogfQogCiB2b2lkIExv
YWRGb250Q2FsbGJhY2s6Om5vdGlmeUVycm9yKCkgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D
aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWIzMTFjOWVhYjM3MmNjOWUw
M2Q2ODE4MmExMGNhODM4NjIzMzU0Ny4uN2I3N2IzZTg2MWJiYTQxZDdjYzc3OWRkMGIyOTUwYTM4
NTUwYzYwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl
c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTEwLTAzICBCZWFyIFRyYXZpcyAg
PGJldHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIEZvbnQgTG9hZGluZ10gRGVjcmVt
ZW50IHRoZSBmb250IGxvYWRpbmcgY291bnQgYmVmb3JlIG5vdGlmeWluZyBjYWxsYmFja3MKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzQwMQorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v
bWFjL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCB0aGUgdGVzdCB0aGlzIGJ1ZyB3YXMgY2F1c2lu
ZyB0byBmYWlsLgorCiAyMDE0LTEwLTAzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Vi
a2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTc0Mjc1LgpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlv
dXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwMjU0ZmJiZGIzNWM1
NDM5MTExZTVkOGE4NzdjN2UwYzllMTUzMDY0Li42OWU0NzY0MzhlMWZkYmE1ZmYxMGI5YWU4NWFi
ZjBkYzZhMzYxOWVmIDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4
cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9u
cwpAQCAtMTM5Miw3ICsxMzkyLDcgQEAgd2Via2l0Lm9yZy9iLzEzNTM5MCBmYXN0L2Nzcy9mb250
bG9hZGVyLW11bHRpcGxlLWZhY2VzLWRvd25sb2FkLWVycm9yLmh0bWwgWyBQYXMKIHdlYmtpdC5v
cmcvYi8xMzUzOTAgZmFzdC9jc3MvZm9udGxvYWRlci1tdWx0aXBsZS1mYWNlcy5odG1sIFsgUGFz
cyBdCiB3ZWJraXQub3JnL2IvMTM1MzkwIGZhc3QvY3NzL2ZvbnRsb2FkZXItbXVsdGlwbGUtZmFt
aWxpZXMuaHRtbCBbIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEzNTM5MCBmYXN0L2Nzcy9mb250bG9h
ZGVyLXBhZ2UtY2FjaGUuaHRtbCBbIFBhc3MgXQotd2Via2l0Lm9yZy9iLzEzNTM5MCBodHRwL3Rl
c3RzL3dlYmZvbnQvZm9udGxvYWRlci1sb2FkaW5nLWF0dHJpYnV0ZS5odG1sIFsgU2tpcCBdCit3
ZWJraXQub3JnL2IvMTM1MzkwIGh0dHAvdGVzdHMvd2ViZm9udC9mb250bG9hZGVyLWxvYWRpbmct
YXR0cmlidXRlLmh0bWwgWyBQYXNzIF0KIAogd2Via2l0Lm9yZy9iLzEzNjk5NCBodHRwL3Rlc3Rz
L21lZGlhL2hscy92aWRlby1jb29raWUuaHRtbCBbIEZhaWx1cmUgXQogCg==
</data>
<flag name="review"
          id="263963"
          type_id="1"
          status="+"
          setter="ap"
    />
    <flag name="commit-queue"
          id="264280"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>