<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137389</bug_id>
          
          <creation_ts>2014-10-03 04:34:52 -0700</creation_ts>
          <short_desc>[GTK] Do not generate a symlink in derived sources for every header in WebCore/bindings/gobject</short_desc>
          <delta_ts>2014-10-05 00:41:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>130075</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>gustavo</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
    
    <cc>rakuco</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1039183</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-03 04:34:52 -0700</bug_when>
    <thetext>We only need a symlink for static sources that are included in public generated headers, because they are added with as &lt;webkitdom/WebKitDOMFoo.h&gt; so they need to be inside a webkitdom directory. Also use proper targets and commands to create the symlinks only when needed instead of for every build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039184</commentid>
    <comment_count>1</comment_count>
      <attachid>239199</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-03 04:36:58 -0700</bug_when>
    <thetext>Created attachment 239199
Patch

This removes one of the targets that are always built, see bug #130075</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039217</commentid>
    <comment_count>2</comment_count>
      <attachid>239199</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-10-03 09:01:25 -0700</bug_when>
    <thetext>Comment on attachment 239199
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239199&amp;action=review

&gt; Source/WebCore/PlatformGTK.cmake:770
&gt; +# Some of the static headers are included by generated public headers with include &lt;webkitdom/WebKitDOMFoo.h&gt;.
&gt; +# We need those headers in the derived sources to be in webkitdom directory.
&gt; +add_custom_command(
&gt; +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMCustom.h
&gt; +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustom.h
&gt; +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustom.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
&gt; +)
&gt; +add_custom_command(
&gt; +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMEventTarget.h
&gt; +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMEventTarget.h
&gt; +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMEventTarget.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
&gt; +)
&gt; +add_custom_command(
&gt; +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMNodeFilter.h
&gt; +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMNodeFilter.h
&gt; +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMNodeFilter.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
&gt; +)
&gt; +add_custom_command(
&gt; +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMObject.h
&gt; +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMObject.h
&gt; +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMObject.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
&gt; +)
&gt; +add_custom_command(
&gt; +    OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMXPathNSResolver.h
&gt; +    DEPENDS ${WEBCORE_DIR}/bindings/gobject/WebKitDOMXPathNSResolver.h
&gt; +    COMMAND ln -n -s -f ${WEBCORE_DIR}/bindings/gobject/WebKitDOMXPathNSResolver.h ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}
&gt; +)
&gt; +add_custom_target(fake-generated-webkitdom-headers
&gt; +    DEPENDS ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMCustom.h
&gt; +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMEventTarget.h
&gt; +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMNodeFilter.h
&gt; +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMObject.h
&gt; +            ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/WebKitDOMXPathNSResolver.h

I think there are a couple ways to make this a little cleaner. One is to use a macro and a list of file names (you could even omit the directories). The other is to use a single add_custom_command with multiple outputs and dependencies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039231</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-03 09:20:23 -0700</bug_when>
    <thetext>I guess I prefer the macro solution, not sure I will find the time to learn how to do that in cmake, though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039264</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-10-03 10:56:55 -0700</bug_when>
    <thetext>Let me see if I can find a few moments to propose something this weekend.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039483</commentid>
    <comment_count>5</comment_count>
      <attachid>239273</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-04 01:34:36 -0700</bug_when>
    <thetext>Created attachment 239273
Simplified version using a foreach loop

Hope this is cleaner</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039583</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-05 00:41:24 -0700</bug_when>
    <thetext>Committed r174326: &lt;http://trac.webkit.org/changeset/174326&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239199</attachid>
            <date>2014-10-03 04:36:58 -0700</date>
            <delta_ts>2014-10-04 01:34:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wcore-fake-generated-headers.diff</filename>
            <type>text/plain</type>
            <size>4230</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA5Y2E3YTMwLi41ZjkyNWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTQtMTAtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgorCisgICAgICAgIFtHVEtdIERvIG5vdCBnZW5lcmF0ZSBhIHN5bWxpbmsgaW4gZGVyaXZlZCBz
b3VyY2VzIGZvciBldmVyeSBoZWFkZXIgaW4gV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzczODkKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvbmx5IG5lZWQg
YSBzeW1saW5rIGZvciBzdGF0aWMgc291cmNlcyB0aGF0IGFyZSBpbmNsdWRlZCBpbgorICAgICAg
ICBwdWJsaWMgZ2VuZXJhdGVkIGhlYWRlcnMsIGJlY2F1c2UgdGhleSBhcmUgYWRkZWQgd2l0aCBh
cworICAgICAgICA8d2Via2l0ZG9tL1dlYktpdERPTUZvby5oPiBzbyB0aGV5IG5lZWQgdG8gYmUg
aW5zaWRlIGEgd2Via2l0ZG9tCisgICAgICAgIGRpcmVjdG9yeS4gQWxzbyB1c2UgcHJvcGVyIHRh
cmdldHMgYW5kIGNvbW1hbmRzIHRvIGNyZWF0ZSB0aGUKKyAgICAgICAgc3ltbGlua3Mgb25seSB3
aGVuIG5lZWRlZCBpbnN0ZWFkIG9mIGZvciBldmVyeSBidWlsZC4KKworICAgICAgICAqIFBsYXRm
b3JtR1RLLmNtYWtlOgorCiAyMDE0LTEwLTAzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1A
c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gRml4IGJ1aWxkIGJyZWFrIHNpbmNlIHIxNzQy
MzEgYW5kIHIxNzQyNTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt
YWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggMzQ5YzYxZS4uODM5
MGU2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIv
U291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTQ1OSw2ICs0NTksNyBAQCB0YXJn
ZXRfbGlua19saWJyYXJpZXMoV2ViQ29yZVBsYXRmb3JtR1RLCiAKIGluY2x1ZGVfZGlyZWN0b3Jp
ZXMoCiAgICAgJHtXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVN9CisgICAgIiR7V0VCQ09SRV9E
SVJ9L2JpbmRpbmdzL2dvYmplY3QvIgogICAgICIke0RFUklWRURfU09VUkNFU19ESVJ9IgogICAg
ICIke0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9IgogKQpAQCAtNzM0
LDggKzczNSwzOSBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgQ09NTUFORCBlY2hvICR7R09i
amVjdERPTUJpbmRpbmdzU3RhYmxlX0NMQVNTX0xJU1R9IHwgJHtQRVJMX0VYRUNVVEFCTEV9ICR7
V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMvZ29iamVjdC1nZW5lcmF0ZS1oZWFkZXJzLnBs
IGdkb20gPiAke0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9L3dlYmtp
dGRvbS5oCiApCiAKLWFkZF9jdXN0b21fdGFyZ2V0KGZha2UtaW5zdGFsbGVkLXdlYmtpdGRvbS1o
ZWFkZXJzCi0gICAgQ09NTUFORCBsbiAtbiAtcyAtZiAke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9n
b2JqZWN0LyouaCAke0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9Cisj
IFNvbWUgb2YgdGhlIHN0YXRpYyBoZWFkZXJzIGFyZSBpbmNsdWRlZCBieSBnZW5lcmF0ZWQgcHVi
bGljIGhlYWRlcnMgd2l0aCBpbmNsdWRlIDx3ZWJraXRkb20vV2ViS2l0RE9NRm9vLmg+LgorIyBX
ZSBuZWVkIHRob3NlIGhlYWRlcnMgaW4gdGhlIGRlcml2ZWQgc291cmNlcyB0byBiZSBpbiB3ZWJr
aXRkb20gZGlyZWN0b3J5LgorYWRkX2N1c3RvbV9jb21tYW5kKAorICAgIE9VVFBVVCAke0RFUklW
RURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9L1dlYktpdERPTUN1c3RvbS5oCisg
ICAgREVQRU5EUyAke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3Rv
bS5oCisgICAgQ09NTUFORCBsbiAtbiAtcyAtZiAke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9nb2Jq
ZWN0L1dlYktpdERPTUN1c3RvbS5oICR7REVSSVZFRF9TT1VSQ0VTX0dPQkpFQ1RfRE9NX0JJTkRJ
TkdTX0RJUn0KKykKK2FkZF9jdXN0b21fY29tbWFuZCgKKyAgICBPVVRQVVQgJHtERVJJVkVEX1NP
VVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElSfS9XZWJLaXRET01FdmVudFRhcmdldC5oCisg
ICAgREVQRU5EUyAke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUV2ZW50
VGFyZ2V0LmgKKyAgICBDT01NQU5EIGxuIC1uIC1zIC1mICR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdz
L2dvYmplY3QvV2ViS2l0RE9NRXZlbnRUYXJnZXQuaCAke0RFUklWRURfU09VUkNFU19HT0JKRUNU
X0RPTV9CSU5ESU5HU19ESVJ9CispCithZGRfY3VzdG9tX2NvbW1hbmQoCisgICAgT1VUUFVUICR7
REVSSVZFRF9TT1VSQ0VTX0dPQkpFQ1RfRE9NX0JJTkRJTkdTX0RJUn0vV2ViS2l0RE9NTm9kZUZp
bHRlci5oCisgICAgREVQRU5EUyAke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9nb2JqZWN0L1dlYktp
dERPTU5vZGVGaWx0ZXIuaAorICAgIENPTU1BTkQgbG4gLW4gLXMgLWYgJHtXRUJDT1JFX0RJUn0v
YmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01Ob2RlRmlsdGVyLmggJHtERVJJVkVEX1NPVVJDRVNf
R09CSkVDVF9ET01fQklORElOR1NfRElSfQorKQorYWRkX2N1c3RvbV9jb21tYW5kKAorICAgIE9V
VFBVVCAke0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9L1dlYktpdERP
TU9iamVjdC5oCisgICAgREVQRU5EUyAke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9nb2JqZWN0L1dl
YktpdERPTU9iamVjdC5oCisgICAgQ09NTUFORCBsbiAtbiAtcyAtZiAke1dFQkNPUkVfRElSfS9i
aW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTU9iamVjdC5oICR7REVSSVZFRF9TT1VSQ0VTX0dPQkpF
Q1RfRE9NX0JJTkRJTkdTX0RJUn0KKykKK2FkZF9jdXN0b21fY29tbWFuZCgKKyAgICBPVVRQVVQg
JHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElSfS9XZWJLaXRET01YUGF0
aE5TUmVzb2x2ZXIuaAorICAgIERFUEVORFMgJHtXRUJDT1JFX0RJUn0vYmluZGluZ3MvZ29iamVj
dC9XZWJLaXRET01YUGF0aE5TUmVzb2x2ZXIuaAorICAgIENPTU1BTkQgbG4gLW4gLXMgLWYgJHtX
RUJDT1JFX0RJUn0vYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01YUGF0aE5TUmVzb2x2ZXIuaCAk
e0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9CispCithZGRfY3VzdG9t
X3RhcmdldChmYWtlLWdlbmVyYXRlZC13ZWJraXRkb20taGVhZGVycworICAgIERFUEVORFMgJHtE
RVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElSfS9XZWJLaXRET01DdXN0b20u
aAorICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElS
fS9XZWJLaXRET01FdmVudFRhcmdldC5oCisgICAgICAgICAgICAke0RFUklWRURfU09VUkNFU19H
T0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9L1dlYktpdERPTU5vZGVGaWx0ZXIuaAorICAgICAgICAg
ICAgJHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElSfS9XZWJLaXRET01P
YmplY3QuaAorICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElO
R1NfRElSfS9XZWJLaXRET01YUGF0aE5TUmVzb2x2ZXIuaAogKQogCiBzZXQoR09iamVjdERPTUJp
bmRpbmdzX0lETF9GSUxFUyAke0dPYmplY3RET01CaW5kaW5nc1N0YWJsZV9JRExfRklMRVN9ICR7
R09iamVjdERPTUJpbmRpbmdzVW5zdGFibGVfSURMX0ZJTEVTfSkKQEAgLTc2Miw3ICs3OTQsNyBA
QCBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTKEdPYmplY3RET01CaW5kaW5ncykKIAog
YWRkX2RlcGVuZGVuY2llcyhHT2JqZWN0RE9NQmluZGluZ3MKICAgICBXZWJDb3JlCi0gICAgZmFr
ZS1pbnN0YWxsZWQtd2Via2l0ZG9tLWhlYWRlcnMKKyAgICBmYWtlLWdlbmVyYXRlZC13ZWJraXRk
b20taGVhZGVycwogKQogCiBmaWxlKFdSSVRFICR7Q01BS0VfQklOQVJZX0RJUn0vZ3RrZG9jLXdl
YmtpdGRvbS5jZmcK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239273</attachid>
            <date>2014-10-04 01:34:36 -0700</date>
            <delta_ts>2014-10-04 13:47:40 -0700</delta_ts>
            <desc>Simplified version using a foreach loop</desc>
            <filename>wkdom-fake-generated-webkitdom-headers.diff</filename>
            <type>text/plain</type>
            <size>3488</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA5ZTg1ODhmLi5lMzA2MTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTQtMTAtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgorCisgICAgICAgIFtHVEtdIERvIG5vdCBnZW5lcmF0ZSBhIHN5bWxpbmsgaW4gZGVyaXZlZCBz
b3VyY2VzIGZvciBldmVyeSBoZWFkZXIgaW4gV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzczODkKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvbmx5IG5lZWQg
YSBzeW1saW5rIGZvciBzdGF0aWMgc291cmNlcyB0aGF0IGFyZSBpbmNsdWRlZCBpbgorICAgICAg
ICBwdWJsaWMgZ2VuZXJhdGVkIGhlYWRlcnMsIGJlY2F1c2UgdGhleSBhcmUgYWRkZWQgd2l0aCBh
cworICAgICAgICA8d2Via2l0ZG9tL1dlYktpdERPTUZvby5oPiBzbyB0aGV5IG5lZWQgdG8gYmUg
aW5zaWRlIGEgd2Via2l0ZG9tCisgICAgICAgIGRpcmVjdG9yeS4gQWxzbyB1c2UgcHJvcGVyIHRh
cmdldHMgYW5kIGNvbW1hbmRzIHRvIGNyZWF0ZSB0aGUKKyAgICAgICAgc3ltbGlua3Mgb25seSB3
aGVuIG5lZWRlZCBpbnN0ZWFkIG9mIGZvciBldmVyeSBidWlsZC4KKworICAgICAgICAqIFBsYXRm
b3JtR1RLLmNtYWtlOgorCiAyMDE0LTEwLTA0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdh
bGlhLmNvbT4KIAogICAgICAgICBbVGV4TWFwXSBSZW1vdmUgUURvYyBjb21tZW50cyBpbiBHcmFw
aGljc0xheWVyVGV4dHVyZU1hcHBlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZv
cm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCAzNDlj
NjFlLi5kYTg2MjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFr
ZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtNDU5LDYgKzQ1OSw3
IEBAIHRhcmdldF9saW5rX2xpYnJhcmllcyhXZWJDb3JlUGxhdGZvcm1HVEsKIAogaW5jbHVkZV9k
aXJlY3RvcmllcygKICAgICAke1dlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFU30KKyAgICAiJHtX
RUJDT1JFX0RJUn0vYmluZGluZ3MvZ29iamVjdC8iCiAgICAgIiR7REVSSVZFRF9TT1VSQ0VTX0RJ
Un0iCiAgICAgIiR7REVSSVZFRF9TT1VSQ0VTX0dPQkpFQ1RfRE9NX0JJTkRJTkdTX0RJUn0iCiAp
CkBAIC02ODIsNyArNjgzLDkgQEAgaWYgKEVOQUJMRV9RVU9UQSkKICAgICApCiBlbmRpZiAoKQog
Ci1zZXQoR09iamVjdERPTUJpbmRpbmdzU3RhYmxlX0NMQVNTX0xJU1QgQ3VzdG9tIEV2ZW50VGFy
Z2V0IE5vZGVGaWx0ZXIgT2JqZWN0IFhQYXRoTlNSZXNvbHZlcikKK3NldChHT2JqZWN0RE9NQmlu
ZGluZ3NfU1RBVElDX0NMQVNTX0xJU1QgQ3VzdG9tIEV2ZW50VGFyZ2V0IE5vZGVGaWx0ZXIgT2Jq
ZWN0IFhQYXRoTlNSZXNvbHZlcikKKworc2V0KEdPYmplY3RET01CaW5kaW5nc1N0YWJsZV9DTEFT
U19MSVNUICR7R09iamVjdERPTUJpbmRpbmdzX1NUQVRJQ19DTEFTU19MSVNUfSkKIHNldChHT2Jq
ZWN0RE9NQmluZGluZ3NTdGFibGVfSU5TVEFMTEVEX0hFQURFUlMKICAgICAgJHtERVJJVkVEX1NP
VVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElSfS93ZWJraXRkb21kZWZpbmVzLmgKICAgICAg
JHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElSfS93ZWJraXRkb20uaApA
QCAtNzM0LDggKzczNywxOSBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgQ09NTUFORCBlY2hv
ICR7R09iamVjdERPTUJpbmRpbmdzU3RhYmxlX0NMQVNTX0xJU1R9IHwgJHtQRVJMX0VYRUNVVEFC
TEV9ICR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMvZ29iamVjdC1nZW5lcmF0ZS1oZWFk
ZXJzLnBsIGdkb20gPiAke0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9
L3dlYmtpdGRvbS5oCiApCiAKLWFkZF9jdXN0b21fdGFyZ2V0KGZha2UtaW5zdGFsbGVkLXdlYmtp
dGRvbS1oZWFkZXJzCi0gICAgQ09NTUFORCBsbiAtbiAtcyAtZiAke1dFQkNPUkVfRElSfS9iaW5k
aW5ncy9nb2JqZWN0LyouaCAke0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19E
SVJ9CisjIFNvbWUgb2YgdGhlIHN0YXRpYyBoZWFkZXJzIGFyZSBpbmNsdWRlZCBieSBnZW5lcmF0
ZWQgcHVibGljIGhlYWRlcnMgd2l0aCBpbmNsdWRlIDx3ZWJraXRkb20vV2ViS2l0RE9NRm9vLmg+
LgorIyBXZSBuZWVkIHRob3NlIGhlYWRlcnMgaW4gdGhlIGRlcml2ZWQgc291cmNlcyB0byBiZSBp
biB3ZWJraXRkb20gZGlyZWN0b3J5LgorZm9yZWFjaCAoY2xhc3NuYW1lICR7R09iamVjdERPTUJp
bmRpbmdzX1NUQVRJQ19DTEFTU19MSVNUfSkKKyAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCisgICAg
ICAgIE9VVFBVVCAke0RFUklWRURfU09VUkNFU19HT0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9L1dl
YktpdERPTSR7Y2xhc3NuYW1lfS5oCisgICAgICAgIERFUEVORFMgJHtXRUJDT1JFX0RJUn0vYmlu
ZGluZ3MvZ29iamVjdC9XZWJLaXRET00ke2NsYXNzbmFtZX0uaAorICAgICAgICBDT01NQU5EIGxu
IC1uIC1zIC1mICR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NJHtjbGFz
c25hbWV9LmggJHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElSfQorICAg
ICkKKyAgICBsaXN0KEFQUEVORCBHT2JqZWN0RE9NQmluZGluZ3NfU1RBVElDX0dFTkVSQVRFRF9T
T1VSQ0VTICR7REVSSVZFRF9TT1VSQ0VTX0dPQkpFQ1RfRE9NX0JJTkRJTkdTX0RJUn0vV2ViS2l0
RE9NJHtjbGFzc25hbWV9LmgpCitlbmRmb3JlYWNoICgpCisKK2FkZF9jdXN0b21fdGFyZ2V0KGZh
a2UtZ2VuZXJhdGVkLXdlYmtpdGRvbS1oZWFkZXJzCisgICAgREVQRU5EUyAke0dPYmplY3RET01C
aW5kaW5nc19TVEFUSUNfR0VORVJBVEVEX1NPVVJDRVN9CiApCiAKIHNldChHT2JqZWN0RE9NQmlu
ZGluZ3NfSURMX0ZJTEVTICR7R09iamVjdERPTUJpbmRpbmdzU3RhYmxlX0lETF9GSUxFU30gJHtH
T2JqZWN0RE9NQmluZGluZ3NVbnN0YWJsZV9JRExfRklMRVN9KQpAQCAtNzYyLDcgKzc3Niw3IEBA
IFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MoR09iamVjdERPTUJpbmRpbmdzKQogCiBh
ZGRfZGVwZW5kZW5jaWVzKEdPYmplY3RET01CaW5kaW5ncwogICAgIFdlYkNvcmUKLSAgICBmYWtl
LWluc3RhbGxlZC13ZWJraXRkb20taGVhZGVycworICAgIGZha2UtZ2VuZXJhdGVkLXdlYmtpdGRv
bS1oZWFkZXJzCiApCiAKIGZpbGUoV1JJVEUgJHtDTUFLRV9CSU5BUllfRElSfS9ndGtkb2Mtd2Vi
a2l0ZG9tLmNmZwo=
</data>
<flag name="review"
          id="263982"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>