137387 2014-10-03 02:05:08 -0700 REGRESSION (r165896): UIWebView PDFs have a forced black background 2014-10-03 13:28:27 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton aestes andersca mitz sam simon.fraser oldest_to_newest 1039169 0 thorton 2014-10-03 02:05:08 -0700 I made a completely wrong change in http://trac.webkit.org/changeset/165896, trying to maintain Safari's black PDF background but swap to white if the PDF was empty to avoid an all-black view; but, we shouldn't be forcing a background color, as some (all?) clients don't use a black background. Remove that code. <rdar://problem/17948411> 1039170 1 239193 thorton 2014-10-03 02:07:01 -0700 Created attachment 239193 patch 1039171 2 239194 thorton 2014-10-03 02:07:01 -0700 Created attachment 239194 1039191 3 239193 ddkilzer 2014-10-03 05:02:57 -0700 Comment on attachment 239193 patch r=me 1039320 4 thorton 2014-10-03 13:28:27 -0700 http://trac.webkit.org/changeset/174284 239193 2014-10-03 02:07:01 -0700 2014-10-03 05:02:56 -0700 patch blackbackground.diff text/plain 3046 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv aW9zL0NoYW5nZUxvZwppbmRleCA1YzdjNjJiLi5iZWIwMmJkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2lvcy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9pb3MvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMjQgQEAKIDIwMTQtMTAtMDMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh cHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTiAocjE2NTg5Nik6IFVJV2ViVmlldyBQREZz IGhhdmUgYSBmb3JjZWQgYmxhY2sgYmFja2dyb3VuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3Mzg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x Nzk0ODQxMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVyLmg6CisgICAgICAgICogV2ViVmlldy9X ZWJQREZWaWV3UGxhY2Vob2xkZXIubW06CisgICAgICAgICgtW1dlYlBERlZpZXdQbGFjZWhvbGRl ciBsYXlvdXRdKToKKyAgICAgICAgUmVtb3ZlIGFuIGlsbC1hZHZpc2VkIGF0dGVtcHQgdG8gZm9y Y2UgdGhlIFBERiBiYWNrZ3JvdW5kIGNvbG9yIGZyb20gV2ViS2l0LgorICAgICAgICBUaGUgaWRl YSB3YXMgdGhhdCB3ZSB3b3VsZCBtYWludGFpbiBTYWZhcmkncyBibGFjayBiYWNrZ3JvdW5kIGV4 Y2VwdCBpZiB0aGVyZQorICAgICAgICB3ZXJlIG5vIHBhZ2VzIGluIHRoZSBQREYsIGluIHdoaWNo IGNhc2Ugd2Ugd291bGQgdXNlIHdoaXRlIGluc3RlYWQgdG8gYXZvaWQKKyAgICAgICAgaGF2aW5n IGFuIGFsbC1ibGFjayB2aWV3LiBIb3dldmVyLCB0aGlzIGJyb2tlIGNsaWVudHMgd2hvIGRpZG4n dCB3YW50IGEgYmxhY2sKKyAgICAgICAgYmFja2dyb3VuZCwgYmVjYXVzZSB3ZSB3ZXJlIG5vdyBm b3JjaW5nIGl0IHRvIGJsYWNrLiBBbHNvLCB3ZSBkb24ndCBuZWVkIHRvCisgICAgICAgIG1haW50 YWluIHRoZSBibGFjayBjb2xvciBpbiBTYWZhcmkgYmVjYXVzZSBpdCBkb2Vzbid0IHVzZSBXZWJQ REZWaWV3UGxhY2Vob2xkZXIgYW55bW9yZS4KKyAgICAgICAgVGhpcyB3YXNuJ3QgYW4gaW1wb3J0 YW50IHBhcnQgb2YgdGhlIHBhdGNoLCBpbiBhbnkgY2FzZS4KKworMjAxNC0xMC0wMyAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwogICAgICAgICBSRUdSRVNTSU9OIChy MTczMjY1KTogVUlXZWJWaWV3IFBERiBsb2FkaW5nIGlzIGNvbXBsZXRlbHkgYnJva2VuCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzczODYKICAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE4NTI0NzE3PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9p b3MvV2ViVmlldy9XZWJQREZWaWV3UGxhY2Vob2xkZXIuaCBiL1NvdXJjZS9XZWJLaXQvaW9zL1dl YlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVyLmgKaW5kZXggODVlNWY2ZC4uZWVmNTNiNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9pb3MvV2ViVmlldy9XZWJQREZWaWV3UGxhY2Vob2xkZXIu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dlYlBERlZpZXdQbGFjZWhvbGRlci5o CkBAIC0xNjMsOCArMTYzLDYgQEAKICAqLwogLSAoQ0dQREZEb2N1bWVudFJlZiljZ1BERkRvY3Vt ZW50OwogCi0tICh2b2lkKXNldEJhY2tncm91bmRDb2xvcjooVUlDb2xvciAqKWJhY2tncm91bmRD b2xvcjsKLQogQGVuZAogCiAjZW5kaWYgLyogVEFSR0VUX09TX0lQSE9ORSAqLwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9pb3MvV2ViVmlldy9XZWJQREZWaWV3UGxhY2Vob2xkZXIubW0gYi9T b3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dlYlBERlZpZXdQbGFjZWhvbGRlci5tbQppbmRleCBk ZWMxYjk1Li5kMjYwNDAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dl YlBERlZpZXdQbGFjZWhvbGRlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dl YlBERlZpZXdQbGFjZWhvbGRlci5tbQpAQCAtMzIsNyArMzIsNiBAQAogI2ltcG9ydCA8SmF2YVNj cmlwdENvcmUvSlNDb250ZXh0UmVmLmg+CiAjaW1wb3J0IDxKYXZhU2NyaXB0Q29yZS9KU1N0cmlu Z1JlZi5oPgogI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvSlNTdHJpbmdSZWZDRi5oPgotI2ltcG9y dCA8VUlLaXQvVUlLaXQuaD4KICNpbXBvcnQgPFdlYkNvcmUvRGF0YVRyYW5zZmVyLmg+CiAjaW1w b3J0IDxXZWJDb3JlL0V2ZW50SGFuZGxlci5oPgogI2ltcG9ydCA8V2ViQ29yZS9FdmVudE5hbWVz Lmg+CkBAIC01Myw5ICs1Miw2IEBACiAjaW1wb3J0IDx3dGYvQ3VycmVudFRpbWUuaD4KICNpbXBv cnQgPHd0Zi9WZWN0b3IuaD4KIAotU09GVF9MSU5LX0ZSQU1FV09SSyhVSUtpdCkKLVNPRlRfTElO S19DTEFTUyhVSUtpdCwgVUlDb2xvcikKLQogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIEBp bnRlcmZhY2UgV2ViUERGVmlldyAoU2VjcmV0cykKQEAgLTIzMCwxMyArMjI2LDYgQEAgc3RhdGlj IGNvbnN0IGZsb2F0IFBBR0VfSEVJR0hUX0lOU0VUID0gNC4wZiAqIDIuMGY7CiAKICAgICBbc2Vs ZiBzZXRCb3VuZHNTaXplOmJvdW5kaW5nU2l6ZV07CiAKLSAgICBpZiAoW3NlbGYuZGVsZWdhdGUg cmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihzZXRCYWNrZ3JvdW5kQ29sb3I6KV0pIHsKLSAg ICAgICAgaWYgKENHU2l6ZUVxdWFsVG9TaXplKGJvdW5kaW5nU2l6ZSwgQ0dTaXplWmVybykpCi0g ICAgICAgICAgICBbc2VsZi5kZWxlZ2F0ZSBzZXRCYWNrZ3JvdW5kQ29sb3I6W2dldFVJQ29sb3JD bGFzcygpIHdoaXRlQ29sb3JdXTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgW3NlbGYuZGVs ZWdhdGUgc2V0QmFja2dyb3VuZENvbG9yOltnZXRVSUNvbG9yQ2xhc3MoKSBibGFja0NvbG9yXV07 Ci0gICAgfQotCiAgICAgX2RpZENvbXBsZXRlTGF5b3V0ID0gWUVTOwogICAgIFtzZWxmIF9ub3Rp ZnlEaWRDb21wbGV0ZUxheW91dF07CiB9Cg==