137385 2014-10-03 01:02:31 -0700 Netscape plugin API symbol used outside feature guards 2014-10-09 00:34:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac (Intel) OS X 10.9 RESOLVED FIXED P2 Normal --- 1 philip.chimento webkit-unassigned cgarcia commit-queue pnormand oldest_to_newest 1039157 0 philip.chimento 2014-10-03 01:02:31 -0700 When building with the netscape plugin API turned off, I get an undefined symbol m_NPP_Shutdown(). The attached patch surrounds it by feature guards. 1039158 1 239189 philip.chimento 2014-10-03 01:02:56 -0700 Created attachment 239189 Patch 1039944 2 239385 philip.chimento 2014-10-06 22:05:26 -0700 Created attachment 239385 Patch 1039947 3 philip.chimento 2014-10-06 22:16:01 -0700 Attached an updated patch with ChangeLog. 1039950 4 philip.chimento 2014-10-06 22:21:17 -0700 PS. I'd appreciate it if this could also be committed to the webkitgtk 2.4 branch. 1040317 5 pnormand 2014-10-08 09:59:22 -0700 Once the patch landed please add it to the list: http://trac.webkit.org/wiki/WebKitGTK/2.4.x 1040507 6 239385 commit-queue 2014-10-09 00:34:48 -0700 Comment on attachment 239385 Patch Clearing flags on attachment: 239385 Committed r174502: <http://trac.webkit.org/changeset/174502> 1040508 7 commit-queue 2014-10-09 00:34:51 -0700 All reviewed patches have been landed. Closing bug. 239189 2014-10-03 01:02:56 -0700 2014-10-06 22:05:22 -0700 Patch webkit-guard-netscape-symbol.patch text/plain 519 philip.chimento ZGlmZiAtLWdpdCBhL3JlbGVhc2VzL1dlYktpdEdUSy93ZWJraXQtMi40LjYvU291cmNlL1dlYkNv cmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcCBiL3JlbGVhc2VzL1dlYktpdEdUSy93ZWJraXQt Mi40LjYvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcAotLS0gYS9yZWxl YXNlcy9XZWJLaXRHVEsvd2Via2l0LTIuNC42L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2lu UGFja2FnZS5jcHAgIChyZXZpc2lvbiAxNzQyNTgpCisrKyBiL3JlbGVhc2VzL1dlYktpdEdUSy93 ZWJraXQtMi40LjYvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcCAgKHdv cmtpbmcgY29weSkKQEAgLTEyNyw3ICsxMjcsOSBAQAogICAgIGlmICgtLW1fbG9hZENvdW50ID4g MCkKICAgICAgICAgcmV0dXJuOwogCisjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAg ICAgbV9OUFBfU2h1dGRvd24oKTsKKyNlbmRpZgogCiAgICAgdW5sb2FkV2l0aG91dFNodXRkb3du KCk7CiB9 239385 2014-10-06 22:05:26 -0700 2014-10-09 00:34:48 -0700 Patch bug-137385-20141006220526.patch text/plain 1173 philip.chimento SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDM4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEwLTA2ICBQaGlsaXAg Q2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIE5l dHNjYXBlIHBsdWdpbiBBUEkgc3ltYm9sIHVzZWQgb3V0c2lkZSBmZWF0dXJlIGd1YXJkcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3Mzg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbHVnaW5zL1Bs dWdpblBhY2thZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6dW5sb2Fk KTogQWRkIGd1YXJkcyBmb3IgTmV0c2NhcGUgUGx1Z2luCisgICAgICAgIEFQSSBhcm91bmQgc3lt Ym9sLCBzbyB0aGF0IGl0IGNvbXBpbGVzIE9LIHdoZW4gdGhlIEFQSSBpcyBub3QKKyAgICAgICAg YXZhaWxhYmxlLgorCiAyMDE0LTA5LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggbWFrZSBkaXN0Y2hlY2suCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAJKHJldmlzaW9uIDE3 NDMwNykKKysrIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEyNyw3ICsxMjcsOSBAQCB2b2lkIFBsdWdpblBhY2thZ2U6OnVubG9hZCgp CiAgICAgaWYgKC0tbV9sb2FkQ291bnQgPiAwKQogICAgICAgICByZXR1cm47CiAKKyNpZiBFTkFC TEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBtX05QUF9TaHV0ZG93bigpOworI2VuZGlmCiAK ICAgICB1bmxvYWRXaXRob3V0U2h1dGRvd24oKTsKIH0K