137383 2014-10-03 00:18:17 -0700 WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset 2014-10-03 13:37:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca bdakin commit-queue dbates esprehn+autocc glenn ian kondapallykalyan mitz sam simon.fraser oldest_to_newest 1039143 0 thorton 2014-10-03 00:18:17 -0700 WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset 1039144 1 239183 thorton 2014-10-03 00:19:07 -0700 Created attachment 239183 Patch 1039145 2 thorton 2014-10-03 00:19:42 -0700 rdar://problem/18535439 1039247 3 239183 dbates 2014-10-03 10:17:24 -0700 Comment on attachment 239183 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239183&action=review > Source/WebCore/ChangeLog:11 > + Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set. I take it you meant to write documentBackgroundColor instead of pageExtendedBackgroundColor. > Source/WebKit2/ChangeLog:11 > + Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set. Ditto. > Source/WebCore/rendering/RenderView.cpp:590 > + Color backgroundColor = backgroundShouldExtendBeyondPage ? frameView().documentBackgroundColor() : frameView().baseBackgroundColor(); Should we add a remark about this in the comment block that starts at line 583: <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderView.cpp?rev=173865#L583>? 1039324 4 thorton 2014-10-03 13:37:11 -0700 http://trac.webkit.org/changeset/174287 239183 2014-10-03 00:19:07 -0700 2014-10-03 10:17:24 -0700 Patch bug-137383-20141003002023.patch text/plain 4493 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM5N2M2NjIyNmVjMDAx NGI2YzIwYTdlNDdiOTAwOTZiMzc1YTFiYS4uMTliNTA2NThlYWUzODEwYjE3NDhlNTMxMGZiNGRm ZGE1ZTNiM2Q3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEwLTAzICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFdLV2ViVmlldyBz bmFwc2hvdCBvZiBEYXJpbmcgRmlyZWJhbGwgaGFzIHRoZSB3cm9uZyBjb2xvciBpbiB0aGUgb2Jz Y3VyZWQgaW5zZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNzM4MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTg1MzU0Mzk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy Vmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWV3OjpwYWludEJveERlY29yYXRp b25zKToKKyAgICAgICAgVXNlIHBhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvciBpbnN0ZWFkIG9m IGJhc2VCYWNrZ3JvdW5kQ29sb3IgaWYgYmFja2dyb3VuZFNob3VsZEV4dGVuZEJleW9uZFBhZ2Ug aXMgc2V0LgorCiAyMDE0LTEwLTAyICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K IAogICAgICAgICBDU1NPTSBydWxlIHdyYXBwZXJzIGFsd2F5cyBoYXZlIGEgY29ycmVzcG9uZGlu ZyBpbnRlcm5hbCBzdHlsZSBvYmplY3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzI0MDFiYmFmMTFlNWU1N2I0 YjAyZTEyMzA4OGM1OThjYjFmYWNlZC4uNThjMWU0MWE1N2MzN2Q4YTRmNTE3NmQyNzY0MThiNTA3 YjQ5MTJmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEwLTAyICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFdLV2ViVmlldyBzbmFw c2hvdCBvZiBEYXJpbmcgRmlyZWJhbGwgaGFzIHRoZSB3cm9uZyBjb2xvciBpbiB0aGUgb2JzY3Vy ZWQgaW5zZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNzM4MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTg1MzU0Mzk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNuYXBzaG90QXRTaXplKToK KyAgICAgICAgVXNlIHBhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvciBpbnN0ZWFkIG9mIGJhc2VC YWNrZ3JvdW5kQ29sb3IgaWYgYmFja2dyb3VuZFNob3VsZEV4dGVuZEJleW9uZFBhZ2UgaXMgc2V0 LgorCiAyMDE0LTEwLTAyICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TXSBDcmVhdGUgYW4gU1BJIHdyYXBwZXIgZm9yIF9VSUhpZ2hsaWdodFZpZXcgYW5kIHVz ZSBpdCBpbiBXS0NvbnRlbnRWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5j cHAKaW5kZXggYTc5ZGQyNWVkNDg4MWE2ZjRiZThiNTg4MjM4NjU4MmFhMGI5ZGJiYy4uYWY5M2E0 NGY2NjI2MTlkMmQ5M2E3MmRiZjAyNTc3OGJhYzc4ZjAzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJWaWV3LmNwcApAQCAtNTcwLDggKzU3MCw4IEBAIHZvaWQgUmVuZGVyVmlldzo6 cGFpbnRCb3hEZWNvcmF0aW9ucyhQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG9p bnQmKQogICAgICAgICByb290T2JzY3VyZXNCYWNrZ3JvdW5kID0gcmVuZGVyZXJPYnNjdXJlc0Jh Y2tncm91bmQocm9vdFJlbmRlcmVyKTsKICAgICB9CiAKLSAgICBjb21wb3NpdG9yKCkuc2V0Um9v dEV4dGVuZGVkQmFja2dyb3VuZENvbG9yKGZyYW1lVmlldygpLmZyYW1lKCkuc2V0dGluZ3MoKS5i YWNrZ3JvdW5kU2hvdWxkRXh0ZW5kQmV5b25kUGFnZSgpCi0gICAgICAgID8gZnJhbWVWaWV3KCku ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKSA6IENvbG9yKCkpOworICAgIGJvb2wgYmFja2dyb3Vu ZFNob3VsZEV4dGVuZEJleW9uZFBhZ2UgPSBmcmFtZVZpZXcoKS5mcmFtZSgpLnNldHRpbmdzKCku YmFja2dyb3VuZFNob3VsZEV4dGVuZEJleW9uZFBhZ2UoKTsKKyAgICBjb21wb3NpdG9yKCkuc2V0 Um9vdEV4dGVuZGVkQmFja2dyb3VuZENvbG9yKGJhY2tncm91bmRTaG91bGRFeHRlbmRCZXlvbmRQ YWdlID8gZnJhbWVWaWV3KCkuZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKSA6IENvbG9yKCkpOwog CiAgICAgUGFnZSogcGFnZSA9IGRvY3VtZW50KCkucGFnZSgpOwogICAgIGZsb2F0IHBhZ2VTY2Fs ZUZhY3RvciA9IHBhZ2UgPyBwYWdlLT5wYWdlU2NhbGVGYWN0b3IoKSA6IDE7CkBAIC01ODcsNyAr NTg3LDcgQEAgdm9pZCBSZW5kZXJWaWV3OjpwYWludEJveERlY29yYXRpb25zKFBhaW50SW5mbyYg cGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYpCiAgICAgaWYgKGZyYW1lVmlldygpLmlzVHJh bnNwYXJlbnQoKSkgLy8gRklYTUU6IFRoaXMgbmVlZHMgdG8gYmUgZHluYW1pYy4gV2Ugc2hvdWxk IGJlIGFibGUgdG8gZ28gYmFjayB0byBibGl0dGluZyBpZiB3ZSBldmVyIHN0b3AgYmVpbmcgdHJh bnNwYXJlbnQuCiAgICAgICAgIGZyYW1lVmlldygpLnNldENhbm5vdEJsaXRUb1dpbmRvdygpOyAv LyBUaGUgcGFyZW50IG11c3Qgc2hvdyBiZWhpbmQgdGhlIGNoaWxkLgogICAgIGVsc2UgewotICAg ICAgICBDb2xvciBiYWNrZ3JvdW5kQ29sb3IgPSBmcmFtZVZpZXcoKS5iYXNlQmFja2dyb3VuZENv bG9yKCk7CisgICAgICAgIENvbG9yIGJhY2tncm91bmRDb2xvciA9IGJhY2tncm91bmRTaG91bGRF eHRlbmRCZXlvbmRQYWdlID8gZnJhbWVWaWV3KCkuZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKSA6 IGZyYW1lVmlldygpLmJhc2VCYWNrZ3JvdW5kQ29sb3IoKTsKICAgICAgICAgaWYgKGJhY2tncm91 bmRDb2xvci5hbHBoYSgpKSB7CiAgICAgICAgICAgICBDb21wb3NpdGVPcGVyYXRvciBwcmV2aW91 c09wZXJhdG9yID0gcGFpbnRJbmZvLmNvbnRleHQtPmNvbXBvc2l0ZU9wZXJhdGlvbigpOwogICAg ICAgICAgICAgcGFpbnRJbmZvLmNvbnRleHQtPnNldENvbXBvc2l0ZU9wZXJhdGlvbihDb21wb3Np dGVDb3B5KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cAppbmRleCA5NmEzOTdmMmE2OTEyZGYwMTY2ZWZmOTgyYjUzM2RiNzlhMzdmZmJjLi5iYjQzYjYz MzAyNjUyNTg5NzJmOTU0OTA2MGZjMzc1NGE5MzBmYTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0xNjY4LDcgKzE2NjgsOCBAQCBQYXNz UmVmUHRyPFdlYkltYWdlPiBXZWJQYWdlOjpzbmFwc2hvdEF0U2l6ZShjb25zdCBJbnRSZWN0JiBy ZWN0LCBjb25zdCBJbnRTaXplJgogCiAgICAgYXV0byBncmFwaGljc0NvbnRleHQgPSBzbmFwc2hv dC0+Yml0bWFwKCktPmNyZWF0ZUdyYXBoaWNzQ29udGV4dCgpOwogCi0gICAgZ3JhcGhpY3NDb250 ZXh0LT5maWxsUmVjdChJbnRSZWN0KEludFBvaW50KCksIGJpdG1hcFNpemUpLCBmcmFtZVZpZXct PmJhc2VCYWNrZ3JvdW5kQ29sb3IoKSwgQ29sb3JTcGFjZURldmljZVJHQik7CisgICAgQ29sb3Ig YmFja2dyb3VuZENvbG9yID0gY29yZUZyYW1lLT5zZXR0aW5ncygpLmJhY2tncm91bmRTaG91bGRF eHRlbmRCZXlvbmRQYWdlKCkgPyBmcmFtZVZpZXctPmRvY3VtZW50QmFja2dyb3VuZENvbG9yKCkg OiBmcmFtZVZpZXctPmJhc2VCYWNrZ3JvdW5kQ29sb3IoKTsKKyAgICBncmFwaGljc0NvbnRleHQt PmZpbGxSZWN0KEludFJlY3QoSW50UG9pbnQoKSwgYml0bWFwU2l6ZSksIGJhY2tncm91bmRDb2xv ciwgQ29sb3JTcGFjZURldmljZVJHQik7CiAKICAgICBpZiAoIShvcHRpb25zICYgU25hcHNob3RP cHRpb25zRXhjbHVkZURldmljZVNjYWxlRmFjdG9yKSkgewogICAgICAgICBkb3VibGUgZGV2aWNl U2NhbGVGYWN0b3IgPSBjb3JlUGFnZSgpLT5kZXZpY2VTY2FsZUZhY3RvcigpOwo=