137377 2014-10-02 18:41:11 -0700 -asan-blacklist option also renamed to generic -fsanitize-blacklist 2014-10-03 14:18:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler dbates dburkart ddkilzer jake.nielsen.webkit oldest_to_newest 1039092 0 dfarler 2014-10-02 18:41:11 -0700 In addition to the ASan flags moving up to the clang front-end, the generic -fsanitize-blacklist is now used for the ASan symbol blacklist as well. 1039096 1 239172 dfarler 2014-10-02 18:49:39 -0700 Created attachment 239172 Patch 1039248 2 239172 dbates 2014-10-03 10:32:54 -0700 Comment on attachment 239172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > Tools/ChangeLog:9 > + * asan/asan.xcconfig: > + -asan-blacklist -> -fsanitize-blacklist Do we know version/revision of clang added support for -fsanitize-blacklist? If so, or if it's straightforward to determine this, then I suggest we add a remark to this change log entry about the version/revision of clang that added such support. 1039249 3 dbates 2014-10-03 10:33:51 -0700 (In reply to comment #2) > (From update of attachment 239172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > > > Tools/ChangeLog:9 > > + * asan/asan.xcconfig: > > + -asan-blacklist -> -fsanitize-blacklist > > Do we know version/revision of clang added support for -fsanitize-blacklist? [...] I meant to write: Do we know which version/revision of clang added support for -fsanitize-blacklist? 1039337 4 dfarler 2014-10-03 14:16:20 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 239172 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > > > > > Tools/ChangeLog:9 > > > + * asan/asan.xcconfig: > > > + -asan-blacklist -> -fsanitize-blacklist > > > > Do we know version/revision of clang added support for -fsanitize-blacklist? [...] > > I meant to write: > > Do we know which version/revision of clang added support for -fsanitize-blacklist? -fsanitize-blacklist is a generic option that has been available for quite some time, way before ASan was available. I’ll reference the same revision in my previous patch. 1039342 5 dfarler 2014-10-03 14:18:42 -0700 Committed r174290: <http://trac.webkit.org/changeset/174290> 239172 2014-10-02 18:49:39 -0700 2014-10-03 10:32:54 -0700 Patch bug-137377-20141002184940.patch text/plain 1400 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MjUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWJjNmY5M2U0M2ZhMDNhOTIzYjA5MTZiOGMwZTZhYWIx OThiNjQ3NC4uNzBmNWJmODQ5OWNjZDdlMWM5NWU5ZjViOWUzZjkzYmNhMTExZDdhOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTEwLTAyICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAg ICAgICAtYXNhbi1ibGFja2xpc3Qgb3B0aW9uIGFsc28gcmVuYW1lZCB0byBnZW5lcmljIC1mc2Fu aXRpemUtYmxhY2tsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzczNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGFzYW4vYXNhbi54Y2NvbmZpZzoKKyAgICAgICAgLWFzYW4tYmxhY2tsaXN0IC0+ IC1mc2FuaXRpemUtYmxhY2tsaXN0CisKIDIwMTQtMTAtMDIgIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSB2ZXJzaW9uIG51bWJlciAxMDEwMDAgaW5zdGVh ZCBvZiAxMDEwMCBmb3IgT1MgWCBZb3NlbWl0ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvYXNhbi9hc2Fu LnhjY29uZmlnIGIvVG9vbHMvYXNhbi9hc2FuLnhjY29uZmlnCmluZGV4IDlhOTBmZWE2NzdkMmM0 YWQ1MzAxYTkyNDU5YjgwMmY4Y2NhZDhiZTMuLjllMTQ1YmRhOWNiMWIxYzIwZTNiNjBkM2MxZjVi ZDQ0N2YxZGJiZjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2FzYW4vYXNhbi54Y2NvbmZpZworKysgYi9U b29scy9hc2FuL2FzYW4ueGNjb25maWcKQEAgLTEsNiArMSw2IEBACiBHQ0NfVFJFQVRfV0FSTklO R1NfQVNfRVJST1JTID0gTk87CiAKLUFTQU5fT1RIRVJfQ0ZMQUdTID0gLWZzYW5pdGl6ZT1hZGRy ZXNzIC1PMSAtYXNhbi1ibGFja2xpc3Q9JChBU0FOX0lHTk9SRSkgLVduby1lcnJvciAtZm5vLW9t aXQtZnJhbWUtcG9pbnRlciAtZyAtRFVTRV9TWVNURU1fTUFMTE9DPTE7CitBU0FOX09USEVSX0NG TEFHUyA9IC1mc2FuaXRpemU9YWRkcmVzcyAtTzEgLWZzYW5pdGl6ZS1ibGFja2xpc3Q9JChBU0FO X0lHTk9SRSkgLVduby1lcnJvciAtZm5vLW9taXQtZnJhbWUtcG9pbnRlciAtZyAtRFVTRV9TWVNU RU1fTUFMTE9DPTE7CiBBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTID0gJChBU0FOX09USEVSX0NG TEFHUyk7CiBBU0FOX09USEVSX0xERkxBR1MgPSAtZnNhbml0aXplPWFkZHJlc3MgJChBU0FOX09U SEVSX0xERkxBR1NfJChQTEFURk9STV9OQU1FKSk7CiBBU0FOX09USEVSX0xERkxBR1NfbWFjb3N4 ID0gLWxjbGFuZ19ydC5hc2FuX29zeF9keW5hbWljOwo=