137360 2014-10-02 14:13:29 -0700 Annoying build warnings in WTFString API tests 2014-10-03 19:13:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 b.long b.long commit-queue ysuzuki oldest_to_newest 1038975 0 b.long 2014-10-02 14:13:29 -0700 I just built WebKitGTK and got a bunch of output like this: [6/7] Building CXX object Tools/TestWebKitAPI/CMakeFiles/TestWTF.dir/Tests/WTF/WTFString.cpp.o ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp: In member function ‘virtual void TestWebKitAPI::WTF_StringToInt_Test::TestBody()’: ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:169:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:173:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:189:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:197:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:202:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp: In member function ‘virtual void TestWebKitAPI::WTF_StringToDouble_Test::TestBody()’: ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:221:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:225:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:238:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:250:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:255:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:260:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, ok); ^ I'm not sure why EXPECT_EQ(false, ...) causes these warnings, but it seems like EXPECT_TRUE and EXPECT_FALSE are more clear anyway in these cases. 1038989 1 239141 b.long 2014-10-02 14:46:05 -0700 Created attachment 239141 Patch 1039019 2 239141 darin 2014-10-02 16:03:19 -0700 Comment on attachment 239141 Patch Change seems fine. I think the GTK compiler has a configuration problem of some sort. 1039043 3 239141 commit-queue 2014-10-02 16:41:29 -0700 Comment on attachment 239141 Patch Clearing flags on attachment: 239141 Committed r174246: <http://trac.webkit.org/changeset/174246> 1039044 4 commit-queue 2014-10-02 16:41:31 -0700 All reviewed patches have been landed. Closing bug. 1039430 5 ysuzuki 2014-10-03 19:13:36 -0700 *** Bug 137344 has been marked as a duplicate of this bug. *** 239141 2014-10-02 14:46:05 -0700 2014-10-02 16:41:28 -0700 Patch bug-137360-20141002164606.patch text/plain 4600 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MjI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzAyMTU5MGFjZDE3ZWQzYzc0YWNjNDA4MDBlMDFhMTM1 NmJmZjU1ZC4uY2Q5NjU4MzVkYzM0YWNlMzIwZDQ3YWJhZjQ1ZWRlOGQ1NWExYmMwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTEwLTAyICBCcmVuZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKwor ICAgICAgICBBbm5veWluZyBidWlsZCB3YXJuaW5ncyBpbiBXVEZTdHJpbmcgQVBJIHRlc3RzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzczNjAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJL aXRBUEkvVGVzdHMvV1RGL1dURlN0cmluZy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpU RVNUKTogQ2hhbmdlIEVYUEVDVF9FUShmYWxzZSwgb2spIHRvIEVYUEVDVF9GQUxTRShvaykgYW5k IEVYUEVDVF9FUSh0cnVlLCBvaykgdG8gRVhQRUNUX1RSVUUob2spLgorCiAyMDE0LTEwLTAyICBD b21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTc0MTIwLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L1dURlN0cmluZy5jcHAKaW5kZXggZjQwZTZhZjUxMDJjNjdiMGNhYzdmOGQyMzk1N2YxYjFhNGQ1 ZmQ1Yi4uNTNhOGI4ODU0MjI2MTQ0YWEzNTZiY2MyYjJkYjYwMTE5MGFjMzIyNyAxMDA2NDQKLS0t IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcAorKysgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XVEZTdHJpbmcuY3BwCkBAIC0xNjYsNTAgKzE2Niw1 MCBAQCBURVNUKFdURiwgU3RyaW5nVG9JbnQpCiAKICAgICBFWFBFQ1RfRVEoMCwgU3RyaW5nKCku dG9JbnQoKSk7CiAgICAgRVhQRUNUX0VRKDAsIFN0cmluZygpLnRvSW50KCZvaykpOwotICAgIEVY UEVDVF9FUShmYWxzZSwgb2spOworICAgIEVYUEVDVF9GQUxTRShvayk7CiAKICAgICBFWFBFQ1Rf RVEoMCwgZW1wdHlTdHJpbmcoKS50b0ludCgpKTsKICAgICBFWFBFQ1RfRVEoMCwgZW1wdHlTdHJp bmcoKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsKKyAgICBFWFBFQ1Rf RkFMU0Uob2spOwogCiAgICAgRVhQRUNUX0VRKDAsIFN0cmluZygiMCIpLnRvSW50KCkpOwogICAg IEVYUEVDVF9FUSgwLCBTdHJpbmcoIjAiKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1RfRVEodHJ1 ZSwgb2spOworICAgIEVYUEVDVF9UUlVFKG9rKTsKIAogICAgIEVYUEVDVF9FUSgxLCBTdHJpbmco IjEiKS50b0ludCgpKTsKICAgICBFWFBFQ1RfRVEoMSwgU3RyaW5nKCIxIikudG9JbnQoJm9rKSk7 Ci0gICAgRVhQRUNUX0VRKHRydWUsIG9rKTsKKyAgICBFWFBFQ1RfVFJVRShvayk7CiAKICAgICBF WFBFQ1RfRVEoMjE0NzQ4MzY0NywgU3RyaW5nKCIyMTQ3NDgzNjQ3IikudG9JbnQoKSk7CiAgICAg RVhQRUNUX0VRKDIxNDc0ODM2NDcsIFN0cmluZygiMjE0NzQ4MzY0NyIpLnRvSW50KCZvaykpOwot ICAgIEVYUEVDVF9FUSh0cnVlLCBvayk7CisgICAgRVhQRUNUX1RSVUUob2spOwogCiAgICAgRVhQ RUNUX0VRKDAsIFN0cmluZygiMjE0NzQ4MzY0OCIpLnRvSW50KCkpOwogICAgIEVYUEVDVF9FUSgw LCBTdHJpbmcoIjIxNDc0ODM2NDgiKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2Us IG9rKTsKKyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAgRVhQRUNUX0VRKC0yMTQ3NDgzNjQ4 LCBTdHJpbmcoIi0yMTQ3NDgzNjQ4IikudG9JbnQoKSk7CiAgICAgRVhQRUNUX0VRKC0yMTQ3NDgz NjQ4LCBTdHJpbmcoIi0yMTQ3NDgzNjQ4IikudG9JbnQoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKHRy dWUsIG9rKTsKKyAgICBFWFBFQ1RfVFJVRShvayk7CiAKICAgICBFWFBFQ1RfRVEoMCwgU3RyaW5n KCItMjE0NzQ4MzY0OSIpLnRvSW50KCkpOwogICAgIEVYUEVDVF9FUSgwLCBTdHJpbmcoIi0yMTQ3 NDgzNjQ5IikudG9JbnQoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKGZhbHNlLCBvayk7CisgICAgRVhQ RUNUX0ZBTFNFKG9rKTsKIAogICAgIC8vIGZhaWwgaWYgd2Ugc2VlIGxlYWRpbmcganVuawogICAg IEVYUEVDVF9FUSgwLCBTdHJpbmcoIngxIikudG9JbnQoKSk7CiAgICAgRVhQRUNUX0VRKDAsIFN0 cmluZygieDEiKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsKKyAgICBF WFBFQ1RfRkFMU0Uob2spOwogCiAgICAgLy8gc3VjY2VlZCBpZiB3ZSBzZWUgbGVhZGluZyBzcGFj ZXMKICAgICBFWFBFQ1RfRVEoMSwgU3RyaW5nKCIgMSIpLnRvSW50KCkpOwogICAgIEVYUEVDVF9F USgxLCBTdHJpbmcoIiAxIikudG9JbnQoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKHRydWUsIG9rKTsK KyAgICBFWFBFQ1RfVFJVRShvayk7CiAKICAgICAvLyBzaWxlbnRseSBpZ25vcmUgdHJhaWxpbmcg anVuawogICAgIEVYUEVDVF9FUSgxLCBTdHJpbmcoIjF4IikudG9JbnQoKSk7CiAgICAgRVhQRUNU X0VRKDEsIFN0cmluZygiMXgiKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1RfRVEodHJ1ZSwgb2sp OworICAgIEVYUEVDVF9UUlVFKG9rKTsKIH0KIAogVEVTVChXVEYsIFN0cmluZ1RvRG91YmxlKQpA QCAtMjE4LDQ2ICsyMTgsNDYgQEAgVEVTVChXVEYsIFN0cmluZ1RvRG91YmxlKQogCiAgICAgRVhQ RUNUX0VRKDAuMCwgU3RyaW5nKCkudG9Eb3VibGUoKSk7CiAgICAgRVhQRUNUX0VRKDAuMCwgU3Ry aW5nKCkudG9Eb3VibGUoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKGZhbHNlLCBvayk7CisgICAgRVhQ RUNUX0ZBTFNFKG9rKTsKIAogICAgIEVYUEVDVF9FUSgwLjAsIGVtcHR5U3RyaW5nKCkudG9Eb3Vi bGUoKSk7CiAgICAgRVhQRUNUX0VRKDAuMCwgZW1wdHlTdHJpbmcoKS50b0RvdWJsZSgmb2spKTsK LSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsKKyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAg RVhQRUNUX0VRKDAuMCwgU3RyaW5nKCIwIikudG9Eb3VibGUoKSk7CiAgICAgRVhQRUNUX0VRKDAu MCwgU3RyaW5nKCIwIikudG9Eb3VibGUoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKHRydWUsIG9rKTsK KyAgICBFWFBFQ1RfVFJVRShvayk7CiAKICAgICBFWFBFQ1RfRVEoMS4wLCBTdHJpbmcoIjEiKS50 b0RvdWJsZSgpKTsKICAgICBFWFBFQ1RfRVEoMS4wLCBTdHJpbmcoIjEiKS50b0RvdWJsZSgmb2sp KTsKLSAgICBFWFBFQ1RfRVEodHJ1ZSwgb2spOworICAgIEVYUEVDVF9UUlVFKG9rKTsKIAogICAg IC8vIGZhaWwgaWYgd2Ugc2VlIGxlYWRpbmcganVuawogICAgIEVYUEVDVF9FUSgwLjAsIFN0cmlu ZygieDEiKS50b0RvdWJsZSgpKTsKICAgICBFWFBFQ1RfRVEoMC4wLCBTdHJpbmcoIngxIikudG9E b3VibGUoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKGZhbHNlLCBvayk7CisgICAgRVhQRUNUX0ZBTFNF KG9rKTsKIAogICAgIC8vIHN1Y2NlZWQgaWYgd2Ugc2VlIGxlYWRpbmcgc3BhY2VzCiAgICAgRVhQ RUNUX0VRKDEuMCwgU3RyaW5nKCIgMSIpLnRvRG91YmxlKCkpOwogICAgIEVYUEVDVF9FUSgxLjAs IFN0cmluZygiIDEiKS50b0RvdWJsZSgmb2spKTsKLSAgICBFWFBFQ1RfRVEodHJ1ZSwgb2spOwor ICAgIEVYUEVDVF9UUlVFKG9rKTsKIAogICAgIC8vIGlnbm9yZSB0cmFpbGluZyBqdW5rLCBidXQg cmV0dXJuIGZhbHNlIGZvciAib2siCiAgICAgLy8gRklYTUU6IFRoaXMgaXMgYW4gaW5jb25zaXN0 ZW5jeSB3aXRoIHRvSW50LCB3aGljaCBhbHdheXMgZ3VhcmFudGVlcwogICAgIC8vIGl0IHdpbGwg cmV0dXJuIDAgaWYgaXQncyBhbHNvIGdvaW5nIHRvIHJldHVybiBmYWxzZSBmb3Igb2suCiAgICAg RVhQRUNUX0VRKDEuMCwgU3RyaW5nKCIxeCIpLnRvRG91YmxlKCkpOwogICAgIEVYUEVDVF9FUSgx LjAsIFN0cmluZygiMXgiKS50b0RvdWJsZSgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9r KTsKKyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAgLy8gcGFyc2Ugb25seSBudW1iZXJzLCBu b3Qgc3BlY2lhbCB2YWx1ZXMgc3VjaCBhcyAiaW5maW5pdHkiCiAgICAgRVhQRUNUX0VRKDAuMCwg U3RyaW5nKCJpbmZpbml0eSIpLnRvRG91YmxlKCkpOwogICAgIEVYUEVDVF9FUSgwLjAsIFN0cmlu ZygiaW5maW5pdHkiKS50b0RvdWJsZSgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsK KyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAgLy8gcGFyc2Ugb25seSBudW1iZXJzLCBub3Qg c3BlY2lhbCB2YWx1ZXMgc3VjaCBhcyAibmFuIgogICAgIEVYUEVDVF9FUSgwLjAsIFN0cmluZygi bmFuIikudG9Eb3VibGUoKSk7CiAgICAgRVhQRUNUX0VRKDAuMCwgU3RyaW5nKCJuYW4iKS50b0Rv dWJsZSgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsKKyAgICBFWFBFQ1RfRkFMU0Uo b2spOwogfQogCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==