13736 2007-05-15 16:09:41 -0700 REGRESSION (r19811): Using the down arrow in a textarea gets "stuck" at the end of a wrapped line 2009-10-12 14:53:31 -0700 1 1 1 Unclassified WebKit HTML Editing 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ddkilzer webkit-unassigned alex alp ap bdakin bugs harrison jonathon justin.garcia mitz oldest_to_newest 9931 0 ddkilzer 2007-05-15 16:09:41 -0700 * SUMMARY After typing text into a textarea, scrolling down using the down arrow sometimes gets stuck at the end of a wrapped line. * STEPS TO REPRODUCE 1. Type text into a (LTR) textarea. 2. Move cursor to the top-left corner so that using the down-arrow moves the cursor only vertically (to the beginning of each line). 3. Start using the down arrow on the typed text. * EXPECTED RESULTS The down arrow should move the cursor all the way to the bottom of the textarea, and the cursor should stay on the far left side of every line. * ACTUAL RESULTS Occasionally, hitting the down arrow will move the cursor to the end of the current line (instead of to the beginning of the next line), and additional down arrow key presses will not move it any further. * REGRESSION This is a regression from shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.9 (8P135). This happened on a local debug build of WebKit r21489 with the aforementioned software. * NOTES I can't reproduce this on demand. I believe it has something to do with how the text is edited in the textarea, creating some kind of internal representation that misbehaves when using the down arrow. 9932 1 ddkilzer 2007-05-15 16:11:12 -0700 I most recently saw this while typing in the "Comment (on this bug):" field on the edit attachment page for Bug 13732: http://bugs.webkit.org/attachment.cgi?id=14568&action=edit 7037 2 riegel 2007-06-20 06:29:04 -0700 Similarly, navigating a textarea set to no wrap with the arrows places/hides the cursor with the right scrollbar and the bottom scrollbar. To duplicate add enough lines to create a right scrollbar, then midway through create a line long enough to create a bottom scrollbar. (by bottom scrollbar I mean positioned at the bottom of the texarea for scrolling left and right, and by right scrollbar I mean positioned at the right of the textarea) Then using just the arrow keys navigate to the line below your long line. Hit the left arrow, This should place your cursor at the end of the really long line. It does but it fails to scroll completely so it can be seen. The offset is the width of the scrollbars. 7036 3 riegel 2007-06-20 06:30:16 -0700 Similarly, navigating a textarea set to no wrap with the arrows places/hides the cursor with the right scrollbar and the bottom scrollbar. To duplicate add enough lines to create a right scrollbar, then midway through create a line long enough to create a bottom scrollbar. (by bottom scrollbar I mean positioned at the bottom of the texarea for scrolling left and right, and by right scrollbar I mean positioned at the right of the textarea) Then using just the arrow keys navigate to the line below your long line. Hit the left arrow, This should place your cursor at the end of the really long line. It does but it fails to scroll completely so it can be seen. The offset is the width of the scrollbars. 7029 4 ddkilzer 2007-06-20 08:57:00 -0700 (In reply to comment #3) > Similarly, navigating a textarea set to no wrap with the arrows places/hides > the cursor with the right scrollbar and the bottom scrollbar. Terry, please file a new bug about this issue. Thanks! 4286 5 ddkilzer 2007-07-19 10:11:47 -0700 * STEPS TO REPRODUCE 1. Open this bug (or any Bugzilla bug on bugs.webkit.org). 2. Hit Cmd-L to select URL for the current bugs.webkit.org page you're on, then hit Cmd-C to copy it to the pasteboard. 3. Click in "Additional Comments:" textarea to give it focus. 4. Type the following line of text (without double quotes) but DO NOT hit Enter at the end; it should be on a single line; note the space at the end of the line: "2. Follow the Windows instructions on this page to check out the source code: " 5. Hit Cmd-V to paste the URL (which should wrap to the next line). 6. Hit Enter to create a new line and move the caret to a blank line. 7. Hit the up arrow key twice to move the caret to the top left corner of the textarea. 8. Hit the down arrow twice. * EXPECTED RESULTS The caret should be on the third (blank) line of the textarea. * ACTUAL RESULTS The caret gets "stuck" at the end of the first line. * NOTES It probably doesn't matter what text is typed or what is pasted as long as a word wrap occurs when the paste happens. 4280 6 ddkilzer 2007-07-19 13:50:28 -0700 <rdar://problem/5347931> 2014 7 ddkilzer 2007-08-18 18:04:01 -0700 Using my new autospade script (Bug 15002): Reproduced bug: r19818 Did NOT reproduce bug: r19809 1893 8 justin.garcia 2007-08-20 11:42:51 -0700 (In reply to comment #7) > Using my new autospade script (Bug 15002): > > Reproduced bug: r19818 > Did NOT reproduce bug: r19809 Probably regressed in r19811. 997 9 ddkilzer 2007-09-02 21:09:47 -0700 (In reply to comment #8) > Probably regressed in r19811. Verified with internal autospade: Works: r19810 Fails: r19811 59073 10 eric 2007-10-21 21:26:54 -0700 Wow. I was just able to reproduce it as I was typing a comment about how I couldn't... so strange. I'm on TOT (r26859). 59274 11 eric 2007-10-23 16:13:10 -0700 I just reproduced this w/o any pasting. I was moving up and down in a scrolled text area on Facebook. 84189 12 ddkilzer 2008-06-23 14:01:03 -0700 See also Bug 19465, although that was a slightly different issue. 95879 13 alp 2008-10-18 14:35:47 -0700 Issue also shows up with the caret browsing patches applied (bug #16135). 99736 14 justin.garcia 2008-11-21 17:54:05 -0800 I believe that the xposfor... code is correct. What's we're seeing is a symptom of: https://bugs.webkit.org/show_bug.cgi?id=9535 100916 15 25644 bdakin 2008-12-01 17:01:08 -0800 Created attachment 25644 Patch 100943 16 25644 mitz 2008-12-01 19:34:31 -0800 Comment on attachment 25644 Patch > + for (RenderObject* next = renderer->nextInPreOrder((RenderObject*)container); You should not need to cast container, which is a RenderBlock*, to RenderObject*. I wonder if this for loop can be made clearer by rewriting it as a while loop and only one copy of "next = renderer->nextInPreOrder(container)". Can you try making the tests dump as text? I think you can get the selection in JavaScript and test if it is in the node and offset you expect it to be and output PASS/FAIL accordingly. 100972 17 25664 bdakin 2008-12-01 22:20:59 -0800 Created attachment 25664 Newer Patch This patch addresses Dan's first two comments. The last comment about the layout tests made me have a realization. I remember when Darin and I were debugging this together, we realized that the selection was actually correct before the fix. The caret was just painting in the wrong place. So actually, these tests won't catch the bug as they are written in dump render tree (except with pixel tests of course). And changing the tests as Dan suggests definitely would not fix the bug. I think the best solution is to keep these tests as they are, and unfortunately, they only mean something when the pixel tests are run. 100974 18 25664 mitz 2008-12-01 22:27:43 -0800 Comment on attachment 25664 Newer Patch Yup, asking about turning the tests into text-only tests was silly. r=me 100983 19 bdakin 2008-12-01 23:25:35 -0800 Oh, it wasn't too silly. I wrote the patch, and it took me a bit of testing and debugging to remember why getting the selection wouldn't work. Fixed with r38898. 100994 20 ddkilzer 2008-12-02 02:52:56 -0800 It's too bad the test case can't report the row/column of the insertion bar (as text) when it's done running. Did that differ before and after the fix? 154130 21 alex 2009-10-12 12:16:27 -0700 Apparently this patch is causing problems with the caret browsing, the issue in the bug 25676 does not happen if we avoid the call to the searchAheadForBetterMatch. 154170 22 alex 2009-10-12 14:53:31 -0700 (In reply to comment #21) > Apparently this patch is causing problems with the caret browsing, the issue in > the bug 25676 does not happen if we avoid the call to the > searchAheadForBetterMatch. Actually if we use the test uploaded in the patch (wrapped-line-caret-1.html) we can check that if we move the caret to the last position (after the last x) and we move up we can not reach the first line. I would say the patch fixes the problem in one situation but breaks the opposite use case, causing also a problem when we have inlines and we move with the cursor with the caret browsing, like in the bug 25676. 25644 2008-12-01 17:01:08 -0800 2008-12-01 22:20:59 -0800 Patch forReview.txt text/plain 9985 bdakin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODg4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMDgtMTItMDEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzM2IFJFR1JFU1NJ T04gCisgICAgICAgIChyMTk4MTEpOiBVc2luZyB0aGUgZG93biBhcnJvdyBpbiBhIHRleHRhcmVh IGdldHMgInN0dWNrIiBhdCB0aGUgCisgICAgICAgIGVuZCBvZiBhIHdyYXBwZWQgbGluZQorICAg ICAgICBBbmQgY29ycmVzcG9uZGluZzogPHJkYXI6Ly9wcm9ibGVtLzUzNDc5MzE+CisKKyAgICAg ICAgVGhlIGJhc2ljIHByb2JsZW0gaGVyZSBpcyB0aGF0IFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hB bmRPZmZzZXQoKSAKKyAgICAgICAgZmFpbGVkIHRvIGxvb2sgYmV5b25kIGEgc2luZ2xlIHJlbmRl cmVyLiBUaGlzIHBhdGNoIGxvb2tzIGZvciBhIAorICAgICAgICBiZXR0ZXIgbWF0Y2ggYmV5b25k IHRoZSBmaXJzdCByZW5kZXJlciB3aGVuIHRoZSBhZmZpbml0eSBpcyAKKyAgICAgICAgZG93bnN0 cmVhbSBhbmQgd2UgZmFpbGVkIHRvIGZpbmQgYSAicGVyZmVjdCIgbWF0Y2guIAorICAgICAgICAq IGRvbS9Qb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc05vblRleHRMZWFmQ2hpbGQp OgorICAgICAgICAoV2ViQ29yZTo6c2VhcmNoQWhlYWRGb3JCZXR0ZXJNYXRjaCk6CisgICAgICAg IChXZWJDb3JlOjpQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KToKKworICAgICAgICBU aGlzIGlzIGEgZml4IEkgbWFkZSBiYXNlZCBvbiBjb2RlIGluc3BlY3Rpb24uIEl0IGxvb2tzIGxp a2UgdGhlIAorICAgICAgICBvbGQgY29kZSBoZXJlIGFuZCBza2lwcGVkIG92ZXIgdGhlIHBhcmVu dCBhcyBhIHBvc3NpYmxlIG1hdGNoLiAKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6bmV4dEluUHJlT3JkZXJBZnRl ckNoaWxkcmVuKToKKwogMjAwOC0xMi0wMSAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdl YkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Qb3NpdGlv bi5jcHAJKHJldmlzaW9uIDM4ODYxKQorKysgV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC03NzEsNiArNzcxLDM2IEBAIHZvaWQgUG9zaXRpb246OmdldElubGluZUJv eEFuZE9mZnNldChFQWYKICAgICBnZXRJbmxpbmVCb3hBbmRPZmZzZXQoYWZmaW5pdHksIHByaW1h cnlEaXJlY3Rpb24sIGlubGluZUJveCwgY2FyZXRPZmZzZXQpOwogfQogCitzdGF0aWMgYm9vbCBp c05vblRleHRMZWFmQ2hpbGQoUmVuZGVyT2JqZWN0KiBvYmplY3QpCit7CisgICAgaWYgKG9iamVj dC0+Zmlyc3RDaGlsZCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKG9iamVjdC0+ aXNUZXh0KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwor c3RhdGljIElubGluZVRleHRCb3gqIHNlYXJjaEFoZWFkRm9yQmV0dGVyTWF0Y2goUmVuZGVyT2Jq ZWN0KiByZW5kZXJlcikKK3sKKyAgICBJbmxpbmVUZXh0Qm94KiBtYXRjaCA9IDA7CisgICAgaW50 IG1pbk9mZnNldCA9IElOVF9NQVg7CisgICAgUmVuZGVyQmxvY2sqIGNvbnRhaW5lciA9IHJlbmRl cmVyLT5jb250YWluaW5nQmxvY2soKTsKKyAgICBmb3IgKFJlbmRlck9iamVjdCogbmV4dCA9IHJl bmRlcmVyLT5uZXh0SW5QcmVPcmRlcigoUmVuZGVyT2JqZWN0Kiljb250YWluZXIpOyAKKyAgICAg ICAgbmV4dCAmJiAhbmV4dC0+aXNSZW5kZXJCbG9jaygpICYmICFuZXh0LT5pc0JSKCkgJiYgIWlz Tm9uVGV4dExlYWZDaGlsZChuZXh0KTsKKyAgICAgICAgbmV4dCA9IG5leHQtPm5leHRJblByZU9y ZGVyKChSZW5kZXJPYmplY3QqKWNvbnRhaW5lcikpIHsKKyAgICAgICAgaWYgKG5leHQtPmlzVGV4 dCgpKSB7CisgICAgICAgICAgICBmb3IgKElubGluZVRleHRCb3gqIGJveCA9IHN0YXRpY19jYXN0 PFJlbmRlclRleHQqPihuZXh0KS0+Zmlyc3RUZXh0Qm94KCk7IGJveDsgYm94ID0gYm94LT5uZXh0 VGV4dEJveCgpKSB7CisgICAgICAgICAgICAgICAgaW50IGNhcmV0TWluT2Zmc2V0ID0gYm94LT5j YXJldE1pbk9mZnNldCgpOworICAgICAgICAgICAgICAgIGlmIChjYXJldE1pbk9mZnNldCA8IG1p bk9mZnNldCkgeworICAgICAgICAgICAgICAgICAgICBtYXRjaCA9IGJveDsKKyAgICAgICAgICAg ICAgICAgICAgbWluT2Zmc2V0ID0gY2FyZXRNaW5PZmZzZXQ7CisgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQorICAgIHJldHVybiBtYXRjaDsKK30KKwog dm9pZCBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVBZmZpbml0eSBhZmZpbml0eSwg VGV4dERpcmVjdGlvbiBwcmltYXJ5RGlyZWN0aW9uLCBJbmxpbmVCb3gqJiBpbmxpbmVCb3gsIGlu dCYgY2FyZXRPZmZzZXQpIGNvbnN0CiB7CiAgICAgY2FyZXRPZmZzZXQgPSBvZmZzZXQoKTsKQEAg LTgwMiw2ICs4MzIsMTEgQEAgdm9pZCBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVB ZgogCiAgICAgICAgICAgICBjYW5kaWRhdGUgPSBib3g7CiAgICAgICAgIH0KKyAgICAgICAgaWYg KGNhbmRpZGF0ZSAmJiAhYm94ICYmIGFmZmluaXR5ID09IERPV05TVFJFQU0pIHsKKyAgICAgICAg ICAgIGJveCA9IHNlYXJjaEFoZWFkRm9yQmV0dGVyTWF0Y2godGV4dFJlbmRlcmVyKTsKKyAgICAg ICAgICAgIGlmIChib3gpCisgICAgICAgICAgICAgICAgY2FyZXRPZmZzZXQgPSBib3gtPmNhcmV0 TWluT2Zmc2V0KCk7CisgICAgICAgIH0KICAgICAgICAgaW5saW5lQm94ID0gYm94ID8gYm94IDog Y2FuZGlkYXRlOwogICAgIH0KIApJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCShy ZXZpc2lvbiAzODg2MSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTMxOCw5ICszMTgsOSBAQCBSZW5kZXJPYmplY3QqIFJlbmRlck9iamVj dDo6bmV4dEluUHJlT3JkCiAgICAgaWYgKCEobyA9IG5leHRTaWJsaW5nKCkpKSB7CiAgICAgICAg IG8gPSBwYXJlbnQoKTsKICAgICAgICAgd2hpbGUgKG8gJiYgIW8tPm5leHRTaWJsaW5nKCkpIHsK LSAgICAgICAgICAgIG8gPSBvLT5wYXJlbnQoKTsKICAgICAgICAgICAgIGlmIChvID09IHN0YXlX aXRoaW4pCiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgICAgICBvID0gby0+cGFy ZW50KCk7CiAgICAgICAgIH0KICAgICAgICAgaWYgKG8pCiAgICAgICAgICAgICBvID0gby0+bmV4 dFNpYmxpbmcoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM4ODg0KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMDgtMTItMDEgIEJldGgg RGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRlc3RzIGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM3MzYgUkVHUkVTU0lPTiAKKyAgICAgICAgKHIxOTgxMSk6IFVzaW5nIHRo ZSBkb3duIGFycm93IGluIGEgdGV4dGFyZWEgZ2V0cyAic3R1Y2siIGF0IHRoZSAKKyAgICAgICAg ZW5kIG9mIGEgd3JhcHBlZCBsaW5lCisgICAgICAgIEFuZCBjb3JyZXNwb25kaW5nOiA8cmRhcjov L3Byb2JsZW0vNTM0NzkzMT4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQt bGluZS1jYXJldC0xLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3dy YXBwZWQtbGluZS1jYXJldC0yLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9l ZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMS0KKyAgICAgICAgZXhwZWN0ZWQu Y2hlY2tzdW06IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlv bi93cmFwcGVkLWxpbmUtY2FyZXQtMS1leHBlY3RlZC5wbmc6IAorICAgICAgICBBZGRlZC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0 LTEtZXhwZWN0ZWQudHh0OiAKKyAgICAgICAgQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFj L2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0yLQorICAgICAgICBleHBlY3Rl ZC5jaGVja3N1bTogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0 aW9uL3dyYXBwZWQtbGluZS1jYXJldC0yLWV4cGVjdGVkLnBuZzogCisgICAgICAgIEFkZGVkLgor ICAgICAgICAqIHBsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2Fy ZXQtMi1leHBlY3RlZC50eHQ6IAorICAgICAgICBBZGRlZC4KKwogMjAwOC0xMi0wMSAgRGF2aWQg S2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1ZyAyMjQ2NjogUkVHUkVT U0lPTiAoMzU4NjcpOiBNYW55IHJlc291cmNlcyBtaXNzaW5nIHdoZW4gc2F2aW5nIHdlYmFyY2hp dmUgb2Ygd2Via2l0Lm9yZwpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vd3Jh cHBlZC1saW5lLWNhcmV0LTEuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5n L3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTEuaHRtbAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSw4IEBACis8c3Bhbj5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBj YXJldCBpcyBhdCB0aGUgc3RhcnQgb2YgdGhlIHNlY29uZCBsaW5lLjwvc3Bhbj4KKworPGRpdiBp ZD0iZWRpdCIgY29udGVudEVkaXRhYmxlPSJ0cnVlIiBzdHlsZT0id2lkdGg6IDM1MHB4OyBoZWln aHQ6IDEwMHB4OyBib3JkZXI6IDFweCBzb2xpZCBibHVlOyI+YSZuYnNwOzwvZGl2PgorPHNjcmlw dD4KK3ZhciBlZGl0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImVkaXQiKTsKK2VkaXQuYXBw ZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoInh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eHh4eHh4eHh4eHh4eHh4eHh4eHgiKSk7Cit3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRp b24oZWRpdC5maXJzdENoaWxkLCAyKTsKKzwvc2NyaXB0PgpJbmRleDogTGF5b3V0VGVzdHMvZWRp dGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTIuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMi5odG1sCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5l LWNhcmV0LTIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3IEBACis8c3Bhbj5UaGlzIHRl c3QgcGFzc2VzIGlmIHRoZSBjYXJldCBpcyBhdCB0aGUgc3RhcnQgb2YgdGhlIHNlY29uZCBsaW5l Ljwvc3Bhbj4KKworPGRpdiBpZD0iZWRpdCIgY29udGVudEVkaXRhYmxlPSJ0cnVlIiBzdHlsZT0i d2lkdGg6IDM1MHB4OyBoZWlnaHQ6IDEwMHB4OyBib3JkZXI6IDFweCBzb2xpZCBibHVlOyI+YSZu YnNwOzxzcGFuIHN0eWxlPWNvbG9yOmJsdWU7Ij54eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eHh4eHh4eHh4eHh4eHh4PC9zcGFuPjwvZGl2PgorPHNjcmlwdD4KK3ZhciBlZGl0ID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImVkaXQiKTsKK3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3Np dGlvbihlZGl0LmZpcnN0Q2hpbGQsIDIpOworPC9zY3JpcHQ+CkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTEtZXhwZWN0 ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRp bmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0xLWV4cGVjdGVkLmNoZWNrc3VtCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0aW9uL3dy YXBwZWQtbGluZS1jYXJldC0xLWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxIEBACitmZGZjMzcyMDkyZTFhNmY1ZGFkOTVjNmM1MzEwZTU3YwpcIE5vIG5ld2xpbmUgYXQg ZW5kIG9mIGZpbGUKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVj dGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJl dC0xLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMS1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTYgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAor ICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4 MDB4NjAwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBS ZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1ODQKKyAgICAgIFJlbmRlckJsb2Nr IChhbm9ueW1vdXMpIGF0ICgwLDApIHNpemUgNzg0eDE4CisgICAgICAgIFJlbmRlcklubGluZSB7 U1BBTn0gYXQgKDAsMCkgc2l6ZSAzNjh4MTgKKyAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0g YXQgKDAsMCkgc2l6ZSAzNjh4MTgKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRo IDM2ODogIlRoaXMgdGVzdCBwYXNzZXMgaWYgdGhlIGNhcmV0IGlzIGF0IHRoZSBzdGFydCBvZiB0 aGUgc2Vjb25kIGxpbmUuIgorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6 ZSAweDAKKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDE4KSBzaXplIDM1MngxMDIgW2Jv cmRlcjogKDFweCBzb2xpZCAjMDAwMEZGKV0KKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgxLDEpIHNpemUgMTF4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxKSB3aWR0aCAxMTog ImEgIgorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDEsMTkpIHNpemUgMzQ0eDE4Cisg ICAgICAgICAgdGV4dCBydW4gYXQgKDEsMTkpIHdpZHRoIDM0NDogInh4eHh4eHh4eHh4eHh4eHh4 eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHgiCitjYXJldDogcG9zaXRpb24gMiBvZiBjaGlsZCAw IHsjdGV4dH0gb2YgY2hpbGQgMiB7RElWfSBvZiBjaGlsZCAwIHtCT0RZfSBvZiBjaGlsZCAwIHtI VE1MfSBvZiBkb2N1bWVudApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcv c2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0yLWV4cGVjdGVkLmNoZWNrc3VtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVk LWxpbmUtY2FyZXQtMi1leHBlY3RlZC5jaGVja3N1bQkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMi1l eHBlY3RlZC5jaGVja3N1bQkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorZWRmOTNjNzM5OWY5 ZjNjOTljMGZiZTBlNjg4MmExMDQKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNh cmV0LTItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMi1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24v d3JhcHBlZC1saW5lLWNhcmV0LTItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDE3IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCww KSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9j ayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQg KDgsOCkgc2l6ZSA3ODR4NTg0CisgICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoMCww KSBzaXplIDc4NHgxOAorICAgICAgICBSZW5kZXJJbmxpbmUge1NQQU59IGF0ICgwLDApIHNpemUg MzY4eDE4CisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMzY4eDE4 CisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAzNjg6ICJUaGlzIHRlc3QgcGFz c2VzIGlmIHRoZSBjYXJldCBpcyBhdCB0aGUgc3RhcnQgb2YgdGhlIHNlY29uZCBsaW5lLiIKKyAg ICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCisgICAgICBSZW5kZXJC bG9jayB7RElWfSBhdCAoMCwxOCkgc2l6ZSAzNTJ4MTAyIFtib3JkZXI6ICgxcHggc29saWQgIzAw MDBGRildCisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMSwxKSBzaXplIDExeDE4Cisg ICAgICAgICAgdGV4dCBydW4gYXQgKDEsMSkgd2lkdGggMTE6ICJhICIKKyAgICAgICAgUmVuZGVy SW5saW5lIHtTUEFOfSBhdCAoMCwwKSBzaXplIDM0NHgxOCBbY29sb3I9IzAwMDBGRl0KKyAgICAg ICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDEsMTkpIHNpemUgMzQ0eDE4CisgICAgICAgICAg ICB0ZXh0IHJ1biBhdCAoMSwxOSkgd2lkdGggMzQ0OiAieHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eHh4eHh4eHh4eHh4eHh4eHh4eCIKK2NhcmV0OiBwb3NpdGlvbiAyIG9mIGNoaWxkIDAgeyN0ZXh0 fSBvZiBjaGlsZCAyIHtESVZ9IG9mIGNoaWxkIDAge0JPRFl9IG9mIGNoaWxkIDAge0hUTUx9IG9m IGRvY3VtZW50Cg== 25664 2008-12-01 22:20:59 -0800 2008-12-01 22:27:43 -0800 Newer Patch forReview2.txt text/plain 10195 bdakin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODg4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMDgtMTItMDEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzM2IFJFR1JFU1NJ T04gCisgICAgICAgIChyMTk4MTEpOiBVc2luZyB0aGUgZG93biBhcnJvdyBpbiBhIHRleHRhcmVh IGdldHMgInN0dWNrIiBhdCB0aGUgCisgICAgICAgIGVuZCBvZiBhIHdyYXBwZWQgbGluZQorICAg ICAgICBBbmQgY29ycmVzcG9uZGluZzogPHJkYXI6Ly9wcm9ibGVtLzUzNDc5MzE+CisKKyAgICAg ICAgVGhlIGJhc2ljIHByb2JsZW0gaGVyZSBpcyB0aGF0IFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hB bmRPZmZzZXQoKSAKKyAgICAgICAgZmFpbGVkIHRvIGxvb2sgYmV5b25kIGEgc2luZ2xlIHJlbmRl cmVyLiBUaGlzIHBhdGNoIGxvb2tzIGZvciBhIAorICAgICAgICBiZXR0ZXIgbWF0Y2ggYmV5b25k IHRoZSBmaXJzdCByZW5kZXJlciB3aGVuIHRoZSBhZmZpbml0eSBpcyAKKyAgICAgICAgZG93bnN0 cmVhbSBhbmQgd2UgZmFpbGVkIHRvIGZpbmQgYSAicGVyZmVjdCIgbWF0Y2guIAorICAgICAgICAq IGRvbS9Qb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc05vblRleHRMZWFmQ2hpbGQp OgorICAgICAgICAoV2ViQ29yZTo6c2VhcmNoQWhlYWRGb3JCZXR0ZXJNYXRjaCk6CisgICAgICAg IChXZWJDb3JlOjpQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KToKKworICAgICAgICBU aGlzIGlzIGEgZml4IEkgbWFkZSBiYXNlZCBvbiBjb2RlIGluc3BlY3Rpb24uIEl0IGxvb2tzIGxp a2UgdGhlIAorICAgICAgICBvbGQgY29kZSBoZXJlIGFuZCBza2lwcGVkIG92ZXIgdGhlIHBhcmVu dCBhcyBhIHBvc3NpYmxlIG1hdGNoLiAKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6bmV4dEluUHJlT3JkZXJBZnRl ckNoaWxkcmVuKToKKwogMjAwOC0xMi0wMSAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdl YkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Qb3NpdGlv bi5jcHAJKHJldmlzaW9uIDM4ODYxKQorKysgV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCiAjaW5j bHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIlBvc2l0aW9uSXRlcmF0b3IuaCIKKyNpbmNsdWRl ICJSZW5kZXJCbG9jay5oIgogI2luY2x1ZGUgIlRleHQuaCIKICNpbmNsdWRlICJUZXh0SXRlcmF0 b3IuaCIKICNpbmNsdWRlICJodG1sZWRpdGluZy5oIgpAQCAtNzcxLDYgKzc3Miw0MSBAQCB2b2lk IFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmCiAgICAgZ2V0SW5saW5lQm94QW5k T2Zmc2V0KGFmZmluaXR5LCBwcmltYXJ5RGlyZWN0aW9uLCBpbmxpbmVCb3gsIGNhcmV0T2Zmc2V0 KTsKIH0KIAorc3RhdGljIGJvb2wgaXNOb25UZXh0TGVhZkNoaWxkKFJlbmRlck9iamVjdCogb2Jq ZWN0KQoreworICAgIGlmIChvYmplY3QtPmZpcnN0Q2hpbGQoKSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIGlmIChvYmplY3QtPmlzVGV4dCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7Cisg ICAgcmV0dXJuIHRydWU7Cit9CisKK3N0YXRpYyBJbmxpbmVUZXh0Qm94KiBzZWFyY2hBaGVhZEZv ckJldHRlck1hdGNoKFJlbmRlck9iamVjdCogcmVuZGVyZXIpCit7CisgICAgSW5saW5lVGV4dEJv eCogbWF0Y2ggPSAwOworICAgIGludCBtaW5PZmZzZXQgPSBJTlRfTUFYOworICAgIFJlbmRlckJs b2NrKiBjb250YWluZXIgPSByZW5kZXJlci0+Y29udGFpbmluZ0Jsb2NrKCk7CisgICAgUmVuZGVy T2JqZWN0KiBuZXh0ID0gcmVuZGVyZXI7CisgICAgd2hpbGUgKChuZXh0ID0gbmV4dC0+bmV4dElu UHJlT3JkZXIoY29udGFpbmVyKSkpIHsKKyAgICAgICAgaWYgKG5leHQtPmlzUmVuZGVyQmxvY2so KSkKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBpZiAobmV4dC0+aXNCUigpKQorICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIGlmIChpc05vblRleHRMZWFmQ2hpbGQobmV4dCkpCisgICAg ICAgICAgICBicmVhazsKKyAgICAgICAgaWYgKG5leHQtPmlzVGV4dCgpKSB7CisgICAgICAgICAg ICBmb3IgKElubGluZVRleHRCb3gqIGJveCA9IHN0YXRpY19jYXN0PFJlbmRlclRleHQqPihuZXh0 KS0+Zmlyc3RUZXh0Qm94KCk7IGJveDsgYm94ID0gYm94LT5uZXh0VGV4dEJveCgpKSB7CisgICAg ICAgICAgICAgICAgaW50IGNhcmV0TWluT2Zmc2V0ID0gYm94LT5jYXJldE1pbk9mZnNldCgpOwor ICAgICAgICAgICAgICAgIGlmIChjYXJldE1pbk9mZnNldCA8IG1pbk9mZnNldCkgeworICAgICAg ICAgICAgICAgICAgICBtYXRjaCA9IGJveDsKKyAgICAgICAgICAgICAgICAgICAgbWluT2Zmc2V0 ID0gY2FyZXRNaW5PZmZzZXQ7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAg ICAgICB9CisgICAgfQorICAgIHJldHVybiBtYXRjaDsKK30KKwogdm9pZCBQb3NpdGlvbjo6Z2V0 SW5saW5lQm94QW5kT2Zmc2V0KEVBZmZpbml0eSBhZmZpbml0eSwgVGV4dERpcmVjdGlvbiBwcmlt YXJ5RGlyZWN0aW9uLCBJbmxpbmVCb3gqJiBpbmxpbmVCb3gsIGludCYgY2FyZXRPZmZzZXQpIGNv bnN0CiB7CiAgICAgY2FyZXRPZmZzZXQgPSBvZmZzZXQoKTsKQEAgLTgwMiw2ICs4MzgsMTEgQEAg dm9pZCBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVBZgogCiAgICAgICAgICAgICBj YW5kaWRhdGUgPSBib3g7CiAgICAgICAgIH0KKyAgICAgICAgaWYgKGNhbmRpZGF0ZSAmJiAhYm94 ICYmIGFmZmluaXR5ID09IERPV05TVFJFQU0pIHsKKyAgICAgICAgICAgIGJveCA9IHNlYXJjaEFo ZWFkRm9yQmV0dGVyTWF0Y2godGV4dFJlbmRlcmVyKTsKKyAgICAgICAgICAgIGlmIChib3gpCisg ICAgICAgICAgICAgICAgY2FyZXRPZmZzZXQgPSBib3gtPmNhcmV0TWluT2Zmc2V0KCk7CisgICAg ICAgIH0KICAgICAgICAgaW5saW5lQm94ID0gYm94ID8gYm94IDogY2FuZGlkYXRlOwogICAgIH0K IApJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAzODg2MSkKKysr IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMx OCw5ICszMTgsOSBAQCBSZW5kZXJPYmplY3QqIFJlbmRlck9iamVjdDo6bmV4dEluUHJlT3JkCiAg ICAgaWYgKCEobyA9IG5leHRTaWJsaW5nKCkpKSB7CiAgICAgICAgIG8gPSBwYXJlbnQoKTsKICAg ICAgICAgd2hpbGUgKG8gJiYgIW8tPm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgICAgIG8gPSBv LT5wYXJlbnQoKTsKICAgICAgICAgICAgIGlmIChvID09IHN0YXlXaXRoaW4pCiAgICAgICAgICAg ICAgICAgcmV0dXJuIDA7CisgICAgICAgICAgICBvID0gby0+cGFyZW50KCk7CiAgICAgICAgIH0K ICAgICAgICAgaWYgKG8pCiAgICAgICAgICAgICBvID0gby0+bmV4dFNpYmxpbmcoKTsKSW5kZXg6 IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHJldmlzaW9uIDM4ODg0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMDgtMTItMDEgIEJldGggRGFraW4gIDxiZGFraW5AYXBw bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3RzIGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MzYg UkVHUkVTU0lPTiAKKyAgICAgICAgKHIxOTgxMSk6IFVzaW5nIHRoZSBkb3duIGFycm93IGluIGEg dGV4dGFyZWEgZ2V0cyAic3R1Y2siIGF0IHRoZSAKKyAgICAgICAgZW5kIG9mIGEgd3JhcHBlZCBs aW5lCisgICAgICAgIEFuZCBjb3JyZXNwb25kaW5nOiA8cmRhcjovL3Byb2JsZW0vNTM0NzkzMT4K KworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0xLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0y Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlvbi93 cmFwcGVkLWxpbmUtY2FyZXQtMS0KKyAgICAgICAgZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgor ICAgICAgICAqIHBsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2Fy ZXQtMS1leHBlY3RlZC5wbmc6IAorICAgICAgICBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTEtZXhwZWN0ZWQudHh0OiAK KyAgICAgICAgQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0aW9u L3dyYXBwZWQtbGluZS1jYXJldC0yLQorICAgICAgICBleHBlY3RlZC5jaGVja3N1bTogQWRkZWQu CisgICAgICAgICogcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1j YXJldC0yLWV4cGVjdGVkLnBuZzogCisgICAgICAgIEFkZGVkLgorICAgICAgICAqIHBsYXRmb3Jt L21hYy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMi1leHBlY3RlZC50eHQ6 IAorICAgICAgICBBZGRlZC4KKwogMjAwOC0xMi0wMSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIEJ1ZyAyMjQ2NjogUkVHUkVTU0lPTiAoMzU4NjcpOiBNYW55 IHJlc291cmNlcyBtaXNzaW5nIHdoZW4gc2F2aW5nIHdlYmFyY2hpdmUgb2Ygd2Via2l0Lm9yZwpJ bmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTEu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVk LWxpbmUtY2FyZXQtMS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw4IEBACis8c3Bhbj5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBjYXJldCBpcyBhdCB0aGUgc3Rh cnQgb2YgdGhlIHNlY29uZCBsaW5lLjwvc3Bhbj4KKworPGRpdiBpZD0iZWRpdCIgY29udGVudEVk aXRhYmxlPSJ0cnVlIiBzdHlsZT0id2lkdGg6IDM1MHB4OyBoZWlnaHQ6IDEwMHB4OyBib3JkZXI6 IDFweCBzb2xpZCBibHVlOyI+YSZuYnNwOzwvZGl2PgorPHNjcmlwdD4KK3ZhciBlZGl0ID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoImVkaXQiKTsKK2VkaXQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQu Y3JlYXRlVGV4dE5vZGUoInh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eHgiKSk7Cit3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24oZWRpdC5maXJzdENoaWxk LCAyKTsKKzwvc2NyaXB0PgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vd3Jh cHBlZC1saW5lLWNhcmV0LTIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5n L3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTIuaHRtbAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSw3IEBACis8c3Bhbj5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBj YXJldCBpcyBhdCB0aGUgc3RhcnQgb2YgdGhlIHNlY29uZCBsaW5lLjwvc3Bhbj4KKworPGRpdiBp ZD0iZWRpdCIgY29udGVudEVkaXRhYmxlPSJ0cnVlIiBzdHlsZT0id2lkdGg6IDM1MHB4OyBoZWln aHQ6IDEwMHB4OyBib3JkZXI6IDFweCBzb2xpZCBibHVlOyI+YSZuYnNwOzxzcGFuIHN0eWxlPWNv bG9yOmJsdWU7Ij54eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4PC9z cGFuPjwvZGl2PgorPHNjcmlwdD4KK3ZhciBlZGl0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImVkaXQiKTsKK3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihlZGl0LmZpcnN0Q2hp bGQsIDIpOworPC9zY3JpcHQ+CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGlu Zy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTEtZXhwZWN0ZWQuY2hlY2tzdW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBw ZWQtbGluZS1jYXJldC0xLWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0x LWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitmZGZjMzcyMDky ZTFhNmY1ZGFkOTVjNmM1MzEwZTU3YwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUt Y2FyZXQtMS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0xLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlv bi93cmFwcGVkLWxpbmUtY2FyZXQtMS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTYgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgw LDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJs b2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBh dCAoOCw4KSBzaXplIDc4NHg1ODQKKyAgICAgIFJlbmRlckJsb2NrIChhbm9ueW1vdXMpIGF0ICgw LDApIHNpemUgNzg0eDE4CisgICAgICAgIFJlbmRlcklubGluZSB7U1BBTn0gYXQgKDAsMCkgc2l6 ZSAzNjh4MTgKKyAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAzNjh4 MTgKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDM2ODogIlRoaXMgdGVzdCBw YXNzZXMgaWYgdGhlIGNhcmV0IGlzIGF0IHRoZSBzdGFydCBvZiB0aGUgc2Vjb25kIGxpbmUuIgor ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKKyAgICAgIFJlbmRl ckJsb2NrIHtESVZ9IGF0ICgwLDE4KSBzaXplIDM1MngxMDIgW2JvcmRlcjogKDFweCBzb2xpZCAj MDAwMEZGKV0KKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgxLDEpIHNpemUgMTF4MTgK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxKSB3aWR0aCAxMTogImEgIgorICAgICAgICBSZW5k ZXJUZXh0IHsjdGV4dH0gYXQgKDEsMTkpIHNpemUgMzQ0eDE4CisgICAgICAgICAgdGV4dCBydW4g YXQgKDEsMTkpIHdpZHRoIDM0NDogInh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eHh4eHh4eHgiCitjYXJldDogcG9zaXRpb24gMiBvZiBjaGlsZCAwIHsjdGV4dH0gb2YgY2hpbGQg MiB7RElWfSBvZiBjaGlsZCAwIHtCT0RZfSBvZiBjaGlsZCAwIHtIVE1MfSBvZiBkb2N1bWVudApJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQt bGluZS1jYXJldC0yLWV4cGVjdGVkLmNoZWNrc3VtCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMi1leHBl Y3RlZC5jaGVja3N1bQkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9l ZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMi1leHBlY3RlZC5jaGVja3N1bQko cmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorZWRmOTNjNzM5OWY5ZjNjOTljMGZiZTBlNjg4MmEx MDQKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTItZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL3NlbGVjdGlv bi93cmFwcGVkLWxpbmUtY2FyZXQtMi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0 LTItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE3IEBACitsYXllciBhdCAo MCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xh eWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkg c2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODR4NTg0 CisgICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoMCwwKSBzaXplIDc4NHgxOAorICAg ICAgICBSZW5kZXJJbmxpbmUge1NQQU59IGF0ICgwLDApIHNpemUgMzY4eDE4CisgICAgICAgICAg UmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMzY4eDE4CisgICAgICAgICAgICB0ZXh0 IHJ1biBhdCAoMCwwKSB3aWR0aCAzNjg6ICJUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBjYXJldCBp cyBhdCB0aGUgc3RhcnQgb2YgdGhlIHNlY29uZCBsaW5lLiIKKyAgICAgICAgUmVuZGVyVGV4dCB7 I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCisgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCwx OCkgc2l6ZSAzNTJ4MTAyIFtib3JkZXI6ICgxcHggc29saWQgIzAwMDBGRildCisgICAgICAgIFJl bmRlclRleHQgeyN0ZXh0fSBhdCAoMSwxKSBzaXplIDExeDE4CisgICAgICAgICAgdGV4dCBydW4g YXQgKDEsMSkgd2lkdGggMTE6ICJhICIKKyAgICAgICAgUmVuZGVySW5saW5lIHtTUEFOfSBhdCAo MCwwKSBzaXplIDM0NHgxOCBbY29sb3I9IzAwMDBGRl0KKyAgICAgICAgICBSZW5kZXJUZXh0IHsj dGV4dH0gYXQgKDEsMTkpIHNpemUgMzQ0eDE4CisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwx OSkgd2lkdGggMzQ0OiAieHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eCIKK2NhcmV0OiBwb3NpdGlvbiAyIG9mIGNoaWxkIDAgeyN0ZXh0fSBvZiBjaGlsZCAyIHtESVZ9 IG9mIGNoaWxkIDAge0JPRFl9IG9mIGNoaWxkIDAge0hUTUx9IG9mIGRvY3VtZW50Cg==