137344 2014-10-02 08:44:54 -0700 Suppress warnings on GCC: google-tests header mis-recognize false as null literal 2014-10-03 19:13:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 137360 P2 Normal --- 1 ysuzuki ysuzuki cdumez commit-queue gyuyoung.kim kling mrobinson oldest_to_newest 1038869 0 ysuzuki 2014-10-02 08:44:54 -0700 Suppress warnings on GCC: google-tests header mis-recognize false as null literal 1038870 1 239111 ysuzuki 2014-10-02 08:48:53 -0700 Created attachment 239111 Patch 1039403 2 239111 cdumez 2014-10-03 16:27:13 -0700 Comment on attachment 239111 Patch r=me 1039427 3 239111 commit-queue 2014-10-03 18:57:13 -0700 Comment on attachment 239111 Patch Rejecting attachment 239111 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 239111, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: de: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp Hunk #1 FAILED at 166. Hunk #2 FAILED at 218. 2 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Christophe Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5926707538165760 1039429 4 ysuzuki 2014-10-03 19:13:36 -0700 Ah, the other patch contains this patch's change. https://bugs.webkit.org/show_bug.cgi?id=137360 Thank you for your review, Chris :) *** This bug has been marked as a duplicate of bug 137360 *** 239111 2014-10-02 08:48:53 -0700 2014-10-03 18:57:13 -0700 Patch bug-137344-20141003004923.patch text/plain 5007 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MjE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGY0M2JlYzI1YjM0NzA1MjhiNTFhNjUzYzBhMWE0ZDRm NjM0NzAxOS4uZjU2MmYxMTI2ZmI3NmVkODQ1ODk0NDJlMDkxYmJiNDM2ZDBlMjFmNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTEwLTAyICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgor CisgICAgICAgIFN1cHByZXNzIHdhcm5pbmdzIG9uIEdDQzogZ29vZ2xlLXRlc3RzIGhlYWRlciBt aXMtcmVjb2duaXplIGZhbHNlIGFzIG51bGwgbGl0ZXJhbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ3Rlc3QncyBJc051bGxMaXRlcmFsSGVscGVyIG1p cy1yZWNvZ25pemUgZmFsc2UgYXMgbnVsbCBsaXRlcmFsIG9uIEdDQy4KKyAgICAgICAgSG93ZXZl ciwgc2luY2UgZ3Rlc3QgY2hlY2tzIGl0IGJ5IHVzaW5nIGZ1bmN0aW9uIHBhcmFtZXRlcidzIG92 ZXJyaWRpbmcsCisgICAgICAgIGl0IGZvcmNlcyBjYXN0aW5nIGZhbHNlIGxpdGVyYWwgdG8gYSBw b2ludGVyIGFuZCByYWlzZXMgd2FybmluZ3MuCisgICAgICAgIFRvIHNvbHZlIGl0LCB1c2UgRVhQ RUNUX1RSVUUvRVhQRUNUX0ZBTFNFIGluc3RlYWQgb2YgRVhQRUNUX0VRKGZhbHNlLCBvaykuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XVEZTdHJpbmcuY3BwOgorICAgICAg ICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTQtMTAtMDIgIENhcmxvcyBBbGJlcnRvIExv cGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gW0pIQnVpbGRd IFN3aXRjaCBzb3VyY2V3YXJlLm9yZyBtaXJyb3IgdG8gaHR0cC4KZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dURlN0cmluZy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dURi9XVEZTdHJpbmcuY3BwCmluZGV4IGY0MGU2YWY1MTAyYzY3YjBjYWM3Zjhk MjM5NTdmMWIxYTRkNWZkNWIuLjUzYThiODg1NDIyNjE0NGFhMzU2YmNjMmIyZGI2MDExOTBhYzMy MjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dURlN0cmluZy5j cHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcApAQCAt MTY2LDUwICsxNjYsNTAgQEAgc3RhdGljIHZvaWQgdGVzdE51bWJlclRvU3RyaW5nRUNNQVNjcmlw dChkb3VibGUgbnVtYmVyLCBjb25zdCBjaGFyKiByZWZlcmVuY2UpCiAKICAgICBFWFBFQ1RfRVEo MCwgU3RyaW5nKCkudG9JbnQoKSk7CiAgICAgRVhQRUNUX0VRKDAsIFN0cmluZygpLnRvSW50KCZv aykpOwotICAgIEVYUEVDVF9FUShmYWxzZSwgb2spOworICAgIEVYUEVDVF9GQUxTRShvayk7CiAK ICAgICBFWFBFQ1RfRVEoMCwgZW1wdHlTdHJpbmcoKS50b0ludCgpKTsKICAgICBFWFBFQ1RfRVEo MCwgZW1wdHlTdHJpbmcoKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsK KyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAgRVhQRUNUX0VRKDAsIFN0cmluZygiMCIpLnRv SW50KCkpOwogICAgIEVYUEVDVF9FUSgwLCBTdHJpbmcoIjAiKS50b0ludCgmb2spKTsKLSAgICBF WFBFQ1RfRVEodHJ1ZSwgb2spOworICAgIEVYUEVDVF9UUlVFKG9rKTsKIAogICAgIEVYUEVDVF9F USgxLCBTdHJpbmcoIjEiKS50b0ludCgpKTsKICAgICBFWFBFQ1RfRVEoMSwgU3RyaW5nKCIxIiku dG9JbnQoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKHRydWUsIG9rKTsKKyAgICBFWFBFQ1RfVFJVRShv ayk7CiAKICAgICBFWFBFQ1RfRVEoMjE0NzQ4MzY0NywgU3RyaW5nKCIyMTQ3NDgzNjQ3IikudG9J bnQoKSk7CiAgICAgRVhQRUNUX0VRKDIxNDc0ODM2NDcsIFN0cmluZygiMjE0NzQ4MzY0NyIpLnRv SW50KCZvaykpOwotICAgIEVYUEVDVF9FUSh0cnVlLCBvayk7CisgICAgRVhQRUNUX1RSVUUob2sp OwogCiAgICAgRVhQRUNUX0VRKDAsIFN0cmluZygiMjE0NzQ4MzY0OCIpLnRvSW50KCkpOwogICAg IEVYUEVDVF9FUSgwLCBTdHJpbmcoIjIxNDc0ODM2NDgiKS50b0ludCgmb2spKTsKLSAgICBFWFBF Q1RfRVEoZmFsc2UsIG9rKTsKKyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAgRVhQRUNUX0VR KC0yMTQ3NDgzNjQ4LCBTdHJpbmcoIi0yMTQ3NDgzNjQ4IikudG9JbnQoKSk7CiAgICAgRVhQRUNU X0VRKC0yMTQ3NDgzNjQ4LCBTdHJpbmcoIi0yMTQ3NDgzNjQ4IikudG9JbnQoJm9rKSk7Ci0gICAg RVhQRUNUX0VRKHRydWUsIG9rKTsKKyAgICBFWFBFQ1RfVFJVRShvayk7CiAKICAgICBFWFBFQ1Rf RVEoMCwgU3RyaW5nKCItMjE0NzQ4MzY0OSIpLnRvSW50KCkpOwogICAgIEVYUEVDVF9FUSgwLCBT dHJpbmcoIi0yMTQ3NDgzNjQ5IikudG9JbnQoJm9rKSk7Ci0gICAgRVhQRUNUX0VRKGZhbHNlLCBv ayk7CisgICAgRVhQRUNUX0ZBTFNFKG9rKTsKIAogICAgIC8vIGZhaWwgaWYgd2Ugc2VlIGxlYWRp bmcganVuawogICAgIEVYUEVDVF9FUSgwLCBTdHJpbmcoIngxIikudG9JbnQoKSk7CiAgICAgRVhQ RUNUX0VRKDAsIFN0cmluZygieDEiKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2Us IG9rKTsKKyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAgLy8gc3VjY2VlZCBpZiB3ZSBzZWUg bGVhZGluZyBzcGFjZXMKICAgICBFWFBFQ1RfRVEoMSwgU3RyaW5nKCIgMSIpLnRvSW50KCkpOwog ICAgIEVYUEVDVF9FUSgxLCBTdHJpbmcoIiAxIikudG9JbnQoJm9rKSk7Ci0gICAgRVhQRUNUX0VR KHRydWUsIG9rKTsKKyAgICBFWFBFQ1RfVFJVRShvayk7CiAKICAgICAvLyBzaWxlbnRseSBpZ25v cmUgdHJhaWxpbmcganVuawogICAgIEVYUEVDVF9FUSgxLCBTdHJpbmcoIjF4IikudG9JbnQoKSk7 CiAgICAgRVhQRUNUX0VRKDEsIFN0cmluZygiMXgiKS50b0ludCgmb2spKTsKLSAgICBFWFBFQ1Rf RVEodHJ1ZSwgb2spOworICAgIEVYUEVDVF9UUlVFKG9rKTsKIH0KIAogVEVTVChXVEYsIFN0cmlu Z1RvRG91YmxlKQpAQCAtMjE4LDQ2ICsyMTgsNDYgQEAgc3RhdGljIHZvaWQgdGVzdE51bWJlclRv U3RyaW5nRUNNQVNjcmlwdChkb3VibGUgbnVtYmVyLCBjb25zdCBjaGFyKiByZWZlcmVuY2UpCiAK ICAgICBFWFBFQ1RfRVEoMC4wLCBTdHJpbmcoKS50b0RvdWJsZSgpKTsKICAgICBFWFBFQ1RfRVEo MC4wLCBTdHJpbmcoKS50b0RvdWJsZSgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsK KyAgICBFWFBFQ1RfRkFMU0Uob2spOwogCiAgICAgRVhQRUNUX0VRKDAuMCwgZW1wdHlTdHJpbmco KS50b0RvdWJsZSgpKTsKICAgICBFWFBFQ1RfRVEoMC4wLCBlbXB0eVN0cmluZygpLnRvRG91Ymxl KCZvaykpOwotICAgIEVYUEVDVF9FUShmYWxzZSwgb2spOworICAgIEVYUEVDVF9GQUxTRShvayk7 CiAKICAgICBFWFBFQ1RfRVEoMC4wLCBTdHJpbmcoIjAiKS50b0RvdWJsZSgpKTsKICAgICBFWFBF Q1RfRVEoMC4wLCBTdHJpbmcoIjAiKS50b0RvdWJsZSgmb2spKTsKLSAgICBFWFBFQ1RfRVEodHJ1 ZSwgb2spOworICAgIEVYUEVDVF9UUlVFKG9rKTsKIAogICAgIEVYUEVDVF9FUSgxLjAsIFN0cmlu ZygiMSIpLnRvRG91YmxlKCkpOwogICAgIEVYUEVDVF9FUSgxLjAsIFN0cmluZygiMSIpLnRvRG91 YmxlKCZvaykpOwotICAgIEVYUEVDVF9FUSh0cnVlLCBvayk7CisgICAgRVhQRUNUX1RSVUUob2sp OwogCiAgICAgLy8gZmFpbCBpZiB3ZSBzZWUgbGVhZGluZyBqdW5rCiAgICAgRVhQRUNUX0VRKDAu MCwgU3RyaW5nKCJ4MSIpLnRvRG91YmxlKCkpOwogICAgIEVYUEVDVF9FUSgwLjAsIFN0cmluZygi eDEiKS50b0RvdWJsZSgmb2spKTsKLSAgICBFWFBFQ1RfRVEoZmFsc2UsIG9rKTsKKyAgICBFWFBF Q1RfRkFMU0Uob2spOwogCiAgICAgLy8gc3VjY2VlZCBpZiB3ZSBzZWUgbGVhZGluZyBzcGFjZXMK ICAgICBFWFBFQ1RfRVEoMS4wLCBTdHJpbmcoIiAxIikudG9Eb3VibGUoKSk7CiAgICAgRVhQRUNU X0VRKDEuMCwgU3RyaW5nKCIgMSIpLnRvRG91YmxlKCZvaykpOwotICAgIEVYUEVDVF9FUSh0cnVl LCBvayk7CisgICAgRVhQRUNUX1RSVUUob2spOwogCiAgICAgLy8gaWdub3JlIHRyYWlsaW5nIGp1 bmssIGJ1dCByZXR1cm4gZmFsc2UgZm9yICJvayIKICAgICAvLyBGSVhNRTogVGhpcyBpcyBhbiBp bmNvbnNpc3RlbmN5IHdpdGggdG9JbnQsIHdoaWNoIGFsd2F5cyBndWFyYW50ZWVzCiAgICAgLy8g aXQgd2lsbCByZXR1cm4gMCBpZiBpdCdzIGFsc28gZ29pbmcgdG8gcmV0dXJuIGZhbHNlIGZvciBv ay4KICAgICBFWFBFQ1RfRVEoMS4wLCBTdHJpbmcoIjF4IikudG9Eb3VibGUoKSk7CiAgICAgRVhQ RUNUX0VRKDEuMCwgU3RyaW5nKCIxeCIpLnRvRG91YmxlKCZvaykpOwotICAgIEVYUEVDVF9FUShm YWxzZSwgb2spOworICAgIEVYUEVDVF9GQUxTRShvayk7CiAKICAgICAvLyBwYXJzZSBvbmx5IG51 bWJlcnMsIG5vdCBzcGVjaWFsIHZhbHVlcyBzdWNoIGFzICJpbmZpbml0eSIKICAgICBFWFBFQ1Rf RVEoMC4wLCBTdHJpbmcoImluZmluaXR5IikudG9Eb3VibGUoKSk7CiAgICAgRVhQRUNUX0VRKDAu MCwgU3RyaW5nKCJpbmZpbml0eSIpLnRvRG91YmxlKCZvaykpOwotICAgIEVYUEVDVF9FUShmYWxz ZSwgb2spOworICAgIEVYUEVDVF9GQUxTRShvayk7CiAKICAgICAvLyBwYXJzZSBvbmx5IG51bWJl cnMsIG5vdCBzcGVjaWFsIHZhbHVlcyBzdWNoIGFzICJuYW4iCiAgICAgRVhQRUNUX0VRKDAuMCwg U3RyaW5nKCJuYW4iKS50b0RvdWJsZSgpKTsKICAgICBFWFBFQ1RfRVEoMC4wLCBTdHJpbmcoIm5h biIpLnRvRG91YmxlKCZvaykpOwotICAgIEVYUEVDVF9FUShmYWxzZSwgb2spOworICAgIEVYUEVD VF9GQUxTRShvayk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK